sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-03-12 20:58:37 +03:00
Code
117,939 Commits 62 Branches 1,155 Tags
Commit Graph

661 Commits

Author SHA1 Message Date
Noel Power
75afaeb749 s3/lib/netapi: Fix 'Possible null pointer dereference' warning 
source3/lib/netapi/localgroup.c:1103: warning: nullPointer: Possible null pointer dereference: r <--[cppcheck]

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
 2019-05-29 10:10:23 +00:00
Andreas Schneider
025b32e525 s3:netapi: Use C99 initializer for poptOption in netapi example 
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
 2019-01-28 10:29:16 +01:00
Andreas Schneider
f68d6aa335 s3:lib: Use C99 initializer for poptOption in netapi nltest 
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
 2019-01-28 10:29:15 +01:00
Andreas Schneider
d34edc6b7b s3:lib: Use C99 initializer for poptOption in netapi common test 
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
 2019-01-28 10:29:15 +01:00
Volker Lendecke
5ba64d4968 netapi: Use dom_sid_str_buf 
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2018-12-11 00:40:31 +01:00
Andreas Schneider
dbdd57e31c s3:tests: Initialize pointers with NULL in netdisplay test 
Found by Undefined Sanitizer

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
 2018-11-22 22:13:26 +01:00
Volker Lendecke
1643c334db libsmb: Give dsgetdcname.c its own header 
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2018-04-11 01:06:39 +02:00
Volker Lendecke
43c104a8e2 s3: Avoid netlogon_creds_cli.h in includes.h 
There's no point recompiling all of source3 if netlogon_creds_cli.h is changed

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
 2017-09-16 08:36:16 +02:00
Jeremy Allison
dbd3293246 s3: clients: Use netlogon_creds_cli_close_global_db() in all normal exit paths. 
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12932

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
 2017-07-26 21:35:22 +02:00
Stefan Metzmacher
e0113918c5 s3:libsmb: remove unused 'bool show_hdr' from cli_cm_open() 
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
 2017-06-27 16:57:47 +02:00
Chris Lamb
a4ab7c73bd Correct "occured" typos. 
Signed-off-by: Chris Lamb <chris@chris-lamb.co.uk>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
 2017-02-22 08:26:21 +01:00
Stefan Metzmacher
af9783300c s3:lib/netapi: Use lp_client_ipc_max_protocol() in libnetapi_open_ipc_connection() 
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
 2016-12-19 09:48:24 +01:00
Stefan Metzmacher
5cb394a288 s3:lib/netapi: make use of set_cmdline_auth_info_signing_state_raw() 
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2016-10-21 20:44:23 +02:00
Günther Deschner
a72a52fca1 werror: replace WERR_UNKNOWN_LEVEL with WERR_INVALID_LEVEL in source3/lib/netapi/ 
Guenther

Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2016-09-28 00:04:34 +02:00
Günther Deschner
e325845d89 werror: replace WERR_DEFAULT_JOIN_REQUIRED with WERR_NERR_DEFAULTJOINREQUIRED in source3/lib/netapi/joindomain.c 
Guenther

Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2016-09-28 00:04:33 +02:00
Günther Deschner
b4d971314d werror: replace WERR_SETUP_DOMAIN_CONTROLLER with WERR_NERR_SETUPDOMAINCONTROLLER in source3/lib/netapi/joindomain.c 
Guenther

Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2016-09-28 00:04:32 +02:00
Günther Deschner
30ff33527d werror: replace WERR_SETUP_NOT_JOINED with WERR_NERR_SETUPNOTJOINED in source3/lib/netapi/joindomain.c 
Guenther

Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2016-09-28 00:04:31 +02:00
Günther Deschner
1ffcbd8840 werror: replace WERR_USER_NOT_FOUND with WERR_NERR_USERNOTFOUND in source3/lib/netapi/group.c 
Guenther

Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2016-09-28 00:04:26 +02:00
Günther Deschner
52420e763c werror: replace WERR_GROUPNOTFOUND with WERR_NERR_GROUPNOTFOUND in source3/lib/netapi/group.c 
Guenther

Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2016-09-28 00:04:25 +02:00
Günther Deschner
a3ac8e6600 werror: replace WERR_DEST_NOT_FOUND with WERR_NERR_DESTNOTFOUND in source3/lib/netapi/cm.c 
Guenther

Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2016-09-28 00:04:25 +02:00
Günther Deschner
9219c9df44 werror: replace WERR_NO_SUCH_SERVICE with WERR_SERVICE_DOES_NOT_EXIST in source3/lib/netapi/serverinfo.c 
Guenther

Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2016-09-28 00:04:24 +02:00
Günther Deschner
9bde08f153 werror: replace WERR_INVALID_PARAM with WERR_INVALID_PARAMETER in source3/lib/netapi/ 
Guenther

Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2016-09-28 00:04:22 +02:00
Günther Deschner
2324d9cd32 werror: replace WERR_GENERAL_FAILURE with WERR_GEN_FAILURE in source3/lib/netapi/ 
Guenther

Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2016-09-28 00:04:20 +02:00
Günther Deschner
db1c5d721b werror: replace WERR_NOMEM with WERR_NOT_ENOUGH_MEMORY in source3/lib/netapi/ 
Guenther

Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2016-09-28 00:04:18 +02:00
Amitay Isaacs
2d47c2b7a1 s3-netapi: Fix format-nonliteral warning 
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12168

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2016-08-24 01:33:50 +02:00
Andreas Schneider
169e8aeda5 s3-libnetapi: Correctly check for lp_realm. 
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
 2016-06-15 16:31:17 +02:00
Ralph Boehme
983a55bc45 CVE-2016-2115: s3:lib/netapi: use SMB_SIGNING_IPC_DEFAULT 
Use SMB_SIGNING_IPC_DEFAULT for RPC connections.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11756

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
 2016-04-12 19:25:26 +02:00
Aurelien Aptel
1f9d1f9cd7 s3/lib/netapi/tests/netuser.c: fix wrong closing paren 
Signed-off-by: Aurelien Aptel <aaptel@suse.com>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Revewied-by: Jeremy Allison <jra@samba.org>
 2016-02-25 22:06:27 +01:00
Mathieu Parent
c315fce17e Fix various spelling errors 
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Fri Nov  6 13:43:45 CET 2015 on sn-devel-104
 2015-11-06 13:43:45 +01:00
Anoop C S
b0a9a69bcc libnetapi: Fix 241166 Fixing logically dead code 
Signed-off-by: Anoop C S <achiraya@redhat.com>
Reviewed-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>

Autobuild-User(master): Michael Adam <obnox@samba.org>
Autobuild-Date(master): Thu Mar 26 17:30:27 CET 2015 on sn-devel-104
 2015-03-26 17:30:27 +01:00
Volker Lendecke
06a727e8f8 lib: Remove load_case_tables_library() 
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2015-03-24 00:00:20 +01:00
Anoop C S
73f951e98f libnetapi: Fix CID 1272947 Fix logically dead code 
Signed-off-by: Anoop C S <achiraya@redhat.com>
Reviewed-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
 2015-03-23 16:04:19 +01:00
Volker Lendecke
38628b1e32 Fix the O3 developer build 
Different gcc versions complain at different places

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>

Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Tue Mar  3 13:14:53 CET 2015 on sn-devel-104
 2015-03-03 13:14:53 +01:00
Andrew Bartlett
b299409410 netapi: Move DC check to NetJoinDomain() where it is needed. 
This partially reverts 15f6e27bd5a9065c8b781fa21f5989ce2c355776.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=10891

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andreas Schneider <asn@samba.org>
 2014-12-11 19:14:06 +01:00
Stefan Metzmacher
1669e5cdec s3:lib/netapi/examples: fix pointer from integer error in nltest.c 
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2014-11-25 07:25:44 +01:00
Stefan Metzmacher
1733df2811 s3:lib/netapi/tests: fix invalid switch enum level warning 
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2014-11-25 07:25:44 +01:00
Gabriel Buades
745a1c54b6 Change expired password flag indicator 
Signed-off-by: Gabriel Buades <gbuades@soffid.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Jim McDonough <jmcd@samba.org>
 2014-11-03 23:46:04 +01:00
Günther Deschner
eb8d914d91 s3-netapi: add DS_8 and WS flags to libnetapi and nltest. 
Guenther

Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
 2014-10-24 11:30:05 +02:00
Stefan Metzmacher
c8dca765a0 s3:lib/netapi: avoid calling cli_set_username() 
Change-Id: I3ab768d2df06749187555a16d7b930f7cc8f8b9f
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
 2014-10-17 12:57:07 +02:00
Stefan Metzmacher
71432b9eda s3:libsmb: Remove unused domain copy stored in cli_state 
Change-Id: I7333140906bb3a487205b5760396dcc00a9f49b0
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
 2014-10-17 12:57:07 +02:00
Andrew Bartlett
2b9d6d3d9b s3:libsmb: Remove unused password copy stored in cli_state 
Change-Id: Ia6b33a25628ae08be8a8c6baeb71ce390315cb45
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
 2014-10-17 12:57:07 +02:00
Stefan Metzmacher
80c57ab797 s3:lib/netapi/examples: remove unused variables 
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
 2014-04-02 09:03:43 +02:00
Stefan Metzmacher
7d3b35c155 s3:lib/netapi/examples: fix const warnings in netlogon_control2.c 
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
 2014-04-02 09:03:43 +02:00
Stefan Metzmacher
59394b3682 s3:lib/netapi/examples: fix invalid pointer value warnings in getjoininformation.c 
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
 2014-04-02 09:03:42 +02:00
Stefan Metzmacher
18c19d51d1 s3:lib/netapi: fix some incompatible pointer type warnings in NetGetJoinableOUs_l() 
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
 2014-04-02 09:03:42 +02:00
Garming Sam
f548585051 param: rename lp function and variable from "cli_maxprotocol" to "client_max_protocol" 
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2014-02-07 16:19:15 -08:00
Garming Sam
2ca2ab3550 param: rename lp function and variable from "serverstring" to "server_string" 
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
 2014-02-07 16:19:11 -08:00
Jeremy Allison
f799f63e43 CVE-2013-4408:s3:Ensure LookupRids() replies arrays are range checked. 
Bug: https://bugzilla.samba.org/show_bug.cgi?id=10185

Signed-off-by: Jeremy Allison <jra@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>

Autobuild-User(master): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(master): Mon Dec  9 09:00:41 CET 2013 on sn-devel-104
 2013-12-09 09:00:41 +01:00
Jeremy Allison
0dc6181894 CVE-2013-4408:s3:Ensure LookupNames replies arrays are range checked. 
Bug: https://bugzilla.samba.org/show_bug.cgi?id=10185

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Jeremy Allison <jra@samba.org>
 2013-12-09 07:05:46 +01:00
Hans Leidekker
4503bdf560 netapi: Add support for info level 502 in NetShareAdd. 
Signed-off-by: Hans Leidekker <hans@meelstraat.net>
Reviewed-by: Guenther Deschner <gd@samba.org>

Autobuild-User(master): Günther Deschner <gd@samba.org>
Autobuild-Date(master): Tue Nov 19 21:48:17 CET 2013 on sn-devel-104
 2013-11-19 21:48:17 +01:00