1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-13 13:18:06 +03:00
Commit Graph

881 Commits

Author SHA1 Message Date
Andrew Tridgell
31e50ccae7 r19114: fixed another checker warning and a possible error on allocation
failure
(This used to be commit bc02f7ef96)
2007-10-10 14:20:36 -05:00
Andrew Tridgell
f1f807e66b r19113: fixed another checker warning.
(This used to be commit d12550af01)
2007-10-10 14:20:35 -05:00
Andrew Tridgell
36246a191c r19112: fixed a checker warning.
In case you haven't noticed, lots of our packages now run the IBM
checker in the build farm on 'snab'
(This used to be commit b39a79f17c)
2007-10-10 14:20:35 -05:00
Volker Lendecke
06ac3dbd9a r19079: talloc_array can fail
(This used to be commit 441ad8a45c)
2007-10-10 14:20:34 -05:00
Volker Lendecke
ecd970abb6 r19076: ldb_dn_copy_partial can fail
(This used to be commit 78aa689a74)
2007-10-10 14:20:33 -05:00
Volker Lendecke
c56585e5fe r19075: Fix a potential NULL dereference
(This used to be commit 84ae80b39b)
2007-10-10 14:20:33 -05:00
Volker Lendecke
9bbc8736e7 r19074: Merge from 3_0: Fix a potential NULL dereference.
Volker
(This used to be commit af72af684b)
2007-10-10 14:20:33 -05:00
Simo Sorce
118dae99de r19069: The sequence number is a 64 bit unsigned integer
Well spotted Volker
(This used to be commit f4239ef598)
2007-10-10 14:20:33 -05:00
Volker Lendecke
19df909135 r19068: Fix a potential NULL dereference
(This used to be commit 2dff8ee8cc)
2007-10-10 14:20:33 -05:00
Andrew Tridgell
bf86ece6cb r19009: ensure that data values from ldap libs are null terminated, to allow
ldb_msg_find_attr_as_string() to work correctly.

Thanks to Jim Myers for spotting this!
(This used to be commit b2076c1a7e)
2007-10-10 14:20:28 -05:00
Andrew Bartlett
c2a2c2456d r18978: Fix bug found by:
http://www.ee.oulu.fi/research/ouspg/protos/testing/c06/ldapv3/

The issue here is that if the UTF8 conversion fails, because this
isn't actually UTF8 data, then we need to do a binary compare instead.

Andrew Bartlett
(This used to be commit a113e47784)
2007-10-10 14:20:26 -05:00
Andrew Tridgell
4c3b07b654 r18942: add a ldb_set_create_perms() function in ldb. I didn't call it
ldb_set_umask() (which is what we had discussed) as it doesn't
actually set the umask (in effect it sets the inverse of the umask -
the perms to be used for the file)
(This used to be commit 7e2ec87590)
2007-10-10 14:20:22 -05:00
Andrew Tridgell
4e7c9367a7 r18939: don't rely on the umask being right in ldb creation. Both Samba3 and
Samba4 smbd force the umask to 0, which meant we ended up with ldb
being world writable.

This isn't really an ideal fix, as it means ldb no longer honors umask
(as it should do, like all good libraries).

Unfortunately the 'proper' fix is too complex for now

this also merges a tiny code style fix from s4 to s3
(This used to be commit 1a42f38dfd)
2007-10-10 14:20:22 -05:00
Andrew Tridgell
26ece8f697 r18910: Change ldb_msg_add_string() to not actually add an attribute if the
string is zero length. This allows callers to not have to worry about
creating an invalid ldap attribute.

See extensive discussion on samba-technical list :-)
(This used to be commit 7a1db8c2a4)
2007-10-10 14:20:20 -05:00
Stefan Metzmacher
95340f8afb r18903: merge from samba3:
define HAVE_LDB_LDAP and HAVE_LDB_SQLITE3

metze
(This used to be commit 4e2f5ba490)
2007-10-10 14:20:19 -05:00
Volker Lendecke
1b8d6b3e7d r18894: Merge const fixes from 3_0
(This used to be commit 4ce447223c)
2007-10-10 14:20:19 -05:00
Simo Sorce
5e1e97a20d r18882: make style consistent
(This used to be commit a141ee9473)
2007-10-10 14:20:18 -05:00
Simo Sorce
df83913eb1 r18881: remove wrong check and statement.
to manipulate rootDSE we use ldb_dn_new() as base and that has 0 elements.
(This used to be commit 3e131177da)
2007-10-10 14:20:18 -05:00
Volker Lendecke
51f27dc3f1 r18851: Some C++ warnings
(This used to be commit 69f05f288c)
2007-10-10 14:20:16 -05:00
Andrew Tridgell
088c24e4e6 r18840: make these compatible with g++ warnings
(This used to be commit bcfa93954f)
2007-10-10 14:20:15 -05:00
Andrew Tridgell
45ca27699c r18834: get the log context code right
(This used to be commit b6bb5d7b77)
2007-10-10 14:19:16 -05:00
Andrew Tridgell
0b5e01c19b r18832: fixed standalone build
(This used to be commit 1ebc098b67)
2007-10-10 14:19:15 -05:00
Andrew Tridgell
58619eebc1 r18831: minor build changes for samba3. The logging changes will be removed
when the tdb api is updated
(This used to be commit 6ace943fac)
2007-10-10 14:19:15 -05:00
Andrew Tridgell
6c86ed60fc r18830: ensure backends aren't added twice (needed for samba3)
(This used to be commit 54b864b491)
2007-10-10 14:19:15 -05:00
Andrew Bartlett
77db3973c4 r18781: Move the usnCreated and usnChanged handling around again.
This moves these attributes from objectguid into an optional backend
(objectguid), used by ltdb.  For OpenLDAP, the entryUUID module
converts entryCSN into usnChanged.

This also changes the sequence number API, and uses 'time based'
sequence numbers, when an LDAP or similar backend is detected.

To assist this, we also store the last modified time in the TDB,
whenever we change a value.

Andrew Bartlett
(This used to be commit 72858f8594)
2007-10-10 14:19:11 -05:00
Simo Sorce
8d1b32083e r18777: add helper functions to create an ldb_request structure
(This used to be commit bcbe82873f)
2007-10-10 14:19:11 -05:00
Andrew Bartlett
df98ee6558 r18770: Avoid crashes and fix up other issues in the client-side paged_searches module.
In particular, we must query the remote server to find out if paged
searches are supported, not the local ldb.

This patch also removes the ue of bool, and returns it to LDB error codes.

Andrew Bartlett
(This used to be commit d36d05858b)
2007-10-10 14:19:10 -05:00
Andrew Tridgell
1188fa1a18 r18602: updated web page for new ldb build method
(This used to be commit 36c35262f2)
2007-10-10 14:18:55 -05:00
Andrew Tridgell
ee528dc0f2 r18596: removed superfluous semicolon
(This used to be commit 4f3628dea6)
2007-10-10 14:18:54 -05:00
Simo Sorce
9dd6cac44a r18591: Better defaults for share creation
Fix logic error in paged_results
(This used to be commit 34ce1f8e1b)
2007-10-10 14:18:53 -05:00
Andrew Tridgell
182ab7107c r18539: 'make distclean' should delete config.cache
(This used to be commit 5a8becb1be)
2007-10-10 14:18:43 -05:00
Andrew Tridgell
1d7a878c8b r18538: we need a pipe here, not a logical OR
also fix cn name for this record, and ensure tests/tmp is created
(This used to be commit 588c91f06b)
2007-10-10 14:18:43 -05:00
Andrew Tridgell
0e9147029f r18536: fixed the loading of external binary files from ldif into ldb
(This used to be commit fbe13ed83e)
2007-10-10 14:18:43 -05:00
Andrew Tridgell
fafa8c3e47 r18535: move the AC_CANONICAL_HOST and host specific flag tests into
libreplace. This should fix the standalone build of tdb on HPUX, where
we need to blacklist mmap.

Unfortunately this requires that we have a copy of config.guess and
config.sub in each of our project subdirectories. I tried to find a
way to use something like AC_CONFIG_AUX_DIR($libreplacedir) and just
put config.{guess,sub} in the lib/replace/ directory, but I couldn't
figure out how to do that in a way that kept autoconf happy for each
of our separate builds. Any autoconf guru out there see a way to do
this?
(This used to be commit 823cd3ab35)
2007-10-10 14:18:42 -05:00
Jelmer Vernooij
e9c465621e r18515: Remove calls to "time" for now as some sh implementations don't have it,
causing this test to fail.
(This used to be commit fc3f41a4ab)
2007-10-10 14:18:40 -05:00
Andrew Bartlett
595c141a69 r18504: Handle mappings for RENAME and KEEP attributes better. We don't need
to mess with the values in these cases.

Where we do convert the values, try and convert substrings.  This
isn't going to be perfect, but we should try rather than segfault.

This also avoids using the wrong arm of the union for the attribute
name

The change in the entryUUID module is to correct the case of
sAMAccountName, due to the case sensitive ldap.js test.

Andrew Bartlett
(This used to be commit 81d9a692c1)
2007-10-10 14:18:40 -05:00
Andrew Bartlett
1e4f5a096c r18495: More work on the LDAP backend (which now passes a lot of our tests!)
This adds a list of attributes that are in our wildcard seaches, but
the remote server requires to be explicitly listed.  This also cleans
up the handling of wildcards in ldb_map to be more consistant.

Also fix the partitions module to rebase the search, if on the GC
port, we do a subtree search.  (Otherwise backends can rightly
complain that the search is not in their scope).

Andrew Bartlett
(This used to be commit bc58792b71)
2007-10-10 14:18:38 -05:00
Stefan Metzmacher
d08fb7b1cc r18485: include libreplace.m4 in the aclocal.m4 files
and use the macros in configure.ac

metze
(This used to be commit 95d33e4d71)
2007-10-10 14:18:36 -05:00
Andrew Tridgell
05cdd9ccaf r18439: 2nd try at a talloc_move() api. This type with the ** ptr interface
exposed.

Unfortunately this generates a large number of type punning
warnings. We'll have to find some magic to hide those.
(This used to be commit 254cbf09de)
2007-10-10 14:18:29 -05:00
Andrew Tridgell
24fe49a3d1 r18438: I should have examined these uses of talloc_move() more
carefully. Most of them are OK, but a couple were not.
(This used to be commit b0de283882)
2007-10-10 14:18:29 -05:00
Andrew Tridgell
12e7682e7b r18437: added a 'make valgrindtest' target for ldb
(This used to be commit 4c33c6bb97)
2007-10-10 14:18:29 -05:00
Andrew Tridgell
7f63cebd33 r18436: converted ldb to use talloc_move() instead of talloc_steal() when
appropriate.

Note that I also removed the error checks that were being done on the
result of talloc_steal(). They are pointless as talloc_steal() doesn't
have any failure modes that wouldn't cause a segv anyway, and they
tend to clutter the code
(This used to be commit c0d9e7d473)
2007-10-10 14:18:29 -05:00
Andrew Bartlett
33c4fea4cd r18410: Reduce noise in the ldb_ildap backend. We regularly search for things
that don't exist, and this is not a cause for panic.

Andrew Bartlett
(This used to be commit c89e416d28)
2007-10-10 14:18:25 -05:00
Andrew Tridgell
81e4403e79 r18347: run slapd in the foreground so timelimit can kill it
(This used to be commit 8cc456e6dc)
2007-10-10 14:18:14 -05:00
Andrew Tridgell
d939ff7bee r18346: make sure we kill off the slapd process
(This used to be commit 0e1d4be23a)
2007-10-10 14:18:13 -05:00
Andrew Tridgell
f658414c5f r18327: 'struct token' is defined on some hosts
(This used to be commit b2bba4e726)
2007-10-10 14:18:09 -05:00
Andrew Tridgell
9adf2883ef r18321: fixed some warnings on AIX
(This used to be commit 449fab2c26)
2007-10-10 14:18:08 -05:00
Simo Sorce
fb15300c60 r18317: Make sure we actually have a valid reply or fail
(This used to be commit 41cb3a9258)
2007-10-10 14:18:07 -05:00
Andrew Tridgell
e91cee468e r18309: FreeBSD 6.1 has a symbol ldap_new_connection() in the system ldap
library. Even though we don't like to that library, it gets loaded via
nss-ldap, which means nss-ldap calls into the samba ldap lib with the
wrong parameters, and crashes.

We really need to use a completely different namespace in libcli/ldap/
(This used to be commit c440e0eed9)
2007-10-10 14:18:06 -05:00
Andrew Tridgell
30ee8beb93 r18301: I discovered how to load the warnings from a build farm build into
emacs compile mode (hint, paste to a file, and compile as "cat
filename").

This allowed me to fix nearly all the warnings for a IA_64 SuSE build
very quickly.
(This used to be commit eba6c84eff)
2007-10-10 14:18:04 -05:00