Günther Deschner
690ed0c5e2
s3-rpc: when using rpc_pipe_open_internal, make sure to go through NDR.
...
Otherwise a lot of information that is usually generated in the ndr_push remains
in an uninitialized state.
Guenther
2010-07-08 16:35:26 +02:00
Simo Sorce
7236f8cda9
s3:dcerpc Use prs_parse_dcerpc_bind
2010-07-08 01:41:29 -04:00
Simo Sorce
ae526514a9
s3:rpc user idl define dcerpc_ctx_list instead of custom RPC_CONTEXT
2010-07-08 01:08:05 -04:00
Günther Deschner
0cbe0f3c5f
s3-dcerpc: use dcerpc_push_ncacn_packet() for setup_fault_pdu().
...
Guenther
Signed-off-by: Simo Sorce <idra@samba.org>
2010-07-07 23:45:50 -04:00
Günther Deschner
8fdc02aa63
s3-dcerpc: use dcerpc_push_ncacn_packet() for setup_bind_nak().
...
Guenther
Signed-off-by: Simo Sorce <idra@samba.org>
2010-07-07 23:45:50 -04:00
Volker Lendecke
b4c3f72d44
s3: Fix a segfault in the RPC server
...
After converting the rpc infratructure to talloc, read_from_internal_pipe freed
the outdata too early. If the last fragment was read in two pieces (as
rpcclient does it), all the outdata was freed during the read of the first
piece of the read of the last fragment. Later read&x calls, trying to read the
rest of the last fragment stepped into p->out_data.frag with non-zero offset
when this was already freed.
2010-07-06 15:11:31 +02:00
Matthias Dieter Wallnöfer
915ddf0dc7
samr.idl:UserInfo structures - fix some names according to MS-SAMR documentation
...
See MS-SAMR section "FULL IDL"
2010-07-05 15:35:54 +02:00
Volker Lendecke
dfc84ece9d
s3: Remove procid_self() from srv_spoolss_reply[open|close]printer()
2010-07-05 11:06:32 +02:00
Volker Lendecke
6436ea3e7a
s3: Remove procid_self() from srv_spoolss_drv_upgrade_printer()
2010-07-05 11:06:31 +02:00
Volker Lendecke
b0c83d50f9
s3: Replace register_message_flags() with serverid_register_msg_flags()
...
message_send_all is now done by walking the serverid.tdb, not the
connections.tdb anymore.
Günther, Simo, please check!
2010-07-04 21:49:03 +02:00
Günther Deschner
786198e523
s3-registry: remove unused reg_util_marshalling code.
...
Guenther
2010-07-02 10:50:21 +02:00
Günther Deschner
b381fba089
s3-registry: avoid using registry_value union.
...
Just pull and push data as is.
Guenther
2010-07-02 10:50:21 +02:00
Simo Sorce
3721161d90
s3:auth Fix switch statement referencing a uninitialized variable
...
Looking at the original commit (9a747d500f
)
this seem the right solution.
Andrew please check.
2010-07-01 18:18:41 -04:00
Günther Deschner
e4ba8fb3b9
s3-printing: Fix Bug #7541 , %D in "printer admin" causing smbd crash.
...
Guenther
2010-07-01 14:13:16 +02:00
Günther Deschner
2a4bd64973
s3-winreg: implement _winreg_QueryMultipleValues().
...
Guenther
2010-06-30 21:46:08 +02:00
Günther Deschner
de0d9e0bff
s3-winreg: implement _winreg_QueryMultipleValues2().
...
Guenther
2010-06-30 21:46:08 +02:00
Andreas Schneider
f8b6ac6a08
s3-eventlog: Fixed the keyname delimiter for the registry key.
2010-06-28 12:56:13 +02:00
Günther Deschner
b6100fa72f
s3-eventlog: make sure _eventlog_OpenEventLogW fails when we cannot open the registry key.
...
Guenther
2010-06-28 12:53:10 +02:00
Jeremy Allison
2e8c563961
Second part of fix converting prs_XX struct and functions to talloc. Remove unneeded prs_mem_free calls.
...
Jeremy.
Signed-off-by: Simo Sorce <idra@samba.org>
2010-06-18 07:42:05 -04:00
Jeremy Allison
f4e7d9d38e
Convert the prs_XXX struct and functions to use talloc instead of malloc. Passes valgrind and make tests for client and server. Second version of this patch after splitting up at Simo's request. Patch to follow will delete extraneous prs_mem_free() calls.
...
Jeremy.
Signed-off-by: Simo Sorce <idra@samba.org>
2010-06-18 07:41:47 -04:00
Jeremy Allison
7e388c8b27
Remove an unused chunk of code (will make it easier to talloc'ize prs_XXX).
...
Jeremy.
2010-06-16 10:27:54 -07:00
Andreas Schneider
47ae4a518c
s3-spoolss: Provide a memory context for clean_up_driver_struct().
...
If we use a stack variable to setup spoolss_AddDriverInfoCtr this would
segfault with a talloc bad magic value.
2010-06-16 12:03:46 +02:00
Volker Lendecke
3f7e2222f4
s3: Remove the pointless PRINTERNAME macro
2010-06-13 12:40:27 +02:00
Simo Sorce
a53ca94416
s3:rpc improve handles memory hierarchy and use better name.
...
While there also cleanup the code a bit.
Signed-off-by: Günther Deschner <gd@samba.org>
2010-06-11 00:43:23 +02:00
Andreas Schneider
0962763822
s3:misc make use of server_[event/messaging]_context directly
...
Untangle these functions from smbd specific dependencies so they can be freely
used in multiple servers.
2010-06-10 17:30:45 -04:00
Simo Sorce
405a0c558c
s3:cleaunp reformatting for readability
2010-06-10 14:57:06 -04:00
Simo Sorce
446deb0082
s3:cleanup remove trailing spaces
2010-06-10 14:56:59 -04:00
Volker Lendecke
34b29b1198
Revert "s3:auth Change auth_ntlmssp_server_info API to return NTSTATUS"
...
This reverts commit edba46ce94
.
Conflicts:
source3/auth/auth_ntlmssp.c
2010-06-08 11:38:08 +02:00
Simo Sorce
5da783f4a7
s3:smbd add utility function to check if there are open pipes
2010-06-07 17:25:48 -04:00
Simo Sorce
f9fc4df0c0
s3:rpc make num_pipe_handles get an actual pipe as argument
...
Let the function abstract out how handles are counted
2010-06-07 17:25:48 -04:00
Simo Sorce
22e9015e97
s3:rpc handles are used by all pipes, use better name
2010-06-07 17:25:48 -04:00
Simo Sorce
f7e2e8370b
s3:rpc fix potential out of bound memory access
...
memcpy copies memory unconditionally, we are passing "" in some cases here.
Use strncpy which will stop reading from src if the null byte is found and
will fill with nulls the destination.
2010-06-07 17:25:47 -04:00
Andrew Bartlett
9a747d500f
s3:auth add hooks to indicate if signing or sealing is desired with NTLMSSP
...
This allows the right hooks to be called in GENSEC when s3compat
implements the auth_ntlmssp interface. Otherwise, we can't do the
signing or sealing as we have not negoitated it's use.
Andrew Bartlett
2010-06-07 23:34:29 +10:00
Andrew Bartlett
edba46ce94
s3:auth Change auth_ntlmssp_server_info API to return NTSTATUS
...
It's nicer to have an NTSTATUS return, and in s3compat there may be a
reason other than 'no memory' why this can fail.
Andrew Bartlett
2010-06-07 23:34:29 +10:00
Andrew Bartlett
0af2dc43ad
s3:named pipe proxy Improve error messages when named pipes fail to forward
...
I hope this helps the next person who needs to debug this.
Andrew Bartlett
2010-06-07 23:34:29 +10:00
Günther Deschner
4591fdbc18
s3-privileges: use LUID defines from lsa IDL.
...
Guenther
2010-06-07 10:33:36 +02:00
Andreas Schneider
15f64af8e3
s3-rpc: Create a file with all functions for a internal named pipe.
...
This makes it possible to use the samr rpc server in winbind without
linking in smbd.
Reviewed-by: Simo Sorce <idra@samba.org>
2010-06-04 12:12:50 -04:00
Andreas Schneider
3344adc340
s3-rpc: Seperate rpc_srv_register for plain connection.
...
This will make it possible to create plain rpc named pipe connnections.
Reviewed-by: Simo Sorce <idra@samba.org>
2010-06-04 12:12:43 -04:00
Günther Deschner
84a8f0451d
s3-build: only include generated spoolss headers (not ndr headers).
...
Guenther
2010-06-03 11:00:27 +02:00
Günther Deschner
b6a2cea74d
s3-security: use shared "Standard access rights.".
...
Guenther
2010-06-03 11:00:26 +02:00
Günther Deschner
b5c2af9447
s3-security: use shared "File Object specific access rights".
...
Guenther
2010-06-03 11:00:25 +02:00
Günther Deschner
2794d2ee7f
s3-security: use shared Security Access Masks Rights.
...
Guenther
2010-06-03 11:00:25 +02:00
Günther Deschner
a75436e3ee
s3-security: use shared SECINFO_DACL define.
...
Guenther
2010-06-03 11:00:12 +02:00
Günther Deschner
e24a59f932
s3-security: use shared SECINFO_SACL define.
...
Guenther
2010-06-03 10:59:54 +02:00
Günther Deschner
630c27bdad
s3-security: use shared SECINFO_GROUP define.
...
Guenther
2010-06-03 10:59:38 +02:00
Günther Deschner
415d3d5fe7
s3-security: use shared SECINFO_OWNER define.
...
Guenther
2010-06-03 10:59:15 +02:00
Günther Deschner
1ba611a56c
s3-eventlog: try to pass RPC-EVENTLOG during make test as non-root.
...
Guenther
2010-06-01 23:05:17 +02:00
Günther Deschner
fca69a9e2f
s3-netlogon: Fix crash bug in _netr_NetrEnumerateTrustedDomains().
...
Guenther
2010-05-31 21:27:29 +02:00
Simo Sorce
471ed70c49
s3:smbd map_username() doesn't need sconn anymore
...
Signed-off-by: Andreas Schneider <asn@samba.org>
2010-05-31 18:21:29 +02:00
Günther Deschner
98641648d8
s3-netlogon: use LSA in _netr_NetrEnumerateTrustedDomains.
...
Guenther
2010-05-31 15:31:00 +02:00