1
0
mirror of https://github.com/samba-team/samba.git synced 2025-06-22 07:17:05 +03:00

249 Commits

Author SHA1 Message Date
Volker Lendecke
3df0bf7d60 r16360: Fix Klocwork ID 136 520 521 522 523 542 574 575 576 607
in net_rpc.c: 715 716 732 734 735 736 737 738 739 749

in net_rpc_audit.c: 754 755 756

in net_rpc_join.c: 757

in net_rpc_registry: 766 767

in net_rpc_samsync.c: 771 773

in net_sam.c: 797 798

Volker
2007-10-10 11:18:48 -05:00
Günther Deschner
446d79a000 r16345: Improve the chance that our users can discover one of the coolest 'net'
features.

Guenther
2007-10-10 11:17:37 -05:00
Günther Deschner
5d776d5fab r16344: Allow to set passwords directly when creating users via "net rpc user
add" (as the documentation says, and currently onle "net ads user add"
did). Fixes #3843.

Guenther
2007-10-10 11:17:36 -05:00
Jeremy Allison
face01ef01 r16284: Start fixing up gcc4 -O6 warnings on an x86_64 box. size_t != unsigned
int
in a format string.
Jeremy.
2007-10-10 11:17:31 -05:00
Volker Lendecke
a85dfb9eff r15657: Fix some Tru64 warnings 2007-10-10 11:17:05 -05:00
Gerald Carter
4c4ea7b20f r15543: New implementation of 'net ads join' to be more like Windows XP.
The motivating factor is to not require more privileges for
the user account than Windows does when joining a domain.

The points of interest are

* net_ads_join() uses same rpc mechanisms as net_rpc_join()
* Enable CLDAP queries for filling in the majority of the
  ADS_STRUCT->config information
* Remove ldap_initialized() from sam/idmap_ad.c and
  libads/ldap.c
* Remove some unnecessary fields from ADS_STRUCT
* Manually set the dNSHostName and servicePrincipalName attribute
  using the machine account after the join

Thanks to Guenther and Simo for the review.

Still to do:

* Fix the userAccountControl for DES only systems
* Set the userPrincipalName in order to support things like
  'kinit -k' (although we might be able to just use the sAMAccountName
  instead)
* Re-add support for pre-creating the machine account in
  a specific OU
2007-10-10 11:16:57 -05:00
Volker Lendecke
f21adc04f7 r15471: Clarify error message 2007-10-10 11:16:51 -05:00
Günther Deschner
e55e1e1e96 r15198: Mention the auditing tool in "net rpc help".
Guenther
2007-10-10 11:16:28 -05:00
Günther Deschner
ba81b508ca r15194: We need to be able to join as PDC as well. Thanks to Andrew Bartlett.
Guenther
2007-10-10 11:16:28 -05:00
Volker Lendecke
0ef5e4372c r15137: Refuse to join if our netbios name is longer than 15 chars. I think this is
sufficient to fix bug #3659.

Volker
2007-10-10 11:16:26 -05:00
Volker Lendecke
a6e88785e7 r15136: Fix join consistency check 2007-10-10 11:16:25 -05:00
Günther Deschner
22b6875897 r15123: Don't even try to join with an inproper configuration.
Guenther
2007-10-10 11:16:25 -05:00
Gerald Carter
a95d11345e r15053: fix portabilities issues between 32-bit winbind clients and a 64-bit winbindd server 2007-10-10 11:16:00 -05:00
Günther Deschner
0fed66926f r15041: Adding rpc client calls to manipulate auditing policies on remote CIFS
servers. Also add a new "net rpc audit" tool. The lsa query infolevels
were taken from samb4 IDL, the lsa policy flags and categories are
partly documented on msdn. I need to cleanup the double
lsa_query_info_policy{2}{_new} calls next.

Guenther
2007-10-10 11:15:59 -05:00
Volker Lendecke
ba41c62b8b r15011: Fix bug # 2413. net rpc info can't reliably work anonymously anymore.
Volker
2007-10-10 11:15:56 -05:00
Volker Lendecke
1df58c7a00 r14101: Fix a segfault in trustdom establish, cli is NULL here. 2007-10-10 11:11:12 -05:00
Jeremy Allison
1d710d06a2 r13915: Fixed a very interesting class of realloc() bugs found by Coverity.
realloc can return NULL in one of two cases - (1) the realloc failed,
(2) realloc succeeded but the new size requested was zero, in which
case this is identical to a free() call.

The error paths dealing with these two cases should be different,
but mostly weren't. Secondly the standard idiom for dealing with
realloc when you know the new size is non-zero is the following :

 tmp = realloc(p, size);
 if (!tmp) {
    SAFE_FREE(p);
    return error;
 } else {
    p = tmp;
 }

However, there were *many* *many* places in Samba where we were
using the old (broken) idiom of :

 p = realloc(p, size)
 if (!p) {
    return error;
 }

which will leak the memory pointed to by p on realloc fail.

This commit (hopefully) fixes all these cases by moving to
a standard idiom of :

 p = SMB_REALLOC(p, size)
 if (!p) {
    return error;
 }

Where if the realloc returns null due to the realloc failing
or size == 0 we *guarentee* that the storage pointed to by p
has been freed. This allows me to remove a lot of code that
was dealing with the standard (more verbose) method that required
a tmp pointer. This is almost always what you want. When a
realloc fails you never usually want the old memory, you
want to free it and get into your error processing asap.

For the 11 remaining cases where we really do need to keep the
old pointer I have invented the new macro SMB_REALLOC_KEEP_OLD_ON_ERROR,
which can be used as follows :

 tmp = SMB_REALLOC_KEEP_OLD_ON_ERROR(p, size);
 if (!tmp) {
    SAFE_FREE(p);
    return error;
 } else {
    p = tmp;
 }

SMB_REALLOC_KEEP_OLD_ON_ERROR guarentees never to free the
pointer p, even on size == 0 or realloc fail. All this is
done by a hidden extra argument to Realloc(), BOOL free_old_on_error
which is set appropriately by the SMB_REALLOC and SMB_REALLOC_KEEP_OLD_ON_ERROR
macros (and their array counterparts).

It remains to be seen what this will do to our Coverity bug count :-).

Jeremy.
2007-10-10 11:10:59 -05:00
Günther Deschner
5b89e8bc24 r13711: * Correctly handle acb_info/acct_flags as uint32 not as uint16.
* Fix a couple of related parsing issues.
* in the info3 reply in a samlogon, return the ACB-flags (instead of
  returning zero)

Guenther
2007-10-10 11:10:25 -05:00
Gerald Carter
9eb743584d r13382: added server affinity cache stores for 'net rpc join' and trusted domain code 2007-10-10 11:09:57 -05:00
Gerald Carter
17e63ac4ed r13316: Let the carnage begin....
Sync with trunk as off r13315
2007-10-10 11:06:23 -05:00
Lars Müller
f650e3bdaf r12986: Use d_fprintf(stderr, ...) for any error message in net.
All 'usage' messages are still printed to stdout.

Fix some compiler warnings for system() calls where we didn't used the
return code.  Add appropriate error messages and return with the error
code we got from system() or NT_STATUS_UNSUCCESSFUL.
2007-10-10 11:06:09 -05:00
Günther Deschner
e0be0e0523 r12338: add ifdef DEBUG_PASSWORD before printing clear text password.
Guenther
2007-10-10 11:05:54 -05:00
Jeremy Allison
d720867a78 r11137: Compile with only 2 warnings (I'm still working on that code) on a gcc4
x86_64 box.
Jeremy.
2007-10-10 11:05:02 -05:00
Jim McDonough
8075b99b44 r10909: Give better shutdown messages 2007-10-10 11:04:56 -05:00
Gerald Carter
939c3cb5d7 r10656: BIG merge from trunk. Features not copied over
* \PIPE\unixinfo
* winbindd's {group,alias}membership new functions
* winbindd's lookupsids() functionality
* swat (trunk changes to be reverted as per discussion with Deryck)
2007-10-10 11:04:48 -05:00
Gerald Carter
ffe4188847 r10431: fix segfault when the pip open fails in 'net rpc' commands 2007-10-10 11:03:41 -05:00
Jim McDonough
7af7343d9c r10247: Fix help text for net rpc shutdown. 2007-10-10 11:03:39 -05:00
Gerald Carter
ace8556b65 r9787: BUG 2998: patch from Humberto Diogenes <virtual.spirit@digizap.com.br> to include 'net rpc service' help in net rpc usage output 2007-10-10 11:03:26 -05:00
Tim Potter
e928a20c2b r8935: Fix signed/unsigned comparison warning. Bugzilla #2943. 2007-10-10 11:00:21 -05:00
Günther Deschner
bf67a86114 r8911: cosmetic fixes.
Guenther
2007-10-10 11:00:19 -05:00
Volker Lendecke
503a58b6be r8833: Fix some uninitialized variables.
Volker
2007-10-10 11:00:18 -05:00
Jim McDonough
cb5634a305 r8189: commit vampire ldif patch, mostly from Don Watson (dwatson@us.ibm.com). Yes,
that's my copyright...that's just how we have to do things at big blue.

Adds subcommand to vampire to allow data to be put into an ldif file instead
of actually writing to the passdb.  See "net rpc help vampire" for usage
info.  This should be added to docs as well.
2007-10-10 10:58:18 -05:00
Jeremy Allison
9506b8e145 r7882: Looks like a large patch - but what it actually does is make Samba
safe for using our headers and linking with C++ modules. Stops us
from using C++ reserved keywords in our code.
Jeremy
2007-10-10 10:58:00 -05:00
Günther Deschner
6f4d4acc86 r7876: Now that we have "net rpc share migrate security" completly remove the
share-acl from "net rpc share migrate shares".

God, how ugly does this syntax get.

Guenther
2007-10-10 10:57:59 -05:00
Jeremy Allison
a667d9e474 r7852: Correct fix from Lars for the argv issue.
Jeremy.
2007-10-10 10:57:59 -05:00
Jeremy Allison
5fbabaef8c r7849: Dodgy fix - we shouldn't be assuming argc++ points to a valid argv.
Jeremy.
2007-10-10 10:57:59 -05:00
Günther Deschner
97097497ae r7632: Cleanup "net share migrate"-code.
* Allow to copy share security descriptors to already existing shares
  separatly.

* Added abstraction function to enum all or a single share info

Guenther
2007-10-10 10:57:17 -05:00
Lars Müller
2c68568e52 r7609: Move top level dir handling in from of the loop. This makes the code
much straither.

copy_top_level_perms() is jra's work.

I modified the copy_top_level_perms() function to use the copy_clistate.

And I don't forget trunk.

Lars
2007-10-10 10:57:16 -05:00
Günther Deschner
1815e0745e r7532: compile fix.
Guenther
2007-10-10 10:57:11 -05:00
Lars Müller
506aaefa37 r7512: Fix net share migrate files to also migrate the ACLs of the top level
dir of a share.  Till now we excluded '.' and '..' in general.  For the
fix the information about top or lower level dir is stored in the
copy_clistate.  src and dst share are now also part of this struct and
we only pass a pointer to the struct to the functions.

This bug was found by Bill Calero of Novell.  Thanks Bill!

With this checkin no new functionality was added.  But the copy_clistate
already knows about a mode. Later beside the migrate an additional
report mode will be added.

This changes are coordinated with Günther <gd>.

Lars
2007-10-10 10:57:10 -05:00
Gerald Carter
a0ac9a8ffd r7415: * big change -- volker's new async winbindd from trunk 2007-10-10 10:57:08 -05:00
Günther Deschner
5125852939 r7391: - Added client-support for various lsa_query_trust_dom_info-calls and a
rpcclient-tester for some info-levels.

  Jerry, I tried to adopt to prs_pointer() where possible and to not
  interfere with your work for usrmgr.

- Add "net rpc trustdom vampire"-tool.

  This allows to retrieve Interdomain Trust(ed)-Relationships from
  NT4-Servers including cleartext-passwords (still stored in the local
  secrets.tdb).

  The net-hook was done in cooperation with Lars Mueller
  <lmuelle@suse.de>.

  To vampire trusted domains simply call:

        net rpc trustdom vampire -S nt4dc -Uadmin%pass

Guenther
2007-10-10 10:57:07 -05:00
Gerald Carter
3002aa2250 r6943: missed in last sync 2007-10-10 10:56:58 -05:00
Volker Lendecke
f25da82ffd r6880: Fix bug 2070 after positive feedback from Leon Vernikov. Thanks!
Volker
2007-10-10 10:56:56 -05:00
John Terpstra
11804521f9 r6823: Add deletion confirmation / error message. 2007-10-10 10:56:55 -05:00
Gerald Carter
c43c1ec80c r6601: fixing query and set alias info calls (level 1 from the
MMC manage computer plugin.
2007-10-10 10:56:46 -05:00
Volker Lendecke
3493d9f383 r6263: Get rid of generate_wellknown_sids, they are const static and initializable
statically.

Volker
2007-10-10 10:56:33 -05:00
Gerald Carter
6bbd61cfd1 r6029: adding files necessary to support 'net rpc service' functions; will fill in tomorrow 2007-10-10 10:56:16 -05:00
Günther Deschner
45a2a7bedb r5954: Fix some compiler warnings and add missing exclude-block in "net rpc
share migrate" (found by Lars Mueller <lmuelle@suse.de>).

Guenther
2007-10-10 10:56:11 -05:00
Volker Lendecke
ab8991c384 r5910: Partial fix for bug 2438. I'll leave the debug message in place, that fix is a
bit more effort.

The real fix for this would be to open an schannel netlogon connection to the
remote DC and change the trust account password...

Volker
2007-10-10 10:56:08 -05:00