1
0
mirror of https://github.com/samba-team/samba.git synced 2025-11-21 12:23:50 +03:00
Commit Graph

48 Commits

Author SHA1 Message Date
Andrew Bartlett
582073eff1 Ensure we don't try and set the acct_flags if they are 0 (meaning
unchanged in this interface).

We seem to have two very similar interfaces here, and this is the
poorer interface, for this reason.

Andrew Bartlett
2008-02-28 10:43:57 +11:00
Rafal Szczesniak
9ff6568f95 r26633: A couple of fixes in comments. 2007-12-30 13:21:01 -06:00
Jelmer Vernooij
566aa14139 r25554: Convert last instances of BOOL, True and False to the standard types. 2007-10-10 15:07:55 -05:00
Rafal Szczesniak
4fe47e4f97 r25256: Fix missing field set in libnet_ModifyUser routine.
Submitted by Matthias Dieter Wallnoefer <mwallnoefer@yahoo.de>

rafal
2007-10-10 15:07:00 -05:00
Andrew Bartlett
078671d501 r24127: Set the Domain SID into the libnet context, and have libnet_UserInfo
return full SIDs for the user SID and primary group sid.

This should help kai with his getpwnam work in winbind.

Andrew Bartlett
2007-10-10 15:01:27 -05:00
Andrew Tridgell
fcf38a38ac r23792: convert Samba4 to GPLv3
There are still a few tidyups of old FSF addresses to come (in both s3
and s4). More commits soon.
2007-10-10 14:59:12 -05:00
Stefan Metzmacher
58551f2f28 r22944: fix bug #4618:
rename private -> private_data

metze
2007-10-10 14:52:30 -05:00
Rafal Szczesniak
0c37360577 r20162: Always return some error string.
rafal
2007-10-10 14:29:16 -05:00
Rafal Szczesniak
1f3fd5f854 r20103: Change the returned type of prerequisite checking functions,
as metze once suggested.

rafal
2007-10-10 14:29:06 -05:00
Rafal Szczesniak
f4621dae44 r19970: more comments and fixes
rafal
2007-10-10 14:28:42 -05:00
Rafal Szczesniak
2b60090ca6 r19956: remove unused function
rafal
2007-10-10 14:28:40 -05:00
Rafal Szczesniak
0dbba04fe0 r19938: Return function status instead of rpc layer status. This is
needed to correctly return STATUS_MORE_ENTRIES and the like.

rafal
2007-10-10 14:28:39 -05:00
Rafal Szczesniak
4ccc6e63dd r19922: Use new composite_create functions in composite context
initialisation.
Redesign libnet_UserList function to actually do what it
was intended to do.

rafal
2007-10-10 14:28:36 -05:00
Rafal Szczesniak
d5f7141a6c r19753: verify result of received request before sending the next one.
I don't know why I forgot this...

rafal
2007-10-10 14:28:19 -05:00
Rafal Szczesniak
1ea37bf3b3 r19640: add some comments
rafal
2007-10-10 14:25:23 -05:00
Rafal Szczesniak
4e6d479b07 r19586: draft version of libnet_UserList function. still a bit of work
to do left.

rafal
2007-10-10 14:24:57 -05:00
Rafal Szczesniak
2ed463e3cd r19398: more comments
rafal
2007-10-10 14:21:25 -05:00
Rafal Szczesniak
7ca0d3dbcb r19024: remove read-only and policy dependent fields and flags
from user modify routines.

rafal
2007-10-10 14:20:29 -05:00
Rafal Szczesniak
e2621d0063 r18656: fix stupid mistake causing segfaults in torture test
and also add one more field to be set.

rafal
2007-10-10 14:19:00 -05:00
Rafal Szczesniak
06e0c5d166 r18615: add more time fields and fix a silly mistake.
rafal
2007-10-10 14:18:56 -05:00
Rafal Szczesniak
4a932255a0 r17856: The two new functions - libnet_LookupName and libnet_UserInfo.
These two perform name resolving in SAM database and fetching
user account information, respectively. The code is quite rough
yet, but it builds and basic tests work. Now, I'm working on
cleaning it up...

rafal
2007-10-10 14:16:48 -05:00
Rafal Szczesniak
fe5652c2b8 r17670: 1) Refactor libnet context structure a bit, to have rpc connection
properties more consistently reflected.
2) Add domain open routine for lsa pipe - this is needed for ongoing
   name resolve function.

Tests (still neglected) and comments to follow.

rafal
2007-10-10 14:16:21 -05:00
Rafal Szczesniak
8d9330c490 r17448: Define macros to set fields in api function modifying user account.
rafal
2007-10-10 14:15:26 -05:00
Rafal Szczesniak
c58fa8676c r16692: More comments and further code in set_user_changes routine.
rafal
2007-10-10 14:09:38 -05:00
Rafal Szczesniak
24006a3601 r16572: More comments and simple refactoring of one condition.
rafal
2007-10-10 14:09:36 -05:00
Rafal Szczesniak
d91cbec264 r16531: Add a function preparing argument for modify user routine.
rafal
2007-10-10 14:09:33 -05:00
Rafal Szczesniak
d8113fa5e1 r16211: Refactor domain_opened function a bit and add a few comments.
rafal
2007-10-10 14:09:06 -05:00
Rafal Szczesniak
51501cdeef r15919: - Create function checking prerequisites like valid domain
opened and rpc pipe connected. Each user management routine
  calls the function before doing their job
- Initial work on user modify functionality (does nothing yet)

rafal
2007-10-10 14:08:40 -05:00
Stefan Metzmacher
d273d8ae52 r15857: don't clear the error string after setting it
metze
2007-10-10 14:08:33 -05:00
Andrew Tridgell
4898b29c32 r15850: another spot where r->out.error_string can be uninitialied 2007-10-10 14:08:32 -05:00
Andrew Tridgell
1d1d2aaeae r15849: ensure we don't try to talloc_steal() an invalid error_string in
r->out on error
2007-10-10 14:08:31 -05:00
Rafal Szczesniak
dc93aef09a r15666: Fix a silly typo.
rafal
2007-10-10 14:08:05 -05:00
Rafal Szczesniak
89e9a88719 r15663: Turn libnet_DeleteUser into async function and fix subtle bug probably
causing ejsnet test to segfault. Also, cleanup a bit and add monitor
fn pointer to internal user delete libnet function.
Time for some comments now.

rafal
2007-10-10 14:08:04 -05:00
Rafal Szczesniak
1ed80c594c r15625: Partial commit of my current work. It makes libnet api functions
a bit more smart and more aware of what libnet_context can offer.
The context is a help when some of the arguments are not passed
(programmer counts on using sensible defaults) and stores some of
results so that similar subsequent calls don't need to reopen some
of policy handles, pipes, etc. again. It also helps to hide some
of details the library user don't really want to know much about.

Also, change domain open function to be part of public api, as
it is going to be used in ejsnet interface.

Note, this is work in progress. Comments are welcome.

rafal
2007-10-10 14:07:24 -05:00
Jelmer Vernooij
3dd477ca51 r14464: Don't include ndr_BASENAME.h files unless strictly required, instead
try to include just the BASENAME.h files (containing only structs)
2007-10-10 13:57:27 -05:00
Andrew Bartlett
a5e7c17c34 r12892: Add a 'Migrate from Windows' page to our installation section in SWAT.
Doing this required reworking ejsnet, particularly so it could take a
set of credentials, not just a username and password argument.

This required fixing the ejsnet.js test script, which now adds and
deletes a user, and is run from 'make test'.  This should prevent it
being broken again.

Deleting a user from ejsnet required that the matching backend be
added to libnet, hooking fortunetly onto already existing code for the
actual deletion.

The js credentials interface now handles the 'set machine account' flag.

New functions have been added to provision.js to wrap the basic
operations (so we can write a command line version, as well as the web
based version).

Andrew Bartlett
2007-10-10 13:50:59 -05:00
Andrew Bartlett
7ccddfd351 r12858: This moves the libnet_LookupPdc code to use a GetDC request to find
the remote server's name, or in the absence of a local nbt_server to
communicate with (or without root access), a node status request.

The result is that we are in a better position to use kerberos, as well
as to remove the 'password server' mandatory parameter for the samsync
and samdump commands.  (I need this to put these into SWAT).

The only problem I have is that I must create a messaging context, which
requires a server ID.  As a client process, I don't expect to get
messages, but it is currently required for replies, so I generate a
random() number.  We probably need the servers to accept connections on
streamed sockets too, for client-only tasks that want IRPC.

Because I wanted to test this code, I have put the NET-API-* tests into
our test scripts, to ensure they pass and keep passing.  They are good
frontends onto the libnet system, and I see no reason not to test them.

In doing so the NET-API-RPCCONNECT test was simplified to take a
binding string on the command line, removing duplicate code, and
testing the combinations in the scripts instead.

(I have done a bit of work on the list shares code in libnet_share.c
to make it pass 'make test')

In the future, I would like to extend the libcli/findds.c code (based
off volker's winbind/wb_async_helpers.c, which is why it shows up a bit
odd in the patch) to handle getting multiple name replies, sending a
getdc request to each in turn.

(posted to samba-technical for review, and I'll happily update with
any comments)

Andrew Bartlett
2007-10-10 13:50:54 -05:00
Jelmer Vernooij
6391761601 r12696: Reduce the size of include/structs.h 2007-10-10 13:49:40 -05:00
Jelmer Vernooij
8aae0f168e r12510: Change the DCE/RPC interfaces to take a pointer to a
dcerpc_interface_table struct rather then a tuple of interface
name, UUID and version.

This removes the requirement for having a global list of DCE/RPC interfaces,
except for these parts of the code that use that list explicitly
(ndrdump and the scanner torture test).

This should also allow us to remove the hack that put the authservice parameter
in the dcerpc_binding struct as it can now be read directly from
dcerpc_interface_table.

I will now modify some of these functions to take a dcerpc_syntax_id
structure rather then a full dcerpc_interface_table.
2007-10-10 13:47:48 -05:00
Rafal Szczesniak
a7bf9ada34 r11749: 1) Buffer allocation's been moved and isn't needed here.
2) Connect to a server instead of pdc after locating it.

rafal
2007-10-10 13:46:21 -05:00
Rafal Szczesniak
5114ef8d1c r11708: Fix allocation of too small buffer to hold ip address.
Thanks metze for catching that.

rafal
2007-10-10 13:46:16 -05:00
Rafal Szczesniak
6b0c083c9b r11705: Fix segfaulting create user function.
rafal
2007-10-10 13:46:15 -05:00
Rafal Szczesniak
798b00c24a r8077: Propagate changes in rpc connect routine to functions using it
(it's quite common).

rafal
2007-10-10 13:19:06 -05:00
Rafal Szczesniak
b9deaa995d r7732: Implementation of very basic lookup function (to be used in more
specific routines like resolving a pdc).
Also, couple of formatting fixes.

rafal
2007-10-10 13:18:27 -05:00
Tim Potter
0c1f54461c r7630: Unused variable. 2007-10-10 13:18:15 -05:00
Rafal Szczesniak
f6ef7b882a r7490: Rename functions and prefices s/rpc_composite/libnet_rpc/
This makes more clear where the functions belong to. Also
the rule will be that lowercased function names are not
part of "official" libnet API (though it doesn't mean one
absolutely cannot use them).

rafal
2007-10-10 13:17:59 -05:00
Rafal Szczesniak
80e2f04ce1 r7380: Mistakenly put one file twice in command line. Here's source of
CreateUser call. It serves one level of call by now. Once any
more is needed it can be placed, of course.

rafal
2007-10-10 13:17:48 -05:00
Rafal Szczesniak
c5fdc38b17 r5365: Initial code for adding user accounts via libnet call.
rafal
2007-10-10 13:09:46 -05:00