1
0
mirror of https://github.com/samba-team/samba.git synced 2025-11-15 16:23:49 +03:00
Commit Graph

75 Commits

Author SHA1 Message Date
Stefan Metzmacher
b55b19190d libads: fix typo
metze
2007-12-06 09:54:19 +01:00
Jeremy Allison
f35a266b3c RIP BOOL. Convert BOOL -> bool. I found a few interesting
bugs in various places whilst doing this (places that assumed
BOOL == int). I also need to fix the Samba4 pidl generation
(next checkin).
Jeremy.
2007-10-18 17:40:25 -07:00
Michael Adam
3e155b249e r25422: Get rid of some cast warnings. 2007-10-10 12:31:04 -05:00
Gerald Carter
00a93ed336 r25407: Revert Longhorn join patch as it is not correct for the 3.2 tree.
The translate_name() used by cli_session_setup_spnego() cann rely
Winbindd since it is needed by the join process (and hence before
Winbind can be run).
2007-10-10 12:31:03 -05:00
Gerald Carter
8304ccba73 r25400: Windows 2008 (Longhorn) Interop fixes for AD specific auth2 flags,
and client fixes.  Patch from Todd Stetcher <todd.stetcher@isilon.com>.
2007-10-10 12:31:02 -05:00
Günther Deschner
53c99d415d r25328: When using ldap sasl wrapping with gssapi it's important to receive warnings
for clock-skew errors.

Guenther
2007-10-10 12:31:00 -05:00
Günther Deschner
cb2dc715e3 r25133: Fix sasl wrapping (for ldap sign&seal).
The gss_import_name() broke as we switched from the internal MIT OID
"gss_nt_krb5_principal" to "GSS_KRB5_NT_PRINCIPAL_NAME" and didn't switch from
passing the krb5_principal (or better: a pointer to that, see MIT's "*HORRIBLE*
bug") to pass the string principal directly.

Jerry, Jeremy, neither I could figure out the need of passing in a
krb5_principal at all nor could I reproduce the crash you were seeing.

I sucessfully tested the code (now importing a string) with MIT 1.2.7, 1.3.6,
1.4.3, 1.5.1, 1.6.1 and Heimdal 0.7.2, 1.0, 1.0.1.

Guenther
2007-10-10 12:30:43 -05:00
Günther Deschner
2dea9464bb r25109: Remove obsolete argument from ads_guess_service_principal().
Guenther
2007-10-10 12:30:41 -05:00
Günther Deschner
f31949ec34 r25108: Make ifdef labyrinth in sasl code a bit more readable.
Guenther
2007-10-10 12:30:40 -05:00
Günther Deschner
f5b3de4d30 r24804: As a temporary workaround, also try to guess the server's principal in the
"not_defined_in_RFC4178@please_ignore" case to make at least LDAP SASL binds
succeed with windows server 2008.

Guenther
2007-10-10 12:30:23 -05:00
Günther Deschner
f783b32b65 r24251: Neverending fun:
Heimdal doesn't accept all OIDs and gss_import_name() fails with
GSS_S_BAD_NAMETYPE using this one. Use the GSS_KRB5_NT_PRINCIPAL_NAME OID
instead (which works with at least MIT 1.6.1 and Heimdal 1.0.1).

Guenther
2007-10-10 12:29:21 -05:00
Stefan Metzmacher
d0ec732387 r24131: - make it more clear what the different min and max fields mean
- with the "GSSAPI" sasl mech the plain, sign or seal negotiation
  is independed from the req_flags and ret_flags
- verify the server supports the wrapping type we want
- better handling on negotiated buffer sizes

metze
2007-10-10 12:29:09 -05:00
Stefan Metzmacher
29e2d8e044 r24128: fix double free in error path
metze
2007-10-10 12:29:09 -05:00
Stefan Metzmacher
a5e1f9fd29 r24104: fix the build, sorry...
metze
2007-10-10 12:29:07 -05:00
Stefan Metzmacher
581a1d3a20 r24103: add some useful debug messages, as not all LDAP
libraries support wrapping hooks...

metze
2007-10-10 12:29:07 -05:00
Stefan Metzmacher
cbaf44de1e r24098: - make use of the ads_service_principal abstraction
also for the "GSSAPI" sasl mech.
- also use the ads_kinit_password() fallback logic
  from the "GSS-SPNEGO" sasl mech.

metze
2007-10-10 12:29:06 -05:00
Stefan Metzmacher
b545667d2a r24095: add one more fallback alternative to
construct the principal

metze
2007-10-10 12:29:05 -05:00
Stefan Metzmacher
83de27968d r24093: move gssapi/krb5 principal handling into a function
metze
2007-10-10 12:29:05 -05:00
Stefan Metzmacher
4a4fc8cccb r24062: fix logic for broken krb5 libs which always force
sign and seal...

metze
2007-10-10 12:29:00 -05:00
Stefan Metzmacher
34ab84aceb r24042: add support for krb5 sign and seal in LDAP via "GSS-SPNEGO"
metze
2007-10-10 12:28:59 -05:00
Stefan Metzmacher
85d6cd3dfb r24037: only setup sasl wrapping after a successful bind
metze
2007-10-10 12:28:58 -05:00
Volker Lendecke
8716edf157 r23953: Some C++ warnings 2007-10-10 12:28:49 -05:00
Stefan Metzmacher
a079b66384 r23948: add gsskrb5 sign and seal support for LDAP connections
NOTE: only for the "GSSAPI" SASL mech yet

metze
2007-10-10 12:28:48 -05:00
Stefan Metzmacher
408bb2e6e2 r23946: add support for NTLMSSP sign and seal
NOTE: windows servers are broken with sign only...

metze
2007-10-10 12:28:48 -05:00
Stefan Metzmacher
2075c05b3d r23945: add infrastructure to select plain, sign or seal LDAP connection
metze
2007-10-10 12:28:48 -05:00
Stefan Metzmacher
00909194a6 r23888: move elements belonging to the current ldap connection to a
substructure.

metze
2007-10-10 12:28:38 -05:00
Andrew Tridgell
b0132e94fc r23784: use the GPLv3 boilerplate as recommended by the FSF and the license text 2007-10-10 12:28:22 -05:00
Jeremy Allison
407e6e695b r23779: Change from v2 or later to v3 or later.
Jeremy.
2007-10-10 12:28:20 -05:00
Volker Lendecke
3d3d61687e r22844: Introduce const DATA_BLOB data_blob_null = { NULL, 0, NULL }; and
replace all data_blob(NULL, 0) calls.
2007-10-10 12:22:01 -05:00
Stefan Metzmacher
34a5badbde r22153: fix LDAP SASL "GSSAPI" bind against w2k3, this isn't critical
because we try "GSS-SPNEGO" first and all windows version support
that.

metze
2007-10-10 12:19:17 -05:00
Stefan Metzmacher
e9f2aa22f9 r22092: - make spnego_parse_auth_response() more generic and
not specific for NTLMSSP
- it's possible that the server sends a mechOID and authdata
  if negResult != SPNEGO_NEG_RESULT_INCOMPLETE, but we still
  force the mechOID to be present if negResult == SPNEGO_NEG_RESULT_INCOMPLETE

metze
2007-10-10 12:19:10 -05:00
Jeremy Allison
ab3150fe4e r22079: Tsk, tsk, Metze didn't compile before check-in :-).
Merge the memory leak fix (with fix :-) to 3.0.25.
Jeremy.
2007-10-10 12:19:09 -05:00
Stefan Metzmacher
8c6930b701 r22078: fix memory leak in not often used code, we only use it if the server
doesn't support GSS-SPNEGO in SASL

can someone please review this, maybe it's also for 3.0.25

metze
2007-10-10 12:19:09 -05:00
Jeremy Allison
1a2be06d4a r21850: After Jerry explained to me the HORRIBLE way in which
the MIT gss libraries *SUCK*, move the frees to the end
of the function so MIT doesn't segfault.....
Add a comment so that another engineer knows why I did
this.
Jeremy.
2007-10-10 12:18:38 -05:00
Jeremy Allison
89bdd30e4b r21847: Fix memory leaks in error paths (and in main code path in one case...)
in sasl bind. Wonder why coverity didn't find these ?
Jeremy.
2007-10-10 12:18:37 -05:00
Gerald Carter
fe70c22496 r21273: * Protect the sasl bind against a NULL principal string
in the SPNEGO negTokenInit
2007-10-10 12:17:53 -05:00
Günther Deschner
7e1a84b722 r21240: Fix longstanding Bug #4009.
For the winbind cached ADS LDAP connection handling
(ads_cached_connection()) we were (incorrectly) assuming that the
service ticket lifetime equaled the tgt lifetime. For setups where the
service ticket just lives 10 minutes, we were leaving hundreds of LDAP
connections in CLOSE_WAIT state, until we fail to service entirely with
"Too many open files".

Also sequence_number() in winbindd_ads.c needs to delete the cached LDAP
connection after the ads_do_search_retry() has failed to submit the
search request (although the bind succeeded (returning an expired
service ticket that we cannot delete from the memory cred cache - this
will get fixed later)).

Guenther
2007-10-10 12:17:50 -05:00
Gerald Carter
4fb57bce87 r21046: Backing out svn r20403 (Andrew's krb5 ticket cleanup
as this is causing the WRONG_PASSWORD error in the SetUserInfo()
call during net ads join).

We are now back to always list RC4-HMAC first if supported by
the krb5 libraries.
2007-10-10 12:17:29 -05:00
Andrew Bartlett
0b72c04906 r20403: Cleaning out my Samba 3.0 tree:
As discussed with jerry at the CIFS conf: overriding the
administrator's wishes from the krb5.conf has only every given me
segfaults.  We suggest leaving this up to the defaults from the
libraries anyway.

Andrew Bartlett
2007-10-10 12:16:47 -05:00
Herb Lewis
c6cdf76c58 r20132: get rid of defined but not used warning - static function only used
inside the #ifdef HAVE_KRB5
2007-10-10 12:16:26 -05:00
Volker Lendecke
86f4ca84f2 r18047: More C++ stuff 2007-10-10 11:43:24 -05:00
Volker Lendecke
b2ff9680eb r18019: Fix a C++ warnings: Don't use void * in libads/ for LDAPMessage anymore.
Compiled it on systems with and without LDAP, I hope it does not break the
build farm too badly. If it does, I'll fix it tomorrow.

Volker
2007-10-10 11:39:49 -05:00
Jeremy Allison
e779491751 r17899: Fix Stanford checker bug - possible null deref.
Jeremy.
2007-10-10 11:38:57 -05:00
Jeremy Allison
9dafb7f48c r16945: Sync trunk -> 3.0 for 3.0.24 code. Still need
to do the upper layer directories but this is what
everyone is waiting for....

Jeremy.
2007-10-10 11:19:14 -05:00
Jeremy Allison
37ab42afbc r15210: Add wrapper functions smb_krb5_parse_name, smb_krb5_unparse_name,
smb_krb5_parse_name_norealm_conv that pull/push from unix charset
to utf8 (which krb5 uses on the wire). This should fix issues when
the unix charset is not compatible with or set to utf8.
Jeremy.
2007-10-10 11:16:28 -05:00
Gerald Carter
17e63ac4ed r13316: Let the carnage begin....
Sync with trunk as off r13315
2007-10-10 11:06:23 -05:00
Simo Sorce
58e48fef45 r13137: make cleare where long ifdefs ends 2007-10-10 11:06:15 -05:00
Jeremy Allison
4591984176 r11504: Added Andrew Bartletts removal of another NTLMSSP implementation
patch.
Jeremy.
2007-10-10 11:05:18 -05:00
Gerald Carter
939c3cb5d7 r10656: BIG merge from trunk. Features not copied over
* \PIPE\unixinfo
* winbindd's {group,alias}membership new functions
* winbindd's lookupsids() functionality
* swat (trunk changes to be reverted as per discussion with Deryck)
2007-10-10 11:04:48 -05:00
Volker Lendecke
3d491ebf9c r8989: Fix a warning 2007-10-10 11:00:23 -05:00