1
0
mirror of https://github.com/samba-team/samba.git synced 2024-12-29 11:21:54 +03:00
Commit Graph

1850 Commits

Author SHA1 Message Date
Volker Lendecke
2494868ffb r20020: Arglll... eventlogadm links against reg_db but not the rest of the registry
stuff. Revert the last change.

This needs better fixing.

Volker
(This used to be commit ad1e00430b)
2007-10-10 12:16:21 -05:00
Volker Lendecke
61bd0c8e45 r20019: Replace one set of tricky code by calls to another set of tricky code:
Initializing the reg_db now uses reg_createkey and reg_setvalue.

Volker
(This used to be commit cab5ccbbe4)
2007-10-10 12:16:21 -05:00
Volker Lendecke
b676097927 r20017: Make srvsvc_NetShareAdd & friends take care of registry shares
(This used to be commit fc29a283cc)
2007-10-10 12:16:21 -05:00
Volker Lendecke
fe34827ffd r20015: We have to zero out handle on key_close, otherwise the NT4 regedit will re-use the handle
(This used to be commit 0afd696f88)
2007-10-10 12:16:20 -05:00
Volker Lendecke
c6597384ba r20013: Fix segfaults: parm_error is a unique in/out ptr
(This used to be commit 0104371dd6)
2007-10-10 12:16:20 -05:00
Volker Lendecke
3f1978c059 r20012: Reformatting
(This used to be commit b32c65cb62)
2007-10-10 12:16:20 -05:00
Volker Lendecke
760056ec8d r20007: Fix a const warning just introduced
(This used to be commit 3da37287ca)
2007-10-10 12:16:19 -05:00
Volker Lendecke
ecf90c495e r19991: Sorry for this 2000-liner...
The main thing here is a rewrite of srv_winreg_nt.c. The core functionality
has moved to registry/reg_api.c which is then usable by the rest of Samba as
well.

On that way it fixes creating keys with more than one element in the
path. This did not work before.

Two things that sneaked in (sorry :-) is the change of some routines from
NTSTATUS to WERROR the removed "parent" argument to regkey_open_internal.

Volker
(This used to be commit fea52801de)
2007-10-10 12:16:18 -05:00
Volker Lendecke
575845ccbe r19963: Add 'registry shares = yes' and registry key security descriptors.
(This used to be commit 6cab254c49)
2007-10-10 12:16:16 -05:00
Volker Lendecke
1c91cca86e r19947: Change regkey_open_internal to take the parent key and a talloc_ctx as
arguments. This also replaces regkey_close_internal by TALLOC_FREE.

Volker
(This used to be commit a177bbb2d5)
2007-10-10 12:16:14 -05:00
Volker Lendecke
f1d492d11f r19930: Revert the winreg idl changes. At least enumkey does not work anymore today.
With more than 5 different trees I can't swear that I did test this properly
yesterday. Sorry for the noise.

Volker
(This used to be commit 978a6196bf)
2007-10-10 12:16:10 -05:00
Volker Lendecke
7ef185fae7 r19929: Fix indentation
(This used to be commit 2369ad0852)
2007-10-10 12:16:10 -05:00
Volker Lendecke
8e8821b1da r19919: Convert winreg_EnumKey to use ref ** instead of a unique *.
Volker
(This used to be commit b714b51884)
2007-10-10 12:16:10 -05:00
Volker Lendecke
4a361ffd7f r19918: Convert winreg_CreateKey to use a ref ** instead of a unique *. W2k3 can still
create keys on Samba and vice versa.

Jelmer, please check.

Thanks,

Volker
(This used to be commit 1b460d6cdf)
2007-10-10 12:16:09 -05:00
Volker Lendecke
2d6e409dc2 r19915: Fix two type-punned warnings
(This used to be commit f1266475da)
2007-10-10 12:16:09 -05:00
Volker Lendecke
f57cd1f63c r19914: The "default" value with the name "" need different 0-length treatment as the
other StringBufs, otherwise clicking on a key with this value being set leads
to regedit.exe on w2k3 chew all memory.
(This used to be commit b148cde7f3)
2007-10-10 12:16:09 -05:00
Volker Lendecke
b189e6d76e r19912: Move the subkey cache to srv_winreg_nt.c
(This used to be commit 01a53590a6)
2007-10-10 12:16:08 -05:00
Volker Lendecke
015534e254 r19872: Move the value cache to srv_winreg_nt.c. Fix some minor issues found while
playing with regedit.exe.

Volker
(This used to be commit 81bd816fa2)
2007-10-10 12:16:03 -05:00
Volker Lendecke
3f62a1a3eb r19867: Introduce struct regkey_info in srv_winreg_nt.c to be able to re-add the
QueryValue and later the QueryKey cache independent of the backend.

Volker
(This used to be commit 0ed3a21fcc)
2007-10-10 12:16:03 -05:00
Volker Lendecke
6b0819e96c r19860: Streamline _winreg_QueryValue a bit. We've been pushing around memory
considerably here.

This temporarily removes a cache for the tdb based registry, I'll re-add that
in srv_winreg_nt.c in the next step.

This fixes creating/renaming values from the windows regedit.exe, as "New
Value #1" was not entering the cache after being created.

Volker
(This used to be commit c8c81f0e86)
2007-10-10 12:16:03 -05:00
Volker Lendecke
c895111579 r19824: Fix the max value calculation in QueryInfoKey
(This used to be commit cd14b7f052)
2007-10-10 12:16:00 -05:00
Volker Lendecke
ead21a53ae r19819: Windows returns an empty string instead of NULL here
(This used to be commit c1083216c8)
2007-10-10 12:15:59 -05:00
Volker Lendecke
ded7c032a3 r19803: Fix problem reported by Chetan S: QueryInfoKey needs to report the max name
length in *bytes* for UTF-16, not the string length. This got lost during the
conversion.

This took a while to figure out :-)

Thanks to Chetan!

Volker
(This used to be commit 8df6544fa8)
2007-10-10 12:15:56 -05:00
Volker Lendecke
bfad442144 r19780: Ok, regkey_open_internal needs a regkey_close_internal. Giving a talloc ctx is
misleading here. This needs fixing properly :-)

Volker
(This used to be commit f808182346)
2007-10-10 12:15:55 -05:00
Volker Lendecke
e82cd437cc r19778: Make regkey_open_internal take a talloc ctx
(This used to be commit cb7f4211b8)
2007-10-10 12:15:55 -05:00
Volker Lendecke
09ec562a09 r19776: Hmmm. I should have done one instead of three commits. Sorry :-)
(This used to be commit e2a35ceffe)
2007-10-10 12:15:54 -05:00
Volker Lendecke
9bb1f909fd r19775: Fix typo
(This used to be commit 370e29ebb9)
2007-10-10 12:15:54 -05:00
Volker Lendecke
64bab725f0 r19689: Fix a NULL dereference found by coverity (the call to strlen).
Jerry, please check this. The way I understood alpha_strcpy the last arg needs
to be the size of the target, not of the source.

Thanks,

Volker
(This used to be commit 287d68daab)
2007-10-10 12:15:47 -05:00
Volker Lendecke
bef92ebb25 r19669: set_share_security does not need a mem_ctx passed
(This used to be commit 53eaa603eb)
2007-10-10 12:15:46 -05:00
Volker Lendecke
24f7144930 r19468: Fix some potential NULL dereferences
(This used to be commit c8ed412976)
2007-10-10 12:15:37 -05:00
Volker Lendecke
2a10d76865 r19448: Convert delete_share_security to struct share_params plus some cleanups
(This used to be commit c73d0815a3)
2007-10-10 12:15:36 -05:00
Volker Lendecke
7b9ef5e840 r19292: Avoid some potential segfaults: In winreg_EnumValue all pointers are unique
pointers and can thus be independently NULL.

Thanks,

Volker
(This used to be commit d48ac0726a)
2007-10-10 12:15:29 -05:00
Volker Lendecke
4980baf2e1 r19224: Add setting the rng_fault_state to the already converted pipes.
Convert the low-hanging fruit of the LSA server. This provides a sample how
the server calls can be converted one by one, see the "proxy_lsa_call"
function.

Volker
(This used to be commit 99e54a213a)
2007-10-10 12:15:23 -05:00
Volker Lendecke
b71a0be998 r19220: Check if a backend has set rng_fault_state and send a dce-level fault pdu.
Volker
(This used to be commit 21c08e7ef4)
2007-10-10 12:15:22 -05:00
Volker Lendecke
9d8d4f24b1 r19156: Make enumprinters use the share iterators.
Volker
(This used to be commit 9b1759617c)
2007-10-10 12:15:18 -05:00
Volker Lendecke
e918cf3abf r19154: Trivial logic simplification: Get rid of two indentation levels. Survives the
consistency checks just checked into Samba4.

Volker
(This used to be commit c48bb4b37b)
2007-10-10 12:15:17 -05:00
Jim McDonough
dc1f0804dd r19058: Implement "user cannot change password", and complete "user must change
password at next logon" code.  The "password last set time" of zero now
means "user must change password", because that's how windows seems to
use it.  The "can change" and "must change" times are now calculated
based on the "last set" time and policies.

We use the "can change" field now to indicate that a user cannot change
a password by putting MAX_TIME_T in it (so long as "last set" time isn't
zero).  Based on this, we set the password-can-change bit in the
faked secdesc.
(This used to be commit 21abbeaee9)
2007-10-10 12:15:06 -05:00
Volker Lendecke
7ced2e983d r19028: Implement getprinterinfo level 6 (only the status) and get rid of snum in the
getprinter calls. Survives the RPC-SAMBA3-SPOOLSS test which I will activate
when the Samba4 build farm has picked it up.

Volker
(This used to be commit d7248b6cfa)
2007-10-10 12:15:03 -05:00
Gerald Carter
b3ec4697ef r18962: * Add IDL for SaveKey() and RestoreKey() and regenerated
* Tested RegSaveKey() using win32 app.  Apparently
  this code has been brokne for a really long time.
(This used to be commit 5381dcbde3)
2007-10-10 12:14:51 -05:00
Gerald Carter
2279881bd4 r18954: Fix segv in QueryValue and Enumvalue. regedit.exe now
is happy again when creating keys and values
(This used to be commit 6e9e9f8fac)
2007-10-10 12:14:50 -05:00
Gerald Carter
d89a951517 r18940: Fix a few memory corruption bugs to make CreateKey() and DeleteKey() work
(This used to be commit e7e3e35c1d)
2007-10-10 12:14:49 -05:00
Gerald Carter
c67b555874 r18934: fix a segv in CreateKey()
(This used to be commit 92f22f67ed)
2007-10-10 12:14:48 -05:00
Gerald Carter
855d12e567 r18932: In RegEnumvalue() and RegQueryValue(), the output buffer
size must match the real value of the data.
(This used to be commit e11108024a)
2007-10-10 12:14:48 -05:00
Gerald Carter
49c73b5734 r18931: * Fix the IDL for QueryInfoKey. teh Classname in an
in,out ref pointer
* Clarify variable names in EnumValue IDL
* Fix server code for _winreg_EnumValue() and _winreg_QueryInfoKe()
(This used to be commit f520a9d0fb)
2007-10-10 12:14:48 -05:00
Gerald Carter
5935ea9da1 r18929: * Clarify QueryValue IDL and regenerate code
* Fix server _winreg_Query_Value() implementation so that
  usrmgr.exe starts now
(This used to be commit 435d7bfc37)
2007-10-10 12:14:47 -05:00
Jeremy Allison
fec9850644 r18898: Fix for bug #4100 from Udo Eberhardt <udo.eberhardt@thesycon.de>.
Ensure we initialize values for smb_io_notify_info_data_strings to
fix crash.
Jeremy.
(This used to be commit ceefb8dd3c)
2007-10-10 12:14:44 -05:00
Volker Lendecke
10a8d62e96 r18888: Fix a 64-bit warning
(This used to be commit 94b53f2f2a)
2007-10-10 12:14:41 -05:00
Jelmer Vernooij
387bfebfcf r18823: Fix some errors in the srsvc handling code and start running the RPC-SRVSVC
test against samba3.
(This used to be commit f0508ecb44)
2007-10-10 12:01:03 -05:00
Stefan Metzmacher
7239a85f0a r18804: resume_hnd isn't a ref pointer and can be NULL
metze
(This used to be commit 8736262342)
2007-10-10 12:00:59 -05:00
Jelmer Vernooij
7ba2554d88 r18802: Use the pidl-generated code for the srvsvc interface, both client and server code.
This has had some basic testing. I'll do more during the next couple of days and hopefully also
make RPC-SRVSVC from Samba4 pass against it.
(This used to be commit ef10672399)
2007-10-10 12:00:59 -05:00