1
0
mirror of https://github.com/samba-team/samba.git synced 2025-03-03 12:58:35 +03:00

24698 Commits

Author SHA1 Message Date
Volker Lendecke
36282a8b6a Attempt to fix the darwin build
(This used to be commit c919f5146990fa4b1b0cde79d55e5e3008b94e3f)
2008-06-21 16:17:14 +02:00
Volker Lendecke
3cf5395ad5 Use "init_shared_module" instead of "init_module" for initializing .so's
(This used to be commit 0c2fd687b25e32d446ef799927db6933bc61223d)
2008-06-21 11:25:41 +02:00
Volker Lendecke
df905a5d77 Make pipes_struct its own talloc ctx
(This used to be commit 829b1ad4697f2f1ea008377d591456722dccd025)
2008-06-21 10:34:34 +02:00
Volker Lendecke
c203de0e3a Fix a SAFE_FREE/TALLOC_FREE mixup
(This used to be commit b39852f51313059899630ba63509fee904ba3613)
2008-06-21 10:34:34 +02:00
Kai Blin
accc68f63e net: Don't crash on invalid command line options.
This backs out the workaround Jerry added in
4c3bfea9f8d238f9100eaa264b9b2941dff5a6dd.
Thanks for the catch.
(This used to be commit 20e0bb4800938863cb0aac1a19473748132043fc)
2008-06-21 00:07:21 +02:00
Jeremy Allison
c4d6ca41d9 Fix bug - fix conversion of ns units when converting from nttime to timespec.
Fix from hkurma@datadomain.com.
Jeremy.
(This used to be commit 8c87a4319cc83f55fb105cae81a8efbc3fb5b98b)
2008-06-20 13:23:31 -07:00
Jeremy Allison
2a4b8fa664 Fix bug . Winbindd fails to cope correctly with a workgroup name containing a '.'.
Jeremy.
(This used to be commit 96325ff44dc404a68d4ebd423cf78210ec3ff902)
2008-06-20 12:49:14 -07:00
root
37ae3f9c20 net: Fix crash when specifying invalid options on the command line
(This used to be commit 4c3bfea9f8d238f9100eaa264b9b2941dff5a6dd)
2008-06-19 13:41:47 -05:00
Volker Lendecke
be5dc4f3c8 Remove current_user references from nttrans.c
(This used to be commit 5f8a5e68ea166fbeda3af6e5ec381ec09d06f0f6)
2008-06-19 18:51:38 +02:00
Volker Lendecke
52664f62ba Remove current_user references from trans2.c
This involved replacing the CHECK_NTQUOTA_HANDLE_OK macro by a function.
(This used to be commit 5595cdf837edb82db69a3e57bcf3108be7feeeb8)
2008-06-19 18:51:38 +02:00
Volker Lendecke
e901466061 Remove some current_user references from trans2.c
(This used to be commit 4c31cc0b62f532eafdc44398b29b773ad8cb0646)
2008-06-19 18:51:38 +02:00
Volker Lendecke
f1cd0bdbcc Remove reference to current_user from reply.c
(This used to be commit e895e44cc7d675d128430fb53c138e5e8736e59f)
2008-06-19 18:51:38 +02:00
Volker Lendecke
40f5eab5eb Wrap the unix token info in a unix_user_token in auth_serversupplied_info
No functional change, this is a preparation for more current_user ref removal
(This used to be commit dcaedf345e62ab74ea87f0a3fa1e3199c75c5445)
2008-06-19 18:51:37 +02:00
Volker Lendecke
e40b6e296a Remove the "current_user" arg from fsp_belongs_conn
fsp_belongs_conn only used the vuid struct member anyway, and this is available
in the smb_request structure as well.
(This used to be commit 64e9372ab997739d46669c0cc4a4c6edb11d5e64)
2008-06-19 18:51:37 +02:00
Volker Lendecke
49ca8efa91 Remove the "current_user" arg from check_fsp
check_fsp only used the vuid struct member anyway, and this is available in the
smb_request structure as well.
(This used to be commit 8d364c4c3311b406847158fc37e9208d298cf8ba)
2008-06-19 18:51:37 +02:00
Michael Adam
769646efc6 loadparm: use the return value of the special handlers in lp_load().
Up to now, the bool return value was silently ignored.

Michael
(This used to be commit c65d425fec964bc0b8778b596615a8bcce0378aa)
2008-06-19 17:22:27 +02:00
Michael Adam
09d769057e loadparm: don't treat a missing include file as an error in handle_include().
Michael
(This used to be commit a8ef8870beb91fcd2745aa59de6c59b49ea00e39)
2008-06-19 17:22:27 +02:00
Michael Adam
0f32b22031 testsuite: enable the testparm_s3 tests.
Michael
(This used to be commit 0f5c13e5735990f4325f98156a7dc410276372fe)
2008-06-19 17:22:27 +02:00
Michael Adam
24de341973 testsuite: add a testparm_s3 test script.
This is a first testparm/lp_load test that runs testparm on a couple
of configuration files. The main purpose for now is to test the options
that have special handlers (to check whether the handlers succeed).
In particular, all the Macro expansions that are available via
alloc_sub_basic() are tested with the include handler. This is to
catch such crashbugs as  where %m expansion led to a segfault.

The tests now are very simple. Just check if testparm completes
successfully on the given config files. This can (and should) be
elaborated in the future.

Michael
(This used to be commit eb28146d40b8a8bc2c20b8d222abf191ea178d5a)
2008-06-19 17:22:27 +02:00
Michael Adam
b0c3f1459d testsuite: update introductory comment to test_net_regsistry.sh
This is now used to test rpc and local access depending on
command line parameters.

Michael
(This used to be commit 73c17b630317b5019e5d5f2b989b8de081a73e07)
2008-06-19 17:22:27 +02:00
Volker Lendecke
39479c9ee6 Remove current_user_info reference from vfs_recycle.c
(This used to be commit fdc03c0a5ba0da4fbc4610880e06150c11d4c737)
2008-06-19 15:53:43 +02:00
Volker Lendecke
3283a5d0de Remove current_user_info reference from vfs_fake_perms.c
(This used to be commit a227181e8d2ed0824a323a3d4b4cfda5e438f8ce)
2008-06-19 15:53:43 +02:00
Volker Lendecke
ff215c4f81 Remove current_user_info reference from vfs_expand_msdfs.c
(This used to be commit 05a66980a9b5a7c6222ceb038d819d23fd172186)
2008-06-19 15:53:43 +02:00
Volker Lendecke
17885401b8 current_user is not used in vfs_aixacl2.c
(This used to be commit 407136abdf45ad832382dba44e1c9a3b4f253f09)
2008-06-19 15:53:43 +02:00
Volker Lendecke
156cd09899 RWX on a file does not imply DELETE access
Without this the changed checks in can_delete_file_in_directory give DELETE
access where there is none. So we can end up granting the ntcreate&x preparing
the unlink where we should not, which leads to a NT_STATUS_ACCESS_DENIED at
close time later, which in turn does *not* give the access denied error message
in the Windows GUI.

can_delete_file_in_directory will grant access now by looking at the directory
permissions.
(This used to be commit 51b5364c2afb3a18df4bec2bc1624760ccc01676)
2008-06-19 15:27:41 +02:00
Volker Lendecke
066f6c856f Fix checks in can_delete_file_in_directory()
With at least NFSv4 ACLs around the write permission for the owner is a bogus
check if we can delete a file in a directory. Like in Windows, there are two
ways which can grant us such: First, the DELETE permission on the file itself,
or if that does not help, the DELETE_CHILD permission on the directory. It
might be a bit more code that runs, but essentially we should end up with the
same set of syscalls in the non-acl case.
(This used to be commit daa9b056645a45edfb3a70e3536011ebe5678970)
2008-06-19 15:27:41 +02:00
Volker Lendecke
7df309c339 Remove some code
Did not measure it, but I think a single write is better than a read and a
conditional branch
(This used to be commit abe1bed665ad8d1dbf9177dcbb9344b25df9594c)
2008-06-19 12:03:31 +02:00
Volker Lendecke
809b992b17 Fix typo
(This used to be commit 2eef2c682c18ad37b78214c755b9dd7c8b607cb8)
2008-06-19 12:02:12 +02:00
Volker Lendecke
bdc9391021 Fix the build on FreeBSD 4.6.2
(This used to be commit 4f50cb63e9b565ae0747127baa651a1a1874298b)
2008-06-19 12:02:12 +02:00
Jeremy Allison
33aa758bf3 Fix 'make distclean'. delheaders: no longer exists as a dependency.
Jeremy.
(This used to be commit 8b26afdcddc75d3b9a97309757a97314b406cb59)
2008-06-18 12:56:36 -07:00
Derrell Lipman
6398f945e8 Remove prototype of unimplemented smbc_chown() function.
(This used to be commit 0e84e3bb800cec2b63df4692afbf9c40850b108f)
2008-06-18 11:00:46 -04:00
Volker Lendecke
2b7fca9e79 Revert "Fix a memleak in svcctl_init_keys()"
This reverts commit b1afb31f3cadd4749bf6e3eb5d8935588bf8ebfc.

This one is very strange: I need to investigate why valgrind showed it as
leaking, and why in my initial tests this did not fail.
(cherry picked from commit 24730f5981efb920811e7929a9483bd72bb0984c)
(This used to be commit b1e8e5d173cdaa3fb9c1fb1d9aacf8e665bc5d61)
2008-06-18 16:31:35 +02:00
Michael Adam
1917b38873 Fix Bug (segfauls in handle_include with %m macro expansion).
In alloc_sub_basic, when expanding '%m', substitute "" instead of
NULL for remote_machine when this is NULL. Else a NULL string
is returned.

Michael
(This used to be commit c65b456c6a145d15b7fd27a2a3440a0709fc3277)
2008-06-18 14:50:53 +02:00
Michael Adam
aedce263a8 file_access: add a function header comment for can_access_file_acl().
Michael
(This used to be commit 7d5fb873bde0a84de522650945effeaf602c759e)
2008-06-18 00:06:46 +02:00
Michael Adam
24e7f40687 smbd/dir.c: remove unneeded stat buf parameter from user_can_read_file()
This is not needed anymore since user_can_access_file_acl() ist used.

Michael
(This used to be commit 3c349f773a52e3de693d3bb79f5060c9f1e01e41)
2008-06-18 00:02:28 +02:00
Michael Adam
b172eb1d47 file_access: remove unneeded stat buf parameter from can_access_file_acl().
This is a security descriptor level function only.

Michael
(This used to be commit 5931540fa1681f026fed42df387d17e43c493c47)
2008-06-17 23:58:49 +02:00
Michael Adam
92c983292e net sam: fix typo in comment
Michael
(This used to be commit b9f6904044889328ded229b7ff04d31218f4fef8)
2008-06-17 23:57:26 +02:00
Michael Adam
00168e4d5a net sam: fix typo in debug message.
Michael
(This used to be commit 6d7f64c3481d3aa7ec6b0d468f3d6218f62cd92e)
2008-06-17 23:56:42 +02:00
Michael Adam
ba3eee6cf8 testsuite: give admin rights to testuser only for the "net rpc registry" test.
Remove the user from BUILTIN\Administrators at the end of the tests.
Note: BUILTIN\Administrators is not deletet at the end because that
functionality is not implemented.

Michael
(This used to be commit 1734f9305a38eff05f0147d9c7391ef34085e7b2)
2008-06-17 23:54:15 +02:00
Michael Adam
aeec9c7f55 testsuite: don't give the testuser administrative rights globally.
It breaks RPC-SAMBA3-GETUSERNAME for reasons I have not quite
understood yet. Somhow loosing rights fails when the user
belogns to BUILTIN\Administrators at some point.

Michael
(This used to be commit 9fe99c69f35b005b66c1eacb5d999cc73f1bb521)
2008-06-17 23:51:23 +02:00
Volker Lendecke
c8dfed63a6 Fix a brown paper bag segfault in clitar
Thanks to "No Body is Perfect" from gmail, whoever that is :-)

Volker
(cherry picked from commit 679d8dfa390601f777bfb43c02cd921eae5edcf4)
(This used to be commit b8e1d62b8e8f724b855c8ab9801abee0b2791e36)
2008-06-17 21:14:47 +02:00
Günther Deschner
8fd045f918 rpcclient: add more generic internal dscracknames call.
Guenther
(This used to be commit 2351b0845ca78707901daca6a6d0425959c6f28e)
2008-06-17 20:01:51 +02:00
Günther Deschner
44e153e3c1 netapi: use NetUserEnum filter in example code.
Guenther
(This used to be commit ad105177686da823ef9cce1c1bedaf0f84a49b8c)
2008-06-17 20:00:11 +02:00
Günther Deschner
b330ea29c7 netapi: add NetUserEnum filter constants to public headers.
Guenther
(This used to be commit 32a66131eb56e1c66b89e348141047c6b98cf35e)
2008-06-17 20:00:00 +02:00
Günther Deschner
d0b7bccf6d netapi: implement NetUserEnum filters.
Guenther
(This used to be commit 0bd69df7704789888eba2a07aba505dce037c4eb)
2008-06-17 19:59:50 +02:00
Günther Deschner
68064b8101 re-run make idl.
Guenther
(This used to be commit 383636aaca0e59fef8a010ba697e5edf9ce2648b)
2008-06-17 19:59:38 +02:00
Günther Deschner
a040b8be7d netapi: add NetUserEnum filter constants to IDL.
Guenther
(This used to be commit 12669b12c25a64b02c0e49b3ef96cf317992b18c)
2008-06-17 19:59:22 +02:00
Günther Deschner
08cf0bb878 netapi: some IDL cosmetics.
Guenther
(This used to be commit 4fd6bc61d0034659c5a89bf2eae188a04a3b41eb)
2008-06-17 19:58:39 +02:00
Günther Deschner
ffba83d22d netapi: add NetRemoteTOD example code.
Guenther
(This used to be commit 2b82779a401dd1d14f5842872ac37b2454efc92b)
2008-06-17 19:58:11 +02:00
Günther Deschner
a2290e5e00 netapi: implement NetRemoteTOD().
Guenther
(This used to be commit 76877680a8a6400bc2d3b5e3b788b7d5fc683850)
2008-06-17 19:58:01 +02:00