1
0
mirror of https://github.com/samba-team/samba.git synced 2025-02-08 05:57:51 +03:00

1076 Commits

Author SHA1 Message Date
Andrew Bartlett
1fdaca3342 The last of the fstring/pstring mixups, and an extra 'static'.
(This used to be commit b328b67fd8fd605636ed58ffd33cf5be3d480672)
2003-01-14 06:46:14 +00:00
Andrew Bartlett
183ccefce7 A couple more pstcpy/fstrcpy mixups - doing an fstrcpy into a pstring is
harmless, but breaks my automated check.
(This used to be commit e5d2b1f6c3c0883054f4e0eab2cac958706a790d)
2003-01-14 06:36:40 +00:00
Gerald Carter
27b05b4df9 typo from merge
(This used to be commit 1f33b4acb32c5461b9249d3786ea5fc6898e5f18)
2003-01-11 02:36:13 +00:00
Gerald Carter
47873e781d [merge] make sure to updatre print queue cache during timeout_processing() to send notify events; CR 1491
(This used to be commit 142c5029c701e7a82074e301278846c02843f46f)
2003-01-11 02:29:23 +00:00
Gerald Carter
6df2dc56ff a 0 length printer data value is not a memory allocation error; fix CR601
(This used to be commit 3442c270f1bc67890f4e2de3386fcfdec610170d)
2003-01-09 19:51:28 +00:00
Andrew Bartlett
ff18825765 We already have one function to move unistr2 -> multibyte-static, so we
don't need a second just for pdb.

Also, remove magic 'is lp_guest_account' test - the magic RID should be
up to the passdb backend to set.

Andrew Bartlett
(This used to be commit f71c8338d35a2e8c73c3d8006ea6858cb522c715)
2003-01-02 13:10:25 +00:00
Andrew Bartlett
6d66fb308a BIG patch...
This patch makes Samba compile cleanly with -Wwrite-strings.
 - That is, all string literals are marked as 'const'.  These strings are
always read only, this just marks them as such for passing to other functions.

What is most supprising is that I didn't need to change more than a few lines of code (all
in 'net', which got a small cleanup of net.h and extern variables).  The rest
is just adding a lot of 'const'.

As far as I can tell, I have not added any new warnings - apart from making all
of tdbutil.c's function const (so they warn for adding that const string to
struct).

Andrew Bartlett
(This used to be commit 92a777d0eaa4fb3a1c7835816f93c6bdd456816d)
2003-01-02 09:07:17 +00:00
Andrew Bartlett
60f9614400 Move our password change code along a little - use NTSTATUS, and implmenet
minimum password age and min password length for all password changes.

Andrew Bartlett
(This used to be commit 028f808c032becfa4618924cb301a4af2708fa96)
2003-01-01 04:19:34 +00:00
Simo Sorce
60667264b7 the shutdown call does not have a 16 bit flags, but 2 byte representing booleans
this commit change the structure and code to reflect this

some test revelead I'm right.

some other revelead currently the abort shutdown does not work against my test machine even if it returns successfully ... need investigation
(This used to be commit c5892b656dedd0367adc33d9606311d1dde99a58)
2002-12-30 04:41:27 +00:00
Jeremy Allison
7f23546730 Forward port the change to talloc_init() to make all talloc contexts
named. Ensure we can query them.
Jeremy.
(This used to be commit 842e08e52a665ae678eea239759bb2de1a0d7b33)
2002-12-20 20:23:06 +00:00
Gerald Carter
b1cfbb0f69 * fix memory leak when constructing an driver_level_6 structure
and no dependent files (working on smbd memory leak).  No CR# yet.
(This used to be commit f017fa7c478f87165b7b6aa83059fe6fad29ac15)
2002-12-17 21:35:56 +00:00
Jim McDonough
5f9348d4fc Store printer guid in the dsspooler registry key so we don't have to
query the directory server every time someone asks
(This used to be commit f0fc4e30f6284565de404a20450a587cd3fe00a5)
2002-12-13 21:54:09 +00:00
Jim McDonough
bfd8043a40 More printer publishing code.
- Add published attribute to info2, needed for win clients to work properly
- Return proper info on getprinter 7

This means you can now look at the sharing tab of a printer and get correct
info about whether it is published or not, and change it.
(This used to be commit adda04379ee46f105436262663652f3f576fa3cf)
2002-12-13 18:56:48 +00:00
Jim McDonough
2dd0e949d0 Automatic printer publishing when using APW or choosing 'list in the directory' in printer settings. Currently very little is published, and you cannot unpublish because of a bug in win2k clients.
(This used to be commit bbd7c8071a095c4e410f92489050b677a0f0ace1)
2002-12-04 17:28:51 +00:00
Gerald Carter
1ad8139ef1 [merge from app_head]
XP sends GetPrinterData("ChangeId"). So we now respond accordingly.
Possible fix for CR 1147.
(This used to be commit 42a2e7d701fd342f2553660eb5094af8723fb50e)
2002-12-04 01:14:34 +00:00
Andrew Bartlett
af365408d5 Instead of walking the entire group database, grabbing all members of each
group, testing for membership etc, use the already calculated NT_USER_TOKEN.

(which is initgroups() based)

So far we only fill out the 'domain' groups - we need to fill out the
'other sids' as well, and we possibly need to filter the list for 'domain
groups' only (the old code did that), but Win2k doesn't seem to mind
this for now.

I also need to find out what the magic '7' is about.  Fortunetly JF is in town,
so I'll grill him tomorrow :-).

Andrew Bartlett
(This used to be commit 7e846e7387247f8bc2b07a1a1006014c6978143b)
2002-11-25 06:54:22 +00:00
Tim Potter
ee90b48633 Spelling fix.
(This used to be commit 43cd6e5a702bb1004b36a5845e0765851395ebf2)
2002-11-20 03:00:32 +00:00
Andrew Tridgell
1abaa7c9d3 more %U fixes for head
(This used to be commit ea3787d819df14f8b451780a55d2bf76dc4030ef)
2002-11-20 00:39:57 +00:00
Gerald Carter
155048633f formatting fix
(This used to be commit 6ce20a61a85f129d42c06844d51f4b2b35b41869)
2002-11-18 15:45:06 +00:00
Jeremy Allison
250c980119 Removed global_myworkgroup, global_myname, global_myscope. Added liberal
dashes of const. This is a rather large check-in, some things may break.
It does compile though :-).
Jeremy.
(This used to be commit 82b8f749a36b42e22186297482aad2abb04fab8a)
2002-11-12 23:15:52 +00:00
Gerald Carter
b0f9f11f5f fix for CR 601. Only call addprinter command when the port, driver, comment, or location field changed
(This used to be commit c6d45216f6d3573fb2342f4d3aa3a50415924674)
2002-11-11 22:05:05 +00:00
Jeremy Allison
7f94064e4a First cut of fix for changenotify on a print server handle. Use the connections tdb
with an snum of -1 and a special printername.
Jeremy.
(This used to be commit 940b04ddfa87acc939911e3fe76496e3c4675632)
2002-11-10 22:24:10 +00:00
Gerald Carter
4be3750d8e deldriver fix
(This used to be commit f20de1f9b0dcac15fbf968e6d5d5af2fdd5fbda1)
2002-11-09 14:48:27 +00:00
Gerald Carter
b3f55b37a0 re-enable ffpcn on print server handle
(This used to be commit e87829b4942237de542d21051092fee069a9c73d)
2002-11-09 05:41:27 +00:00
Andrew Bartlett
aa208a58e2 Make it easier to track things down here - add some debugs on failure.
(This used to be commit 62ee7b7dc08e7be261211de8f85b8e9be4df7b54)
2002-11-08 22:14:31 +00:00
Jeremy Allison
47955b2f6c Merge of scalable printing code fix... Needs testing.
Also tidied up some of Richard's code (I don't think he uses the compiler
flags -g -Wall -Wshadow -Wstrict-prototypes -Wpointer-arith -Wcast-qual like
I do :-) :-).
Jeremy.
(This used to be commit 10024ed06e9d91f24fdc78d59eef2f76bf395438)
2002-11-07 02:38:42 +00:00
Gerald Carter
71f34ddabd PURGE_PRINTER fix from APP_HEAD
(This used to be commit 8af12875b0608b83187e4156843e37097de4cd13)
2002-10-25 22:17:29 +00:00
Jeremy Allison
158ae87aa9 Reverted a fix from Volker (sorry). We need to move this fix to the correct
place.
Jeremy.
(This used to be commit e46e38beabe8ae5b1ba1941dcffecbc89165ce2a)
2002-10-23 22:23:39 +00:00
Jeremy Allison
b064077145 Debug level 12 is a typo.
Jeremy.
(This used to be commit 4d9b205362997f897be4739efd52ee2cfde4c6cb)
2002-10-23 01:55:40 +00:00
Jeremy Allison
7689a9c969 First cut of new ACL mapping code from Andreas Gruenbacher <agruen@suse.de>.
This is not 100% the same as what SuSE shipped in their Samba, there is
a crash bug fix, a race condition fix, and a few logic changes I'd like to
discuss with Andreas. Added Andreas to (C) notices for posix_acls.c
Jeremy.
(This used to be commit a81d700ae9c82d4b7ea631ab7862162a2ed3d512)
2002-10-23 01:22:45 +00:00
Jeremy Allison
9b323a3c0d Fix for systems that allow more than 65536 open files per process.
Jeremy.
(This used to be commit ff537f10a0c0b6b1d9055eb776d1e8a9864e8363)
2002-10-22 22:17:06 +00:00
Volker Lendecke
c7731c988e Same segfault as in add_groupmem.
Volker
(This used to be commit 1f702dcd2ced6f64a619e3ddbb570f41f7f0986b)
2002-10-21 20:33:00 +00:00
Volker Lendecke
5dbf435408 This moves the group mapping API into the passdb backend.
Currently this calls back to mapping.c, but we have the framework
to get the information into LDAP and the passdb.tdb (should we? I
think so..).

This has received moderate testing with net rpc vampire and
usrmgr. I found the add_groupmem segfault in add_aliasmem as
well, but that will be another checkin.

Volker
(This used to be commit f30095852fea19421ac8e25dfe9c5cd4b2206f84)
2002-10-21 19:28:56 +00:00
Volker Lendecke
605ab78401 Fix full_name for info23 as well. Thanks, Andrew.
Volker
(This used to be commit 382c444225fae54ae577baae8948a64a843a2afc)
2002-10-19 08:09:28 +00:00
Volker Lendecke
0c35d78632 This fixes some bugs for NT4 usrmgr.exe
Volker
(This used to be commit 32d6bcf3acefc77873a7241cc0c7e26241a65301)
2002-10-19 07:50:48 +00:00
Gerald Carter
a0fbdc3d64 fix from APP_HEAD to commit a re-init'd printer to disk
(This used to be commit 64a159144483457887df2c6d779e6a139dfc6d1f)
2002-10-16 18:21:55 +00:00
Gerald Carter
30acf331a9 merge from app_head to use GMT in job submission notification
(This used to be commit b130c681d2e8e6dcabe8cfd85dd718a294b04233)
2002-10-15 00:28:04 +00:00
Andrew Bartlett
4ac9ccfde4 Nice *big* patch from metze.
The actual design change is relitivly small however:

It all goes back to jerry's 'BOOL store', added to many of the elements in a
SAM_ACCOUNT.  This ensured that smb.conf defaults did not get 'fixed' into
ldap.  This was a great win for admins, and this patch follows in the same way.

This patch extends the concept - we don't store values back into LDAP unless
they have been changed.  So if we read a value, but don't update it, or we
read a value, find it's not there and use a default, we will not update
ldap with that value.  This reduced clutter in our LDAP DB, and makes it
easier to change defaults later on.

Metze's particular problem was that when we 'write back' an unchanged value,
we would clear any muliple values in that feild.  Now he can still have his
mulitivalued 'uid' feild, without Samba changing it for *every* other
operation.

This also applies to many other attributes, and helps to eliminate a nasty
race condition.  (Time between get and set)

This patch is big, and needs more testing, but metze has tested usrmgr, and
I've fixed some pdbedit bugs, and tested domain joins, so it isn't compleatly
flawed ;-).

The same system will be introduced into the SAM code shortly, but this fixes
bugs that people were coming across in production uses of Samba 3.0/HEAD, hence
it's inclusion here.

Andrew Bartlett
(This used to be commit 7f237bde212eb188df84a5d8adb598a93fba8155)
2002-10-12 03:38:07 +00:00
Gerald Carter
a92bf85234 print job properties fix from APP_HEAD. a null devmode is not a failure.
(This used to be commit b507dba452ecbd96ec95242f761501d0c5e0d7b5)
2002-10-09 18:54:20 +00:00
Gerald Carter
01da7d5617 add_printer_hook() fix from APP_HEAD
(This used to be commit 94201672a5c3cffd145e9f04a3ddd0d17a57e73b)
2002-10-09 17:00:04 +00:00
Gerald Carter
876afb5d0f merge from APP_HEAD
* s/driverlocation/comment
* detect native mode domain and enumerate local groups

Also

* Added sendfile stats from SAMBA_2_2
(This used to be commit 764b58e2c0b3179cffe157c0ab58761b156b8423)
2002-10-08 18:29:57 +00:00
Volker Lendecke
0672da5c43 Third part of my fix for usrmgr. Assuming automagic mapping
only in parts of srv_samr_nt is not good.

This is soo broken. :-)

Volker
(This used to be commit 74e4a3479f380b320daa0d46c0ba4daa9f98c18f)
2002-10-08 15:29:13 +00:00
Simo Sorce
650e0274a1 try to put every security descriptors related definitions in the same file.
also try to uniform names to a clean scheme.

first part.
(This used to be commit a123e05877caf90c28980be2d84b1d0b46e4fd21)
2002-10-06 23:53:34 +00:00
Jeremy Allison
9c94d1a2f7 Add a timeout to tdb_lock_bystring(). Ensure we never have more than
MAX_PRINT_JOBS in a queue.
Jeremy.
(This used to be commit bb58a08af459b4abae9d53ab98c15f40638ce52b)
2002-10-04 22:53:30 +00:00
Gerald Carter
83e58265b5 merge of new client side support the Win2k LSARPC UUID in rpcbind
from APP_HEAD
(This used to be commit 38c9e4299845fd77cc8629945ce2d259489f7437)
2002-10-04 03:51:43 +00:00
Jeremy Allison
32027e3b6b Missing break meant getprintprocessordirectory always returned UNKNOWN_LEVEL.
Jeremy.
(This used to be commit 1b283b649f68890b0aa450aa1ac90f1e8031a6fd)
2002-10-02 22:55:40 +00:00
Volker Lendecke
4b5c0793de Second part of my fix -- incorrect merge.
(This used to be commit 2613d3a48a8d60c3db38406a1abd943dbe0b7d09)
2002-09-30 06:45:58 +00:00
Volker Lendecke
cdeffe6d90 We have to hand out info on Builtin here as well. They are stored in
group mapping not as local, but as WKN_GRP.

Volker
(This used to be commit cb05dcab2de117ea4db54af313a05905cd5a0d0a)
2002-09-29 10:39:03 +00:00
Jeremy Allison
543edfbeab It turns out that Windows allows delete printer on a handle
opened by an admin user, then used on a pipe handle created
by an anonymous user..... but they're working on security.... riiight !
Jeremy.
(This used to be commit 322d8b4c83439261cfd2ff79b557bddb1e784660)
2002-09-27 22:51:59 +00:00
Jeremy Allison
3c7334c1b5 Check for security on delete printer was reversed...
Jeremy.
(This used to be commit 0d27cc909b4489b54e57481bd8a9494fb077dc3d)
2002-09-27 22:08:25 +00:00