Volker Lendecke
4db26c803d
Fix a crash bug in nt_printer_publish_ads
...
Reported by Martin Zielinski <mz@seh.de >
2008-01-16 11:39:20 +01:00
Jeremy Allison
7b9d9fba23
Fix CID 498. Ensure we don't prs_mem_free an uninitialized
...
prs_struct.
Jeremy.
2008-01-11 23:24:13 -08:00
Michael Adam
0b86c420be
Remove redundant parameter fd from SMB_VFS_FSTAT().
...
Michael
2008-01-07 15:59:01 +01:00
Michael Adam
df929796f2
Remove redundant parameter fd from SMB_VFS_LSEEK().
...
Michael
2008-01-07 15:59:01 +01:00
Jeremy Allison
c4e5a50504
Refactor the crypto code after a very helpful conversation
...
with Volker. Mostly making sure we have data on the incoming
packet type, not stored in the smb header.
Jeremy.
2008-01-04 12:56:23 -08:00
Volker Lendecke
bc3bd7a8e7
Remove tiny code duplication
...
ndr_size_security_descriptor does the same as sec_desc_size
2007-12-29 23:13:26 +01:00
Volker Lendecke
515f6a8cff
Remove a global
2007-12-28 17:16:35 +01:00
Jeremy Allison
4056bb8645
Two more static fstrings gone.
...
Jeremy.
2007-12-18 18:16:40 -08:00
Jeremy Allison
f9182bbe62
Remove another static fstring.
...
Jeremy.
2007-12-18 18:01:34 -08:00
Volker Lendecke
bb35e794ec
Replace sid_string_static by sid_string_dbg in DEBUGs
2007-12-15 22:09:36 +01:00
Jeremy Allison
70950b419a
Fix bug leftover from pstring conversion noticed by ceez
...
on irc.
Jeremy.
2007-12-10 13:43:12 -08:00
Volker Lendecke
2f3c865707
Tiny simplifications
...
locking.c:open_read_only was unused
don't export the silly boolean flag locking_init(bool read_only)
2007-12-10 12:22:01 +01:00
Volker Lendecke
0006b14d38
remove a static
2007-12-10 12:22:01 +01:00
Jeremy Allison
ec003f3936
Remove next_token - all uses must now be next_token_talloc.
...
No more temptations to use static length strings.
Jeremy.
2007-12-07 17:32:32 -08:00
Stefan Metzmacher
178afff879
printing: remove emtpy print_test.c
...
metze
2007-12-06 09:55:32 +01:00
Jeremy Allison
0ccd87c56b
Fix the build. fstrterminate was used in one place.
...
Jeremy.
2007-12-03 15:47:30 -08:00
Jeremy Allison
e72bce5b62
Remove unused wpstring and macros. Stop using pstrcpy in smbd/*.c
...
Jeremy.
2007-12-03 15:19:22 -08:00
Jeremy Allison
7722a7d2c6
Change tdb_unpack "P" to return a malloc'ed string rather
...
than expect a pstring space to put data into.
Fix the (few) callers.
Jeremy.
2007-12-03 14:54:06 -08:00
Jeremy Allison
b5a2a1e3f8
Remove pstring from srv_spoolss_nt.c. All gone from rpc_server/*.c
...
Jeremy.
2007-11-27 19:05:08 -08:00
Volker Lendecke
1fab16ffb8
Remove some statics
2007-11-27 14:18:47 +01:00
Jeremy Allison
d2ee75326a
Remove pstring from printing/*.c except for the
...
tdb_unpack requirement (I'll be making that an
allocating interface later).
Jeremy.
2007-11-21 13:56:36 -08:00
Jeremy Allison
f570175615
Remove pstrcpy I missed.
...
Jeremy.
2007-11-20 19:05:30 -08:00
Jeremy Allison
ae7885711f
Remove more pstring. Unify talloc_sub functions to make
...
them a better match for replacing string_sub. Remove
more unused code.
Jeremy.
2007-11-19 18:56:22 -08:00
Jeremy Allison
1ea3ac8014
More pstring removal. This one was tricky. I had to add
...
one horror (pstring_clean_name()) which will have to
remain until I've removed all pstrings from the client code.
Jeremy.
2007-11-15 14:19:52 -08:00
Jeremy Allison
ab8934844a
Fix case where we have no dns domain name. Return a talloc of "".
...
Jeremy.
2007-11-08 17:58:55 -08:00
Jeremy Allison
2a0173743d
Remove more fstring/pstring bad useage. Go talloc !
...
Jeremy.
2007-11-08 17:25:45 -08:00
Jeremy Allison
963fc76852
Remove most of the remaining globals out of lib/util_sock.c.
...
I have a plan for dealing with the remaining..... Watch
this space.
Jeremy.
2007-11-03 23:20:10 -07:00
Jeremy Allison
95d01279a5
I can't get away without a 'length' arg. :-).
...
Jeremy.
2007-11-03 18:41:26 -07:00
Jeremy Allison
e848506c85
Stop get_peer_addr() and client_addr() from using global
...
statics. Part of my library cleanups.
Jeremy.
2007-11-03 18:15:45 -07:00
Gerald (Jerry) Carter
d6cdbfd875
Patch 2 of 3 from Debian Samba packagers:
...
The point is doing the following associations:
- non discardable state data (all TDB files that may need to be backed
up) go to statedir
- shared data (codepage stuff) go to codepagedir
The patch *does not change* the default location for these
directories. So, there is no behaviour change when applying it.
The main change is for samba developers who have to think when dealing
with files that previously pertained to libdir whether they:
- go in statedir
- go in codepagedir
- stay in libdir
2007-11-01 15:53:44 -04:00
Jeremy Allison
f35a266b3c
RIP BOOL. Convert BOOL -> bool. I found a few interesting
...
bugs in various places whilst doing this (places that assumed
BOOL == int). I also need to fix the Samba4 pidl generation
(next checkin).
Jeremy.
2007-10-18 17:40:25 -07:00
Stefan Metzmacher
9e5ad21e67
remove unused print_test.c code
...
metze
2007-10-13 15:09:24 +02:00
Jeremy Allison
baf1f52e34
Add const to the get_peer_addr() and get_socket_addr()
...
calls. Use the IPv6 varient for get_peer_addr().
Jeremy.
2007-10-11 15:36:13 -07:00
Volker Lendecke
0141e64ad4
r25534: Apply some const
...
Why? It moves these structs from the data into the text segment, so they
will never been copy-on-write copied. Not much, but as in German you say
"Kleinvieh macht auch Mist...."
2007-10-10 12:31:12 -05:00
Jeremy Allison
b4ee924000
r25399: Excise uint - > uint32 (where appropriate) or unsigned int.
...
Jeremy.
2007-10-10 12:31:02 -05:00
Michael Adam
9a28be220d
r25294: Tidy up callers of unistr2_to_ascii() to pass sizeof(target_area) to
...
the maxeln parameter instead of sizeof(target_area) - 1 (or even
sizeof(fstring) - 1 in some places.
I hope these were really all there were.
Michael
2007-10-10 12:30:58 -05:00
Jeremy Allison
39c211a702
r25138: More pstring elimination. Add a TALLOC_CTX parameter
...
to unix_convert().
Jeremy.
2007-10-10 12:30:44 -05:00
Jeremy Allison
7f0db75fb0
r25117: The mega-patch Jerry was waiting for. Remove all pstrings from
...
the main server code paths. We should now be able to cope with
paths up to PATH_MAX length now.
Final job will be to add the TALLOC_CTX * parameter to
unix_convert to make it explicit (for Volker).
Jeremy.
2007-10-10 12:30:41 -05:00
Jeremy Allison
dee8beba7a
r25009: Large patch discussed with Volker. Move unix_convert to a talloc-based
...
interface. More development will come on top of this. Remove the
"mangled map" parameter.
Jeremy.
2007-10-10 12:30:32 -05:00
Jeremy Allison
9256ec0a20
r24464: Now Volker removed the readbmpx we don't need cached errors any more.
...
Jeremy.
2007-10-10 12:29:50 -05:00
Stefan Metzmacher
cdaa24e804
r24120: add a file_id_create() hook into the VFS layer
...
it's needed for some cluster filesystems to
overload this function.
metze
2007-10-10 12:29:08 -05:00
Volker Lendecke
fa53632568
r24069: Fix Coverity ID 368. We would segfault if 0 < data.dsize < 8
2007-10-10 12:29:01 -05:00
Stefan Metzmacher
00909194a6
r23888: move elements belonging to the current ldap connection to a
...
substructure.
metze
2007-10-10 12:28:38 -05:00
Andrew Tridgell
87c91e4362
r23801: The FSF has moved around a lot. This fixes their Mass Ave address.
2007-10-10 12:28:27 -05:00
Andrew Tridgell
b0132e94fc
r23784: use the GPLv3 boilerplate as recommended by the FSF and the license text
2007-10-10 12:28:22 -05:00
Jeremy Allison
407e6e695b
r23779: Change from v2 or later to v3 or later.
...
Jeremy.
2007-10-10 12:28:20 -05:00
Volker Lendecke
ca988f4e79
r23724: Reduce access to the global inbuf a tiny bit. Add a struct smb_request
...
that contains some of the fields from the SMB header, removing the need
to access inbuf directly. This right now is used only in the open file
code & friends, and creating that header is only done when needed. This
needs more work, but it is a start.
Jeremy, I'm only checking this into 3_0, please review before I merge it
to _26.
Volker
2007-10-10 12:23:48 -05:00
Volker Lendecke
9b10dbbd5d
r23183: Check in a change made by Tridge:
...
This replaces the internal explicit dev/ino file id representation by a
"struct file_id". This is necessary as cluster file systems and NFS
don't necessarily assign the same device number to the shared file
system. With this structure in place we can now easily add different
schemes to map a file to a unique 64-bit device node.
Jeremy, you might note that I did not change the external interface of
smb_share_modes.c.
Volker
2007-10-10 12:22:52 -05:00
Volker Lendecke
4afe37d431
r23168: Move the lp_max_connections() into service.c.
2007-10-10 12:22:51 -05:00
Volker Lendecke
3452a870d5
r23167: Remove an unused parameter
2007-10-10 12:22:51 -05:00