1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-27 14:04:05 +03:00

40 Commits

Author SHA1 Message Date
Volker Lendecke
76d53e7648 Alternative fix for 45db33e73 and 0d443ae7931
Simo is right, we need to ask passdb first. At least this fixes a nasty to find
NT_STATUS_ACCESS_DENIED problem in the build farm for the test run I just did
on host "opi".

Michael, can you re-check if this also fixes the error you found, leading to
the two fixes?

Thanks,

Volker
2009-01-02 15:00:05 +01:00
Volker Lendecke
13248e8917 Revert "s:Fix uid_to_sid mapping when the idmap cache is empty."
This reverts commit 9a9b64dbdfce4414ada22d4f882c8c757b5813e1.
2009-01-02 15:00:05 +01:00
Volker Lendecke
c033ea5626 Revert "s3:idmap: Remove passd check from idmap_backends_unixid_to_sid()."
This reverts commit 45db33e73262d8e195a46fb96405dfb3dc43d6bc.
2009-01-02 15:00:05 +01:00
Michael Adam
45db33e732 s3:idmap: Remove passd check from idmap_backends_unixid_to_sid().
As noted by Metzy, it makes no sense here to check id->sid.
What is worse, this might even be passed in uninitialized.

This still fixes the bug for me (of course), but we might need
to check, if another special handling of passdb is needed
(possibly changing from constant return code NT_STATUS_OK...)

Michael

Signed-off-by: Michael Adam <obnox@samba.org>
2008-12-25 12:14:03 +01:00
Michael Adam
9a9b64dbdf s:Fix uid_to_sid mapping when the idmap cache is empty.
This failed for backends other than passed, since
idmap_backends_unixid_to_sid() always asked passdb first,
which returned Success no matter whether a mapping was
found or not.

One effect wast that getpwuid failed after "net cache flush".
Only after filling the cache with a getpwnam call it succeeded.

This fix makes the behaviour of idmap_backends_unixid_to_sid()
exactly the same as that of idmap_backends_sid_to_unixid()

Michael

Signed-off-by: Michael Adam <obnox@samba.org>
2008-12-25 12:14:02 +01:00
Michael Adam
11d5b1a21a s3:winbindd/idmap: add diagnostic entry debug msg to idmap_backends_sid_to_unixid
Michael
2008-12-01 04:37:21 +01:00
Michael Adam
7b4e54359f s3:winbindd/idmap: add diagnostic entry debug msg to idmap_backends_unixid_to_sid
Michael
2008-12-01 04:37:21 +01:00
Michael Adam
5f5fa28c5d s3:winbindd/idmap: add diagnostic entry debug msg to idmap_find_domain().
Michael
2008-12-01 04:37:21 +01:00
Steven Danneman
00c6271d5c Added ability to remove id mappings in wbinfo and libwbclient.
The idmap_tdb backend already provides an interface to remove existing id
mappings.  This commit plumbs that ability up through, winbindd, libwbclient,
and wbinfo.

Added new winbindd command:
        WINBINDD_REMOVE_MAPPING
Added new libwbclient interfaces:
        wbcRemoveUidMapping() and wbcRemoveGidMapping()
Added new wbinfo options:
        --remove-uid-mapping
        --remove-gid-mapping

Increased libwbclient version to 0.2
Increased winbind interface version to 20
2008-11-18 16:04:04 -08:00
Herb Lewis
24992010cb get rid of unneeded argument in get_methods and get_alloc_methods
(This used to be commit 07b0323472b78d49cff06b78924c3015bea52a30)
2008-09-04 14:35:27 -07:00
Michael Adam
620d873183 idmap tdb2: fix inconsistent mappings by checking for race and retrying to fetch mapping.
Michael
(This used to be commit cb4c74c9c206e5a445ca636fa6562ce721ea5839)
2008-08-13 11:54:08 +02:00
Volker Lendecke
18bc97287c Some doxygen comments for idmap
(This used to be commit adecc6d91338e7e34afd0672aada5d0e47247a33)
2008-08-12 11:28:29 +02:00
Volker Lendecke
340ab6a256 idmap rewrite
(This used to be commit 30a180f2fce8cf6a3e5548f6bba453272ba70b33)
2008-08-12 11:28:29 +02:00
Volker Lendecke
8d4bd2d960 Remove the multi-ID lookup code and the 3.2.0 version of idmap_cache
(This used to be commit 1bd98521dc3f16ad77ccccd3979288c58e03ebe8)
2008-08-12 11:28:29 +02:00
Volker Lendecke
0c1e27abf6 Directly call backends from idmap_[ugs]_to_[ugs]id
(This used to be commit f955407042e6d2384acccc399d72ff65ba0e721c)
2008-08-12 11:28:28 +02:00
Simo Sorce
9669411d1e Fix regression introduced with 4086ef15b395f1a536fb669af2103a33ecc14de4
We must not return an error here just because we are offline.
We must instead fix the mappings to the best of our knowledge
(ie mark as mapped, expired ones, and as unmapped, unknown ones)
(This used to be commit 4436272dd4d6cdd223b1dc3d217a97cbe3bc887b)
2008-07-12 21:42:23 -04:00
Simo Sorce
8812606c43 Remove one nested level by reversing if condition
(This used to be commit 657a2f20dd4d422d45d7e054f463641cdff16816)
2008-07-12 21:41:55 -04:00
Simo Sorce
eda1a267e1 Add back mem leak fixes
(This used to be commit 2adea093c5709e128bdde1e37c6a897db7cbc3b1)
2008-07-12 21:40:33 -04:00
Simo Sorce
02e592486f Make again idmap_init static
(This used to be commit e113b7c13f2457676fdec9e52f09046286e25b60)
2008-07-12 21:40:28 -04:00
Volker Lendecke
343c7ff3d2 Revert "Fix two memory leaks in an error path in idmap.c"
This reverts commit 7cec389e19323e99b6b6258e539be9d1fd65810f.
(This used to be commit d0b34cbb4eba2b6543402af2c9f95407546cefad)
2008-07-11 17:53:26 +02:00
Volker Lendecke
622d36aa41 Revert "Make idmap_init() static"
This reverts commit c8d1bbfddce41cd6bf37dd0a622ef3437a24b492.
(This used to be commit 5cded3da00c0af40a98d86011507553f97fe6a22)
2008-07-11 17:53:26 +02:00
Volker Lendecke
b6dcc24987 Revert "Convert idmap_cache to gencache"
This reverts commit 0bf0434f22b0ea46fda3ccc4dd612adbc88dd4f2.
(This used to be commit cc536677735ecc318cbd2176ce53b124f44d85a0)
2008-07-11 17:53:24 +02:00
Volker Lendecke
ebb2d70a60 Revert "Make use of ADD_TO_ARRAY"
This reverts commit 81f334bd6da601a040f754c46705cfa2fd4f8c45.
(This used to be commit d4d106776af3f475d46a4dd78794b7b48a3572af)
2008-07-11 17:53:24 +02:00
Volker Lendecke
ca34287063 Make use of ADD_TO_ARRAY
(This used to be commit 81f334bd6da601a040f754c46705cfa2fd4f8c45)
2008-07-05 12:19:13 +02:00
Volker Lendecke
0234276af8 Convert idmap_cache to gencache
(This used to be commit 0bf0434f22b0ea46fda3ccc4dd612adbc88dd4f2)
2008-07-05 12:19:13 +02:00
Volker Lendecke
1999791b7c Make idmap_init() static
This is called only from idmap_alloc_init, which feels kindof weird.

Digging deeper in the code...
(This used to be commit c8d1bbfddce41cd6bf37dd0a622ef3437a24b492)
2008-07-02 13:34:09 +02:00
Volker Lendecke
ab57861686 Fix two memory leaks in an error path in idmap.c
(This used to be commit 7cec389e19323e99b6b6258e539be9d1fd65810f)
2008-07-02 13:34:09 +02:00
Karolin Seeger
a7cf0bd32a idmap: Fix typos in comments.
Karolin
(This used to be commit 94a4d7fa3209eb668161b8110af6f877b4833fa7)
2008-06-17 10:30:19 +02:00
Karolin Seeger
98ed31a107 Fix typo.
arguements -> arguments

Karolin
(This used to be commit 16b5b772d216d10613d433884634b1215efbd6e6)
2008-06-17 09:46:17 +02:00
Simo Sorce
a123abdb91 Fix trusted users on a DC that uses the old idmap syntax. There was no default backend therefore on IDs were mapped by default.
(This used to be commit f6069126e5e6d239b1ae00e897a420227f923e3f)
2008-04-03 00:26:35 +02:00
Volker Lendecke
900288a2b8 Replace sid_string_static by sid_string_dbg in DEBUGs
(This used to be commit bb35e794ec129805e874ceba882bcc1e84791a09)
2007-12-15 22:09:36 +01:00
Stefan Metzmacher
38f8d32d10 winbindd: remove unused WINBINDD_DUMP_MAPS support
Also the design of this function was really bad,
instead do the dump into a file, the client should get
back the list of mappings.

metze
(This used to be commit ce7fe8acf41e90553431c7cda6823700701835c7)
2007-12-12 10:07:05 +01:00
Stefan Metzmacher
92482e5667 idmap: add a const to idmap_dump_maps()
metze
(This used to be commit de31913f0a4fd407d935ec4e27a6123ab7847ab5)
2007-12-11 12:56:23 +01:00
Jeremy Allison
7faee02d0d Remove the char[1024] strings from dynconfig. Replace
them with malloc'ing accessor functions. Should save a
lot of static space :-).
Jeremy.
(This used to be commit 52dc5eaef2106015b3a8b659e818bdb15ad94b05)
2007-12-10 11:30:37 -08:00
Michael Adam
bf13b9f180 Fix a debug message (missing newline).
Michael
(This used to be commit 2a1755327f6cef6c969308e9ebcb238048535533)
2007-12-05 17:14:55 +01:00
Gerald (Jerry) Carter
2545457268 Prevent segv in winbindd running on a DC using the "idmap backend" syntax.
The number of domains should be counted as they are added and not assumed
to match the loop counter.

manually cherry-picked 8ad2826c48a0d4d26abc3bb209860c776f55822f
(This used to be commit 99b75cada2c4caaec5d30c8351080f0a41e44bd1)
2007-11-20 13:27:14 -06:00
Volker Lendecke
8f391ae471 Fix an incompatible pointer type warning
(This used to be commit 3c50caa9620899f982cd4a833356d965f47ec843)
2007-10-19 16:46:13 -05:00
Jeremy Allison
30191d1a57 RIP BOOL. Convert BOOL -> bool. I found a few interesting
bugs in various places whilst doing this (places that assumed
BOOL == int). I also need to fix the Samba4 pidl generation
(next checkin).
Jeremy.
(This used to be commit f35a266b3cbb3e5fa6a86be60f34fe340a3ca71f)
2007-10-18 17:40:25 -07:00
Simo Sorce
b111d543a5 Fix default domains support using compat syntax.
Without this fix idmap_rid can't be used with the compatible syntax.
Includes fix to keep trusted domains working
(This used to be commit 8c770c367c71d118651964fef63e2fd0fa4a05a5)
2007-10-16 14:16:03 -04:00
Stefan Metzmacher
28aa4bff8d r25154: move winbindd code into winbindd/
metze
(This used to be commit 3ac7566ae14c48ff9b0f6b232e0ec4b2f73df558)
2007-10-10 12:30:46 -05:00