1
0
mirror of https://github.com/samba-team/samba.git synced 2025-02-05 21:57:51 +03:00

29147 Commits

Author SHA1 Message Date
Volker Lendecke
5595cdf837 Remove current_user references from trans2.c
This involved replacing the CHECK_NTQUOTA_HANDLE_OK macro by a function.
2008-06-19 18:51:38 +02:00
Volker Lendecke
4c31cc0b62 Remove some current_user references from trans2.c 2008-06-19 18:51:38 +02:00
Volker Lendecke
e895e44cc7 Remove reference to current_user from reply.c 2008-06-19 18:51:38 +02:00
Volker Lendecke
dcaedf345e Wrap the unix token info in a unix_user_token in auth_serversupplied_info
No functional change, this is a preparation for more current_user ref removal
2008-06-19 18:51:37 +02:00
Volker Lendecke
64e9372ab9 Remove the "current_user" arg from fsp_belongs_conn
fsp_belongs_conn only used the vuid struct member anyway, and this is available
in the smb_request structure as well.
2008-06-19 18:51:37 +02:00
Volker Lendecke
8d364c4c33 Remove the "current_user" arg from check_fsp
check_fsp only used the vuid struct member anyway, and this is available in the
smb_request structure as well.
2008-06-19 18:51:37 +02:00
Michael Adam
c65d425fec loadparm: use the return value of the special handlers in lp_load().
Up to now, the bool return value was silently ignored.

Michael
2008-06-19 17:22:27 +02:00
Michael Adam
a8ef8870be loadparm: don't treat a missing include file as an error in handle_include().
Michael
2008-06-19 17:22:27 +02:00
Michael Adam
0f5c13e573 testsuite: enable the testparm_s3 tests.
Michael
2008-06-19 17:22:27 +02:00
Michael Adam
eb28146d40 testsuite: add a testparm_s3 test script.
This is a first testparm/lp_load test that runs testparm on a couple
of configuration files. The main purpose for now is to test the options
that have special handlers (to check whether the handlers succeed).
In particular, all the Macro expansions that are available via
alloc_sub_basic() are tested with the include handler. This is to
catch such crashbugs as #5548 where %m expansion led to a segfault.

The tests now are very simple. Just check if testparm completes
successfully on the given config files. This can (and should) be
elaborated in the future.

Michael
2008-06-19 17:22:27 +02:00
Michael Adam
73c17b6303 testsuite: update introductory comment to test_net_regsistry.sh
This is now used to test rpc and local access depending on
command line parameters.

Michael
2008-06-19 17:22:27 +02:00
Volker Lendecke
fdc03c0a5b Remove current_user_info reference from vfs_recycle.c 2008-06-19 15:53:43 +02:00
Volker Lendecke
a227181e8d Remove current_user_info reference from vfs_fake_perms.c 2008-06-19 15:53:43 +02:00
Volker Lendecke
05a66980a9 Remove current_user_info reference from vfs_expand_msdfs.c 2008-06-19 15:53:43 +02:00
Volker Lendecke
407136abdf current_user is not used in vfs_aixacl2.c 2008-06-19 15:53:43 +02:00
Volker Lendecke
51b5364c2a RWX on a file does not imply DELETE access
Without this the changed checks in can_delete_file_in_directory give DELETE
access where there is none. So we can end up granting the ntcreate&x preparing
the unlink where we should not, which leads to a NT_STATUS_ACCESS_DENIED at
close time later, which in turn does *not* give the access denied error message
in the Windows GUI.

can_delete_file_in_directory will grant access now by looking at the directory
permissions.
2008-06-19 15:27:41 +02:00
Volker Lendecke
daa9b05664 Fix checks in can_delete_file_in_directory()
With at least NFSv4 ACLs around the write permission for the owner is a bogus
check if we can delete a file in a directory. Like in Windows, there are two
ways which can grant us such: First, the DELETE permission on the file itself,
or if that does not help, the DELETE_CHILD permission on the directory. It
might be a bit more code that runs, but essentially we should end up with the
same set of syscalls in the non-acl case.
2008-06-19 15:27:41 +02:00
Volker Lendecke
abe1bed665 Remove some code
Did not measure it, but I think a single write is better than a read and a
conditional branch
2008-06-19 12:03:31 +02:00
Volker Lendecke
2eef2c682c Fix typo 2008-06-19 12:02:12 +02:00
Volker Lendecke
4f50cb63e9 Fix the build on FreeBSD 4.6.2 2008-06-19 12:02:12 +02:00
Jeremy Allison
8b26afdcdd Fix 'make distclean'. delheaders: no longer exists as a dependency.
Jeremy.
2008-06-18 12:56:36 -07:00
Derrell Lipman
0e84e3bb80 Remove prototype of unimplemented smbc_chown() function. 2008-06-18 11:00:46 -04:00
Volker Lendecke
b1e8e5d173 Revert "Fix a memleak in svcctl_init_keys()"
This reverts commit b1afb31f3cadd4749bf6e3eb5d8935588bf8ebfc.

This one is very strange: I need to investigate why valgrind showed it as
leaking, and why in my initial tests this did not fail.
(cherry picked from commit 24730f5981efb920811e7929a9483bd72bb0984c)
2008-06-18 16:31:35 +02:00
Michael Adam
c65b456c6a Fix Bug #5548 (segfauls in handle_include with %m macro expansion).
In alloc_sub_basic, when expanding '%m', substitute "" instead of
NULL for remote_machine when this is NULL. Else a NULL string
is returned.

Michael
2008-06-18 14:50:53 +02:00
Michael Adam
7d5fb873bd file_access: add a function header comment for can_access_file_acl().
Michael
2008-06-18 00:06:46 +02:00
Michael Adam
3c349f773a smbd/dir.c: remove unneeded stat buf parameter from user_can_read_file()
This is not needed anymore since user_can_access_file_acl() ist used.

Michael
2008-06-18 00:02:28 +02:00
Michael Adam
5931540fa1 file_access: remove unneeded stat buf parameter from can_access_file_acl().
This is a security descriptor level function only.

Michael
2008-06-17 23:58:49 +02:00
Michael Adam
b9f6904044 net sam: fix typo in comment
Michael
2008-06-17 23:57:26 +02:00
Michael Adam
6d7f64c348 net sam: fix typo in debug message.
Michael
2008-06-17 23:56:42 +02:00
Michael Adam
1734f9305a testsuite: give admin rights to testuser only for the "net rpc registry" test.
Remove the user from BUILTIN\Administrators at the end of the tests.
Note: BUILTIN\Administrators is not deletet at the end because that
functionality is not implemented.

Michael
2008-06-17 23:54:15 +02:00
Michael Adam
9fe99c69f3 testsuite: don't give the testuser administrative rights globally.
It breaks RPC-SAMBA3-GETUSERNAME for reasons I have not quite
understood yet. Somhow loosing rights fails when the user
belogns to BUILTIN\Administrators at some point.

Michael
2008-06-17 23:51:23 +02:00
Volker Lendecke
b8e1d62b8e Fix a brown paper bag segfault in clitar
Thanks to "No Body is Perfect" from gmail, whoever that is :-)

Volker
(cherry picked from commit 679d8dfa390601f777bfb43c02cd921eae5edcf4)
2008-06-17 21:14:47 +02:00
Günther Deschner
2351b0845c rpcclient: add more generic internal dscracknames call.
Guenther
2008-06-17 20:01:51 +02:00
Günther Deschner
ad10517768 netapi: use NetUserEnum filter in example code.
Guenther
2008-06-17 20:00:11 +02:00
Günther Deschner
32a66131eb netapi: add NetUserEnum filter constants to public headers.
Guenther
2008-06-17 20:00:00 +02:00
Günther Deschner
0bd69df770 netapi: implement NetUserEnum filters.
Guenther
2008-06-17 19:59:50 +02:00
Günther Deschner
383636aaca re-run make idl.
Guenther
2008-06-17 19:59:38 +02:00
Günther Deschner
12669b12c2 netapi: add NetUserEnum filter constants to IDL.
Guenther
2008-06-17 19:59:22 +02:00
Günther Deschner
4fd6bc61d0 netapi: some IDL cosmetics.
Guenther
2008-06-17 19:58:39 +02:00
Günther Deschner
2b82779a40 netapi: add NetRemoteTOD example code.
Guenther
2008-06-17 19:58:11 +02:00
Günther Deschner
76877680a8 netapi: implement NetRemoteTOD().
Guenther
2008-06-17 19:58:01 +02:00
Günther Deschner
1262ab1843 netapi: make NetRemoteTOD() headers public.
Guenther
2008-06-17 19:57:06 +02:00
Günther Deschner
78bc98cb55 netapi: add NetRemoteTOD() skeleton.
Guenther
2008-06-17 19:56:44 +02:00
Günther Deschner
782ab0f1c1 re-run make idl.
Guenther
2008-06-17 19:56:27 +02:00
Günther Deschner
8dd1a5fabf netapi: add NetRemoteTOD() to IDL.
Guenther
2008-06-17 19:56:16 +02:00
Günther Deschner
e0b1172004 net_vampire: add error and result_message to samsync_context.
Guenther
2008-06-17 19:55:16 +02:00
Günther Deschner
7e7f07ec59 net_vampire: add domain_name to samsync_context.
Guenther
2008-06-17 19:55:10 +02:00
Günther Deschner
cb7ace209c libads: add ads_get_machine_kvno() to make ads_get_kvno() a bit more generic.
Guenther
2008-06-17 19:54:09 +02:00
Günther Deschner
ec86852fc6 clikrb5: remove unrequired create_kerberos_key_from_string_direct() prototype.
Guenther
2008-06-17 19:51:52 +02:00
Günther Deschner
d20353d30c dsgetdcname: allow to use NULL mem_ctx.
Guenther
2008-06-17 19:51:24 +02:00