1
0
mirror of https://github.com/samba-team/samba.git synced 2025-02-03 13:47:25 +03:00

1437 Commits

Author SHA1 Message Date
Stefan Metzmacher
38f505530b tsocket: make sure we delete the fd event before calling close()
We got random double free errors, when getting events from
epoll_wait() and try to dereference the private talloc pointer
attached to it.

Before doing the close() in the tstream_disconnect_send() function
we need to delete the fd event.

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Tue Sep 28 01:02:55 UTC 2010 on sn-devel-104
2010-09-28 01:02:55 +00:00
Volker Lendecke
35d9530f3b Remove talloc_autofree_context() from pm_process
This would be a classic for talloc_tos(), InFile is freed a few lines down. But
unfortunately S4 does not support talloc_tos().
2010-09-27 18:14:47 +02:00
Volker Lendecke
8e02130c62 Lift talloc_autofree_context() from OpenConfFile() 2010-09-27 18:14:47 +02:00
Michael Adam
84127dd504 libsmbconf: parse an empty share as empty share, not as NULL.
This fixes a segfault in net conf import:
Importing a text file with an empty share resulted in a segfault.
Now this creates an empty share in registry config, just as it
should.

Thanks to Gregor Beck <gbeck@sernet.de> for reporting.
2010-09-27 12:43:39 +02:00
Stefan Metzmacher
f9ba8f5d8a lib/util: change tevent_req_nterror() to a macro
This way we can record where a tevent_req was finished by
tevent_req_nterror().

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Mon Sep 27 03:18:14 UTC 2010 on sn-devel-104
2010-09-27 03:18:14 +00:00
Rusty Russell
b7cd6af5b4 tdb: fix non-WAF build, commit 1.2.6 ABI file.
Sorry Jeremy.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2010-09-27 11:06:51 +09:30
Rusty Russell
2dcf76c924 tdb: TDB_INCOMPATIBLE_HASH, to allow safe changing of default hash.
This flag to tdb_open/tdb_open_ex effects creation of a new database:
1) Uses the Jenkins lookup3 hash instead of the old gdbm hash if none is
   specified,
2) Places a non-zero field in header->rwlocks, so older versions of TDB will
   refuse to open it.

This means that the caller (ie Samba) can set this flag to safely
change the hash function.  Versions of TDB from this one on will either
use the correct hash or refuse to open (if a different hash is specified).
Older TDB versions will see the nonzero rwlocks field and refuse to open
it under any conditions.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2010-09-27 10:48:28 +09:30
Rusty Russell
ccac258d14 tdb: automatically identify Jenkins hash tdbs
If the caller to tdb_open_ex() doesn't specify a hash, and tdb_old_hash
doesn't match, try tdb_jenkins_hash.

This was Metze's idea: it makes life simpler, especially with the upcoming
TDB_INCOMPATIBLE_HASH flag.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2010-09-27 10:48:28 +09:30
Rusty Russell
3258cf3f11 tdb: add Bob Jenkins lookup3 hash as helper hash.
This is a better hash than the default: shipping it with tdb makes it easy
for callers to use it as the hash by passing it to tdb_open_ex().

This version taken from CCAN and modified, which took it from
http://www.burtleburtle.net/bob/c/lookup3.c.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2010-09-27 10:48:28 +09:30
Stefan Metzmacher
182a69c5be lib/util/asn1: add asn1_peek_tag_needed_size() and asn1_peek_full_tag()
We need a way to ask for the length of a tag without having the full
buffer yet.

metze
2010-09-26 06:45:39 +02:00
Jelmer Vernooij
0a18f89e8a pyteven: Fix build warnings. 2010-09-25 12:20:58 -07:00
Jelmer Vernooij
296ff486e4 Check in configure/Makefile for those projects that have waf as primary build system. 2010-09-25 12:20:57 -07:00
Jelmer Vernooij
e68afdc02f pytevent: Add more tests. 2010-09-25 12:20:57 -07:00
Jelmer Vernooij
ddb3c48f1a pytevent: Fill in client side fnuctions. 2010-09-25 12:20:57 -07:00
Jelmer Vernooij
465cff7531 tevent: Add infrastructure for python bindings. 2010-09-25 12:20:56 -07:00
Jelmer Vernooij
1f22b63b34 tevent: Switch to using waf by default. 2010-09-25 12:20:56 -07:00
Volker Lendecke
e325a5b674 talloc: Add a warning about talloc_autofree_context() and dlclose() 2010-09-24 17:21:42 -07:00
Volker Lendecke
66731461a6 tdb: add restore
Based on an idea by Simon McVittie, largely rewritten
2010-09-23 12:19:09 -07:00
Jelmer Vernooij
4b901f6d8b torture: Remove unused variable. 2010-09-23 11:36:12 -07:00
Andrew Tridgell
8ccbbe042b lib-subunit: fixed build on systems without subunit devel library
Pair-Programmed-With: Jelmer Vernooij <jelmer@samba.org>
2010-09-23 07:17:57 +00:00
Jelmer Vernooij
136aa0d5ac smbtorture: Report times. 2010-09-22 22:29:09 -07:00
Jelmer Vernooij
a15a33a9a8 torture: Use system subunit library if available. 2010-09-22 22:29:09 -07:00
Jelmer Vernooij
029add7e07 smbtorture: Use subunit C library. 2010-09-22 22:29:09 -07:00
Björn Jacke
9b73bb0099 libreplace: fix endless strerror_r has been redefined warnings on AIX 2010-09-22 11:18:59 -07:00
Jelmer Vernooij
0aff42a6e4 torture: Remove active_testname variable. 2010-09-21 22:54:34 -07:00
Jelmer Vernooij
e456c69498 torture: Fix running individual tests. 2010-09-21 22:54:34 -07:00
Jelmer Vernooij
4c681f760f strlist: Make test names unique. 2010-09-21 22:54:33 -07:00
Björn Jacke
7c9dab4761 tevent: include libreplace heade before tevent header
this is supposed to fix bug #7463. Thanks to Joachim Schmitz.
2010-09-21 19:11:58 -07:00
Jelmer Vernooij
049c4fa04d pytalloc: Add default compare function. 2010-09-21 11:47:03 -07:00
Jelmer Vernooij
a7393449eb pidl: Fix segfault when accessing unicode objects. 2010-09-20 22:40:46 -07:00
Günther Deschner
1585c4df68 lib/tdb: fix c++ build warning in tdb_header_hash().
Guenther
2010-09-20 16:15:11 -07:00
Volker Lendecke
1c8fd86a1d s3: Fix the charset_pull routine (bug 7531)
In the push routine we do the SVAL, so we should do the SSVAL here.
2010-09-19 21:33:25 -07:00
Jelmer Vernooij
dfedbaeb05 testtools: Import newer upstream revision.
This fixes (among other things) a warning during 'make test' on systems with Python 2.6.
2010-09-19 12:34:55 -07:00
Jelmer Vernooij
7a59c90189 pytdb: Make filename argument optional. 2010-09-19 10:42:29 -07:00
Kirill Smelkov
4c72655678 pytdb: Add support for tdb_freelist_size()
Cc: 597386@bugs.debian.org
Signed-off-by: Kirill Smelkov <kirr@landau.phys.spbu.ru>
Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
2010-09-19 10:03:00 -07:00
Kirill Smelkov
b3314d6ad8 pytdb: Add support for tdb_transaction_prepare_commit()
Cc: 597386@bugs.debian.org
Signed-off-by: Kirill Smelkov <kirr@landau.phys.spbu.ru>
Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
2010-09-19 09:35:43 -07:00
Kirill Smelkov
b826ef9697 pytdb: Add support for tdb_enable_seqnum, tdb_get_seqnum and tdb_increment_seqnum_nonblock
Cc: 597386@bugs.debian.org
Signed-off-by: Kirill Smelkov <kirr@landau.phys.spbu.ru>
Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
2010-09-19 09:34:33 -07:00
Kirill Smelkov
a2621034e9 pytdb: Update open flags to match those for tdb_open() in tdb.h
Namely TDB_NOSYNC, TDB_SEQNUM, TDB_VOLATILE, TDB_ALLOW_NESTING and
TDB_DISALLOW_NESTING were missing.

Cc: 597386@bugs.debian.org
Signed-off-by: Kirill Smelkov <kirr@mns.spb.ru>
Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
2010-09-19 09:31:34 -07:00
Kirill Smelkov
277a1b229c pytdb: Fix repr segfault for internal db
The problem was tdb->name is NULL for TDB_INTERNAL databases, and
so it was crashing ...

    #0  0xb76944f3 in strlen () from /lib/i686/cmov/libc.so.6
    #1  0x0809862b in PyString_FromFormatV (format=0xb72b6a26 "Tdb('%s')", vargs=0xbfc26a94 "")
        at ../Objects/stringobject.c:211
    #2  0x08098888 in PyString_FromFormat (format=0xb72b6a26 "Tdb('%s')") at ../Objects/stringobject.c:358
    #3  0xb72b65f2 in tdb_object_repr (self=0xb759e060) at ./pytdb.c:439

Cc: 597089@bugs.debian.org
Signed-off-by: Kirill Smelkov <kirr@mns.spb.ru>
Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
2010-09-19 09:31:20 -07:00
Kirill Smelkov
c4b1971259 pytdb: Add support for tdb_add_flags() & tdb_remove_flags()
Note, unlike tdb_open where flags is `int', tdb_{add,remove}_flags want
flags as `unsigned', so instead of "i" I used "I" in PyArg_ParseTuple.

Cc: 597386@bugs.debian.org
Signed-off-by: Kirill Smelkov <kirr@mns.spb.ru>
Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
2010-09-19 09:31:08 -07:00
Björn Jacke
1a22b1b44d lib/util: usec_time_diff takes arguments the other way round than TvalDiff did 2010-09-17 14:05:53 +02:00
Björn Jacke
2b254c814b s3/s4: merge msleep and smb_msleep
the merged variant is renamed to smb_msleep as some platforms already have a
msleep function.
2010-09-16 21:38:20 +02:00
Andrew Tridgell
ff515ff477 tdb: added TDB_NO_FSYNC env variable
this might help reduce test times and load on test machines
2010-09-16 21:09:17 +10:00
Volker Lendecke
301b60acc0 Fix a typo 2010-09-15 09:33:34 -07:00
Andrew Tridgell
0212800de8 tsocket: we return -1 on error, not fd
the code used this pattent:

 if (fd < 0) {
   ...various cleanups...
   return fd;
 } 

it is much clearer to do this:

 if (fd < 0) {
   ...various cleanups...
   return -1;
 } 

as otherwise when reading the code you think this function may return
a fd.

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2010-09-15 15:39:36 +10:00
Andrew Tridgell
ba2c394ed4 talloc: fixed spelling errors in comment 2010-09-15 15:39:34 +10:00
Jeremy Allison
0b270f014f Ensure incoming timespec values correctly wrap at nsecs.
Jeremy.
2010-09-14 14:53:17 -07:00
Björn Jacke
9c00fb4aa6 libreplace: use CLOCK_HIGHRES when available
in Solaris 8 CLOCK_HIGHRES was the (only) name for CLOCK_MONOTONIC
2010-09-14 22:11:59 +02:00
Stefan Metzmacher
4c3e6a59af tdb: add ABI/tdb-1.2.4.sigs
metze
2010-09-14 13:10:47 +02:00
Jelmer Vernooij
49411fa107 subunit.pm: Pass through milliseconds in time reports. 2010-09-14 10:54:27 +02:00