1
0
mirror of https://github.com/samba-team/samba.git synced 2024-12-24 21:34:56 +03:00
Commit Graph

46 Commits

Author SHA1 Message Date
Günther Deschner
a15159f5a5 werror: replace WERR_INVALID_PARAM with WERR_INVALID_PARAMETER in source3/utils/
Guenther

Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
2016-09-28 00:04:23 +02:00
Günther Deschner
9c164efe2a werror: replace WERR_NOMEM with WERR_NOT_ENOUGH_MEMORY in source3/utils/
Guenther

Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
2016-09-28 00:04:19 +02:00
Günther Deschner
f7b172fd42 werror: replace WERR_BADFILE with WERR_FILE_NOT_FOUND in source3/utils/
Guenther

Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
2016-09-28 00:04:17 +02:00
Michael Adam
f7cf09e661 s3:net rpc conf: factor validation of parameter out for re-use.
This goes into a new module net_conf_util to be shared
between net conf and net rpc conf.

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2013-09-24 07:44:28 +02:00
Michael Adam
349bcafe09 s3:net rpc conf: rename canon_valname->canon_param_name for clarity in setparm.
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2013-09-24 07:44:28 +02:00
Michael Adam
a00f97a392 s3:net rpc conf: setparm: introduce variables service_name, param_name, valstr for clarity
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2013-09-24 07:44:28 +02:00
Michael Adam
3e53097689 s3:net rpc conf: reorganize the validity check and canonicalization of the input in "setparm"
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2013-09-24 07:44:28 +02:00
Michael Adam
b7db29eb2a s3:net rpc conf: print the provided parameter name on error, not the canonicalized one
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2013-09-24 07:44:28 +02:00
Michael Adam
bceb34543e s3:net rpc conf: remove the (now) unused rpc_conf_reg_valname_forbidden()
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2013-09-24 07:44:28 +02:00
Michael Adam
0c4e5fcc53 s3:net rpc conf: use the published smbconf_reg_parameter_is_valid()
Instead of the duplicated rpc_conf_reg_valname_forbidden()

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2013-09-24 07:44:28 +02:00
Volker Lendecke
aa220c4981 s3: Fix Coverity ID 242725 Uninitialized scalar variable
Not a functional bug, but we copy all of the "key" structure inside
dcerpc_winreg_CreateKey.
2012-05-10 09:11:57 +02:00
Volker Lendecke
dead2168a2 s3: Fix Coverity ID 242726 Uninitialized scalar variable
Not a functional bug, but we copy all of the "key" structure inside
dcerpc_winreg_OpenKey.
2012-05-10 09:11:57 +02:00
Andrew Bartlett
9729bdf89f s3-utils/net: pass struct ndr_interface_table down
This will allow the target service (as determined from the IDL) to be
passed to GSSAPI (rather than the current, incorrect, "cifs").

Andrew Bartlett

Signed-off-by: Stefan Metzmacher <metze@samba.org>
2012-01-18 16:23:24 +01:00
Günther Deschner
af82bf2ac5 s3-net: Fix uninitialized variable in rpc_conf_import_internal().
Michael, please check.

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri Oct 14 19:25:47 CEST 2011 on sn-devel-104
2011-10-14 19:25:47 +02:00
Volker Lendecke
49233b41e6 s3: Fix "ISO C90 forbids mixed declarations and code" 2011-09-18 17:24:22 +02:00
Vicentiu Ciorbaru
3fc2bc34a5 s3-net: Added documentation for net_rpc_conf functions
Added comments to most functions of net rpc conf for easier
understanding of the code.

Signed-off-by: Michael Adam <obnox@samba.org>

Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Mon Aug 22 17:08:15 CEST 2011 on sn-devel-104
2011-08-22 17:08:15 +02:00
Vicentiu Ciorbaru
57b7fb7256 s3-net: Implemented net rpc conf import command
The function takes a local file in smb.conf format,
uses calls to smbconf to create smbconf_service structs,
which are then placed in the remote registry.

The function also provides a test module to only print
the changes that it would make.

Signed-off-by: Michael Adam <obnox@samba.org>
2011-08-22 13:59:28 +02:00
Vicentiu Ciorbaru
a00851f337 s3-net: Added net rpc conf import command to net rpc conf
The function only appears in the commands list usage of net rpc
conf.

Signed-off-by: Michael Adam <obnox@samba.org>
2011-08-22 13:59:28 +02:00
Vicentiu Ciorbaru
66583da28d s3-net: Implemented net rpc conf addshare command
The function is mostly a wrapper around a series of setparm
commands. It can be used to quickly set up a share with simple
parameters.

Signed-off-by: Michael Adam <obnox@samba.org>
2011-08-22 13:59:28 +02:00
Vicentiu Ciorbaru
16b463739b s3-net: Added net rpc conf addshare command to net rpc conf
The function only appears in the commands list usage of net rpc
conf.

Signed-off-by: Michael Adam <obnox@samba.org>
2011-08-22 13:59:28 +02:00
Vicentiu Ciorbaru
7ee8a492c6 s3-net: Implemented net rpc conf setincludes command
The function creates the share key if it does not exist.
If the share key was present it deletes the previous includes.
After this the function sets the new includes accordingly.

Signed-off-by: Michael Adam <obnox@samba.org>
2011-08-22 13:59:28 +02:00
Vicentiu Ciorbaru
f9862971c1 s3-net: Added net rpc conf setincludes command to net rpc conf
The function only appears in the commands list usage of net rpc
conf.

Signed-off-by: Michael Adam <obnox@samba.org>
2011-08-22 13:59:27 +02:00
Vicentiu Ciorbaru
0c7f1d32e8 s3-net: Implemented net rpc conf setparm command
The function creates the share key if it does not exist.
If the share key was present it deletes the previous value.
After this the function sets the new value accordingly.

Signed-off-by: Michael Adam <obnox@samba.org>
2011-08-22 13:59:27 +02:00
Vicentiu Ciorbaru
ffe98b51ef s3-net: Added net rpc conf setparm command to net rpc conf
The function only appears in the commands list usage of net rpc
conf.

Signed-off-by: Michael Adam <obnox@samba.org>
2011-08-22 13:59:27 +02:00
Vicentiu Ciorbaru
1a3b88cfb3 s3-net: Implemented net rpc conf delparm command
The function makes use of existing code from delincludes.
It has the same logic, except it uses the second argument
passed to determine which value to delete from the registry.

Signed-off-by: Michael Adam <obnox@samba.org>
2011-08-22 13:59:27 +02:00
Vicentiu Ciorbaru
689edf8ae1 s3-net: Added net rpc conf delparm command to net rpc conf
The function only appears in the commands list usage of net rpc
conf.

Signed-off-by: Michael Adam <obnox@samba.org>
2011-08-22 13:59:27 +02:00
Vicentiu Ciorbaru
f370965c34 s3-net: Refactored part of rpc_conf_delincludes_internal
The function now makes use of rpc_conf_del_value to delete
the includes of a given share.

Signed-off-by: Michael Adam <obnox@samba.org>
2011-08-22 13:59:27 +02:00
Vicentiu Ciorbaru
4b3e2adf8c s3-net: Created function net_rpc_conf_del_value
Function is used to refactor some of the code used in
delincludes and also to be used in the other key manipulating
functions.

Signed-off-by: Michael Adam <obnox@samba.org>
2011-08-22 13:59:27 +02:00
Vicentiu Ciorbaru
704d7d02ac s3-net: Implemented net rpc conf delincludes command
The function openes the key attached to the service passed as a
parameter to the command and it uses dcerpc_winreg_DeleteValue to
delete the includes value if it exists

Signed-off-by: Michael Adam <obnox@samba.org>
2011-08-22 13:59:26 +02:00
Vicentiu Ciorbaru
a974f01b6b s3-net: Added net rpc conf delincludes command to net rpc conf
The function only appears in the commands list usage of net rpc
conf.

Signed-off-by: Michael Adam <obnox@samba.org>
2011-08-22 13:59:26 +02:00
Vicentiu Ciorbaru
8d335a3ad8 s3-net: Implemented net rpc conf getincludes command
The function creates a smconf_service struct that holds the share
passed as the first argument to the command and searches in it for
"include" parameters. If any are found, they are displayed.

Signed-off-by: Michael Adam <obnox@samba.org>
2011-08-22 13:59:26 +02:00
Vicentiu Ciorbaru
b52bfc1a9a s3-net: Added net rpc conf getincludes command to net rpc conf
The function only appears in the commands list usage of net rpc
conf.

Signed-off-by: Michael Adam <obnox@samba.org>
2011-08-22 13:59:26 +02:00
Vicentiu Ciorbaru
5a36306704 s3-net: Implemented net rpc conf getparm command
The function creates a smconf_service struct that holds the share
passed as the first argument to the command and searches in it for
the parameter passed as the second argument to the command

Signed-off-by: Michael Adam <obnox@samba.org>
2011-08-22 13:59:26 +02:00
Vicentiu Ciorbaru
8e2ee72bcd s3-net: Added net rpc conf getparm command to net rpc conf
The function only appears in the commands list usage of net rpc conf.

Signed-off-by: Michael Adam <obnox@samba.org>
2011-08-22 13:59:26 +02:00
Vicentiu Ciorbaru
7de814c5a7 s3-net: Implemented net rpc conf delshare command
The function makes use of dcerpc_winreg_delete_subkeys_recursive
to clear the share.

Signed-off-by: Michael Adam <obnox@samba.org>
2011-08-22 13:59:26 +02:00
Vicentiu Ciorbaru
4728cf66c5 s3-net: Added net rpc conf delshare command to net rpc conf
The function only appears in the commands list usage of net rpc conf.

Signed-off-by: Michael Adam <obnox@samba.org>
2011-08-22 13:59:25 +02:00
Vicentiu Ciorbaru
f94c8e366f s3-net: Implemented net rpc conf drop command
The function makes use of dcerpc_winreg_delete_subkeys_recursive
to clear the configuration.

Signed-off-by: Michael Adam <obnox@samba.org>
2011-08-22 13:59:25 +02:00
Vicentiu Ciorbaru
01e80f81d8 s3-net: Added net rpc conf drop command to net rpc conf
The function only appears in the commands list usage of net rpc conf.

Signed-off-by: Michael Adam <obnox@samba.org>
2011-08-22 13:59:25 +02:00
Vicentiu Ciorbaru
5f8ec78768 s3-net: Implemented net rpc conf showshare command
The function has the same logic as net rpc conf list, however it
only loads the specific share.

Signed-off-by: Michael Adam <obnox@samba.org>
2011-08-22 13:59:25 +02:00
Vicentiu Ciorbaru
2db3696303 s3-net: Added net rpc conf showshare command to net rpc conf
The function only appears in the commands list usage of net rpc conf.

Signed-off-by: Michael Adam <obnox@samba.org>
2011-08-22 13:59:25 +02:00
Vicentiu Ciorbaru
ed0c5f54aa s3-net: Implemented net rpc conf listshares command.
The function prints the names of the remote shares found, one per line.

Signed-off-by: Michael Adam <obnox@samba.org>
2011-08-22 13:59:25 +02:00
Vicentiu Ciorbaru
1ca6e99141 s3-net: Added net rpc conf listshares command to net rpc conf
The function only appears in the commands list usage of net rpc conf.

Signed-off-by: Michael Adam <obnox@samba.org>
2011-08-22 13:59:24 +02:00
Vicentiu Ciorbaru
8efd30ca61 s3-net: rpc_conf_list now uses the wrapper rpc_conf_open_conf
Signed-off-by: Michael Adam <obnox@samba.org>
2011-08-22 13:59:24 +02:00
Vicentiu Ciorbaru
f16d092ad9 s3-net: Added rpc_conf_open_conf function
The function is used as a wrapper to open the HKLM hive key and
the smbconf key.

Signed-off-by: Michael Adam <obnox@samba.org>
2011-08-22 13:59:24 +02:00
Vicentiu Ciorbaru
08be91b011 s3-net: Added the net rpc conf list command.
The command make use of the smbconf_service struct,
via the function rpc_conf_get_share(). This allows for
further expansion with the use of smbconf.

Signed-off-by: Michael Adam <obnox@samba.org>
2011-08-22 13:59:24 +02:00
Vicentiu Ciorbaru
283da12a73 s3-net: Added the command rpc conf to the net binary.
The net binary now has an extra item linked to it, the
net_rpc_conf.c module.

Signed-off-by: Michael Adam <obnox@samba.org>
2011-08-22 13:59:24 +02:00