1
0
mirror of https://github.com/samba-team/samba.git synced 2025-12-06 16:23:49 +03:00
Commit Graph

539 Commits

Author SHA1 Message Date
Stefan Metzmacher
3309a0f4d9 r10312: fix compiler warning
metze
2007-10-10 13:38:16 -05:00
Simo Sorce
3fc676ac1d r10305: start implementing better error handling
changed the prioivate modules API
error string are now not spread over all
modules but are kept in  a single place.

This allows a better control of memory
and error reporting.
2007-10-10 13:38:16 -05:00
Simo Sorce
610f5646f0 r10304: check for basic ldb_message sanity and return appropriate
LDB_ERR_ value
2007-10-10 13:38:15 -05:00
Simo Sorce
f0ad9495e4 r10303: check no attribute is given empty 2007-10-10 13:38:15 -05:00
Simo Sorce
cbe438be6d r10302: Introduce ldap like error codes 2007-10-10 13:38:15 -05:00
Simo Sorce
acfb4b9283 r10301: fix standalone compiple after tdb changes 2007-10-10 13:38:15 -05:00
Simo Sorce
1da4ac2cdc r10299: remove the public (un)lock functions and introduce a transaction based
private ldb API

ldb_sqlite3 is already working with this model and ldb_tdb will do
as soon as tridge finishes the tdb transaction code.

currently the transactions are always implicit and wrap any single
ldb API call except searching, the transaction functions are
currently not made public on purpose.

Simo.
2007-10-10 13:38:14 -05:00
Simo Sorce
158693b406 r10277: do not ovverride LIKE, thanks to derrel I found out how to do
the same thing with a harmless user function
2007-10-10 13:38:13 -05:00
Andrew Tridgell
4673cdd0d2 r10253: a fairly large tdb cleanup and re-organise. Nearly all of this change
just involves splitting up the core tdb.c code into separate files on
logical boundaries, but there are some minor functional changes as well:

 - move the 'struct tdb_context' into tdb_private.h, hiding it from
   users. This was done to allow the structure to change without
   breaking code that uses tdb.

 - added accessor functions tdb_fd(), tdb_name(), and tdb_log_fn() to
   access the elements of struct tdb_context that were used by
   external code but are no longer visible

 - simplied tdb_append() to use tdb_fetch()/tdb_store(), which is just
   as good due to the way tdb locks work

 - changed some of the types (such as tdb_off to tdb_off_t) to make
   syntax highlighting work better

 - removed the old optional spinlock code. It was a bad idea.

 - fixed a bug in tdb_reopen_all() that caused tdbtorture to sometimes
   fail or report nasty looking errors. This is the only real bug
   fixed in this commit. Jeremy/Jerry, you might like to pickup this
   change for Samba3, as that could definately affect smbd in
   Samba3.

The aim of all of these changes is to make the tdb
transactions/journaling code I am working on easier to write. I
started to write it on top of the existing tdb.c code and it got very
messy. Splitting up the code makes it much easier to follow.

There are more cleanups we could do in tdb, such as using uint32_t
instead of u32 (suggested by metze). I'll leave those for another day.
2007-10-10 13:38:12 -05:00
Simo Sorce
4357a2db5e r10251: some more work on ldb_sqlite3
I must say that writing a new module is a very good way
to find lot of subtle bugs laying in the code

We need more tests!

commit oLschema2ldif.c to keep it safe from data losses (rm -fr :-)

update test generic to reflect the fix made on comparsion functions
2007-10-10 13:38:11 -05:00
Simo Sorce
f6ea6e9382 r10250: the comparison is caseless so we must caseless subtract
otherwise we get the wrong result when comparing upper
case chars with lower case chars
2007-10-10 13:38:11 -05:00
Simo Sorce
466e6812c3 r10236: fix (C) note 2007-10-10 13:38:10 -05:00
Simo Sorce
e5d8d83460 r10233: add commented PRAGMA to avoid fsyncs 2007-10-10 13:38:10 -05:00
Simo Sorce
ace9990060 r10232: Some work on ldb_sqlite3.
It is still far from being usable in samba4 but I want to commit
so that the work does not get lost by mistake.
This is also a good way to get comments if somebody is interested.

Sorry Derrell I ended up rewriting large parts of the code but I find
this style much more readable. Thanks for the hard work done. Your
work was a good reference for me.

ah the current code also shows some good numbers

sqlite3 generic test:
uid search took 0.05 seconds
real    0m12.492s
user    0m0.492s
sys     0m0.345s

with tdb we still get better numbers:
uid search took 0.46 seconds
real    0m0.892s
user    0m0.360s
sys     0m0.468s

but most of the time is spent in adding operations and I think
there's still a lot of space for improvement.

Simo.
2007-10-10 13:38:10 -05:00
Simo Sorce
8ddf4de162 r10231: seem I flipped these, fix. 2007-10-10 13:38:09 -05:00
Jelmer Vernooij
8d246fac49 r10038: Update instructions on using gcov with ldb 2007-10-10 13:36:32 -05:00
Jelmer Vernooij
071dba2d0a r9948: Be a bit less verbose 2007-10-10 13:36:24 -05:00
Andrew Bartlett
d6f57ec921 r9929: Fix indentation
Andrew Bartlett
2007-10-10 13:36:23 -05:00
Andrew Bartlett
b89e7a7fcd r9928: ncName is a DN, and needs to use DN matching rules.
Andrew Bartlett
2007-10-10 13:36:22 -05:00
Jelmer Vernooij
c61efb2ff8 r9918: Fix two copy-n-paste bugs that were preventing the modification
of special DN's when the rdn_name or timestamps modules were in use.
2007-10-10 13:36:22 -05:00
Jelmer Vernooij
8ff1358f40 r9915: Some more mappings. Fix weird sAMAccountName values. 2007-10-10 13:36:21 -05:00
Jelmer Vernooij
4c3b37d660 r9912: Fix another bug in ldb_map. 2007-10-10 13:36:21 -05:00
Jelmer Vernooij
ebed25b47d r9908: Generate posixUser and posixGroup as well 2007-10-10 13:36:21 -05:00
Jelmer Vernooij
76e943d441 r9899: Be more conservative about what is sent to the remote server in ldb_map. 2007-10-10 13:36:21 -05:00
Tim Potter
31069bfd18 r9881: I can't believe this can make a difference... 2007-10-10 13:36:20 -05:00
Tim Potter
c34fbdc6c3 r9880: Convert remaining initialisers to more portable form. This should
clean out a lot of build farm breakage.
2007-10-10 13:36:19 -05:00
Tim Potter
7cc8df0c2f r9879: A quick check to see if nested initialisers (?) is portable across the
build farm.  I have a feeling it isn't.
2007-10-10 13:36:19 -05:00
Jelmer Vernooij
d6dce7ef3e r9857: Fix rename/delete issues 2007-10-10 13:36:18 -05:00
Jelmer Vernooij
de2bde2526 r9854: Finish ldb_map testsuite
Update PLAN
Some more small other fixes
2007-10-10 13:36:18 -05:00
Jelmer Vernooij
b7992de4b7 r9842: More error checks in the ldb_map modules, extend testsuite 2007-10-10 13:36:17 -05:00
Jelmer Vernooij
2283a336e0 r9835: Make ldb_map compile in the stand-alone LDB build 2007-10-10 13:36:17 -05:00
Jelmer Vernooij
77f24ed131 r9813: Conver testsuite for samba3sam module to EJS 2007-10-10 13:35:04 -05:00
Jelmer Vernooij
9a1a7fb60e r9789: Patch from Volker that fixes the build on AIX. 2007-10-10 13:35:01 -05:00
Jelmer Vernooij
eb9d615bcd r9786: Move ldb_map into ldb/modules/
Move samba3sam to dsdb/
2007-10-10 13:35:01 -05:00
Andrew Tridgell
5e3d9708f6 r9775: r11607@blu: tridge | 2005-08-30 12:16:19 +1000
fixed the help message
2007-10-10 13:35:00 -05:00
Jelmer Vernooij
505c9b1d3d r9771: - Prevent ldb crash when a invalid DN is added
- Don't silently drop records with empty attributes

tridge/simo: Could you please verify this patch is correct?
2007-10-10 13:34:59 -05:00
Jelmer Vernooij
d9541535e3 r9770: Couple other bugfixes
Update TODO-list
2007-10-10 13:34:58 -05:00
Jelmer Vernooij
7ecb6988e7 r9766: Prevent erroneous OOM message
ldb_dup_val() sets out->data to NULL if in->length == 0
2007-10-10 13:34:57 -05:00
Jelmer Vernooij
66df76a634 r9751: Remove C version of samba3dump (the EJS version works nicely as well).
Fix a couple of bugs in ldb_map.
2007-10-10 13:34:56 -05:00
Jelmer Vernooij
435e4c6389 r9744: - [upgrade.js] Start working on smb.conf conversion.
- [ldb_map] Support storing non-mappable data in a fallback LDB
2007-10-10 13:34:55 -05:00
Andrew Bartlett
6202267f6e r9728: A *major* update to the credentials system, to incorporate the
Kerberos CCACHE into the system.

This again allows the use of the system ccache when no username is
specified, and brings more code in common between gensec_krb5 and
gensec_gssapi.

It also has a side-effect that may (or may not) be expected: If there
is a ccache, even if it is not used (perhaps the remote server didn't
want kerberos), it will change the default username.

Andrew Bartlett
2007-10-10 13:34:54 -05:00
Jelmer Vernooij
b1844905d2 r9718: Work a bit on the SWAT interface 2007-10-10 13:34:53 -05:00
Jelmer Vernooij
67593bef7f r9712: Bunch of small fixes
Write out basic sam.ldif
2007-10-10 13:34:52 -05:00
Jelmer Vernooij
5100ae211c r9699: Add as much attributes the current Samba4 SAM has to the mapping table (ignoring most of them, currently..) 2007-10-10 13:34:49 -05:00
Jelmer Vernooij
b7b079167d r9698: Fix a bit of memory management
More minor bugfixes
Support mapping objectclasses and do mapping on 'dn' field as well (not just msg->dn)
2007-10-10 13:34:42 -05:00
Jelmer Vernooij
0cff0e03fc r9690: Extend test + fix several bugs 2007-10-10 13:34:41 -05:00
Jelmer Vernooij
40ea2af427 r9689: valgrind-clean now. Editing works now mostly, you just lose half of your
database every time you do it...
2007-10-10 13:34:41 -05:00
Jelmer Vernooij
786379064f r9686: Another round of bugfixes. Works somewhat now, when running under valgrind ;-) 2007-10-10 13:34:41 -05:00
Jelmer Vernooij
7f864d446d r9685: Add tests for samba3sam mapping module
Fix a couple of bugs
Move samba3sam backend to lib/ldb/
Remove some more unused parameters
2007-10-10 13:34:41 -05:00
Jelmer Vernooij
c2211df586 r9672: Fix build for compilers that don't like undefined-length arrays at the end of structs... 2007-10-10 13:34:39 -05:00