1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-26 10:04:02 +03:00

2301 Commits

Author SHA1 Message Date
Jelmer Vernooij
1f3e4f39c5 Use GUID_string rather than smb_uuid_string(). 2008-10-14 02:26:18 +02:00
Volker Lendecke
2b1bef7e87 Remove the current_spoolss_pipes_open thingy.
I looked at a checkout from 2002 and even there it did not what it was supposed
to do. Sadly this also removes one of the nicest comments in the whole Samba
code :-)
2008-10-13 20:59:35 +02:00
Volker Lendecke
76dfca1569 Make the internal pipe functions static 2008-10-13 20:59:34 +02:00
Volker Lendecke
a781b78417 Remove smb_np_struct 2008-10-13 20:59:33 +02:00
Volker Lendecke
ac126ea818 Use "struct files_struct" for pipes instead of smb_np_struct 2008-10-13 20:59:32 +02:00
Volker Lendecke
c530009401 Pass struct smb_request to file_free
on the way to get rid of chain_fsp
2008-10-13 19:32:38 +02:00
Jelmer Vernooij
aa982895e5 Add data_blob_string_const_null() function that includes the terminating
null byte and use it in Samba 3.

This matches the behaviour prior to my data_blob changes.
2008-10-13 05:20:26 +02:00
Jelmer Vernooij
1b99d8fbb5 Use common util_file code. 2008-10-12 17:34:43 +02:00
Volker Lendecke
756b4b6048 Revert "Make get_rpc_pipe() static"
This reverts commit f25972832ec9d5a130da9dc060f4c3ed35bda7db.
2008-10-12 12:16:18 +02:00
Volker Lendecke
f25972832e Make get_rpc_pipe() static 2008-10-12 11:45:33 +02:00
Volker Lendecke
6b98c1b159 Remove unused #defines 2008-10-12 11:45:26 +02:00
Jelmer Vernooij
218f482fbf Use common strlist implementation in Samba 3 and Samba 4. 2008-10-12 00:56:56 +02:00
Jeremy Allison
e5692d4cbe Remove SEC_ACCESS. It's a uint32_t.
Jeremy.
2008-10-09 09:49:03 -07:00
Jeremy Allison
543c6a02ae For the vfs_acl_xattr.c module, make sure we map GENERIC file and directory bits
to specific bits every time a security descriptor is set. The S4 torture suite proves
that generic bits are not returned when querying an ACL set using them (ie. only
the specific bits are stored on disk).
Jeremy.
2008-10-08 18:06:58 -07:00
Günther Deschner
f50ebbe29f s3-srvsvc: fix _srvsvc_NetShareAdd segfault.
parm_err is not a ref pointer.

Guenther
2008-09-26 18:34:21 +02:00
Günther Deschner
efbb8c189d rpc_server: make it a little more obvious what flags we send to a client.
Guenther
(This used to be commit f3791e03ab09cadb1f54e32e67f4dfb3cf42e708)
2008-08-22 00:21:31 +02:00
Jeremy Allison
40b133eb88 Fix coverity CID: 594. Resource leak on error path.
Jeremy.
(This used to be commit 1f38b9963c4ec0d73da496a72ba4ee74d8d581c9)
2008-08-14 11:22:47 +02:00
Jeremy Allison
e29e81624e Fix duplicate gloabl warning.
Jeremy.
(This used to be commit 6da33797b0549a2da7dc0fa7ee21dc5e8a6b1459)
2008-07-30 15:01:33 -07:00
Volker Lendecke
2646fce633 Fix srvsvc_Net[Get|Set]FileSecurity
There were two bugs in those routines: They did not send INTERNAL_OPEN_ONLY to
open_file_ntcreate() and they did not chdir, so the file could never be found.

While there I decided to remove the become_root() calls and call create_file()
instead of the lower-level routines.
(This used to be commit 669771738422776f8c81086ffea4924b62d72957)
2008-07-27 17:59:15 +02:00
Volker Lendecke
33cbe2f88c make read/write to internal pipes available externally
(This used to be commit e11b5cb1e061caf4c3793fb402ca6bee95a8f26c)
2008-07-26 13:20:10 +02:00
Volker Lendecke
a803f0a920 Refactoring: Make close_internal_rpc_pipe_hnd a talloc destructor
(This used to be commit 10b47a0c2cfd62489428518112da82f73a52b7bc)
2008-07-26 13:20:10 +02:00
Volker Lendecke
1ee37bc9c3 Refactor make_internal_rpc_pipe_p: connection_struct is not needed
(This used to be commit defcf0eecfb8eb035d9ca80530720b9e6873f6c7)
2008-07-26 13:20:10 +02:00
Volker Lendecke
042600cbac Make api_rpcTNP static to srv_pipe.c
(This used to be commit 256c93a8b3d4d9a4e52a656c91b89a043a087066)
2008-07-26 11:25:24 +02:00
Zach Loafman
863a6aa07e Fix warnings on FreeBSD-based platforms
Fix two shadowed declaration warnings on FreeBSD-based platform:
'reboot' is a 4.0BSD syscall in unistd.h and 'tcp_seq' is a typedef in
netinet/tcp.h.
(This used to be commit 14d2a4da1da38d6f69c63505d35990322f253e5d)
2008-07-22 15:00:48 +02:00
Volker Lendecke
1335da2a7c Refactoring: Change calling conventions for cli_rpc_pipe_open_noauth
Pass in ndr_syntax_id instead of pipe_idx, return NTSTATUS
(This used to be commit 9abc9dc4dc13bd3e42f98eff64eacf24b51f5779)
2008-07-20 17:37:11 +02:00
Volker Lendecke
2e7cb1a5cc Introduce is_known_pipename
This scans the list of pipes registered via rpc_pipe_register_commands instead
of using static tables.
(This used to be commit 283e6039989adea1c8921b3600b410cb67b6492a)
2008-07-19 20:27:56 +02:00
Karolin Seeger
bce33f8b82 Fix typos.
the user have -> has

Karolin
(This used to be commit 1ee2ad1051e6076709ef8ed2f45bebff10b0c3cf)
2008-07-18 15:36:20 +02:00
Volker Lendecke
bcb652451b Simplify the RPC servers: remove get_pipe_fns
The per-server xxx_get_pipe_fns functions can go once all the RPC servers are
converted
(This used to be commit 6aa2391cbe1cbda8269ded767117f53d83b243e1)
2008-07-18 15:04:05 +02:00
Volker Lendecke
e0f3ea2cbe In api_pipe_bind_req(), check for the iface id, not the pipe name
This requires to store the rpc_interface in "struct rpc_table"
(This used to be commit 654f8de8497aff29f9b1f1822b6a8e734ff329e0)
2008-07-16 23:19:48 +02:00
Volker Lendecke
1bd7293817 In api_pipe_bind_req(), decode the bind request before checking the pipe
(This used to be commit 8be41382ed9bb4fb44a1846fff2c7652388e4f28)
2008-07-16 23:19:47 +02:00
Jeremy Allison
7cd752bce3 Canonicalize servername in the printer functions to remove leading '\\' characters. Ensure we always return consistent names.
Jeremy.
(This used to be commit fc2178b04743d2f94be7b489b793fc67826557ac)
2008-07-02 16:11:59 -07:00
Volker Lendecke
7b3541f39b Fix a file descriptor leak in add_port_hook
This was probably cut&paste from add_printer_hook which further down has the
unconditional close(fd). In add_port_hook() we're not interested in the output
of 'addport command', so don't create the out fd.
(cherry picked from commit 0c5ca2127ac6e3c71e369242376d27429c3aee5e)
(This used to be commit 9fe09398b79ae7c5e78182112a8cd2c9b5f99ad3)
2008-06-28 16:10:50 +02:00
Volker Lendecke
8fffa902e0 Fix valgrind errors in _spoolss_addprinterdriver
Jerry, this was dropped as part of your SVN r15309 (037f9f83). Can you please
check?

Thanks,

Volker
(cherry picked from commit 5aa2411f0b3720b790439359a2dadb23008e936e)
(This used to be commit 8e7effd58f7790d6e71e38c990f6cb05456e47e1)
2008-06-26 16:55:48 +02:00
Volker Lendecke
a3c0be6325 Change print_access_check to take auth_serversupplied_info instead of current_user
Reason: This is the main user of p->current_user which I would like to remove
(This used to be commit fd43059b3dfa8cdac9814de1c76f963ba5de9bcb)
2008-06-26 13:13:23 +02:00
Volker Lendecke
aa02c3fcd5 Remove p->vuid
The users can use p->server_info.

Now pipes_struct is decoupled from the SMB transport.
(This used to be commit d4cf5a131919530317cd457006b4df5af2c69fa7)
2008-06-26 13:13:23 +02:00
Volker Lendecke
8a9881c30b Remove a check on p->vuid in _netr_LogonSamLogon/off
This is in preparation of removing p->vuid completely. I don't think this check
here makes any sort of sense, it only proves that the user having done the
session setup on its way to the schannel bind (ususally anonymous) did not do a
logoff in between. But this would have been caught way before this in
reply_pipe_write_and_X.
(This used to be commit fbc00460f8deaa57bfbf16b12d29acec56578b63)
2008-06-26 13:13:23 +02:00
Volker Lendecke
747a580952 Now that we have p->server_info, use p->server_info->user_session_key
(This used to be commit aefad64e3a5c86d2f988d47e6215ed2085b8fc47)
2008-06-26 13:13:23 +02:00
Volker Lendecke
cebbb2d84a Fix typo
(This used to be commit 41d2daeaa5a87da82a0debc4c9cfe14976215bd8)
2008-06-26 13:13:22 +02:00
Volker Lendecke
d331624fdf Add server_info to pipes_struct
(This used to be commit d621867bb8767e1c4236d28dd9294a61db6cbb10)
2008-06-26 13:13:22 +02:00
Volker Lendecke
9ff4001245 Remove "conn" from pipes_struct
For spoolss, we need the client's IP address
(This used to be commit 64a4dfaa826cf9319ef3f5c65023352bf8af539e)
2008-06-24 10:31:36 +02:00
Volker Lendecke
c5401a2a46 Correct calculation of "remark" in srv_srvsvc_nt.c
Very likely the client is not interested in the values for the IPC$ share :-)
(This used to be commit 40ca5764cf4310769c002b8cb6041fe2af4e6d0b)
2008-06-24 10:31:35 +02:00
Volker Lendecke
344941bb49 Move the responsibility to keep the cwd from srv_dfs_nt to msdfs.c
(This used to be commit 7db382588ac90fe250b72cf4cd07afb39fcae7c0)
2008-06-24 10:31:35 +02:00
Volker Lendecke
13ebf889b3 Remove the "exists" parameter from create_msdfs_link
Jeremy, setting "exists" to True in _dfs_Add prevented the initial creation of
a new symlink for me, because the SMB_VFS_UNLINK failed. This also exists in
3.2. I only check it into 3.3 as I would like you to look at it first.

Thanks,

Volker
(This used to be commit f58b098a4172949018e84c4d0c722d6eb9bba514)
2008-06-22 20:45:53 +02:00
Volker Lendecke
19654e232c Check for sec_initial_uid() instead of uid==0 in dfs management
(This used to be commit 948607f16112f6529f3a54cd6bbe978e8a600bc8)
2008-06-22 20:45:53 +02:00
Volker Lendecke
df905a5d77 Make pipes_struct its own talloc ctx
(This used to be commit 829b1ad4697f2f1ea008377d591456722dccd025)
2008-06-21 10:34:34 +02:00
Volker Lendecke
c203de0e3a Fix a SAFE_FREE/TALLOC_FREE mixup
(This used to be commit b39852f51313059899630ba63509fee904ba3613)
2008-06-21 10:34:34 +02:00
Volker Lendecke
40f5eab5eb Wrap the unix token info in a unix_user_token in auth_serversupplied_info
No functional change, this is a preparation for more current_user ref removal
(This used to be commit dcaedf345e62ab74ea87f0a3fa1e3199c75c5445)
2008-06-19 18:51:37 +02:00
Volker Lendecke
fdcf760d1c Fix bug 5500 -- thanks to mathion at thorrovydeti.com for reporting
(cherry picked from commit 996c3ce6f0dbe79b0679ae30afd873c24fe5b1eb)
(This used to be commit 1f86c7a2a19e66948c9b51572d3c078b6e03ef52)
2008-06-16 13:27:47 +02:00
Volker Lendecke
c404c8950d Fix a crash in _winreg_QueryValue
Coverity ID 474, value_length and type are both unique, not ref pointers and
can thus be NULL.

Karolin, please merge this to -stable.

Thanks,

Volker
(cherry picked from commit 999533c0ccced59141d8baff5bc248d63e2a966f)
(This used to be commit 7e07ec68f15908a998f83d615a1b4d1349935a54)
2008-06-13 15:33:51 +02:00
Jim McDonough
13b2f59383 Don't reset password last set time just because the expired flag
is set to 0.  If the account wasn't expired but autolocked,
using "net user /dom <username> /active:y" would clear this,
incorrectly setting the current time as the new "password last set"
time.
(This used to be commit 0f292d70f698b8ae885005b5704a96476e876571)
2008-06-09 11:49:29 -04:00