1
0
mirror of https://github.com/samba-team/samba.git synced 2025-03-12 20:58:37 +03:00

921 Commits

Author SHA1 Message Date
Gerald Carter
4066f6e59a r6158: fix some misleading error messages
(This used to be commit 91a8e1ac6debffe457624a625e0f407bdbbbcb15)
2007-10-10 10:56:26 -05:00
Gerald Carter
fd52f0eeae r6154: fix winbindd <-> Windows 2003 sp1 issue.
Can't do LsaOpenPolicy() over schannel anymore.
This is an interesting find as it could imply that there are
other changes we haven't seen yet in sp1.

Volker, You might want to look at this for trunk.
(This used to be commit 82e3a9d9b526522376ea967c66c67b02f2c68dd8)
2007-10-10 10:56:25 -05:00
Derrell Lipman
9840db418b r6149: Fixes bugs #2498 and 2484.
1. using smbc_getxattr() et al, one may now request all access control
   entities in the ACL without getting all other NT attributes.
2. added the ability to exclude specified attributes from the result set
   provided by smbc_getxattr() et al, when requesting all attributes,
   all NT attributes, or all DOS attributes.
3. eliminated all compiler warnings, including when --enable-developer
   compiler flags are in use.  removed -Wcast-qual flag from list, as that
   is specifically to force warnings in the case of casting away qualifiers.

Note: In the process of eliminating compiler warnings, a few nasties were
      discovered.  In the file libads/sasl.c, PRIVATE kerberos interfaces
      are being used; and in libsmb/clikrb5.c, both PRIAVE and DEPRECATED
      kerberos interfaces are being used.  Someone who knows kerberos
      should look at these and determine if there is an alternate method
      of accomplishing the task.
(This used to be commit 994694f7f26da5099f071e1381271a70407f33bb)
2007-10-10 10:56:24 -05:00
Derrell Lipman
934d41d239 r6127: Eliminated all compiler warnings pertaining to mismatched "qualifiers". The
whole of samba comiles warning-free with the default compiler flags.

Temporarily defined -Wall to locate other potential problems.  Found an
unused static function (#ifdefed out rather than deleted, in case it's
needed for something in progress).

There are also a number of uses of undeclared functions, mostly krb5_*.
Files with these problems need to have appropriate header files included,
but they are not fixed in this update.

oplock_linux.c.c has undefined functions capget() and capset(), which need
to have "#undef _POSIX_SOURCE" specified before including <sys/capability.h>,
but that could potentially have other side effects, so that remains uncorrected
as well.

The flag -Wall should be added permanently to CFLAGS, and all warnings then
generated should be eliminated.
(This used to be commit 5b19ede88ed80318e392f8017f4573fbb2ecbe0f)
2007-10-10 10:56:24 -05:00
Volker Lendecke
e84ead0cfd r6080: Port some of the non-critical changes from HEAD to 3_0. The main one is the
change in pdb_enum_alias_memberships to match samr.idl a bit closer.

Volker
(This used to be commit 3a6786516957d9f67af6d53a3167c88aa272972f)
2007-10-10 10:56:20 -05:00
Gerald Carter
9d009834a6 r6040: finish out 'net rpc service list'
(This used to be commit 42588ba50cb1b47a00f3e0bed33ca3431eb8af14)
2007-10-10 10:56:18 -05:00
Gerald Carter
abde8c438d r6036: patch from Lin Li <linl@xandros.com> to ensure trusted domains are initialized whenenumerating users and groups
(This used to be commit 105a63c207e8d2b03a30dec2b8b55b92047cba80)
2007-10-10 10:56:17 -05:00
Gerald Carter
906d7b7190 r5945: BUG 2516: fix compile issue on True64
(This used to be commit 5205949dac4566a815ea443114309c284270ba91)
2007-10-10 10:56:10 -05:00
Gerald Carter
3677b964c8 r5751: fix another (correct) compiler warning
(This used to be commit 642a2d5a0aecd507d4f26dc2250de3667af3abbf)
2007-10-10 10:55:59 -05:00
Volker Lendecke
3e4bc25f44 r5724: Fix compiler warning
(This used to be commit c2f710e3219aab647c0ed294d1d3481f5578b930)
2007-10-10 10:55:57 -05:00
Volker Lendecke
9d0a31e963 r5654: Fix bug 1604 -- make winbind work with more than 10 trusted domains.
TODO: This needs to be merged to trunk separately, it has changed a little,
but it's friday evening here.

Volker
(This used to be commit 49c3e04632e9fcdf552259412e8ec54d18269516)
2007-10-10 10:55:53 -05:00
Volker Lendecke
dc0ec44483 r5471: In cli_samr_lookup_rids, flags is not a flags but an array size. W2k3 rejects
everything but 1000 here, so there's no point in exposing that to the caller.

Thanks,

Volker
(This used to be commit 03ec1bd9e54b065c0494bc57a3d78ac0ae28e234)
2007-10-10 10:55:42 -05:00
Volker Lendecke
f51677051c r5428: Apply some const. LDAP attribs should now be declared const char *attr[]. This
gives some new warnings in smbldap.c, but a the callers are cleaned up.

Volker
(This used to be commit 543799fc0ddc3176469acc1fab7093c41556d403)
2007-10-10 10:55:40 -05:00
Gerald Carter
a309fed583 r5336: BUG 2329: fix to re-enable winbindd to locate DC's when 'disable netbios = yes'
(This used to be commit 75a223f1188ae0041c9e3c748af107d642f73810)
2007-10-10 10:55:38 -05:00
Volker Lendecke
aa9132cc55 r5331: Support SIDs as %s replacements in the afs username map parameter.
Add 'log nt token command' parameter. If set, %s is replaced with the user
sid, and %t takes all the group sids.

Volker
(This used to be commit e7dc9fde45c750013ad07f584599dd51f8eb8a54)
2007-10-10 10:55:37 -05:00
Volker Lendecke
7e72aefc0f r5314: Some const, and an uninitialized variable fix.
Volker
(This used to be commit b48a46162d7971be3d44d403a2d62247ef2321f7)
2007-10-10 10:55:37 -05:00
Gerald Carter
44be949f28 r5207: patches from Jay Fenlason @ RedHat (scooped from their Fedora packages)
(This used to be commit 9019a8436162d3606f6b8584701b0832cf5a7439)
2007-10-10 10:55:33 -05:00
Volker Lendecke
d1b7d109fa r4967: Not being in any domain local groups is obviously valid...
Volker
(This used to be commit 78975ab9a996ac61be37410f18ddedb9df58d04b)
2007-10-10 10:55:10 -05:00
Gerald Carter
5e086f2a30 r4905: patch from abartlet to remove storing the auth-user credentials from the cli* in cm_prepare_connection(). using credentials from a domain other thanour primary domain will cause the schannel setup to fail
(This used to be commit a13e29b5f2f1e48225b5b5964bc0777948f16622)
2007-10-10 10:55:07 -05:00
Volker Lendecke
fca72668cc r4760: Make wbinfo --user-sids expand domain local groups. Andrew B., my testing
shows that this info is correctly returned to us in to info3 struct, so
check_info3_in_group does not need to be adapted.

Volker
(This used to be commit a84e778cafcefdc1809474c2123e757c8c9d9b70)
2007-10-10 10:53:54 -05:00
Volker Lendecke
0663235de9 r4749: Fix memleak
(This used to be commit a8aab6de7516b70cae6c096883874fa152777b13)
2007-10-10 10:53:54 -05:00
Gerald Carter
ff90927478 r4746: add server support for lsa_enum_acct_rights(); last checkin for the night
(This used to be commit ccdff4a998405544433aa32938963e4c37962fcc)
2007-10-10 10:53:54 -05:00
Volker Lendecke
0eb941254c r4732: Even if we have 'password server' set, we need to look up the native DC name
via netbios, as the user might have set an IP address or a fqdn.

Volker
(This used to be commit 61466f38429ba67ace3e84c870a0f913f64d122c)
2007-10-10 10:53:52 -05:00
Gerald Carter
b7f908f7ba r4575: adding extra debug to cm_prepare_connection()
(This used to be commit 13a2aa50ea203cee9c2323bb0428f8c50a3c0f77)
2007-10-10 10:53:47 -05:00
Günther Deschner
9aba116607 r4331: Implement SAMR query_dom_info-call info-level 8 server- and client-side,
based on samba4-idl.

This saves us an enormous amount of totally unnecessary ldap-traffic
when several hundreds of winbind-daemons query a Samba3 DC just to get
the fake SAM-sequence-number (time(NULL)) by enumerating all users, all
groups and all aliases when query-dom-info level 2 is used.

Note that we apparently never get the sequence number right (we parse a
uint32, although it's a uint64, at least in samba4 idl). For the time
being, I would propose to stay with that behaviour.

Guenther
(This used to be commit f9ab15a986626581000d4b93961184c501f36b93)
2007-10-10 10:53:44 -05:00
Günther Deschner
992ad28485 r4286: Give back 8 byte lm_session_key in Netrsamlogon-reply.
The old #ifdef JRATEST-block was copying 16 bytes and thus overwriting
acct_flags with bizarre values, breaking a lot of things.

This patch is successfully running in a production environment for quite
some time now and is required to finally allow Exchange 5.5 to access
another Exchange Server when both are running on NT4 in a
samba-controlled domain. This also allows Exchange Replication to take
place, Exchange Administrator to access other Servers in the network,
etc. Fixes Bugzilla #1136.

Thanks abartlet for helping me with that one.

Guenther
(This used to be commit bd4c5125d6989cebc90152a23e113b345806c660)
2007-10-10 10:53:41 -05:00
Tim Potter
7690459dc6 r4260: Change the license for the winbindd external interface more liberal.
(This used to be commit 82b9faaaa2e1e2986a15102605739e7d13885ac6)
2007-10-10 10:53:41 -05:00
Günther Deschner
92138d1920 r4258: strlower username, not (non-existing) domain_username.
Guenther
(This used to be commit 4f10666295ff7c086ac2a38e0a5f0ac80b57b9a0)
2007-10-10 10:53:40 -05:00
Volker Lendecke
4f0088f7e9 r4128: Cron jobs etc seem to do an initgroups for root quite frequently. So
log.winbindd is spammed with 'user root does not exist'. Increase debug level.

Volker
(This used to be commit 7256771dd01029ed103896c0825bb91b88757015)
2007-10-10 10:53:35 -05:00
Jeremy Allison
acf9d61421 r4088: Get medieval on our ass about malloc.... :-). Take control of all our allocation
functions so we can funnel through some well known functions. Should help greatly with
malloc checking.
HEAD patch to follow.
Jeremy.
(This used to be commit 620f2e608f70ba92f032720c031283d295c5c06a)
2007-10-10 10:53:32 -05:00
Jeremy Allison
90a18110e9 r3931: Fix all "may be used uninitialized" and "shadow" warnings.
Jeremy.
(This used to be commit 8e979772a640bb4f00f4d72b6a9c837b8ef14333)
2007-10-10 10:53:25 -05:00
Günther Deschner
94dd257586 r3911: typo.
Guenther
(This used to be commit 52dea588fd0b40a32c56b5634315b149fc088907)
2007-10-10 10:53:24 -05:00
Volker Lendecke
24d3605d99 r3843: If a connection to a DC is requested, open connections simultaeneously to all
DCs found. The first one to reply wins.

Volker
(This used to be commit 84ac54aef2bd56b5c889d3b05b8828aceb8ae00e)
2007-10-10 10:53:20 -05:00
Jeremy Allison
1c20bb833c r3776: Fix for bug #2038 from Johann Hanne <jhml@gmx.net>. Don't check
for no groups after every lookup - move check to the end as we should
only fail if all lookups fail.
Jeremy.
(This used to be commit 3b40c1e4365f37b967e14be02c6aa52893a80f51)
2007-10-10 10:53:17 -05:00
Volker Lendecke
154d5f913b r3566: Completely replace the queryuseraliases call. The previous implementation does
not exactly match what you would expect.

XP workstations during login actually do this, so we should better become a
bit more correct. The LDAP query issued is not really fully optimal, but it is
a lot faster and more correct than what was there before. The change in
passdb.h makes it possible that queryuseraliases is done with a single ldap
query.

Volker
(This used to be commit 2508d4ed1e16c268fc9f3676b0c6a122e070f93d)
2007-10-10 10:53:09 -05:00
Gerald Carter
841868d290 r3140: * try to ensure consistent usage of the username map.
Use the fully qualified DOMAIN\user format for 'security = domain|ads'
  and apply after authentication has succeeded.

* also change fill_domain_username() to only lowercase the username
  and not the domain+username.  This was a cosmetic fix only.
  makes the output more consistent with %D and %U.
(This used to be commit 30ee2d5b0906d5cd73a8faf5170e5aebcc6d69c8)
2007-10-10 10:53:02 -05:00
Andrew Bartlett
4792a8de30 r2868: Well, I'm not quite sure what I'm doing back in Samba 3.0, but anyway...
I've been grumbling about under-efficient calls in SAMR, and finally
got around to fixing some of them.

We now call sys_getgroups() (which in turn calls initgroups(), until
glibc 3.4 is released) to figure out a user's group membership.  This
is far, far more efficient than scanning all the groups looking for a
match, and is still the 'posix way', just using an effiecient call.

The seperate issue of 'who is in this group' remains, but this one has
been biting some people.

I need to talk to VL about how best to exersise nasty corner cases,
but my initial tests hold strong.  (The code is also much simpiler
than before, which has to count for something :-)

Andrew Bartlett
(This used to be commit dc19f161698dab5b71d61fa2bacc7e7b8da5fbba)
2007-10-10 10:52:55 -05:00
Tim Potter
b4cf9e9505 r2835: Since we always have -I. and -I$(srcdir) in CFLAGS, we can get rid of
'..' from all #include preprocessor commands.   This fixes bugzilla #1880
where OpenVMS gets confused about the '.' characters.
(This used to be commit 7f161702fa4916979602cc0295919b541912acd6)
2007-10-10 10:52:55 -05:00
Tim Potter
cc47bf9975 r2822: Fix parameter confusion in priming of name-to-sid cache. Found by
Qiao Yang.
(This used to be commit 30ae13cb9fbe5f04e46bcbd5e0c19da9b33341d5)
2007-10-10 10:52:53 -05:00
Andrew Bartlett
9f9efc0d3b r2779: Some fixes to pam_winbind.c.:
Allow 'require_membership_of' and 'require-membership-of'.

Really use a different struct for the SID->Name lookup.

Andrew Bartlett
(This used to be commit 83dadcd089905aa8ff3392010177ffa1dc8237ba)
2007-10-10 10:52:52 -05:00
Andrew Bartlett
f219db7d69 r2762: Remove silly conversion to and from UTF8 on the winbind pipe. Fix the
naming of the require_membership_of parameter in pam_winbind and fix
the error code for 'you didn't specify a domain' in ntlm_auth.

Andrew Bartlett
(This used to be commit 4bf0b94011fe6bfbec5635e58cafbfe3dc898569)
2007-10-10 10:52:51 -05:00
Tim Potter
3015135314 r2760: Another patch from The Written Word. Don't declare function prototypes
inside a function.  Bugzilla #1762.
(This used to be commit 002cdd4a5b34611983a32018248f9fe122c4111a)
2007-10-10 10:52:51 -05:00
Tim Potter
02c9b46fab r2759: Fix for winbindd on AIX 5.1. Apparently it doesn't have as many methods
in struct secmethod_table as AIX 5.2.  Patch from The Written Word.
(This used to be commit 4f8496ad626478c31e9372e07652d50f581256d0)
2007-10-10 10:52:51 -05:00
Andrew Bartlett
e357bc3216 r2755: Fix NTLMv2 for use with pam_winbind, the plaintext ntlm_auth modes,
and the wbinfo -a test tool.

If 'client ntlmv2 auth' is set, then we will send an NTLMv2, rather
than an NT/LM response to the server.

Andrew Bartlett
(This used to be commit ce2456e436c5d57cd95cd10c6edf759592d0e843)
2007-10-10 10:52:51 -05:00
Volker Lendecke
cc146adb26 r2691: Increase a debug level for a quite frequent operation.
Optimization for 'idmap backend = ldap': When asking sid2id for the wrong
type, don't ask ldap when we have the opposite mapping in the local tdb.

Volker
(This used to be commit c91cff3bd38c1a8e23628b032f09829f9abf792d)
2007-10-10 10:52:49 -05:00
Volker Lendecke
aa62710b2e r2584: After talking to jerry, commit the strlower patch to getent username and
groupnames. In template homedir, leave %D alone uppercased.

Volker
(This used to be commit dcb577f1cd8cf60557c0d061afeec206f58a6b31)
2007-10-10 10:52:47 -05:00
Volker Lendecke
5fe0142ec8 r2566: Fix creation of aliases via usrmgr. Winbind was too strict checking the type
of sids.

Volker
(This used to be commit d3b2921a8fd86beb77eae45ef9cf1a846a93b199)
2007-10-10 10:52:46 -05:00
Jeremy Allison
cf32220e41 r2540: Fix it the way Henrik Nordstrom (the patch author) wants :-).
Jeremy.
(This used to be commit 45707b5700f8a7c422fca2d7c95f9fab50740f35)
2007-10-10 10:52:46 -05:00
Jeremy Allison
2da3d6d5aa r2528: Ensure MIN is defined as a macro so it's not undefined in the .so.
Fix from Andreas <andreas@conectiva.com.br>.
Jeremy.
(This used to be commit b5edad8b6098abac9b197d70fe29fb514e625b34)
2007-10-10 10:52:45 -05:00
Jeremy Allison
772c250250 r2482: Fix from Arthur van Dongen <avdongen@xs4all.nl> to fix acces -> access typos.
Jeremy.
(This used to be commit a278dca1b2c103f368d154aee2d3a1edd5604687)
2007-10-10 10:52:45 -05:00