1
0
mirror of https://github.com/samba-team/samba.git synced 2024-12-28 07:21:54 +03:00
Commit Graph

684 Commits

Author SHA1 Message Date
Gerald Carter
b3e57cb3ff r5968: derrell's large file fix for libsmbclient (BUG 2505)
(This used to be commit 85be4c5df3)
2007-10-10 10:56:13 -05:00
Steve French
2b71ed0cda r5897: Fix domain name parsing for cifs mount util
(This used to be commit 72eda746c2)
2007-10-10 10:56:07 -05:00
Steve French
9ac8568547 r5896: Fix cifs mounts to handle commas embedded in prompted password, and password and credential files.
Fix cifs mounts to handle domain name and user name in username field (in form domain\user)
(This used to be commit d98417b2cf)
2007-10-10 10:56:07 -05:00
Jeremy Allison
7069d481c0 r5835: Make smbclient obey the max protocol argument again.
Jeremy.
(This used to be commit 7cb9618e5d)
2007-10-10 10:56:04 -05:00
Steve French
9db6a5cc3d r5688: ignore user_xattr mount parm so as not to confuse it with a user name
(This used to be commit 58afef91c5)
2007-10-10 10:55:55 -05:00
Jeremy Allison
00340b20f9 r5687: Fix for bug #2398 from Kevin Dalley <kevin@kelphead.org>.
smbtar shouldn't assume /dev/null means dryrun.
Jeremy.
(This used to be commit 84e7b7db89)
2007-10-10 10:55:54 -05:00
Steve French
73d7fb0fd0 r5640: On failed mount (ENXIO) retry share name in uppercase (fix mount to FastConnect AIX SMB server)
(This used to be commit 8bd98b643d)
2007-10-10 10:55:53 -05:00
Gerald Carter
fb84318c34 r5578: get 'recurse; dir' working across multiple levels of dfs referrals
note that this does not handle the situation where the same \\server\share
is mounted mutliple times in the dfs tree since I store a single mount
path per struct cli_state *
(This used to be commit 52c82b51ba)
2007-10-10 10:55:48 -05:00
Gerald Carter
96572957fc r5577: get recurse; dir working across single level dfs referrals
(This used to be commit d4443807bc)
2007-10-10 10:55:48 -05:00
Gerald Carter
038d939c2a r5545: move cli_cm_XXX() connection handling code to clidfs and out of client.c; client.c still maintains a pointer to the first connection so the change is fairly reansparent to other smbclient functions such as -L and -M
(This used to be commit d6a05ffd66)
2007-10-10 10:55:46 -05:00
Gerald Carter
584c412e0a r5542: fix a few more msdfs bugs in smbclient against both smbd and 2k dfs root
shares.
(This used to be commit 5d2624c453)
2007-10-10 10:55:46 -05:00
Günther Deschner
9fa9ca4f8b r5527: Allow own netbios name to be set in smbclient's session setup.
Guenther
(This used to be commit 3660b7e64d)
2007-10-10 10:55:45 -05:00
Gerald Carter
1b0f75ddfb r5520: fix last remaining dfs issues with smbclient.
* all the unix extension commands should work
* send the correct TRANS2_FINDFIRST format to 2k to
  get a listing from a msdfs root share (tested against
  smbd as well).
* mkdir, rmdir, etc... all seem ok.

I'm sure bugs will pop up so keep testing.

Last thing I plan on doing is to clean up the horrible
mess with connection management in smbclient and global
variables (so i can move the cli_cm_xx() routines to a
separate file).
(This used to be commit 53d6a5f9d1)
2007-10-10 10:55:44 -05:00
Gerald Carter
9cc7c62942 r5519: fix msdfs support for [m]get and [m]put
(This used to be commit 6a9e4d6af1)
2007-10-10 10:55:44 -05:00
Gerald Carter
01b87c63c9 r5518: Add initial msdfs support to smbclient. Currently I can only
cd up and down the tree and get directory listings.

Still have to figure out how to get a directory listing on a
2k dfs root.  Also have to work out some issues with relative paths
that cross dfs mount points.

We're protected from the new code paths when connecting to
a non-dfs root share ( the flag from the tcon&X is stored
in the struct cli_state* )
(This used to be commit e57fd2c5f0)
2007-10-10 10:55:44 -05:00
Gerald Carter
37ea9da1fd r5495: * add in some code from Mike Nix <mnix@wanm.com.au> for the SMBsplopen
and SMBsplclose commands (BUG 2010)
* clarify some debug messages in smbspool (also from Mike)

my changes:

* start adding msdfs client routines
* enable smbclient to maintain multiple connections
* set the CAP_DFS flag for our internal clienht routines.

I actualy have a dfs referral working in do_cd() but that code
is too ugly to live so I'm not checking it in just yet.
Further work is to merge with vl's changes in trunk to support multiple
TIDs per cli_state *.
(This used to be commit 0449756309)
2007-10-10 10:55:43 -05:00
Gerald Carter
66ffe14608 r5295: fix compile issue with MIT 1.4 due to broken gssapi.h
(This used to be commit f88f5e1218)
2007-10-10 10:55:37 -05:00
Gerald Carter
3842d6c205 r5263: bug 2249: patch from Manuel Baena <mbaena@lcc.uma.es> to print error message in fullpath()
(This used to be commit 0f66db48b0)
2007-10-10 10:55:35 -05:00
Steve French
f221832d9a r5236: Ignore users mount parm (since unneeded by cifs kernel code). Suggested by Dirk Jagdmann.
(This used to be commit 076485169e)
2007-10-10 10:55:34 -05:00
Gerald Carter
44be949f28 r5207: patches from Jay Fenlason @ RedHat (scooped from their Fedora packages)
(This used to be commit 9019a84361)
2007-10-10 10:55:33 -05:00
Jeremy Allison
d81fba2c2a r4697: Fix for bug #2231 inspired by brad.ellis@its.monash.edu.au.
Remove double "\\" from findfirst.
Jeremy.
(This used to be commit 88a89b3105)
2007-10-10 10:53:51 -05:00
Jeremy Allison
b46913fb95 r4291: More *alloc fixes inspired by Albert Chin (china@thewrittenword.com).
Jeremy
(This used to be commit efc1b688cf)
2007-10-10 10:53:42 -05:00
Jeremy Allison
acf9d61421 r4088: Get medieval on our ass about malloc.... :-). Take control of all our allocation
functions so we can funnel through some well known functions. Should help greatly with
malloc checking.
HEAD patch to follow.
Jeremy.
(This used to be commit 620f2e608f)
2007-10-10 10:53:32 -05:00
Jeremy Allison
90a18110e9 r3931: Fix all "may be used uninitialized" and "shadow" warnings.
Jeremy.
(This used to be commit 8e979772a6)
2007-10-10 10:53:25 -05:00
Jeremy Allison
1b31f46f22 r3714: Getfacl now seems to work on files and directories. Next do setfacl
and port to Samba4.
Jeremy.
(This used to be commit 4d52bf7c8b)
2007-10-10 10:53:16 -05:00
Jeremy Allison
f995b164b9 r3713: Implementation of get posix acls in UNIX extensions. Passes valgrind.
Need to add printout functions in client and set posix acl in server.
SteveF - take a look at this for the cifsfs client !
Once this is working and tested the next step is to write this up for
the UNIX extensions spec. documents.
Jeremy.
(This used to be commit 1bd3f13344)
2007-10-10 10:53:16 -05:00
Richard Sharpe
e53aa4700f r3292: A fix from Narayana Pattipati <narayana[dot]pattipati[at]wipro\dotty/com> for
Solaris to ensure we distinguish properly between 5.1 and 5.10.
(This used to be commit 96baa5bb6c)
2007-10-10 10:53:04 -05:00
Jeremy Allison
6f12b26cb7 r3275: Fix from Michael Sweet <mike@easysw.com> for bug #1892.
Jeremy.
(This used to be commit 13278744cc)
2007-10-10 10:53:04 -05:00
Steve French
7d4eaf8a9b r3068: strip guest mount option off before sending to kernel mount routine to avoid logging spurious message
(This used to be commit a23c607ef0)
2007-10-10 10:53:00 -05:00
Steve French
86228705c0 r2917: Fix ip address override in mount.cifs mount helper and clean up warning messages from the sparse tool and expand syntax help
(This used to be commit 1052eabf29)
2007-10-10 10:52:56 -05:00
Tim Potter
b4cf9e9505 r2835: Since we always have -I. and -I$(srcdir) in CFLAGS, we can get rid of
'..' from all #include preprocessor commands.   This fixes bugzilla #1880
where OpenVMS gets confused about the '.' characters.
(This used to be commit 7f161702fa)
2007-10-10 10:52:55 -05:00
Jeremy Allison
eb9a09954b r2651: Added 'stat' command to smbclient to exercise the UNIX_FILE_BASIC
info level. Outputs data on the file in the same format the the
stat command in Linux. Should be useful to people wanting to learn
how to parse the UNIX extension output.
Yes I will add the docs later :-).
Jeremy.
(This used to be commit b25cc59641)
2007-10-10 10:52:48 -05:00
Jeremy Allison
3ef0710fa4 r2361: Fix the appalling toktocliplist() fn. Bug found by Luis Benvenutto.
Jeremy.
(This used to be commit d434d8e2b4)
2007-10-10 10:52:40 -05:00
Tim Potter
423d98fe93 r1908: Bugzilla #1541. Fix recursive ls in smbclient. Fix by Josef Zlomek.
(This used to be commit e59af43f6b)
2007-10-10 10:52:23 -05:00
Steve French
eeb72e0eb6 r1616: Fix user unmount of shares mount with suid mount.cifs
(This used to be commit 2bd2800715)
2007-10-10 10:52:17 -05:00
Jelmer Vernooij
3382b0a21a r1320: Return an error when the last command read from stdin fails in smbclient +
prepare for better error checking in tar..
(This used to be commit 374f00b56b)
2007-10-10 10:52:06 -05:00
Jeremy Allison
2acd084866 r1154: Change default setting for case sensitivity to "auto". If set to auto
then is the client supports it (current clients supported are Samba and
CIFSVFS - detected by the negprot strings "Samba", "POSIX 2" and a bare
"NT LM 0.12" string) then the setting of the per packet flag smb_flag
FLAG_CASELESS_PATHNAMES is taken into account per packet. This allows
the linux CIFS client to use Samba in a case sensitive manner.
Additional command in smbclient "case_sensitive", toggles the
flag in subsequent packets.
Docs to follow.
Jeremy.
(This used to be commit cf84c0fe1a)
2007-10-10 10:51:57 -05:00
Jeremy Allison
2fc57c9a2c r1085: Now it's had some proper user testing, merge in the deferred open fix. I'm
still doing more testing, but it fixes a behaviour that we've been wrong
on ever since the start of Samba.
Jeremy.
(This used to be commit 894cc6d162)
2007-10-10 10:51:54 -05:00
Jelmer Vernooij
e4952bf590 r947: Patch from Fabian Franz <FabianFranz@gmx.de> that allows you
to specify a port in the device URL.
(This used to be commit e6dcda2b10)
2007-10-10 10:51:51 -05:00
Steve French
e476cc5903 r737: Handle -S and user mount parms
(This used to be commit ea597e7523)
2007-10-10 10:51:36 -05:00
Jeremy Allison
5cc86fe405 r710: Fix smbclient symlink command when widelinks = no.
Jeremy.
(This used to be commit ed699a73f8)
2007-10-10 10:51:35 -05:00
Jeremy Allison
1db9257c95 r96: Stupid f&%'n UNIX extensions.... SETPATHINFO
normally takes as it's param entry the filename to
be acted upon.... Unless it's UNIX extensions create
hardlink, or UNIX extensions create symlink. Then it's
param -> newfile name
data -> oldfile name.
This caused me to stuff them up in 3.0.2 (and the
client commands link and symlink). Fixed them, everything
is now called oldname and newname - thus specifying which
name should already exist (hint - the old one...) and which
will be created (newname).
Jeremy.
(This used to be commit 21cc6ab7e8)
2007-10-10 10:51:08 -05:00
Steve French
d2b58ab66f r88: Add missing guest mount option for mount.cifs
(This used to be commit e688c08d33)
2007-10-10 10:51:08 -05:00
Steve French
f01b3a1576 r77: Fix path canonicalization of the mount target path and help text display in the cifs mount helper
(This used to be commit 69861f168c)
2007-10-10 10:51:07 -05:00
Alexander Bokovoy
c4255df992 r76: Fix smbfs problem with Tree Disconnect issued before smbfs starts its work.
We use cli_state.smb_rw_error to pass this specific case into cli_close_connection()
from smbmount as smb_rw_error can have only selected number of states and
it is ignored in cli_close_connection().

Compiled and tested by Lars Mueller from SuSE on x86, x86_64, ppc, ppc64, s390 and
s390x.
(This used to be commit 738666ce0a)
2007-10-10 10:51:07 -05:00
Gerald Carter
931df5850e r39: * importing .cvsignore files
* updateing WHATSNEW with vl's change
(This used to be commit a7e2730ec4)
2007-10-10 10:51:05 -05:00
Steve French
70c6c78395 r18: Fix free of incremented pointer
(This used to be commit dfac69be4f)
2007-10-10 10:51:03 -05:00
Steve French
620e1eaddc Fix credential file mountinf for cifs vfs
(This used to be commit 9ad22b8a3d)
2004-04-02 00:11:27 +00:00
Gerald Carter
bfa1b2a8bd source code fix for bug 1095 -- honor the '-l' option
(This used to be commit ab48af6993)
2004-03-26 15:40:06 +00:00
Jeremy Allison
7942c2826b Merge from HEAD for Amanda group.
Apply Craig Barratt's fixes to allow multiple exlusion files and patterns.
Jeremy.
(This used to be commit 0272fac8ca)
2004-03-18 23:45:15 +00:00
Alexander Bokovoy
6011a89e24 Fix problems with very long filenames in both smbd and smbclient.
It appears that we pass filename through resolve_wildcards() as pstring and use fstring temporary buffer there.
As result, a long filename in unix charset (UTF-8 by default) can easily expand over 255 bytes while
Windows is able to send to us such names (e.g. Japanese name of ~190 mb chars) which we unable to process through
this small fstring buffer. Tested with W2K and smbclient, Japanese and Cyrillics.
(This used to be commit 83dac6571f)
2004-03-12 14:37:37 +00:00
Gerald Carter
929b0b72d5 BUG 1088: patch from SATOH Fumiyasu <fumiya@miraclinux.com> -- use strchr_m() for query_host (smbclient -L)
(This used to be commit bc6992c4bf)
2004-03-11 14:39:32 +00:00
Jeremy Allison
f0039da196 Added client "hardlink" commant to test doing NT rename with hard links.
Added hardlink_internals() code - UNIX extensions now use this too.
Jeremy.
(This used to be commit aad6eb2240)
2004-03-03 23:14:23 +00:00
Jeremy Allison
fba5a72249 Use a common function to parse all pathnames from the wire. This allows
much closer emulation of Win2k3 error return codes.
Jeremy.
(This used to be commit c9f31fafed)
2004-03-03 20:55:59 +00:00
Gerald Carter
659d6a2b61 BUG 692: patch from SATOH Fumiyasu <fumiya@miraclelinux.com> to correct truncation of share names and workgroup names
(This used to be commit 822e31d841)
2004-03-01 17:40:40 +00:00
Steve French
a3425dad72 Fixes to minor security bug pointed out by AB in the mount helper
(This used to be commit b83802c5a1)
2004-02-26 06:42:51 +00:00
Steve French
5e39e9f313 Fix incorrect strnicmp len
(This used to be commit ad1ebb5000)
2004-02-17 22:51:42 +00:00
Steve French
d5ad8c5099 Disable dev (MS_NODEV) on user mounts from cifs vfs
(This used to be commit 9b0d1072bc)
2004-02-17 21:31:25 +00:00
Steve French
269082724a Disable suid on user mounts (can override with -DCIFS_ALLOW_USR_SUID)
(This used to be commit a718f16e0b)
2004-02-16 23:43:14 +00:00
Gerald Carter
663f07d63b urban's changes for nosuid,nodev
(This used to be commit ed46d9aef3)
2004-02-13 17:32:20 +00:00
Richard Sharpe
db40d06dd4 Commit Andrew Bartlett's interesting patch to smbclient that allows for
multiple logins and changing vuids. I fixed up a couple of variables so it
actually works.

We want to use this to test our multiple SIDs in the kernel changes etc.
(This used to be commit 4df824d38b)
2004-02-12 17:26:34 +00:00
Steve French
e7a09dd637 Update mount.cifs version to 1.1
(This used to be commit e73b6a5ae5)
2004-02-11 23:14:39 +00:00
Steve French
70fde6311d Mount helper fixes for nosetuid, noexec part two of two
(This used to be commit c2b4d81a8d)
2004-02-11 23:11:00 +00:00
Steve French
33b944911f Add missing nosetuid and noexec options
(This used to be commit 5bb6429cc4)
2004-02-11 22:54:01 +00:00
Gerald Carter
3cd61b1597 BUG 900: TAKEDA yasuma <yasuma@miraclelinux.com; fix token processing in cmd_symlink, cmd_link, cmd_chown, cmd_chmod functions
(This used to be commit 60eb69ff64)
2004-02-11 21:42:20 +00:00
Volker Lendecke
4fd80158ab Patch from "Stoian Ivanov" <sdr@bultra.com>: Add -g (greppable..) to
smbclient -L to make the output usable in pipes.

Volker
(This used to be commit 4c90421070)
2004-01-16 15:01:09 +00:00
Gerald Carter
b20f1a95a9 * BUG 446
- setup_logging() in smbclient to be interactive (remove the timestamps)
  - Fix bad return value in pull_ucs2( needs more testing to make sure this
    didn't break something else) that caused clistr_pull() to always read
    the same string from the buffer (pull_usc2() could return -1 if the original
    source length was given as -1)
  - increment some debugging messages to avoid printing them out so often
(This used to be commit 79fe75dcdf)
2004-01-15 19:03:18 +00:00
Steve French
25b483dfc3 cifs mount helper merge
(This used to be commit 865fcdcb85)
2004-01-05 22:18:44 +00:00
Steve French
2e879cfacc mount.cifs failed to mount to directory owned by user when run setuid
(This used to be commit 18c0315c3c)
2003-12-11 19:47:52 +00:00
Tim Potter
f46e42c69d Fix crash bug in smbclient completion. Closes bug #659.
(This used to be commit 4480058d85)
2003-11-04 22:38:58 +00:00
Alexander Bokovoy
3531647574 Fix segfault in mount.cifs helper when there is no options specified during mount
(This used to be commit fb87388a9f)
2003-10-22 15:41:08 +00:00
Jeremy Allison
a4e5e3f3a5 Fix from Craig Barratt <cbarratt@users.sourceforge.net> to fix restore
with filenames > 100 chars.
Jeremy.
(This used to be commit aa40a86cbe)
2003-09-12 01:25:35 +00:00
Jeremy Allison
94f59f5492 More tuning from cachegrind. Change most trim_string() calls to trim_char(0,
as that's what they do. Fix string_replace() to fast-path ascii.
Jeremy.
(This used to be commit f35e9a8b90)
2003-09-05 19:59:55 +00:00
Jeremy Allison
a7e8e39b91 Proposed patch for #308. Needs testing.
Jeremy
(This used to be commit e2b73477e7)
2003-09-02 23:58:39 +00:00
Steve French
78e75d4f6c Update mount helper to take synonyms for file_mode and dir_mode (fmask and dmask)
(This used to be commit 89a0e97094)
2003-08-29 07:31:39 +00:00
Tim Potter
64ca334696 Print an error instead of crashing if no argument is specified for
smbclient -T

Fixes bug 345.
(This used to be commit a46e58e2b6)
2003-08-27 07:39:26 +00:00
Gerald Carter
658ccccdde fix bug #39; save the -W value and restore it after lp_load()
(This used to be commit 79efe7d72b)
2003-08-25 17:55:33 +00:00
Gerald Carter
8bfe26b62d metze's autogenerate patch for version.h
(This used to be commit ae452e51b0)
2003-08-20 17:13:38 +00:00
Steve French
fac0ae1481 Fixes to all mount.cifs to run more safely setuid
(This used to be commit bdb65b9a6e)
2003-08-16 03:32:45 +00:00
Herb Lewis
aa39cc37da get rid of more compiler warnings
(This used to be commit 398bd14fc6)
2003-08-15 04:42:05 +00:00
Herb Lewis
0fc41a8962 get rid of const as these things really are not const
(This used to be commit 61bea183a2)
2003-08-15 02:25:41 +00:00
Volker Lendecke
13a7870e42 Don't ask twice for the password
(This used to be commit 8ebd92da01)
2003-08-14 21:57:11 +00:00
Volker Lendecke
a757fe10b1 Apply a little const
(This used to be commit e3b36906c5)
2003-08-12 21:30:28 +00:00
Volker Lendecke
ce7d025b20 We get the server and workgroup list only over port 139. Fall back to that
and if NetBIOS over TCP/IP is disabled, give an error message.

Fixes Bug #284

Volker
(This used to be commit a2902a6cf8)
2003-08-10 21:43:28 +00:00
Jeremy Allison
ef65d26556 Ensure smbclient obeys -s smb.conf option.
Jeremy.
(This used to be commit 7950f7d6b2)
2003-08-06 22:45:46 +00:00
Jeremy Allison
e602bca52f Reversed replacement. Oops.
Jeremy.
(This used to be commit 520bee397d)
2003-08-06 21:31:11 +00:00
Jeremy Allison
33f6eb9a17 Anal formatting tidyup :-).
Jeremy.
(This used to be commit 9c01974713)
2003-08-06 20:01:31 +00:00
Jeremy Allison
17a713d1b9 Get rid of MAXPATHLEN, move to standard PATH_MAX.
Jeremy.
(This used to be commit 455ed2d51d)
2003-08-06 19:30:42 +00:00
Jeremy Allison
72a8b31303 Fix the option processing for smbtar. Does no one check this !
Jeremy.
(This used to be commit c4af1ec735)
2003-08-01 21:09:10 +00:00
Jeremy Allison
d574b612e4 Finish reformatting.
Jeremy.
(This used to be commit 5ef75fa366)
2003-08-01 06:29:16 +00:00
Jeremy Allison
7e39e87ce0 Reformat lots of clitar code as I hate the style so much :-).
Jeremy.
(This used to be commit 77f2a91549)
2003-08-01 01:03:05 +00:00
Jeremy Allison
14f207be92 Reformat clitar option processing - getting ready to fix it for popt...
Jeremy.
(This used to be commit 94b30e7b4a)
2003-08-01 00:41:57 +00:00
Jeremy Allison
29ca70cd34 Add a command line option (-S on|off|required) to enable signing on client
connections. Overrides smb.conf parameter if set.
Jeremy.
(This used to be commit 879309671d)
2003-07-30 23:49:29 +00:00
Gerald Carter
3a5dc7c2ec convert snprintf() calls using pstrings & fstrings
to pstr_sprintf() and fstr_sprintf() to try to standardize.
lots of snprintf() calls were using len-1; some were using
len.  At least this helps to be consistent.
(This used to be commit 9f835b85dd)
2003-07-23 12:33:59 +00:00
Andrew Tridgell
e895bd2320 fixed the pstrcpy() bug in directory recursion properly
(This used to be commit 132d6fdf63)
2003-07-18 01:36:11 +00:00
Tim Potter
7f7b754483 Fix for bug 222 from Marcin Owsiany.
Don't get stuck in an infinite loop listing directories recursively
if the server returns an empty directory name.  This can happen with
incorrect i18n configuration on a Samba server.
(This used to be commit f93a2831f1)
2003-07-17 04:17:58 +00:00
Tim Potter
bcd659f26a Don't use pstrcpy on non-pstrings.
(This used to be commit 3498624d94)
2003-07-17 03:53:43 +00:00
Tim Potter
bd9a42fa8d Fix from Dragan Krnic for handling files in tar archives > 8GB.
Fixes bug 102.
(This used to be commit b54183a7b2)
2003-07-16 00:13:40 +00:00
Jeremy Allison
ce0709666c More conversions I missed. Thanks metze.
Jeremy.
(This used to be commit 4f78d747e6)
2003-07-04 18:52:31 +00:00
Jeremy Allison
ce72beb2b5 Removed strupper/strlower macros that automatically map to strupper_m/strlower_m.
I really want people to think about when they're using multibyte strings.
Jeremy.
(This used to be commit ff222716a0)
2003-07-03 19:11:31 +00:00
Tim Potter
2d8fef88e8 Suggest the user runs kinit if smbclient -k returns NT_STATUS_MORE_PROCESSING_REQUIRED.
(This used to be commit 66c4beb286)
2003-07-02 03:01:27 +00:00
Steve French
d1fafca608 Fix mount options for ro, dir_mode, file_mode
(This used to be commit 7e7cf0dd98)
2003-06-20 16:41:41 +00:00
Andrew Tridgell
1d03ec88f1 several places in client.c rely in commands[i].name == NULL being a
termination condition for checking for commands. Make sure the last
element is indeed NULL.
(This used to be commit 294f79884d)
2003-06-11 06:23:53 +00:00
Andrew Tridgell
98f448b1f4 i'm getting rather sick of this
**********************************************************
**** PLEASE TEST YOUR CHANGES BEFORE CHECKING THEM IN ****
**********************************************************

Jelmer, your change did not fix the -b option, it just make it not
segfault on debian. It did however add a warning and make it not
compile on some systems. It also gave the io_bufsize the value of a
pointer, not the value the user specified.

(this doesn't apply just to Jelmer, I'm just seeing rather too many
checkins from everyone lately where the code could never have possibly
worked, so was obviously checked in without testing)
(This used to be commit 21931ad7a0)
2003-06-11 06:10:10 +00:00
Jelmer Vernooij
33a7f1bba0 Don't segfault when -b is specified (fixes debian bug #196833)
(This used to be commit 4af9074397)
2003-06-10 19:27:32 +00:00
Andrew Tridgell
524da855ff don't call a function error_message() as that conflicts with a
kerberos name
(This used to be commit 8fa737f223)
2003-06-10 03:46:11 +00:00
Jelmer Vernooij
44fa85fd60 Don't crash when doing namecompletion in smbclient. Fixes debian bug #194776
(This used to be commit f130b4f2a1)
2003-05-29 15:44:35 +00:00
Tim Potter
3c830cad6f Syncup with HEAD:
>revision 1.3
>date: 2003/05/20 04:28:29;  author: sfrench;  state: Exp;  lines: +10 -5
>Fix Linux cifs vfs mount helper parsing of slashes
(This used to be commit b2b4a7e499)
2003-05-28 01:06:53 +00:00
Andrew Bartlett
d9029797fe Fix non-constant initialiser for Sun CC.
(This used to be commit c2948b9248)
2003-05-13 06:13:36 +00:00
Simo Sorce
c823b191ab And finally IDMAP in 3_0
We really need idmap_ldap to have a good solution with ldapsam, porting
it from the prvious code is beeing made, the code is really simple to do
so I am confident it is not a problem to commit this code in.

Not committing it would have been worst.
I really would have been able to finish also the group code, maybe we can
put it into a followin release after 3.0.0 even if it may be an upgrade
problem.

The code has been tested and seem to work right, more testing is needed for
corner cases.

Currently winbind pdc (working only for users and not for groups) is
disabled as I was not able to make a complete group code replacement that
works somewhat in a week (I have a complete patch, but there are bugs)

Simo.
(This used to be commit 0e58085978)
2003-05-12 18:12:31 +00:00
Jelmer Vernooij
0914e541f5 Reverse previous patch from Stefan and me after comments by Andrew Bartlett
(This used to be commit d817eaf0ec)
2003-05-10 11:49:51 +00:00
Jelmer Vernooij
c507ebe567 Patch from metze and me that adds dummy smb_register_*() functions so
that is now possible to, for example, load a module which contains
an auth method into a binary without the auth/ subsystem built in.
(This used to be commit 74d9ecfe2d)
2003-05-10 10:53:48 +00:00
Jeremy Allison
7ae17cc151 Fix for possible segfault in readline handler. Found by vitalyb@mail333.com.
Jeremy.
(This used to be commit 151b7d0d88)
2003-05-10 00:30:47 +00:00
Tim Potter
5bab7b987c Replace workgroup global variable with lp_workgroup()
Call lp_load() before parsing command line options so we can override
the workgroup value with the -W switch.

Fixes bug #39.
(This used to be commit 56f070cd52)
2003-04-28 06:54:49 +00:00
Tim Potter
ab892c1160 Merge:
- Jelmer's popt changes
(This used to be commit b5b6f11940)
2003-04-14 04:05:48 +00:00
Tim Potter
9cfa77ae15 Merge:
- "Fix lingering large offset problems in smbtar etc."
(This used to be commit ba53df64ca)
2003-04-14 04:03:39 +00:00
Alexander Bokovoy
b3e9dfc375 Update smbmount to include unicode and lfs capabilities options -- smbfs supports this already
(This used to be commit fbbb9a6660)
2003-04-08 15:38:38 +00:00
Andrew Bartlett
d5ee9b2f48 Jeremy merged across my string parinoia fixes, but forgot to enable them! :-)
This patch catches up on the rest of the work - as much string checking
as is possible is done at compile time, and the rest at runtime.

Lots of code converted to pstrcpy() etc, and other code reworked to correctly
call sizeof().

Andrew Bartlett
(This used to be commit c5b604e2ee)
2003-03-18 11:22:52 +00:00
Andrew Bartlett
818f2a5dac Fix segfault on FD_SET() when we have an fd of -1
Andrew Bartlett
(This used to be commit 92bd0f69df)
2003-03-18 10:56:37 +00:00
Andrew Bartlett
cdc6fc8acb Add an extra parameter to our 'set_remote_machine_name' and
'set_local_machine_name' so that the client can't change it from under us.

(.NET RC2 and WinXP install calls the machine 'machinename' during NTLMSSP
on the domain join).

Andrew Bartlett
(This used to be commit 4c7163e7c2)
2003-03-18 09:52:55 +00:00
Andrew Bartlett
50eea93516 Add const.
(This used to be commit ed24502301)
2003-03-18 09:43:00 +00:00
cvs2svn Import User
74d3be0218 This commit was manufactured by cvs2svn to create branch 'SAMBA_3_0'.(This used to be commit f0d009c3e9) 2003-03-18 07:09:24 +00:00
Andrew Bartlett
400bb4bfab - Make ReadDirName return a const char*.
- Consequential changes from that

 - mark our fstring/pstring assumptions in function prototypes

Andrew Bartlett
(This used to be commit fe2bc64bc4)
2003-03-16 13:21:12 +00:00
Steve French
2055e724ad Checkin cifs vfs for Linux mount helper
(This used to be commit a55acfd7a2)
2003-03-15 22:35:47 +00:00
Andrew Bartlett
58abc7b5b6 If the server went away, don't segfault by attempting to FD_SET -1.
Andrew Bartlett
(This used to be commit 4b1337ee94)
2003-03-15 06:50:45 +00:00
Andrew Bartlett
01289b14a7 Make sure that the 'remote' machine name can only be set once. For some weird
reason, during a Win2003 installation, when you select 'domain join' it sends
one machine name in the name exchange, and litraly 'machinename' during the
NTLMSSP login.

Also fix up winbindd's logfile handling, so that it matches smbd and nmbd.

(This helps me, by seperating the logs by pid).

Andrew Bartlett
(This used to be commit afe5a3832f)
2003-03-08 10:22:50 +00:00
Steve French
f944fd6975 Add early prototype of cifs mount helper for Linux
(This used to be commit b20bcf8d33)
2003-03-07 22:29:14 +00:00
Andrew Bartlett
192148bab3 More safe_strcpy() off-by-one bug fixes. (mostly moves to pstrcpy()/fstrcpy())
Andrew Bartlett
(This used to be commit 42b5514404)
2003-03-06 07:55:48 +00:00
Richard Sharpe
e3fdd289f5 More janitorial duties, fixing the BIG_UINT changes for large offsets.
(This used to be commit 1af39523cc)
2003-03-03 23:00:22 +00:00
Richard Sharpe
3042cfb7fa Do my janitorial duties to encourage others to do so.
Fix lingering large offset problems in smbtar etc.
(This used to be commit c416eec2f2)
2003-03-03 17:43:33 +00:00
Tim Potter
64e53c9b22 Fix breakage done by myself yesterday.
(This used to be commit f4492de2d6)
2003-02-25 23:28:28 +00:00
Tim Potter
3a2f56cb63 Fixed up some const related compiler warnings.
(This used to be commit 923425e497)
2003-02-25 06:24:13 +00:00
Andrew Bartlett
630944d179 Cleint-side-auth/kerberos fixes from HEAD, and don't connect to a share
twice, let the libsmb code determine what form the share name should take.

Andrew Bartlett
(This used to be commit a25f612664)
2003-02-24 03:28:37 +00:00
Andrew Bartlett
108580c224 The cli_send_tconX code already determines to send \\server\share to port 139
and share to 445, so doing this only confuses the issue (sending
\\server\\server\share to 139) and makes debugging specific error codes more
difficult.

Andrew Bartlett
(This used to be commit 1a723bcda7)
2003-02-18 00:36:37 +00:00
Simo Sorce
07886ac856 fix dumb perror used without errno beeing set.
thanks to RedHat developers for the report
(This used to be commit e257141c9b)
2003-02-15 21:37:15 +00:00
Simo Sorce
584206dccf fix dumb perror used without errno beeing set.
thanks to RedHat developers for the report
(This used to be commit 4a3c6c62d9)
2003-02-15 21:36:28 +00:00
Andrew Bartlett
e4202a9fe7 Antti Andreimann <Antti.Andreimann@mail.ee> has done some changes to enable
users w/o full administrative access on computer accounts to join a
computer into AD domain.

The patch and detailed changelog is available at:
http://www.itcollege.ee/~aandreim/samba

This is a list of changes in general:

1. When creating machine account do not fail if SD cannot be changed.
   setting SD is not mandatory and join will work perfectly without it.
2. Implement KPASSWD CHANGEPW protocol for changing trust password so
   machine account does not need to have reset password right for itself.
3. Command line utilities no longer interfere with user's existing
   kerberos ticket cache.
4. Command line utilities can do kerberos authentication even if
   username is specified (-U). Initial TGT will be requested in this case.

I've modified the patch to share the kinit code, rather than copying it,
and updated it to current CVS.  The other change included in the original patch
(local realms) has been left out for now.

Andrew Bartlett
(This used to be commit ce52f1c2ed)
2003-02-15 00:29:21 +00:00
Alexander Bokovoy
ff1db7b4f7 Fix typo in WIFSIGNALED (as per Waider's report)
(This used to be commit 4463ffeed9)
2003-02-13 16:29:12 +00:00
Martin Pool
404a3f34c8 waitstatus audit: Correctly handle case where smbmnt is killed by a
signal.  Previously this was incorrectly treated as success.
(This used to be commit fe5582c1b2)
2003-02-13 04:45:40 +00:00
Jeremy Allison
5bc835c188 Samba janitors: applying mbp's redundant umask fix.
Jeremy.
(This used to be commit 45d4e58ca5)
2003-02-07 22:52:35 +00:00
Jeremy Allison
9e8fc1ee4e Samba janitors: applying mbp's redundant umask fix.
Jeremy.
(This used to be commit b54f6bf06c)
2003-02-07 22:52:19 +00:00
Tim Potter
11245e0fc3 smb signing compile fix
(This used to be commit 22d7aa0e67)
2003-02-02 22:49:28 +00:00
Andrew Bartlett
ac2eeb7a8f More signing updates - start checking that the server isn't being spoofed.
Andrew Bartlett
(This used to be commit b1c722e306)
2003-02-02 00:11:12 +00:00
Martin Pool
115f3d8470 Add FIXME about dodgy argument parser.
(This used to be commit a580283308)
2003-01-20 00:53:35 +00:00
Gerald Carter
d7ed1e1362 s/WIFSIGNALLED/WIFSIGNALED/g
(This used to be commit dc6cda5951)
2003-01-15 23:11:57 +00:00
Gerald Carter
523e406daf s/WIFSIGNALLED/WIFSIGNALED/g
(This used to be commit 251585142b)
2003-01-15 23:11:45 +00:00
Gerald Carter
99cdb46208 *lots of small merges form HEAD
*sync up configure.in
*don't build torture tools in make all
*make sure to remove torture tools as part of make clean
(This used to be commit 0fb724b321)
2003-01-15 18:57:41 +00:00
Martin Pool
ec894b5695 One more from waitpid() audit: Correctly interpret waitstatus when a
child fails.  Possibly this was causing smbmount to exit(0) when it
really should have indicated a failure.
(This used to be commit 1e33083fe6)
2003-01-15 05:27:33 +00:00
Andrew Bartlett
27b7e51a3c Merge from HEAD:
- fstring/pstring mixups
 - the detection code that found them (disabled)
 - a bit of whitespace
 - a static

Andrew Bartlett
(This used to be commit 9b70fa868e)
2003-01-14 08:53:59 +00:00
Andrew Bartlett
73b0a2bdf8 Fix a number of client-side fstring/pstring mixups.
Andrew Bartlett
(This used to be commit fe1cc779d5)
2003-01-11 12:04:14 +00:00
Christopher R. Hertel
6693cade73 Added code to the handling of the -M option to ensure that we default to
port 139 for that option.  The NetBIOS Messenger Service doesn't run on
a non-NBT port.
(This used to be commit 02986f3e3a)
2003-01-07 04:33:43 +00:00
Christopher R. Hertel
e8a70338d9 Added code to the handling of the -M option to ensure that we default to
port 139 for that option.  The NetBIOS Messenger Service doesn't run on
a non-NBT port.
(This used to be commit a10195b711)
2003-01-07 04:26:37 +00:00
Andrew Bartlett
634c54310c Merge from HEAD - make Samba compile with -Wwrite-strings without additional
warnings.  (Adds a lot of const).

Andrew Bartlett
(This used to be commit 3a7458f947)
2003-01-03 08:28:12 +00:00
Andrew Bartlett
6d66fb308a BIG patch...
This patch makes Samba compile cleanly with -Wwrite-strings.
 - That is, all string literals are marked as 'const'.  These strings are
always read only, this just marks them as such for passing to other functions.

What is most supprising is that I didn't need to change more than a few lines of code (all
in 'net', which got a small cleanup of net.h and extern variables).  The rest
is just adding a lot of 'const'.

As far as I can tell, I have not added any new warnings - apart from making all
of tdbutil.c's function const (so they warn for adding that const string to
struct).

Andrew Bartlett
(This used to be commit 92a777d0ea)
2003-01-02 09:07:17 +00:00
Herb Lewis
41969738a4 merge from 2.2 fix for smbclient large files
(This used to be commit 17f685fdbf)
2002-12-19 20:26:44 +00:00
Herb Lewis
c52a34693d merge from 2.2 fix for smbclient large files
(This used to be commit 723c4caf64)
2002-12-19 20:23:45 +00:00
Herb Lewis
e76f1ffa7e merge smbtar fix from 2.2
(This used to be commit 41188337c3)
2002-12-16 21:32:32 +00:00
Herb Lewis
96978d397a merge smbtar fixes from 2.2
(This used to be commit f3b994326e)
2002-12-16 21:30:20 +00:00
John Terpstra
ad43ee6f5b Updating changes from HEAD.
(This used to be commit 20efb6252c)
2002-12-10 23:19:18 +00:00
Herb Lewis
21e21dfd21 fix stat reporting on put command
(This used to be commit aa38aaf363)
2002-12-05 00:50:29 +00:00
Herb Lewis
c77586e297 fix stat reporting on put command
(This used to be commit c53e10ff87)
2002-12-05 00:47:41 +00:00
Andrew Bartlett
9de7abd8db Link less with smbmnt and smbumount. Also change from a pstrcpy() to a
strncpy() to make it clear that we must operate on a PATH_MAX sized buffer.

Andrew Bartlett
(This used to be commit 49d9698ef0)
2002-12-01 04:11:20 +00:00
Jeremy Allison
ce35c5d0fa Sorry Jim we can't assign to global_xxx(), we need to call set_global_xxx()
to ensure the malloc is done.
Jeremy.
(This used to be commit 57f7ab45b7)
2002-11-13 02:22:39 +00:00
Jeremy Allison
2bd37f8565 Sorry Jim we can't assign to global_xxx(), we need to call set_global_xxx()
to ensure the malloc is done.
Jeremy.
(This used to be commit e57853000a)
2002-11-13 02:21:55 +00:00
Jim McDonough
fb51582f25 Bring smbmount.c in line with jra's global-cide. global_scope was used here...
(This used to be commit 79a0f2c251)
2002-11-13 01:58:19 +00:00
Jim McDonough
c8d96f887d Bring smbmount.c in line with jra's global-cide. global_scope was used here...
(This used to be commit 5170a9f7ff)
2002-11-13 01:54:44 +00:00
Jeremy Allison
2f194322d4 Removed global_myworkgroup, global_myname, global_myscope. Added liberal
dashes of const. This is a rather large check-in, some things may break.
It does compile though :-).
Jeremy.
(This used to be commit f755711df8)
2002-11-12 23:20:50 +00:00
Jeremy Allison
250c980119 Removed global_myworkgroup, global_myname, global_myscope. Added liberal
dashes of const. This is a rather large check-in, some things may break.
It does compile though :-).
Jeremy.
(This used to be commit 82b8f749a3)
2002-11-12 23:15:52 +00:00
Jelmer Vernooij
5e39c988f6 Remove testsmbc.c from source/ in 3.0 as well. It's already in examples/
(This used to be commit c1b3cffb3f)
2002-11-10 11:42:51 +00:00
Andrew Bartlett
017eec27bc Merge append_log fix from HEAD
(This used to be commit 2e33865417)
2002-11-09 23:18:25 +00:00
Andrew Bartlett
a0dd6128bf Kill append_log from smbmount (thanks vance for reminding me).
Andrew Bartlett
(This used to be commit 7501b2a518)
2002-11-09 23:17:01 +00:00
Jelmer Vernooij
dc5297f413 Sync with HEAD
(This used to be commit 1a25dc776d)
2002-11-09 16:57:45 +00:00
Jelmer Vernooij
a3090f0cc8 Move testsmbc.c to examples
(This used to be commit fdd70614d2)
2002-11-04 17:11:18 +00:00
Jelmer Vernooij
1bd97040d1 Sync with HEAD
(This used to be commit 987b62137d)
2002-10-29 17:21:59 +00:00
Jelmer Vernooij
9cfa18208b Don't encourage people to use -P - it's obsolete
(This used to be commit 59ecac901a)
2002-10-18 23:27:49 +00:00
Jeremy Allison
389a16d9d5 Added new error codes. Fix up connection code to retry in the same way
that app-head does.
Jeremy.
(This used to be commit b521abd86b)
2002-10-17 17:10:29 +00:00
Jeremy Allison
c53eb2ed54 Added new error codes. Fix up connection code to retry in the same way
that app-head does.
Jeremy.
(This used to be commit ec7953f201)
2002-10-17 17:10:24 +00:00
Andrew Bartlett
3a5577e552 Patch from Steve Langasek <vorlon@netexpress.net> to use nice big integers when
attempting to calculate the bytes/second being transferred.  (Avoid overflow
etc)

Andrew Bartlett
(This used to be commit cd41e5ab85)
2002-10-03 03:27:00 +00:00
Gerald Carter
f2d1f19a66 syncing up with HEAD. Seems to be a lot of differences creeping in
(i ignored the new SAMBA stuff, but the rest of this looks like it should
have been merged already).
(This used to be commit 3de09e5cf1)
2002-10-01 18:26:00 +00:00
Richard Sharpe
ed521b0cc4 Make sure that variable does not shadow a parameter.
(This used to be commit d83cae2bbd)
2002-09-29 06:44:13 +00:00
Richard Sharpe
6fa3f56e0a Commit a fix to smbclient so that it will connect to EMCs and NetApp's machines.
(This used to be commit 1e4ac9615d)
2002-09-28 03:38:37 +00:00
Gerald Carter
a834a73e34 sync'ing up for 3.0alpha20 release
(This used to be commit 65e7b5273b)
2002-09-25 15:19:00 +00:00
Tim Potter
af78eafa6c Don't uppercase the username and domain in a session setup.
(This used to be commit 0ad19825df)
2002-09-23 21:24:31 +00:00
Volker Lendecke
4af9c9ce3b Fixed a little, long standing bug: smbclient -M <name> should resolve
name#03, not name#20.

Volker
(This used to be commit 99017e887e)
2002-09-05 11:40:06 +00:00
Simo Sorce
05876f8bcd fix wrong check
(This used to be commit cb0ed2faa5)
2002-08-28 16:01:42 +00:00
Jeremy Allison
c3d707b088 Remove strsep - non portable.
Jeremy.
(This used to be commit 03c49b2e51)
2002-08-27 16:48:58 +00:00
Simo Sorce
8f6c926a8f add a trivial seeking function to xfile (tseek) that does not do SEEK_CUR
and add commands reget and reput to smbclient that continues a transfer that has been onterrupted.

thanks to josef Zlomek that did the original patch.
(This used to be commit b275547c9e)
2002-08-27 09:07:08 +00:00
Simo Sorce
ca0345623d fix typos
thanks Josef Zlomek
(This used to be commit fb32fd99b9)
2002-08-20 21:21:56 +00:00
Jelmer Vernooij
b2edf254ed sync 3.0 branch with head
(This used to be commit 3928578b52)
2002-08-17 17:00:51 +00:00
Andrew Bartlett
6ddba1e99b Fix the %m security bug again - and try to make it harder to reintroduce in
future.

This moves us from fstrcpy() and global variables to 'get' and 'set' functions.

In particular, the 'set' function sainity-checks the input, in the same way as
we always have.

Andrew Bartlett
(This used to be commit e57a896f06)
2002-08-10 23:20:04 +00:00
Andrew Tridgell
80c39a9c1f fix for smbtar filename matching
samba-patches 852
(This used to be commit e2558baa32)
2002-07-28 07:53:14 +00:00
Andrew Bartlett
a6a612a814 Looks like I missed this earlier. We should connect as the specified workgroup
- sombody using smbspool won't always have a full smb.conf, and this is how it
was written in the first place anyway.

Again, found by the IRIX compiler.

Andrew Bartlett
(This used to be commit 3118115876)
2002-07-21 01:20:28 +00:00
Andrew Bartlett
29075c97d3 More fixes towards warnings on the IRIX compiler
(and yes, some of these are real bugs)

In particular, the samr code was doing an &foo of various types, to a function
that assumed uint32.  If time_t isn't 32 bits long, that broke.

They are assignment compatible however, so use that and an intermediate
variable.

Andrew Bartlett
(This used to be commit 30d0998c8c)
2002-07-20 13:02:47 +00:00
Andrew Tridgell
e90b652848 updated the 3.0 branch from the head branch - ready for alpha18
(This used to be commit 03ac082dcb)
2002-07-15 10:35:28 +00:00
Andrew Bartlett
04538bfb6c Make smbmnt a standalone program from a linker point of view. Hopefully this
will make it easier to prove this package correct from an audit point of view.

smbumount to follow, but it uses pstrcpy() so I'll need to decide what to do
with that.

Andrew Bartlett
(This used to be commit 62c56f9724)
2002-07-13 09:14:40 +00:00
Andrew Tridgell
ebfff1a475 - fixed a crash bug for 'print -'
- removed an unused variable
(This used to be commit 66af95716d)
2002-07-13 03:51:28 +00:00
Andrew Tridgell
3e63f3e106 fixed a prototype problem in client.c
(This used to be commit 922ab73c3c)
2002-07-02 01:35:07 +00:00
Andrew Tridgell
9930b0b065 used findstatic.pl to make some variables static and remove some dead
code
(This used to be commit 91ad9041e9)
2002-07-01 09:12:41 +00:00
Andrew Bartlett
0746576113 Update cli_full_connection() to take a 'flags' paramater, and try to get a
few more places to use it.

Andrew Bartlett
(This used to be commit 23689b0746)
2002-06-25 08:57:24 +00:00
Andrew Bartlett
e3958c2105 And another .cvsignore
(This used to be commit fa0037a294)
2002-06-25 08:34:17 +00:00