David Disseldorp
40bca3bdd5
s3/net_rpc_printer: replace dup_sec_desc() usage
...
Use security_descriptor_copy() instead, which is also provided by
libcli.
Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
2014-05-28 17:52:13 +02:00
Jeremy Allison
69e24b4e8b
s3: client : Add extra return parameter to all client open calls.
...
Add a return parameter of struct smb_create_returns *cr to
cli_ntcreate()
cli_ntcreate_recv()
cli_nttrans_create()
cli_nttrans_create_recv()
Always pass in NULL for now. This fixes the create
API to always fully return the data the server has
given back to us on the open file to the caller.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
2014-05-09 23:10:07 +02:00
Jelmer Vernooij
d81bada9f7
Typo: sucessfully -> successfully
...
Signed-Off-By: Jelmer Vernooij <jelmer@samba.org>
Change-Id: I23258edf9c197081c882ba85dedf833292e56e4e
Reviewed-on: https://gerrit.samba.org/219
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2014-04-13 16:55:05 +02:00
Günther Deschner
93e92faca9
s3-net: pass down ndr_interface_table to connect_dst_pipe().
...
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
2013-08-05 10:29:59 +02:00
Günther Deschner
8304fe73f6
spoolss: make spoolss deal with ndr64 AddForm by using proper container object.
...
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
2013-01-17 17:11:37 +01:00
Andreas Schneider
15c0594fee
s3-net: Check return values of push_reg_sz().
...
Found by Coverity.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Günther Deschner <gd@samba.org>
2012-12-21 13:56:00 +01:00
Luk Claes
4f6f4ea93c
s3:libsmb: get rid of cli_state_remote_name
...
Signed-off-by: Luk Claes <luk@debian.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2012-05-28 14:49:45 +02:00
Luk Claes
987e81b0ee
s3:libsmb: get rid of cli_state_*_sockaddr
...
Signed-off-by: Luk Claes <luk@debian.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2012-05-28 14:49:44 +02:00
Gregor Beck
36cb40ef2b
s3:registry: remove usage of reg_objects from net_rpc_printer.c
...
Signed-off-by: Andreas Schneider <asn@samba.org>
2012-04-25 14:23:04 +02:00
Volker Lendecke
3f18316358
s3: Fix Coverity ID 2727 to 2740 -- UNINIT
2012-04-19 20:52:27 +02:00
Jeremy Allison
c8a1082f2b
Move the callers that need to use the new cli_open() back to calling
...
it from cli_openx().
2011-12-03 21:36:47 -08:00
Jeremy Allison
4e709dc42f
Rename cli_open -> cli_openx. Prelude to replacing generic cli_open()
...
with a call that uses NTCreateX in preference to OpenAndX.
2011-12-03 21:13:08 -08:00
Björn Baumbach
d409c0b97b
s3-utils/net_rpc_printer.c: fix error message
...
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Sun Jul 24 19:01:47 CEST 2011 on sn-devel-104
2011-07-24 19:01:47 +02:00
Björn Baumbach
c436a7d812
s3-utils/net_rpc_printer.c: replace cli_query_secdesc_old()
...
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2011-07-23 09:31:07 +02:00
Björn Baumbach
768646c9a2
s3-libsmb: rename cli_query_secdesc() to cli_query_secdesc_old()
...
Will introduce new cli_query_secdesc() function
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2011-07-23 09:18:56 +02:00
Björn Baumbach
ebc53c3575
s3-utils/net_rpc_printer.c: print more info on write error
...
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2011-07-23 09:18:54 +02:00
Björn Baumbach
fd7631c633
s3-utils/net_rpc_printer.c: return on read error in net_copy_file()
...
replace cli_read_old() with cli_read()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2011-07-23 09:18:46 +02:00
Stefan Metzmacher
1f1ca59a04
s3:net_rpc_printer: make use of cli_state_remote_name()
...
metze
2011-07-22 17:06:10 +02:00
Stefan Metzmacher
cc4b2a6dc3
s3:net_rpc_printer: make use of cli_state_remote_sockaddr()
...
metze
2011-07-22 17:06:08 +02:00
Björn Baumbach
9b168e128a
s3-libsmb: replace cli_read() with cli_read_old()
...
Will introduce new cli_read() function.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2011-07-20 22:09:25 +02:00
Andrew Bartlett
74eed8f3ed
s3-param Remove special case for global_myname(), rename to lp_netbios_name()
...
There is no reason this can't be a normal constant string in the
loadparm system, now that we have lp_set_cmdline() to handle overrides
correctly.
Andrew Bartlett
2011-06-09 12:40:09 +02:00
Björn Baumbach
25f1583b9f
s3-net_rpc_printer.c: Fix cli_errstr() usage (part of bug #7864 )
...
Convert cli_errstr() to nt_errstr()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2011-05-18 10:53:45 +02:00
Günther Deschner
3d100216b8
s3-net: fix potential crash bug in display_print_driver3().
...
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri May 13 18:49:06 CEST 2011 on sn-devel-104
2011-05-13 18:49:06 +02:00
Günther Deschner
27022587e3
s3-libsmb: move protos to libsmb/proto.h
...
Guenther
2011-05-06 16:37:18 +02:00
Günther Deschner
0bb4701a74
s3: remove various references to server side dcerpc structs (which are not needed).
...
Guenther
2011-05-02 15:03:44 +02:00
Volker Lendecke
0226428eb9
s3: Use cli_writeall instead of cli_write
...
Signed-off-by: Jeremy Allison <jra@samba.org>
2011-04-26 12:22:55 -07:00
Günther Deschner
9824e2e5ee
s3-rpc_client: add and use rpc_client/rpc_client.h.
...
Guenther
2011-04-13 22:23:59 +02:00
Günther Deschner
6e3f0d28a4
s3-includes: only include ntdomain.h where needed.
...
Guenther
2011-03-30 01:13:09 +02:00
Günther Deschner
0a250f4946
registry: create and use shared libcli/registry/util_reg.h header.
...
Guenther
2011-03-30 01:13:07 +02:00
Günther Deschner
0e771263ee
s3-includes: only include system/filesys.h when needed.
...
Guenther
2011-03-30 01:13:07 +02:00
Günther Deschner
faf8becf22
s3-utils: run minimal_includes.pl over utils/*.c
...
Guenther
2011-03-18 01:24:06 +01:00
Jelmer Vernooij
59a077d8f5
Fix some types
...
Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Mon Feb 28 23:30:06 CET 2011 on sn-devel-104
2011-02-28 23:30:06 +01:00
Günther Deschner
fc16baaf91
s3-net: use struct based dcerpc_spoolss_EnumPrinterData_r() call.
...
This is a workaround for a string issue we currently have with argument based
generated dcerpc client code (see bug #7804 for details).
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri Jan 28 22:05:20 CET 2011 on sn-devel-104
2011-01-28 22:05:20 +01:00
Stefan Metzmacher
81443447a1
s3:net: use dcerpc_spoolss_X() functions
...
metze
Signed-off-by: Andreas Schneider <asn@samba.org>
2011-01-21 12:30:22 +01:00
Volker Lendecke
50b3458261
s3: Convert cli_set_secdesc to cli_trans
2011-01-15 16:34:35 +01:00
Joerg Pulz
0f6a4a2f72
Make 'net rpc printer driver' behave the same as rpcclient enumdrivers
...
when dealing with unsupported architectures.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Thu Nov 18 21:40:40 CET 2010 on sn-devel-104
2010-11-18 21:40:40 +01:00
Andrew Bartlett
f768b32e37
libcli/security Provide a common, top level libcli/security/security.h
...
This will reduce the noise from merges of the rest of the
libcli/security code, without this commit changing what code
is actually used.
This includes (along with other security headers) dom_sid.h and
security_token.h
Andrew Bartlett
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Tue Oct 12 05:54:10 UTC 2010 on sn-devel-104
2010-10-12 05:54:10 +00:00
Günther Deschner
fa3264f89b
s3-net: better handle obscure 0x80070002 error reply when trying to update an
...
not yet published printer.
Guenther
2010-10-01 08:33:46 +02:00
Günther Deschner
21576e3f8c
s3-net: make sure we dont crash when publishing a single printer.
...
Guenther
2010-10-01 08:33:46 +02:00
Günther Deschner
813fbbd68c
s3-build: avoid to globally include printing and spoolss headers.
...
This shrinks precompiled headers by 3MB and will slightly speed up any build.
Guenther
2010-07-31 00:50:31 +02:00
Andreas Schneider
1db7356fa1
s3-net: Use talloc_asprintf and return if file is in wrong format.
...
Found by clang-analyzer.
2010-06-29 11:12:12 +02:00
Andreas Schneider
0c579bc3e6
s3-net: Make sure that the data blob is initialized.
...
Found by clang-analyzer.
2010-06-28 12:56:13 +02:00
Günther Deschner
30a9ddccff
s3-spoolss: add and use spoolss_printerinfo2_to_setprinterinfo2().
...
This fixes some invalid typecasts.
Guenther
2010-06-03 16:32:49 +02:00
Michael Adam
0fe1ff99a1
s3:registry: move reg_objects.h to registry/ and use it only where needed
...
Every place outside of registry/ where this is used, should probably
be changed to use pure reg_api.c code.
2010-05-25 10:35:31 +02:00
Michael Adam
112eddf107
s3:net_rpc_printer: use regval_blob/ctr accessor functions
2010-05-25 10:35:30 +02:00
Michael Adam
c4de07a259
s3:net rpc printer: fix use of a possibly uninitialized variable
2010-05-25 10:35:30 +02:00
Andrew Bartlett
cba7f8b827
s3:dom_sid Global replace of DOM_SID with struct dom_sid
...
This matches the structure that new code is being written to,
and removes one more of the old-style named structures, and
the need to know that is is just an alias for struct dom_sid.
Andrew Bartlett
Signed-off-by: Günther Deschner <gd@samba.org>
2010-05-21 10:39:59 +02:00
Günther Deschner
cc06133b0a
s3-rpc_client: move protos to cli_spoolss.h
...
Guenther
2010-05-18 21:42:45 +02:00
Günther Deschner
7f6bb48bdf
s3-secdesc: remove "typedef struct security_descriptor SEC_DESC".
...
Guenther
2010-05-18 12:30:12 +02:00
Jelmer Vernooij
b8268cf7b0
s3: Remove use of iconv_convenience.
2010-05-18 11:45:31 +02:00