1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-29 21:47:30 +03:00

190 Commits

Author SHA1 Message Date
Jeremy Allison
aee6b5942a r17761: Handle times consistently across all client utils.
Fixes bugs reported in libsmbclient.
Jeremy.
(This used to be commit 42a417fb75313b093948602c3be8e2f386048b5f)
2007-10-10 11:38:47 -05:00
Volker Lendecke
b29915d611 r17571: Change the return code of cli_session_setup from BOOL to NTSTATUS
Volker
(This used to be commit 94817a8ef53589011bc4ead4e17807a101acf5c9)
2007-10-10 11:38:39 -05:00
Volker Lendecke
02eea79624 r17333: Some C++ warnings
(This used to be commit be9aaffdaccae06c8c035eaf31862e34b7cfbe38)
2007-10-10 11:38:26 -05:00
Jeremy Allison
fbdcf2663b r16945: Sync trunk -> 3.0 for 3.0.24 code. Still need
to do the upper layer directories but this is what
everyone is waiting for....

Jeremy.
(This used to be commit 9dafb7f48ca3e7af956b0a7d1720c2546fc4cfb8)
2007-10-10 11:19:14 -05:00
Jeremy Allison
2b8abc030b r16644: Fix bug #3887 reported by jason@ncac.gwu.edu
by converting the lookup_XX functions to correctly
return SID_NAME_TYPE enums.
Jeremy.
(This used to be commit ee2b2d96b60c668e37592c79e86c2fd851e15f69)
2007-10-10 11:19:05 -05:00
Derrell Lipman
9220a7bb7b r16552: Fix bug 3849.
Added a next_token_no_ltrim() function which does not strip leading separator
characters.  The new function is used only where really necessary, even though
it could reasonably be used in many more places, to avoid superfluous code
changes.

Derrell
(This used to be commit d90061aa933f7d8c81973918657dd72cbc88bab5)
2007-10-10 11:19:00 -05:00
Derrell Lipman
9718506d35 r16550: Fix bug 3866. Thanks for the report!
Although I've never met a computer or compiler that produced pointers to
functions which are a different size than pointers to data, I suppose they
probably exist.  Assigning a pointer to a function is technically illegal in C
anyway.

Change casts of the option_value based on the option_name to use of variable
argument lists.

For binary compatibility, I've maintained but deprecated the old behavior of
debug_stderr (which expected to be passed a NULL or non-NULL pointer) and
added a new option debug_to_stderr which properly expects a boolean (int)
parameter.

Derrell
(This used to be commit c1b4c510530ca3118d1eccb9615a8cad732c7373)
2007-10-10 11:18:59 -05:00
Volker Lendecke
e7fc37cf0f r16360: Fix Klocwork ID 136 520 521 522 523 542 574 575 576 607
in net_rpc.c: 715 716 732 734 735 736 737 738 739 749

in net_rpc_audit.c: 754 755 756

in net_rpc_join.c: 757

in net_rpc_registry: 766 767

in net_rpc_samsync.c: 771 773

in net_sam.c: 797 798

Volker
(This used to be commit 3df0bf7d6050fd7c9ace72487d4f74d92e30a584)
2007-10-10 11:18:48 -05:00
Jeremy Allison
0eb9bd176e r16287: Use intptr_t to return an integer of an unknown type cast
to void *.
Jeremy.
(This used to be commit e24361ecddef8a48a42a356775b93ce5c4027fae)
2007-10-10 11:17:31 -05:00
Derrell Lipman
e836508704 r14664: r13868@cabra: derrell | 2006-03-22 17:04:30 -0500
Implement enhancement request 3505.  Two additional features are added here.
 There is now a method of saving an opaque user data handle in the smbc_
 context, and there is now a way to request that the context be passed to the
 authentication function.  See examples/libsmbclient/testbrowse.c for an example
 of using these features.
(This used to be commit 203b4911c16bd7e10198a6f0e63960f2813025ef)
2007-10-10 11:15:42 -05:00
Jeremy Allison
a48baaa935 r14418: Try and fix Coverity #39 and #40 by making the
implicit function contract explicit.
Jeremy.
(This used to be commit 6de5e9ae4628d384631db9b66e22d439a303b75c)
2007-10-10 11:15:29 -05:00
Jim McDonough
025041eba4 r14279: Fix coverity #86, 87, 88, 89:
Free grp_sid and owner_sid before returning.  Also, only allow one group
or owner.
(This used to be commit 1043e0d90ccb3493417f7bf05b70bdf5513bb1a3)
2007-10-10 11:15:23 -05:00
Volker Lendecke
784cc042cb r14241: Fix Coverity bug # 146
(This used to be commit 97789ec8fc4ae2d31f6dd554d9979abce186eb30)
2007-10-10 11:15:19 -05:00
Volker Lendecke
6a8432833b r14236: Fix Coverity bug # 90
(This used to be commit 019dff53f906a6eb7961a95089bff12361e31e57)
2007-10-10 11:15:19 -05:00
Volker Lendecke
21db43ab55 r14235: Fix Coverity bug # 91
(This used to be commit 26d471c02c6ddff15836a3c0d30f9e37f018b66d)
2007-10-10 11:15:19 -05:00
Volker Lendecke
2e42254291 r14234: Fix Coverity bug # 93
(This used to be commit 8a8d9057d98b24710c98fa48df9d7f330a8ebdc0)
2007-10-10 11:15:19 -05:00
Alexander Bokovoy
ce53430263 r14158: Fix coverity CID #147 -- do not dereference pointers before checking their existence
(This used to be commit 6b52423033b2eccdfad1e91e9d59619664f570ac)
2007-10-10 11:15:14 -05:00
Gerald Carter
fb5362c069 r13571: Replace all calls to talloc_free() with thye TALLOC_FREE()
macro which sets the freed pointer to NULL.
(This used to be commit b65be8874a2efe5a4b167448960a4fcf6bd995e2)
2007-10-10 11:10:14 -05:00
Günther Deschner
c9b5c9b941 r13495: Derell, I'm removing that double setup_logging(), just a typo.
Guenther
(This used to be commit c0d91f9d19b33995237847389e4c37e086938b9e)
2007-10-10 11:10:06 -05:00
Gerald Carter
0af1500fc0 r13316: Let the carnage begin....
Sync with trunk as off r13315
(This used to be commit 17e63ac4ed8325c0d44fe62b2442449f3298559f)
2007-10-10 11:06:23 -05:00
Derrell Lipman
7ed3868780 r13216: r12422@cabra: derrell | 2006-01-28 23:57:35 -0500
Fix cli_setpathinfo() to actually do what it's supposed to.

 Also, get rid of some apparently drug-induced code to deal with create time
 which isn't being manipulated anyway.
(This used to be commit aa25dc1248b15e8e1b39cf8a98496e5aba475c4a)
2007-10-10 11:06:18 -05:00
Derrell Lipman
c9811b857a r13214: r12420@cabra: derrell | 2006-01-28 19:10:58 -0500
This should fix bug #3446.

 - The authentication domain provided an an SMB URL was being ignored.  This
   patch fixes that.

 - There were a number of places where string copies were not being confirmed to
   be properly null-terminated.  Now, all string copies in libsmbclient.c are
   properly null-terminated.
(This used to be commit 5fbc2fbb461f02ad6c889de2ce9929c605a44e24)
2007-10-10 11:06:18 -05:00
Derrell Lipman
9c15bd311d r13212: r12414@cabra: derrell | 2006-01-28 17:52:17 -0500
lp_load() could not be called multiple times to modify parameter settings based
 on reading from multiple configuration settings.  Each time, it initialized all
 of the settings back to their defaults before reading the specified
 configuration file.

 This patch adds a parameter to lp_load() specifying whether the settings should
 be initialized.  It does, however, still force the settings to be initialized
 the first time, even if the request was to not initialize them.  (Not doing so
 could wreak havoc due to uninitialized values.)
(This used to be commit f2a24de769d1b2266e576597c57a8e3b1e2a2b51)
2007-10-10 11:06:18 -05:00
Derrell Lipman
cbc97b4e5a r12579: r12122@cabra: derrell | 2005-12-29 12:03:00 -0500
allow for arbitrary option value types
(This used to be commit 64c8e32b6382e48bce5c1f18179e66ca765a70af)
2007-10-10 11:06:00 -05:00
Derrell Lipman
e13d0cb3ec r12576: r12115@cabra: derrell | 2005-12-29 11:16:03 -0500
bug (enhancement) #2651: add option to log debug messages to stderr instead of stdout
(This used to be commit 4182eb99af5b343291a661a87d08edd91fd09a7a)
2007-10-10 11:05:59 -05:00
Derrell Lipman
7919fd0ec8 r12570: r12084@cabra: derrell | 2005-12-29 10:05:16 -0500
do not open connection when only looking for cached connection; also, fix crash caused by missing initialization following recent locale changes
(This used to be commit 0070d816ab53eba047c009604d02f7e088290978)
2007-10-10 11:05:59 -05:00
Derrell Lipman
1d49a2956d r12569: r12083@cabra: derrell | 2005-12-29 09:39:45 -0500
fix line length and make formatting/indentation more consistent
(This used to be commit 3d45023368e651315ff5620345c755c103c91065)
2007-10-10 11:05:59 -05:00
Derrell Lipman
44db82065a r12485: r12044@cabra: derrell | 2005-12-25 16:46:47 -0500
When enumerating what could be a server name or a workgroup name, first
 check for an existing server structure.  If none exists, then go through
 the previous determination of whether it's a serrver or a workgroup.  This
 should avoid doing a NetBIOS name query each time, if we've already
 connected to the specified server.  (While we're at it, clean up indenting
 and line length in this area of code.)
(This used to be commit 85e4cab1d949f1ab9ce04b96de0b8d1c8113df67)
2007-10-10 11:05:58 -05:00
Derrell Lipman
3ec1852ae0 r12472: r12040@cabra: derrell | 2005-12-24 23:26:55 -0500
revert immediately previous change and fix problem correctly.  Interfaces were being loaded before all configuration files had been read.  *This* should fix byg 3336.
(This used to be commit ded5fceef1e9086dcdaba1959f812810f04fe8bc)
2007-10-10 11:05:57 -05:00
Derrell Lipman
50a06f76ef r12471: r12038@cabra: derrell | 2005-12-24 23:17:16 -0500
libsmbclient was not loading the global configuration file.  This should fix 3336.
(This used to be commit 6d7a9ce7a7060b9b397ae77b8b54d3cf25e50e5a)
2007-10-10 11:05:57 -05:00
Derrell Lipman
56b20b8397 r12466: r12028@cabra: derrell | 2005-12-24 20:25:38 -0500
parse dates correctly.  w_time and m_time were reversed.
(This used to be commit 481abfbab40209e087c82eadc15c3697eae0ae5b)
2007-10-10 11:05:56 -05:00
Derrell Lipman
103f720617 r12235: r11738@cabra: derrell | 2005-12-14 13:15:14 -0500
Ensure that when libsmbclient copies a cli, it prevents the cli from later
 being freed, by turning off the 'allocated' flag.

 Change a DEBUG message in pipe_open code from level 0 to level 1 since
 libsmbclient is now regularly attempting to open a pipe for share enumeration,
 and falling back to RAP if RPC is unavailable (e.g. win98).  We don't want
 the debug message to display when the pipe open fails, under these normal
 circumstances.
(This used to be commit 965025c057d9e00fb68ea0819e675fcf9ad2f819)
2007-10-10 11:05:50 -05:00
Derrell Lipman
765daab643 r12225: r11729@cabra: derrell | 2005-12-13 22:59:45 -0500
1. Fix a crash bug which should have reared its ugly head ages ago, but for
    some reason, remained dormant until recently.  The bug pertained to
    libsmbclient doing a structure assignment of a cli after having opened a
    pipe.  The pipe open code makes a copy of the cli pointer that was passed
    to it.  If the cli is later copied (and that cli pointer that was saved
    is no longer valid), the pipe code will cause a crash during shutdown or
    when the copied cli is closed.

 2. The 'type' field in enumerated shares was not being set correctly with
    the new RPC-based mechanism for enumerating shares.
(This used to be commit 62a02b8f2a1fcb66881a9c9636e0b27e3049c5a1)
2007-10-10 11:05:50 -05:00
Derrell Lipman
7bf8de2f02 r12119: r10812@cabra: derrell | 2005-12-07 22:44:26 -0500
sync to repository didn't work correctly...???
(This used to be commit 86ab4cf42b3bfe78239ee0b367bff9cfc5484107)
2007-10-10 11:05:45 -05:00
Derrell Lipman
e48ef5b9b1 r12118: r10805@cabra: derrell | 2005-12-07 22:34:55 -0500
first go at supporting long file names.  seeems to work; requires more testing
(This used to be commit 99fbe44ac569f218bd1b4d1026c18cc72f0a1f0e)
2007-10-10 11:05:45 -05:00
Derrell Lipman
44293df2ae r12098: r10797@cabra: derrell | 2005-12-06 12:09:00 -0500
fixed another memory leak and reverted an (incorrect) fix from yesterday
(This used to be commit 8a86d7bddc291da094d060fbe185f071ffdbddd8)
2007-10-10 11:05:44 -05:00
Derrell Lipman
78631d38f1 r12081: r10674@cabra: derrell | 2005-12-05 13:31:28 -0500
get rid of temporary #if 0 blocks
(This used to be commit 376445c90b05c36206c87c974c13e5f9297f35eb)
2007-10-10 11:05:44 -05:00
Derrell Lipman
a54f9eddce r12080: r10673@cabra: derrell | 2005-12-05 13:22:34 -0500
Correct some memory and file descriptor leaks.

 This should fix bugs 3257, 3267 and 3273.
(This used to be commit c5781c9cf5f1f8297e084fbe2c4a22257420a447)
2007-10-10 11:05:44 -05:00
Jeremy Allison
cef9443a87 r11256: Remove use of long long and strtoll in libsmbclient (we
can't assume long long is always there). Removed unused
var in new a/c rename code.
long long still used in eventlog code but Jerry has promised
to fix that.
Jeremy.
(This used to be commit f46d8470652b8bc5c4b8cac8e96973c6165ab19a)
2007-10-10 11:05:09 -05:00
Gerald Carter
846d52efae r11124: Commit Chris' fixes for libmsrpc after the rpc_client
rewrite.  His comments:

        I've gotten the libmsrpc code to work with TRUNK.
        I've put the patch at:
        www.uoguelph.ca/~cnicholl/libmsrpc_trunk_v1.patch.gz

        It is from revision 11093.

        I also fixed a minor bug in the svcctl code, the timeout
        parameter for all the control functions was working
        in milliseconds instead of seconds.

Also fixed bug in Makefile when building libmsrpc.a
(This used to be commit d3a52900ec223316779e59a13cea87ecb500bccc)
2007-10-10 11:05:01 -05:00
Jeremy Allison
b82981bbc8 r10970: Fix bug #3166 - null pointer dereference if $HOME not
defined. Also clarified confusing error messages.
Jeremy.
(This used to be commit e2639ac9ff8319dde04fc6b4a0c257f7af29cf44)
2007-10-10 11:04:58 -05:00
Gerald Carter
54abd2aa66 r10656: BIG merge from trunk. Features not copied over
* \PIPE\unixinfo
* winbindd's {group,alias}membership new functions
* winbindd's lookupsids() functionality
* swat (trunk changes to be reverted as per discussion with Deryck)
(This used to be commit 939c3cb5d78e3a2236209b296aa8aba8bdce32d3)
2007-10-10 11:04:48 -05:00
Gerald Carter
dade4d9e95 r10176: adding smbctool from Kalim's SoC project; requires make bin/smbctool
(This used to be commit 79fcc3bb7b955da5eb1b2af475aa6ef7694a7157)
2007-10-10 11:03:35 -05:00
Gerald Carter
a44e97c99f r10001: adding in libmsrpc from Chris Nicholls (SoC project). not built by default per conversation with Jeremy until the rpc changes from trunk are merged back
(This used to be commit e813de1e522692a6471828bf1fdf503d33f8cd72)
2007-10-10 11:03:30 -05:00
Volker Lendecke
3a8af94424 r8093: Next round. Now it compiles with --enable-socket-wrapper.
Volker
(This used to be commit 25cbcfba30f534f3fb31627ba43421c42ccd5b0f)
2007-10-10 10:58:11 -05:00
Jeremy Allison
19ca97a70f r7882: Looks like a large patch - but what it actually does is make Samba
safe for using our headers and linking with C++ modules. Stops us
from using C++ reserved keywords in our code.
Jeremy
(This used to be commit 9506b8e145982b1160a2f0aee5c9b7a54980940a)
2007-10-10 10:58:00 -05:00
Derrell Lipman
3005405b52 r7817: Eliminate use of ctime_r() in libsmbclient DEBUG statement. It seems that
ctime_r() takes different parameters on Solaris than it does on Linux, and
it's easier to just eliminate the use of it than to write a configure test.
(This used to be commit 513ea79b2ebc9a78c118042abca942da061d4647)
2007-10-10 10:57:21 -05:00
Derrell Lipman
bf484a8f8e r7245: bug fixes in libsmbclient, setting time attributes
(This used to be commit bf33902c059b7f222f89673ce07c8f929860a85f)
2007-10-10 10:57:05 -05:00
Derrell Lipman
2efe68918d r7175: fix incorrect comment
(This used to be commit 6f951c863ea4671a62075c6ac963f198fbf322b1)
2007-10-10 10:57:04 -05:00
Derrell Lipman
f3ad9323c6 r7172: This is the proper fix for setting file times from libsmbclient. We now
try setpathinfo, and if that doesn't work (e.g. on win98), revert to the
previous slower method.
(This used to be commit 6c05812bd90b0db69d974ee2758721dc2974a507)
2007-10-10 10:57:04 -05:00