1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-14 19:24:43 +03:00

23144 Commits

Author SHA1 Message Date
Volker Lendecke
f923bba908 r24327: First round of fixes to chain_reply
The argument to smb_setlen does not contain the nbt header of 4 bytes

The chained function might allocate outbuf itself (as now happens with
reply_read_and_X). This would erroneously overwrite the caller's outbuf.
Give it an outbuf pointer of it's own
2007-10-10 12:29:29 -05:00
Volker Lendecke
7af4c1f547 r24326: Fix the build for Solaris CC 2007-10-10 12:29:29 -05:00
Volker Lendecke
9d2354129d r24325: Push down reply_prep_legacy in reply_read_and_X 2007-10-10 12:29:29 -05:00
Volker Lendecke
304843315c r24324: No reply_prep_legacy() in reply_pipe_read_and_X 2007-10-10 12:29:29 -05:00
Volker Lendecke
96b2187894 r24323: Remove the reply_read_and_X wrapper function 2007-10-10 12:29:29 -05:00
Volker Lendecke
7926b5dfb8 r24322: Wrap reply_read_and_X in reply_prep_legacy 2007-10-10 12:29:28 -05:00
Volker Lendecke
4e819aea0b r24321: Attempt to fix the "hape" cc build 2007-10-10 12:29:28 -05:00
Volker Lendecke
708f5af2e8 r24320: Fix the wct checks in reply_trans2 and the reply_trans calls
No idea what I've been smoking here.

Thanks to Stefan for closely looking
2007-10-10 12:29:28 -05:00
Volker Lendecke
9ddacdfa13 r24319: Check wct in reply_read_and_X 2007-10-10 12:29:28 -05:00
Volker Lendecke
9269e3d588 r24318: Print a prominent warning when reply_prep_legacy is called
This is a temporary function anyway
2007-10-10 12:29:27 -05:00
Volker Lendecke
db1b89072c r24316: Fix an uninitialized read
Jerry, please check this!

Thanks,

Volker
2007-10-10 12:29:27 -05:00
Volker Lendecke
0ced8fcfe1 r24314: Attempt to fix bug 4868 2007-10-10 12:29:27 -05:00
Stefan Metzmacher
34d821daf0 r24312: revision 24091 removed the 'FORCE'...
metze
2007-10-10 12:29:27 -05:00
Stefan Metzmacher
b9ae00f498 r24311: add a reply_force_nterror() macro
metze
2007-10-10 12:29:27 -05:00
Stefan Metzmacher
7a98e09f2e r24310: we should not call END_PROFILE(SMBntcreateX); twice...
metze
2007-10-10 12:29:27 -05:00
Stefan Metzmacher
6014ecbbfd r24309: if no protocol matches, just return choise 0xffff
as we've done before revision 24002

metze
2007-10-10 12:29:26 -05:00
Stefan Metzmacher
1a177eb08d r24308: this needs a better fix that compiles...
metze
2007-10-10 12:29:26 -05:00
Stefan Metzmacher
2961a35e90 r24307: fill in choise with value -1 on error
as we've done before revision 24002

metze
2007-10-10 12:29:26 -05:00
Stefan Metzmacher
4154bee0d9 r24306: the check_fsp() function has an explicit user argument
so use it...

metze
2007-10-10 12:29:26 -05:00
Stefan Metzmacher
81e5afc363 r24304: patch from Bjoern JAcke <bj@SerNet.DE>:
attached patches add EA support for Solaris. If no one disagrees, can
someone check this in please?

metze
2007-10-10 12:29:25 -05:00
Stefan Metzmacher
30f9171cca r24302: add a module that overloads the file_id_create VFS function
and alters the device id depending on the configured algorithm.

The algorithm is configured via "fileid:algorithm":
- "fsname" (default) uses a uint64 hash over the mount point
- "fsid" uses the fsid returned from statfs()

This is needed for "clustering = yes" on some clusterfilesystems

metze
2007-10-10 12:29:25 -05:00
Volker Lendecke
dab5449f38 r24291: Fix Coverity ID 364
We've checked num_rids != 0 above.
2007-10-10 12:29:25 -05:00
Herb Lewis
5ee0bfde50 r24290: fix debug statments to match function name 2007-10-10 12:29:25 -05:00
Jeremy Allison
fa8e66dd8d r24281: Fix bug found by Herb. The vuid entry in the cli_state structure gets
left as nonzero as returned by the failed cli_session_setup_spnego. When we then try
to authenticate as the user in cli_session_setup this returns an
error "Bad userid" (as seen in wireshark).
"We should only leave cli->vuid != 0 on success. Looks like it's
getting set in the cli_session_setup_blob_receive() call and not
cleared again on error."
Jeremy.
2007-10-10 12:29:25 -05:00
Volker Lendecke
c231f7b8f6 r24280: Fix the build of vfs_afsacl.c 2007-10-10 12:29:24 -05:00
Volker Lendecke
f18b7a9a28 r24279: Remove reply_prep_legacy from reply_write_and_X 2007-10-10 12:29:24 -05:00
Volker Lendecke
de143d5fa6 r24278: Push down reply_prep_legacy in reply_write_and_X
Remove the need for reply_prep_legacy for reply_pipe_write_and_X
2007-10-10 12:29:24 -05:00
Stefan Metzmacher
dd7e94258b r24272: try to fix the build on irix...
metze
2007-10-10 12:29:24 -05:00
Volker Lendecke
607e7d2447 r24271: Push reply_prep_legacy into reply_write_and_X 2007-10-10 12:29:24 -05:00
Volker Lendecke
36f2347561 r24270: Fix some END_PROFILE(SMBwriteX) 2007-10-10 12:29:23 -05:00
Volker Lendecke
1297fac117 r24269: Check wct in reply_write_and_X 2007-10-10 12:29:23 -05:00
Volker Lendecke
c2a2145017 r24268: Fix two crashes for spoolss
strlcpy does not like a NULL source. Fix a use-after-free.
2007-10-10 12:29:22 -05:00
Volker Lendecke
3eee1fe280 r24267: Fix the build farm
I had only tested with "net getlocalsid". posix_locking_init() calls this
with a NULL name...
2007-10-10 12:29:22 -05:00
Volker Lendecke
df40d336af r24266: Remove the "open files database hash size" parameter
This has been superseded by the "tdb_hashsize:<tdbname>" parameter
2007-10-10 12:29:22 -05:00
Volker Lendecke
e9bd7a63a8 r24265: Add the tdb_hashsize:<tdbname> parameter
This makes it possible to set the default hashsize for any tdb. I would
like to remove the "open files database hash size" in favor of this one.

I'll check that removal in with the next commit, please complain/revert
if it's not ok.

Volker
2007-10-10 12:29:21 -05:00
Volker Lendecke
2c1376225b r24254: Fix a segfault in r24102
The really pure bugfix would have replaced pparam by *pparam, but we pulled
the fid anyway.

Metze, in line 2421 the FSP_BELONGS_CONN is commented out, is that intended?
The FSCTL_CREATE_OR_GET_OBJECT_ID ioctl did not have it.

Volker
2007-10-10 12:29:21 -05:00
Jeremy Allison
42d1c6713a r24253: From Jan Martin <Jan.Martin@rwedea.com>.
----------------------------------------------------------
In rare cases, Samba 3.0.25b shows directory contents at the wrong
position in the file tree when displaying a subdirectory of a DFS link.

The problem occurs whenever Windows XP asks for a DFS referral for a
subdirectory of a DFS link with a trailing backslash.
Windows does not do this very often, but we saw it several times per day
on our central DFS server.

smbd/msdfs.c, dfs_path_lookup() does the following with the requested
path:
- in line 390, the local copy 'localpath' is 'unix_convert'ed; the
trailing backslash is removed inside unix_convert
- in lines 417-20, 'dfspath' (another copy of the requested path) is
mangled another way without removing trailing backslashes

That's why the following loop (lines 435-461) that is meant to
synchronously cut off the last path component from both strings until it
comes to a DFS link, does not handle both strings the same.  When the
original path ended with a backslash, 'canon_dfspath' has always one
component more than 'localpath', so that *consumedcntp gets too big in
line 446. This value is reported to the client.
----------------------------------------------------------

Bug #4860.

Jeremy.
2007-10-10 12:29:21 -05:00
Günther Deschner
1142f3df54 r24252: Dump guid of msExchMailboxGuid when returned.
Guenther
2007-10-10 12:29:21 -05:00
Günther Deschner
f783b32b65 r24251: Neverending fun:
Heimdal doesn't accept all OIDs and gss_import_name() fails with
GSS_S_BAD_NAMETYPE using this one. Use the GSS_KRB5_NT_PRINCIPAL_NAME OID
instead (which works with at least MIT 1.6.1 and Heimdal 1.0.1).

Guenther
2007-10-10 12:29:21 -05:00
Günther Deschner
054084a235 r24250: Merge W_ERROR_HAVE_NO_MEMORY macro from Samba 4.
Guenther
2007-10-10 12:29:21 -05:00
Volker Lendecke
c08366f840 r24244: Complete the conversion of reply_trans[s]
Remove reply_prep/post_legacy from send_trans_replies
2007-10-10 12:29:20 -05:00
Volker Lendecke
b01664b43b r24243: Remove reply_prep_legacy from api_reply 2007-10-10 12:29:20 -05:00
Volker Lendecke
160f65946a r24242: Remove reply_prep_legacy from api_rpc_trans_reply 2007-10-10 12:29:20 -05:00
Volker Lendecke
8702450e91 r24241: Remove reply_prep_legacy from api_WNPHS and api_SNPHS 2007-10-10 12:29:20 -05:00
Volker Lendecke
0bb95639d6 r24240: Push down reply_prep_legacy one level inside api_fd_reply 2007-10-10 12:29:20 -05:00
Volker Lendecke
e2a9649792 r24239: Push reply_prep_legacy into api_fd_reply 2007-10-10 12:29:20 -05:00
Volker Lendecke
a6a2d97fac r24238: Push down reply_prep_legacy one level 2007-10-10 12:29:19 -05:00
Volker Lendecke
f0598b3ca0 r24237: Add send_trans_reply_new 2007-10-10 12:29:19 -05:00
Volker Lendecke
b38f9347e8 r24236: Push reply_prep_legacy() into named_pipe() 2007-10-10 12:29:19 -05:00
Volker Lendecke
06d0c74b74 r24235: Make handle_trans reply to errors itself 2007-10-10 12:29:19 -05:00