1
0
mirror of https://github.com/samba-team/samba.git synced 2024-12-24 21:34:56 +03:00
Commit Graph

41 Commits

Author SHA1 Message Date
Jeremy Allison
d3b9384308 Fix for #480. Change the interface for init_unistr2 to not take a length
but a flags field. We were assuming that 2*strlen(mb_string) == length of ucs2-le string.
This is not the case. Count it after conversion.
Jeremy.
(This used to be commit f82c273a42)
2003-09-25 21:26:16 +00:00
Gerald Carter
c674e411c7 i guess i'm the only one this ever annyoed...
fix the confusion when we tdb_lock_bystring() but
we retrieve an entry using tdb_fetch_by_string.
It's now always tdb.*bystring()
(This used to be commit 66359531b8)
2003-07-10 20:37:01 +00:00
Tim Potter
e038e2dff3 Fix broken regexp in cvsignore for *.po{,32} files.
(This used to be commit a17622103b)
2003-04-14 05:33:41 +00:00
Martin Pool
553d1184fe Add the correct file :-( to ignore .po and .po32 files.
(This used to be commit 00b1478822)
2003-03-19 03:41:18 +00:00
Martin Pool
f5765025c2 Remove this .po file from the repository. I meant to add a cvsignore
file that ignored it, but I slipped.
(This used to be commit a3f90cc6ab)
2003-03-19 03:39:16 +00:00
Martin Pool
d071b731a6 Ignore .po and .po32 files.
(This used to be commit 9a8d50d45c)
2003-03-19 03:14:28 +00:00
Jeremy Allison
7a9987481e More const fixes.
Jeremy.
(This used to be commit 7b945e10a6)
2003-03-05 01:34:37 +00:00
Gerald Carter
7c7d796b6d Progress on CR 601
cache the printer_info_2 with the open printer handle.
cache is invalidated on a mod_a_printer() call **on that smbd**.

Yes, this means that the window for admins to step on each other
from different clients just got larger, but since handles a generally
short lived this is probably ok.
(This used to be commit 33c7b75225)
2003-02-25 20:51:23 +00:00
Andrew Tridgell
96c795cea7 reverted this patch till I sort out the craziness with UNIHDR
(This used to be commit e3d00fa47d)
2003-01-17 06:15:18 +00:00
Andrew Tridgell
ec879eacc2 This removes the 3rd argument from init_unistr2(). There were 240
calls to init_unistr2() in the code and every one of them got the 3rd
argument incorrect, so I thought it best just to remove the argument.

The incorrect usage was caused by callers using strlen() to determine
the length of the string. The 3rd argument to init_unistr2() was
supposed to be the character length, not the byte length of the
string, so for non-english this could come out wrong.

I also removed the bogus 'always allocate at least 256 bytes'
hack. There may be some code that relies on this, but if there is then
the code is broken and needs fixing.
(This used to be commit b9eff31b14)
2003-01-17 04:58:45 +00:00
Andrew Bartlett
6d66fb308a BIG patch...
This patch makes Samba compile cleanly with -Wwrite-strings.
 - That is, all string literals are marked as 'const'.  These strings are
always read only, this just marks them as such for passing to other functions.

What is most supprising is that I didn't need to change more than a few lines of code (all
in 'net', which got a small cleanup of net.h and extern variables).  The rest
is just adding a lot of 'const'.

As far as I can tell, I have not added any new warnings - apart from making all
of tdbutil.c's function const (so they warn for adding that const string to
struct).

Andrew Bartlett
(This used to be commit 92a777d0ea)
2003-01-02 09:07:17 +00:00
Jeremy Allison
7f23546730 Forward port the change to talloc_init() to make all talloc contexts
named. Ensure we can query them.
Jeremy.
(This used to be commit 842e08e52a)
2002-12-20 20:23:06 +00:00
Jim McDonough
b3bc5738bd Add some const
(This used to be commit 1426a5ca4f)
2002-12-05 19:11:40 +00:00
Jim McDonough
8bd12bc330 Don't segfault when trying to delete a key when none exist.
(This used to be commit 1bf36d3fc6)
2002-12-03 19:24:51 +00:00
Gerald Carter
3cbe892276 fix up print portion of registry. Merge from APP_HEAD.
(This used to be commit ec37633548)
2002-08-30 14:48:33 +00:00
Gerald Carter
4e216f3e94 break out REGISTRY_VALUE & REGVAL_CR objects into separate file for
cleaning linking....
(This used to be commit fd140aadd7)
2002-08-30 11:03:44 +00:00
Gerald Carter
2bd75e4714 fix registry editor API for printing backend after I changed
the NT_PRINTER_PARAM to a REGISTRY_VALUE
(This used to be commit 8d510abe12)
2002-08-22 21:16:11 +00:00
Tim Potter
752f2adec5 Fix compile warnings.
(This used to be commit e84f47a234)
2002-08-22 17:43:27 +00:00
Gerald Carter
11fadbee74 fix GetPrinterDataEx() to work with registry subkeys using a depth > 1
(This used to be commit 8799d4f7cc)
2002-08-18 12:33:41 +00:00
Gerald Carter
50d224a898 fix to allow EnumPrinterKey() to enumerate multiple levels of subkeys.
Works on the top level.  Needs more testing for levels > 1.
(This used to be commit 32a7083843)
2002-08-18 11:11:48 +00:00
Gerald Carter
4ed429481c Fairly large change to printing code.
* removed support for PHANTOM_DEVMODE printer data

* s/NT_PRINTER_PARAM/REGISTRY_VALUE/g - This was a good bit
  of work.  Everything seems stable, but is not complete.

* support for printer data keys other than PrinterDriverData
  in the store and fetch routines.  Still needs to be plugged
  into the XxxPrinterDataEx() calls.

Tested against NT4.0 & 2k.  Like I said, it's not done, but doesn't
crash so it shouldn't upset anyone (unless you're trying to build
a Samba printer server off of HEAD).  More work to come.  Should
settle by Monday.


jerry
(This used to be commit 7ba7c04c0e)
2002-08-16 15:36:37 +00:00
Tim Potter
d8d0a4e909 Merge of case fixes from APPLIANCE_HEAD.
(This used to be commit f8072d964f)
2002-08-11 18:19:03 +00:00
Andrew Bartlett
9542ef87c0 Back out idra's change (at his request) - the values in the tdb *should* be
upper cased already.

However, if you created your registry tdb in the very early versions of jerry's
patch, you could find that usrmgr doesn't function.  Simply delete the
registry.tdb, it will be recreated on startup.

Andrew Bartlett
(This used to be commit 17136a88c3)
2002-08-06 10:10:54 +00:00
Simo Sorce
918e681894 commented out strupper before key check against internal db, it's no good
to check for uppercased strings when we store them not uppercased.

jerry, this fix is needed to make usrmgr.exe work again.
meanwhile we found out that NT_STATUS code may not be appropriate there.
In particular it seem that an NT PDC will send back 02 as error
(ERRbadfile) not 0xc000000f (NT_STATUS_NO_SUCH_FILE NT)

I think further investigation is need to understand which are aprropriate
return codes here.
(This used to be commit 2ad0e81c8d)
2002-08-04 14:25:32 +00:00
Gerald Carter
787cd2c1e9 hardcode printprocessor name since it is everywhere else
(This used to be commit efbfb8ca54)
2002-07-29 18:06:22 +00:00
Gerald Carter
a23e96316e 3 things:
* normalize all registry key strings before storing or looking
  up paths in the registry tdb
* return the current buffer size for REG_INFO even when not returning
  actual data
* fix a segfault report by metze on #samba-technical so that the
  user/group object picker works again (was the "ProductType" key
  lookup that was failing).
(This used to be commit 5640e6cdb2)
2002-07-26 22:40:06 +00:00
Gerald Carter
f1ed55d903 * fix return code so we don't let a client just open any key it wants
(even nonexistent ones).  This gets rid of the Scheduling Agent icon.

* fix NT_STATUS return code for bad registry path (NT_STATUS_NO_SUCH_FILE)
(This used to be commit 915ee5c0ec)
2002-07-24 19:53:49 +00:00
Gerald Carter
a12ed7f506 done! printer_info_2, devicemode, sec_desc, & printer data all enumerate
and display correctly in regedit.exe.

Not sure about REG_SZ values in PrinterDriverData.  If we store these
in UNICODE, I'll have to fix up a few things.

REG_BINARY & REG_DWORD are fine.
(This used to be commit 2a30c243ec)
2002-07-24 08:58:03 +00:00
Gerald Carter
c808cc3643 several changes in this checkin
* added REG_OPEN_HKCR for supporting regedit.exe

* All data n a REGISTRY_VALUE is stored to a pointer now

* fixed REG_INFO to correctly display data when double clicking on
  and entry in the registry editor

* Will now enumerate installed driver_info_3 data

* fixed numerous bugs related to pointer offsets, memory issues, etc..
  in the registry routines

* added a simple caching mechanism to fetch_reg_[keys|values]_specific()

All that is left now is to enumerate PrinterData and I will have finished
what I started out to do....
(This used to be commit 419d7208e8)
2002-07-24 06:42:09 +00:00
Gerald Carter
5b513407c2 * fix to display correct form information in REG_BINARY information
This should be 8 x uint32 (not 7.  I'm guessing the 2nd to the last
  uint32 is the index number for the form?  Not that big a deal
  I don't think.
(This used to be commit 88f0e68bc6)
2002-07-23 05:07:40 +00:00
Gerald Carter
e8177d1104 * changed structure of REG_R_ENUM_VALUE structure since the BUFFER2
is not and [in/out] buffer

* registry value enumeration is working now for the Print\Forms
  key.  The format of the binary data is not quite right yet
  but all installed forms are listed
(This used to be commit 998eb9c731)
2002-07-23 04:55:06 +00:00
Gerald Carter
029fba81c6 fix seg fault due to memory allocation goof.
(This used to be commit 8e94f68a80)
2002-07-22 21:02:18 +00:00
Gerald Carter
6dd9f24d05 another intermediate checkin on the way to enumerating forms
via the registry.  There is a seg fault here which shouldn't
bother anyone until I can get it fixed.  I just need
a check point in case I need to roll back to this version later on.
(This used to be commit e62ae94823)
2002-07-20 13:23:57 +00:00
Gerald Carter
b516eb62db enumeration of printers keys ( no data yet ) via the registry
functions now works :-)
(This used to be commit c5768538f6)
2002-07-20 04:27:30 +00:00
Gerald Carter
39bbeff5b3 fixed a logic error in the sorted_tree_find_child() routine
that caused a valid search to fail.  The printing registry
view now works again.
(This used to be commit 2050859f03)
2002-07-20 02:42:04 +00:00
Gerald Carter
3c0a9c46d8 fixed seg fault in registry frontend caused by trying to
use a destroyed TALLOC_CTX*
(This used to be commit 432b9f8d7c)
2002-07-19 22:16:03 +00:00
Tim Potter
12e237da68 Fixed a compiler warning.
(This used to be commit bc0f1c1ec2)
2002-07-19 22:01:23 +00:00
Gerald Carter
9fe3bd1259 * refactored registry operations some. subkey lists and
registry values are now passed around in containers
  (REGSUBKEY_CTR & REGVAL_CTR) which each possess a TALLOC_CTX.

* removed subkey_specific_fn() from REGISTRY_OPS.  Is implemented
  in the form of a wrapper

* temporarily broke the printing registry ops.

* implemented inheritence for the data_p of nodes in a SORTED_TREE

* All REGISTRY_KEY instances now store a valid REGISTRY_HOOK since
  the default REGOSTRY_OPS structure is stored in the root of the
  cache_tree.

* Probably some other change I forgot....  T
(This used to be commit e7b55e8f01)
2002-07-19 18:49:44 +00:00
Jeremy Allison
5f894476d8 Formatting fixup. Fix shadow warning.
Jeremy.
(This used to be commit beb298898d)
2002-07-19 16:45:37 +00:00
Gerald Carter
06ae9ac5d9 virtual registry framework with initial printing hooks.
(This used to be commit a43d9788fa)
2002-07-18 23:00:24 +00:00
Gerald Carter
78750803d0 splitting off storage/retrieval routines for abstracting the
registry view front end.  Now to plug in the various hooks.
(This used to be commit 9772acd9ad)
2002-07-15 22:27:07 +00:00