Volker Lendecke
b679dda6c9
Fix bogus uninitialized variable warnings
...
(This used to be commit 71d6580c837adcc2cddcdff561f6fb09701501ee)
2008-01-25 21:20:39 +01:00
Volker Lendecke
6d387037b1
Fix Coverity IDs 451, 452
...
(This used to be commit d28a537277bedb65d1c2a01c971a3a22b1aa6624)
2008-01-25 20:55:51 +01:00
Volker Lendecke
e2ad28509c
Tiny simplification
...
(This used to be commit e78f6872bfc19ce0476b8d79c856a8d9c646a913)
2008-01-25 20:55:51 +01:00
Volker Lendecke
31a6f80784
Remove a pointless while loop
...
(This used to be commit f591bd68eafdbaefcaa95510cc4cb9a74cef0562)
2008-01-25 20:55:51 +01:00
Volker Lendecke
0b10c67c0c
Attempt to fix the build on OpenBSD
...
Thanks to metze for pointing this out
(This used to be commit c94c04e3e6f6ae243a55534a76654755bff55651)
2008-01-25 20:53:21 +01:00
Gerald W. Carter
235deb1b66
Always trust the domain flags in the wcache trusted domain cache.
...
Use the flags stored in the tdb when determining if a domain can
be contacted. The tdb should be considered authoratative anyways unless
you know the flags in the winbindd_domain are correct (such as when
first enumerating trusts).
Original suggestion and patch from Steven Danneman <steven.danneman@isilon.com>.
Manually rewritten by me for 3.2.
(This used to be commit f53658a20de07a29abbe2e90917b328d00fc0024)
2008-01-25 12:29:47 -06:00
Gerald W. Carter
fda9247770
Use the correct domain name when looking up the trust password.
...
On a DC, we always use the domain name given. On a domain member,
we use lp_workgroup(). This fixes a bug supporting trusted domains.
(This used to be commit 8b063a414149bdf401a8f854d55ed7dc6f94cb60)
2008-01-25 12:27:16 -06:00
Günther Deschner
7bcf0b0262
Remove more unused LSA marshalling functions.
...
Guenther
(This used to be commit 95e0fb452bda4c81b26e3dec4953bbba37940467)
2008-01-25 17:22:09 +01:00
Günther Deschner
f1193f6603
Remove some unused structures from rpc_lsa.h.
...
Guenther
(This used to be commit a52066e6083ff4b0d21b57ba43a812c02c0cbd78)
2008-01-25 17:22:04 +01:00
Günther Deschner
a059d24488
Add cmd_netlogon_dsr_enumtrustdom() to rpcclient.
...
Guenther
(This used to be commit cb44c901c1bc66da9f3636020401238ce0005105)
2008-01-25 17:21:57 +01:00
Günther Deschner
e49650ea90
run "make idl".
...
Guenther
(This used to be commit 5db4310d4c9149dc9d68f7684dc961926f94544a)
2008-01-25 17:21:50 +01:00
Günther Deschner
c72caca4a2
Fix netr_DsrEnumerateDomainTrusts IDL.
...
Guenther
(This used to be commit 527aae96a6c2da822a21996ba4e6f7df1941fdbc)
2008-01-25 17:21:38 +01:00
Günther Deschner
c04b738a13
Add LIBNETAPI_LOCAL_SERVER() macro.
...
Guenther
(This used to be commit 4bdcf07bcc3aaf7c3f7245cfdda06433bcf4ae60)
2008-01-25 17:21:29 +01:00
Günther Deschner
a30361ede3
No need to close registry on libnetapi_free() anymore.
...
Guenther
(This used to be commit 6bf75652ef07f5a534cef5034b7aad4fdcbcd265)
2008-01-25 17:21:19 +01:00
Michael Adam
3ca606731b
Fix winbindd_can_contact_domain() on a samba DC.
...
The check for inbound trusts is invalid when samba is a DC
and has a trust with an active directory domain.
This effectively prevented tusts with an AD domain on a
samba DC from working (unless using "winbindd rpc only"),
because an ads_connect() was never performed. Only the
rpc-based winbindd methods were working properly.
Jerry: Please check!
Michael
(This used to be commit dcd42a1e0642c69348adfaeecef7f7f2f074ac30)
2008-01-25 16:43:21 +01:00
Günther Deschner
05ff7fd46e
Use generated DSSETUP client & server rpc functions and remove the hand-written ones.
...
Guenther
(This used to be commit d5ebfccebb1f1b56b45673a506fcdb414103c43b)
2008-01-25 15:30:43 +01:00
Günther Deschner
d7d4f1c132
Add generated dssetup code after make idl.
...
Guenther
(This used to be commit 4b3d96be8017a38a6af4ce58ae54a6af005fbe3e)
2008-01-25 15:25:12 +01:00
Günther Deschner
c19d01fedf
Adding dssetup.idl from samba4.
...
Guenther
(This used to be commit d33a5102c294880ae5f6341575f587f32fb14d0c)
2008-01-25 15:25:05 +01:00
Günther Deschner
242a57b624
Remove rpccli_samr_get_dom_pwinfo() and rpccli_samr_get_usrdom_pwinfo().
...
Guenther
(This used to be commit 29690d18608ab2d694c23ed7656348c8c71f204e)
2008-01-25 15:24:27 +01:00
Jeremy Allison
51f62beabd
Fix the same bug with user -> user_obj.
...
Jeremy.
(This used to be commit c5edf7456955471b8590c2cfa67c7f47a387cdf0)
2008-01-24 18:22:43 -08:00
Jeremy Allison
fccae57310
Fix a really subtle old, old bug :-). When canonicalizing the
...
NT ACL into a POSIX one, if the group being set is the primary group
of the file, map it into a SMB_ACL_GROUP_OBJ, not a SMB_ACL_GROUP.
Otherwise we get an extra bogus group entry in the POSIX ACL.
Jeremy.
(This used to be commit 4d302254fdfce2c267cf6b21f662d5aa2dc9c72c)
2008-01-24 18:13:22 -08:00
Jeremy Allison
dd67913a99
Correctly set flags in ACE's inherited from parent. Still one bug
...
left to find then I'll back-port to 3.0.28.
Jeremy.
(This used to be commit 3df2f7ca782e418703d82f7a1f3c035a365f9589)
2008-01-24 17:50:07 -08:00
Jeremy Allison
4ee9d715a0
Fix missing error check that caused crash when winbindd not running.
...
Jeremy.
(This used to be commit f5ca241e2c1adf2ae836fae33a4adac916f46416)
2008-01-24 17:40:35 -08:00
Michael Adam
76e5c1f79a
Fix lookup_sids to detect unix_groups and unix_users domain sids.
...
This fixes panics in wbcLookupRids when 1-2-22 was passed as a
domain sid.
Michael
(This used to be commit c0d9732cf4482b0db02c75f316ff2b41f3336425)
2008-01-25 01:42:22 +01:00
Michael Adam
60daaeeb34
Add a debug message: show the sid lookup_sid() was called for.
...
Michael
(This used to be commit 6c7c6c3f85a4bd171c62031b2b8e59d3f7054061)
2008-01-25 01:42:22 +01:00
Michael Adam
9912f82067
Add debug message: show which domain_child is being forked.
...
Michael
(This used to be commit 373a00ae0d667d257fa93ab14c773e841f2c4f1a)
2008-01-25 01:42:22 +01:00
Michael Adam
d682e04828
Add a debug message to lookup_rids() printing the domain SID.
...
This is to ease debugging. I sporadically get panics that are
apparently due to NULL domain sid passed to lookup_rids somewhere.
Michael
(This used to be commit 723e877c241dd5a0c8addb89507c9eda75b88ea4)
2008-01-25 01:42:22 +01:00
Michael Adam
2a542ce772
Add a debug message winbindd_can_contact_domain()
...
explaining the reason for failure.
Michael
(This used to be commit ba5373ed7f74d560a9de8620039b596b8938d1dc)
2008-01-25 01:42:22 +01:00
Michael Adam
614ba32b22
Fix assignment to request->data.init_conn.is_primary in init_child_connection().
...
The present assignment
"request->data.init_conn.is_primary = domain->internal ? False : True"
simply feels wrong. This seems to be the thing right to do:
"request->data.init_conn.is_primary = domain->primary ? true : false".
The question is: Does this have any purpose at all?
data.init_conn.is_primary seems to be used nowhere
in the whole code at all.
Is it (still) needed?
Michael
(This used to be commit 8bb21b8b3802e7b093a3c4fb41b8550033388878)
2008-01-25 01:42:22 +01:00
Jeremy Allison
d490d8d52d
Merge branch 'v3-2-test' of ssh://jra@git.samba.org/data/git/samba into v3-2-test
...
(This used to be commit ef2913a66c3888d4813d8b778ddd63b2c7e48f3e)
2008-01-24 16:16:40 -08:00
Jeremy Allison
50c7e98a46
Make explicit in debug we're ignoring flags from the parent SD.
...
Jeremy
(This used to be commit 58cfa4b1bdc1ce30cc3befb342cc98ac0e283585)
2008-01-24 16:13:53 -08:00
Günther Deschner
92183450f1
Trying to avoid defining new SAMR acct creation flags when we already have them with different
...
names. Matt, Jeremy, please check.
Guenther
(This used to be commit d4a9e46edf7336f673c001c559af96eb0ecf9f6f)
2008-01-25 01:04:30 +01:00
Günther Deschner
ed8385a177
Re-run make idl.
...
Guenther
(This used to be commit c0bf3af692bee5bc5a3405feb405e67d35d77a16)
2008-01-25 00:11:58 +01:00
Günther Deschner
9f7170f5aa
Rename samr_*AccessMask bitfields to start with SAMR_.
...
Guenther
(This used to be commit 6226f2294e83501d01d18a954bb36efec37aea75)
2008-01-25 00:07:39 +01:00
Günther Deschner
372f74bba2
Add WERR_INVALID_COMPUTER_NAME.
...
Guenther
(This used to be commit cb1ff32eff06031150a6821658152e02a4077bbd)
2008-01-24 23:41:59 +01:00
Günther Deschner
96b41578a7
Add cmd_netlogon_gettrustrid() to rpcclient.
...
Guenther
(This used to be commit 231a4d051f24af7cf5bf13d7dd613f33dc06f21a)
2008-01-24 23:41:53 +01:00
Günther Deschner
cd8ef2e41d
make idl.
...
Guenther
(This used to be commit 212f6fc000d093bad9f78307743639b391db3fe5)
2008-01-24 23:41:45 +01:00
Günther Deschner
5546c09d8b
Add IDL for netr_LogonGetTrustRid.
...
Guenther
(This used to be commit 6f38c2f06080943bb64ce24115ec2164b6c21b95)
2008-01-24 23:41:37 +01:00
Jeremy Allison
85a44396a7
Add debug messages to trace this if needed.
...
Jeremy.
(This used to be commit b628269b3260661cb4eeeab8c533b3129827ba62)
2008-01-24 13:27:00 -08:00
Jeremy Allison
47a8e77513
The checks for OI and CI were just wrong.... Fix them. Thanks to
...
Jim for testing this.
Jeremy.
(This used to be commit e898789e0d819df05b14bcedfa1d230c7a983440)
2008-01-24 13:06:11 -08:00
Jeremy Allison
70e1ce6403
First part of fix for bug #4929 - worked out by jmcd.
...
Cope with protected ACL set correctly.
Jeremy.
(This used to be commit f5e50f42e7c79b4f8857602457db5b97886bd19e)
2008-01-24 12:59:08 -08:00
Günther Deschner
6b1c45a5c2
Fix winbindd build w/o ADS.
...
Guenther
(This used to be commit 40daef4c3d822a28467ff521efca6a55a0370050)
2008-01-24 17:40:35 +01:00
Volker Lendecke
1eb484d4b4
Fix Coverity ID 454
...
(This used to be commit 902d1d6709e47fbc8b538f28cb4364b006c431f8)
2008-01-24 16:31:55 +01:00
Volker Lendecke
ba6c78c355
Fix Coverity ID 463
...
(This used to be commit 21d126c56a633d2d72ffad08db7331ecc0ee3c0c)
2008-01-24 16:31:55 +01:00
Volker Lendecke
0ff38a8263
Fix Coverity ID 465
...
(This used to be commit 8629a0e1c3da7c2d2b0c1d99224177c54bbae930)
2008-01-24 16:31:55 +01:00
Günther Deschner
fcf42bb19c
Add winbind_msg_dump_domain_list to winbindd.
...
Guenther
(This used to be commit 54ad97bd8364c393de2c9471a4c14ca5b880b318)
2008-01-24 16:22:04 +01:00
Günther Deschner
af7f24d979
Add winbindd debugging ndr_print helpers.
...
Guenther
(This used to be commit 4389e4dadbf07c176d9102b74c06e62ecfc242be)
2008-01-24 16:21:59 +01:00
Günther Deschner
108fc52c6b
Add dump-domain-list command for debugging winbindd's domain_list.
...
Guenther
(This used to be commit 10fa43f2840899c0854763e55b9174827c522a5b)
2008-01-24 16:21:53 +01:00
Stefan Metzmacher
048c80bf54
rerun 'make idl'
...
metze
(This used to be commit 37b95450518419e2153e9930b63f894b68096d3d)
2008-01-24 15:17:46 +01:00
Stefan Metzmacher
530e503a92
netlogon.idl: add some MSV1_0_ values from samba3 and use a bitmap32
...
metze
(cherry picked from commit 7222edb9cde5cdeb9d065e890775a7254b26648f)
(This used to be commit 503082e15e03def33434d3e5ff4fbe750873aab0)
2008-01-24 15:17:45 +01:00