1
0
mirror of https://github.com/samba-team/samba.git synced 2024-12-27 03:21:53 +03:00
Commit Graph

56436 Commits

Author SHA1 Message Date
Stefan Metzmacher
36e889f2cf s4:schannel: fix some compiler warnings
If we only do signing we can pass down a const data buffer.

metze
2009-09-25 05:20:16 +02:00
Stefan Metzmacher
68b8149d1f s3:rpc_client: don't randomly fragment rpc pdu's in developer mode
This is really confusing and also breaks against windows,
as it doesn't accept fragmented bind requests.

metze
2009-09-25 05:20:16 +02:00
Nadezhda Ivanova
bb8a4a9d73 Merge branch 'master' of git://git.samba.org/samba 2009-09-24 18:57:27 -07:00
Nadezhda Ivanova
df0d629f37 Fixed a dereferenced null pointer. 2009-09-24 18:54:14 -07:00
Jeff Layton
3aa147f8d2 mount.cifs: print output to stderr
When a mount fails, mount.cifs often prints an error message. In most
cases, this error goes to stdout instead of stderr like it should. Fix
it to print errors to stderr instead.

Reported-by: Jan Engelhardt <jengelh@gmx.de>
Signed-off-by: Jeff Layton <jlayton@redhat.com>
2009-09-24 20:55:43 -04:00
Jeremy Allison
1e4868d251 Reduce debug log level from 0 -> 7 on non-critical message.
Jeremy.
2009-09-24 17:44:45 -07:00
John H Terpstra
8a90106beb Patches to fix typos thanks to OPC oota. 2009-09-24 19:26:03 -05:00
John H Terpstra
fe0387f047 Bug fix thanks to vjbangis viray 2009-09-24 19:18:33 -05:00
Jeremy Allison
d1aa7d4796 Remove the const from the str_list_XXX functions that
allocate both list and containing strings. This fixes
problems that people have tried to cast away and are
not needed.
Jeremy.
2009-09-24 15:52:58 -07:00
Jeremy Allison
536c4dd2d6 Revert b39c390280 - casts should not
be here.
Jeremy.
2009-09-24 15:44:28 -07:00
Jeremy Allison
4f10aa5973 Revert 918b5a7e05. This code
should *not* return const.
Jeremy.
2009-09-24 15:42:36 -07:00
Matthias Dieter Wallnöfer
b39c390280 s3: Fix up various string "const" warnings
My changed introduced some warnings. Fix them.
2009-09-24 23:58:36 +02:00
Matthias Dieter Wallnöfer
918b5a7e05 s3:util_str "str_list_make_v3" - introduce also here the "const" result
I did this to match with the default util strlist library.
2009-09-24 23:58:19 +02:00
Matthias Dieter Wallnöfer
506b0b6435 s3:vfs_default - correct function parameters 2009-09-24 23:49:41 +02:00
Günther Deschner
c789d041f0 s3-winbindd: no reason to call winbindd_can_contact_domain() three times in query_user().
Guenther
2009-09-24 22:55:38 +02:00
Günther Deschner
4b01e378d2 s3: remove unused printing macros.
Guenther
2009-09-24 22:55:29 +02:00
Steven Danneman
60433b154d s3 onefs: Fix 1 second share mode delay handling
When racing to the open and loosing we may get a share_mode violation.
In this case handle the 1-second delay via a defferred open properly.

This requires us to retrieve the share_mode_lock before deferring
open so we don't dereference a NULL pointer assuming we already had
the lck because we were the first opener.
2009-09-24 11:31:35 -07:00
Steven Danneman
74c0a7a1d3 s3 onefs: Fix a race condition exists in onefs_open.c between multiple opens to the same file.
Two openers can stat a file at the same time, see that it doesn't exist,
and then both race to open it first.  The loser will enter
onefs_open_file_ntcreate believing that the file doesnt exist, and thus
skip any current state lookups for that file.  This includes setting
the file_id, and having a valid stat buffer.

Normally on first create the file_id will be set during the open, but
the second opener in this scenario may fail the open (oplock/share mode)
and file_id will not be set, nor will the stat buffer be valid.

In the error paths of this patch, we now double check that the file_id
and the stat buffer are valid before doing other operations.
2009-09-24 11:31:21 -07:00
Zack Kirsch
5e9aade516 s3 onefs: Add some debugging/asserts to give more info when there is bad deferred open state.
Signed-off-by: Tim Prouty <tprouty@samba.org>
2009-09-24 11:19:00 -07:00
Tim Prouty
ad96c11182 s4 torture: Fix RAW-STREAMS to request more specific permissions
This allows RAW-STREAMS to pass when the user isn't root on some
systems that don't give full access rights to non-root users.
2009-09-24 10:59:33 -07:00
Tim Prouty
86b1a4cb86 s3: Add more helpful debugging to some of the streams code 2009-09-24 10:59:33 -07:00
Aravind Srinivasan
32ee976708 vfs catia: Fix a NULL dereference when CATIA is loaded with no mappings specified.
When we use the CATIA vfs module and don't have any mapping specified,
we return NULL for the mapped_name, thereby resulting in segfaults.
When we don't have catia mapping, we should just use the old name
instead of returning NULL for the mapped_name.

Signed-off-by: Tim Prouty <tprouty@samba.org>
2009-09-24 10:59:33 -07:00
Aravind Srinivasan
637901c242 vfs catia: Fix the double translation that was happening with createfile and open.
Since the catia translation is implemented for open, it should not
also be done in createfile.  By removing createfile from catia,
translation is now done correctly for the primary open path.

In order to support systems that have custom createfile
implementations that don't eventually call SMB_VFS_OPEN,
SMB_VFS_TRANSLATE_NAME has been expanded to take an additional
argument that specifies direction.

Signed-off-by: Tim Prouty <tprouty@samba.org>
2009-09-24 10:59:33 -07:00
Aravind Srinivasan
c870043b27 vfs catia: Fix a possible NULL dereference
Also free some unfreed memory.

Signed-off-by: Tim Prouty <tprouty@samba.org>
2009-09-24 10:59:33 -07:00
Andrew Tridgell
42c3eca0d5 s4-drs: el may not be a talloc pointer
Use msg->elements for the new element values
2009-09-24 10:43:30 -07:00
Andrew Tridgell
2deea28520 s4-drs: regenerate IDL after ndr size change 2009-09-24 10:37:30 -07:00
Andrew Tridgell
547a6da58e s4-drs: add defines for replication flags on attributes 2009-09-24 10:37:24 -07:00
Andrew Tridgell
3b7c668606 s4-ldb: sort replPropertyMetaData by attid
We need to sort on both module add and modify
2009-09-24 10:37:19 -07:00
Andrew Tridgell
41e409370b s4-ldb: add instanceType in repl_meta_data module
We need to add instanceType on new records if not added by caller. This is needed in repl_meta_data
to ensure we fill in the meta data for replication
2009-09-24 10:36:45 -07:00
Andrew Tridgell
f8a09e8fb3 s4-drs: fixed the size of DN binary blobs on the wire
Comparison with w2k8 traces shows the size field of
drsuapi_DsReplicaObjectIdentifier3Binary is taken from
drsuapi_DsReplicaObjectIdentifier3

Thanks to metze for spotting this
2009-09-24 10:36:13 -07:00
Andrew Tridgell
baf93360a8 s4-drs: include deleted objects in getncchanges reply
Even though we don't create deleted objects ourselves yet, we need to
pass along deleted objects we receive from other replication partners
2009-09-24 10:35:40 -07:00
Andrew Tridgell
1fa735cc86 s4-drs: add SHOW_DELETED control on dsdb utility calls
The dsdb_find_dn_by_guid() and dsdb_find_sid_by_dn() are using by
the DRS server call getncchanges on objects that may be deleted.
2009-09-24 10:35:32 -07:00
Andrew Tridgell
a9188f7e10 s4-libnet: allow the functional level of becomeDC to be specified
Use
   ads:functional level = 4
for DS_DC_FUNCTION_2008_R2

See libds/common/flags.h
2009-09-24 10:34:53 -07:00
Andrew Tridgell
3cd0f9e264 s4-libnet: avoid a steal with references error 2009-09-24 10:33:36 -07:00
Jelmer Vernooij
96dd5719d4 Add init file for DCE/RPC tests. 2009-09-24 15:03:59 +02:00
Jelmer Vernooij
0450a5bf90 PEP8 2009-09-24 15:03:59 +02:00
Jelmer Vernooij
5cf25fd225 Revert "s4:python fixed subunit tests of dcerpc"
This reverts commit ffd48a79ee.
2009-09-24 15:03:58 +02:00
Volker Lendecke
50f248a06c s3: Forgot to check in one build failure for vfs_gpfs.c 2009-09-24 13:11:46 +02:00
Volker Lendecke
69447de175 s3: Remove an unused variable 2009-09-24 13:11:46 +02:00
Volker Lendecke
568f818a0f s3: Make the vfs_gpfs compile at least
Not sure whether it works in this state :-)
2009-09-24 12:55:14 +02:00
Stefan Metzmacher
f8425b73d7 Revert "s3:winbindd: use a tcp connection for lsa in case lookup_names/lookup_sids doesn't work over ncacn_np"
This reverts commit f23691cffd.

This should not have been commited...

metze
2009-09-24 06:45:10 +02:00
Stefan Metzmacher
9ef39406d8 s3:rpc_server: we need to make a copy of my_name in serverinfo_to_SamInfo_base()
This is important for the case the server_info already contains a logon_server.

metze
2009-09-24 06:41:13 +02:00
Günther Deschner
f23691cffd s3:winbindd: use a tcp connection for lsa in case lookup_names/lookup_sids doesn't work over ncacn_np
metze
2009-09-24 06:41:11 +02:00
Anatoliy Atanasov
4f9de0e995 s4: Handle DRSUAPI_DS_REPLICA_NEIGHBOUR_SPECIAL_SECRET_PROCESSING in getncchanges
When this flag is specified in the request these attributes are treated as
secret: currentValue, dBCSPwd, initialAuthIncoming, initialAuthOutgoing,
lmPwdHistory, ntPwdHistory, priorValue, supplementalCredentials,
trustAuthIncoming, trustAuthOutgoing, unicodePwd
Their value is changed to NULL and the meta_data.originating_change_time to 0
2009-09-23 17:10:27 -07:00
Anatoliy Atanasov
23e4470c31 s4: Handle DRSUAPI_DS_REPLICA_NEIGHBOUR_ASYNC_REP in getncchanges
When this flag is specified in the request we should return
for ncRoot only and so scope of search is LDB_SCOPE_BASE.
2009-09-23 17:10:21 -07:00
Anatoliy Atanasov
97a9ae15b5 s4: Handle DRSUAPI_DS_REPLICA_NEIGHBOUR_FULL_SYNC_PACKET in getncchanges
When this flag is specified in the request we shouldn't use the
uptodateness vector in the request.
2009-09-23 17:10:12 -07:00
Anatoliy Atanasov
71c862cd91 idl: regenerate idl 2009-09-23 15:50:58 -07:00
Anatoliy Atanasov
c9dc6506e6 s4: Handle DRSUAPI_DS_REPLICA_NEIGHBOUR_CRITICAL_ONLY req in getncchanges 2009-09-23 15:50:51 -07:00
Stefan Metzmacher
5925e2952c Revert "r20074: this values seem to be typos in drsuapi"
This reverts commit 1dfd365d57

This change was from and the flags I was seeing have another meaning.

metze

Signed-off-by: Anatoliy Atanasov <anatoliy.atanasov@postpath.com>
2009-09-23 15:50:42 -07:00
Andrew Bartlett
f28219d1a1 s4:ldif_handlers Fix memory leak in objectCategory LDIF handler 2009-09-23 14:01:30 -07:00