1
0
mirror of https://github.com/samba-team/samba.git synced 2025-07-27 07:42:04 +03:00
Commit Graph

54 Commits

Author SHA1 Message Date
f799f63e43 CVE-2013-4408:s3:Ensure LookupRids() replies arrays are range checked.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=10185

Signed-off-by: Jeremy Allison <jra@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>

Autobuild-User(master): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(master): Mon Dec  9 09:00:41 CET 2013 on sn-devel-104
2013-12-09 09:00:41 +01:00
0dc6181894 CVE-2013-4408:s3:Ensure LookupNames replies arrays are range checked.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=10185

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Jeremy Allison <jra@samba.org>
2013-12-09 07:05:46 +01:00
77f7f2a976 s3-libnetapi: pass down ndr_interface_table to libnetapi_open_pipe().
Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
2013-08-05 10:29:59 +02:00
f1fe877d07 s3-netapi: Initialize group_handle of NetGroupSetUsers_r().
Found by Coverity.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
2012-12-12 09:42:33 +01:00
7d20934693 s4-netapi: Initialize group_handle of NetGroupGetUsers_r().
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
2012-12-12 09:42:33 +01:00
5e26e94092 s3-talloc Change TALLOC_ZERO_ARRAY() to talloc_zero_array()
Using the standard macro makes it easier to move code into common, as
TALLOC_ZERO_ARRAY isn't standard talloc.
2011-06-09 12:40:08 +02:00
9824e2e5ee s3-rpc_client: add and use rpc_client/rpc_client.h.
Guenther
2011-04-13 22:23:59 +02:00
7f63018117 s3-libnetapi: prefer dcerpc_samr_X functions in lib/netapi/group.c.
Guenther
2011-02-01 12:49:44 +01:00
f768b32e37 libcli/security Provide a common, top level libcli/security/security.h
This will reduce the noise from merges of the rest of the
libcli/security code, without this commit changing what code
is actually used.

This includes (along with other security headers) dom_sid.h and
security_token.h

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Tue Oct 12 05:54:10 UTC 2010 on sn-devel-104
2010-10-12 05:54:10 +00:00
b7683a2c9d samr: for correctness, rename samr_RidTypeArray to samr_RidAttrArray.
Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Thu Oct  7 12:04:32 UTC 2010 on sn-devel-104
2010-10-07 12:04:32 +00:00
13756d0e80 s3: Attempt to fix bug 7665
Quite a few of our internal routines put stuff on talloc_tos() these days.
In top-level netapi routines, properly allocate a stackframe and clean it
again. Also, don't leak memory in the rpccli_ callers onto the libnetapi
context.
2010-10-02 12:02:02 +02:00
102a70e809 s3-util: use shared dom_sid_dup.
Guenther
2010-09-20 14:05:07 -07:00
e978a3d3f4 s3-lsa: separate out init_lsa headers.
Guenther
2010-08-25 22:50:39 +02:00
55d448254a s3:netapi: remove unused variable 2010-01-26 00:19:09 +01:00
3d679a3b5f s3-rpc: Avoid including every pipe's client and server stubs everywhere in samba.
Guenther
2009-11-26 20:03:17 +01:00
6a650d7d16 Revert "s3: Make libnetapi_open_pipe take strings instead of a ndr_interface_table"
This reverts commit 5fc9d93408.
2009-11-08 19:43:46 +01:00
5fc9d93408 s3: Make libnetapi_open_pipe take strings instead of a ndr_interface_table 2009-11-08 13:12:16 +01:00
0e1840b84a w32err: WERR_GROUP_NOT_FOUND renamed to WERR_GROUPNOTFOUND
In Win 32 we have
NERR_GroupNotFound which maps to WERR_GROUP_NOT_FOUND currently
and we have
ERROR_GROUP_NOT_FOUND which maps to nothing, so it is to be added

Signed-off-by: Anatoliy Atanasov <anatoliy.atanasov@postpath.com>
2009-09-30 15:48:41 +03:00
d9804ae3cc Fix bug #6089 - Winbind samr_OpenDomain not possible with Samba 3.2.6+
What a difference a name makes... :-). Just because something is missnamed
SAMR_ACCESS_OPEN_DOMAIN, when it should actually be SAMR_ACCESS_LOOKUP_DOMAIN,
don't automatically use it for a security check in _samr_OpenDomain().
Jeremy.
2009-04-15 15:40:00 -07:00
d2e348b191 s3-netapi: Fix Coverity #776 (REVERSE_INULL).
Guenther
2009-03-20 11:17:50 +01:00
531af136f9 s3: remove POLICY_HND.
Guenther
2009-03-18 23:22:29 +01:00
a9542ddcb7 libnetapi_open_pipe does not need to return cli_state
The user session key is also available in rpccli->auth->user_session_key

Guenther, please check!

Thanks,

Volker
2009-01-18 20:10:06 +01:00
c017909e2e netapi: NetGroupEnum_r needs to handle servers with no groups.
Guenther
2008-10-23 01:43:06 +02:00
65dc1eeceb s3: fix various samr callers.
Guenther
2008-10-15 17:11:27 +02:00
f792f87094 netapi: fix NetGroupGetUsers (only enumerates users).
Guenther
(This used to be commit a94318be46)
2008-09-12 14:12:33 +02:00
00ba381e09 netapi: fix NetGroupSetUsers.
Guenther
(This used to be commit 735bc2e425)
2008-09-12 14:12:14 +02:00
de1ec0f40c netapi: implement NetGroupGetUsers_r.
Guenther
(This used to be commit 7b77dacde5)
2008-09-11 14:30:08 +02:00
9e7a0a8ddb netapi: implement NetGroupSetUsers_r.
Guenther
(This used to be commit 0ba0ffdb30)
2008-09-11 14:30:00 +02:00
ffdfe3e8b4 netapi: add skeleton for NetGroupSetUsers.
Guenther
(This used to be commit 4d92d000a1)
2008-09-11 14:29:36 +02:00
fcd10d26a4 netapi: make libnetapi_open_ipc_connection static.
Guenther
(cherry picked from commit 0259914f8f)
(This used to be commit 7edc671cc1)
2008-08-14 12:22:11 +02:00
87b9c9ade2 netapi: make non-implemented local calls default to remote "localhost" calls.
Guenther
(cherry picked from commit aa70e58880)
(This used to be commit 9927ac6eec)
2008-08-14 12:22:02 +02:00
cf2ac8f8db netapi: add NetGroupGetUsers skeleton.
GUenther
(This used to be commit 0b4e2687ae)
2008-07-30 16:55:05 +02:00
44465215ff netapi: use "buffer" in libnetapi.
Guenther
(This used to be commit 80957bc1bc)
2008-07-30 16:43:47 +02:00
798b56edae Refactoring: libnetapi_open_pipe takes an interface instead of pipe_idx
(This used to be commit 726e56c72f)
2008-07-21 14:36:27 +02:00
c703304f55 netapi: add caching of samr policy handles.
Guenther
(This used to be commit bf8453da9a)
2008-07-18 17:29:28 +02:00
f09df9b186 netapi: fix NetGroupGetInfo() against NT4.
Guenther
(This used to be commit c0fea9c4d0)
2008-07-18 16:47:05 +02:00
0f966cfd8a netapi: fix NetGroupDel() against NT4.
Guenther
(This used to be commit 55035d7240)
2008-07-18 16:46:58 +02:00
bf0eaf64ce netapi: fill in NetGroupEnum_r().
Guenther
(This used to be commit 64700e09ce)
2008-07-17 10:41:15 +02:00
89f4e869b6 netapi: fix map_group_info_to_buffer for GROUP_INFO_3 change.
Guenther
(This used to be commit f287567719)
2008-07-17 10:37:12 +02:00
c343190344 netapi: add skeleton for NetGroupEnum().
Guenther
(This used to be commit 21a0d9d254)
2008-07-17 10:35:08 +02:00
34413e4707 netapi: fix some build warnings.
Guenther
(This used to be commit 45cd78030f)
2008-06-03 01:37:55 +02:00
b652e5b475 netapi: let libnetapi_samr_open_domain return WERROR.
Guenther
(This used to be commit 3d037a07e0)
2008-06-03 01:27:49 +02:00
2997e2868c netapi: use libnetapi_samr_open_domain().
Guenther
(This used to be commit b07445e86f)
2008-06-03 01:27:45 +02:00
4dcfa15b0b netapi: Implement NetGroupDelUser().
Guenther
(This used to be commit 10f69b3ce5)
2008-06-03 01:27:45 +02:00
749e5a80c2 netapi: implement NetGroupAddUser().
Guenther
(This used to be commit c727a49519)
2008-06-03 01:27:44 +02:00
c30b8c4eaf netapi: add dummy implementation for NetGroupAddUser() and NetGroupDelUser().
Guenther
(This used to be commit 6eba84edc6)
2008-06-03 01:27:44 +02:00
457649fb02 netapi: Implement NetGroupGetInfo_r().
Guenther
(This used to be commit a8baa45aec)
2008-06-03 01:27:43 +02:00
5b111cc4d5 netapi: add dummy implementation of NetGroupGetInfo().
Guenther
(This used to be commit 88d03b1645)
2008-06-03 01:27:43 +02:00
a6f057c0ab netapi: implement NetGroupSetInfo_r().
Guenther
(This used to be commit 4d11c32874)
2008-06-03 01:27:42 +02:00
b01a0a16a6 netapi: Add dummy implementation of NetGroupSetInfo().
Guenther
(This used to be commit 7e47bdc082)
2008-06-03 01:27:42 +02:00