0dc6181894
CVE-2013-4408:s3:Ensure LookupNames replies arrays are range checked.
...
Bug: https://bugzilla.samba.org/show_bug.cgi?id=10185
Signed-off-by: Stefan Metzmacher <metze@samba.org >
Signed-off-by: Jeremy Allison <jra@samba.org >
2013-12-09 07:05:46 +01:00
77f7f2a976
s3-libnetapi: pass down ndr_interface_table to libnetapi_open_pipe().
...
Guenther
Signed-off-by: Günther Deschner <gd@samba.org >
Reviewed-by: Stefan Metzmacher <metze@samba.org >
Reviewed-by: Andreas Schneider <asn@samba.org >
2013-08-05 10:29:59 +02:00
33d1d52508
s3-netapi: Fix zeroing policy handles in NetLocalGroupAdd_r().
...
Found by Coverity.
Signed-off-by: Andreas Schneider <asn@samba.org >
Reviewed-by: Guenther Deschner <gd@samba.org >
2012-12-12 09:42:32 +01:00
5e26e94092
s3-talloc Change TALLOC_ZERO_ARRAY() to talloc_zero_array()
...
Using the standard macro makes it easier to move code into common, as
TALLOC_ZERO_ARRAY isn't standard talloc.
2011-06-09 12:40:08 +02:00
ad0a07c531
s3-talloc Change TALLOC_ZERO_P() to talloc_zero()
...
Using the standard macro makes it easier to move code into common, as
TALLOC_ZERO_P isn't standard talloc.
2011-06-09 12:40:08 +02:00
ee0b0dd3a1
s3-netapi: Fix Coverity CID #2302 : FORWARD_NULL
...
Guenther
2011-04-27 16:51:02 +02:00
9824e2e5ee
s3-rpc_client: add and use rpc_client/rpc_client.h.
...
Guenther
2011-04-13 22:23:59 +02:00
e32b50894b
s3-libnetapi: prefer dcerpc_lsa_X functions.
...
Guenther
2011-02-02 19:02:09 +01:00
b76657f8d9
s3-libnetapi: prefer dcerpc_samr_X functions in lib/netapi/localgroup.c.
...
Guenther
2011-02-01 12:49:52 +01:00
f768b32e37
libcli/security Provide a common, top level libcli/security/security.h
...
This will reduce the noise from merges of the rest of the
libcli/security code, without this commit changing what code
is actually used.
This includes (along with other security headers) dom_sid.h and
security_token.h
Andrew Bartlett
Autobuild-User: Andrew Bartlett <abartlet@samba.org >
Autobuild-Date: Tue Oct 12 05:54:10 UTC 2010 on sn-devel-104
2010-10-12 05:54:10 +00:00
13756d0e80
s3: Attempt to fix bug 7665
...
Quite a few of our internal routines put stuff on talloc_tos() these days.
In top-level netapi routines, properly allocate a stackframe and clean it
again. Also, don't leak memory in the rpccli_ callers onto the libnetapi
context.
2010-10-02 12:02:02 +02:00
4dbd743e46
s3-util_sid: use shared dom_sid_compare_auth and dom_sid_equal_X functions.
...
Guenther
2010-09-20 14:04:37 -07:00
4bf783d4d6
s3-auth Change type of num_sids to uint32_t
...
size_t is overkill here, and in struct security_token in the num_sids
is uint32_t.
This includes a change to the prototype of add_sid_to_array()
and add_sid_to_array_unique(), which has had a number of
consequnetial changes as I try to sort out all the callers using
a pointer to the number of sids.
Andrew Bartlett
Signed-off-by: Andrew Tridgell <tridge@samba.org >
2010-09-11 18:46:05 +10:00
e978a3d3f4
s3-lsa: separate out init_lsa headers.
...
Guenther
2010-08-25 22:50:39 +02:00
b6a2cea74d
s3-security: use shared "Standard access rights.".
...
Guenther
2010-06-03 11:00:26 +02:00
230b880d14
s3-rpc_client: move protos to cli_lsarpc.h
...
Guenther
2010-05-18 21:42:41 +02:00
3d679a3b5f
s3-rpc: Avoid including every pipe's client and server stubs everywhere in samba.
...
Guenther
2009-11-26 20:03:17 +01:00
6a650d7d16
Revert "s3: Make libnetapi_open_pipe take strings instead of a ndr_interface_table"
...
This reverts commit 5fc9d93408
2009-11-08 19:43:46 +01:00
5fc9d93408
s3: Make libnetapi_open_pipe take strings instead of a ndr_interface_table
2009-11-08 13:12:16 +01:00
d9804ae3cc
Fix bug #6089 - Winbind samr_OpenDomain not possible with Samba 3.2.6+
...
What a difference a name makes... :-). Just because something is missnamed
SAMR_ACCESS_OPEN_DOMAIN, when it should actually be SAMR_ACCESS_LOOKUP_DOMAIN,
don't automatically use it for a security check in _samr_OpenDomain().
Jeremy.
2009-04-15 15:40:00 -07:00
a9542ddcb7
libnetapi_open_pipe does not need to return cli_state
...
The user session key is also available in rpccli->auth->user_session_key
Guenther, please check!
Thanks,
Volker
2009-01-18 20:10:06 +01:00
65dc1eeceb
s3: fix various samr callers.
...
Guenther
2008-10-15 17:11:27 +02:00
fcd10d26a4
netapi: make libnetapi_open_ipc_connection static.
...
Guenther
(cherry picked from commit 0259914f8f7edc671cc1
2008-08-14 12:22:11 +02:00
87b9c9ade2
netapi: make non-implemented local calls default to remote "localhost" calls.
...
Guenther
(cherry picked from commit aa70e588809927ac6eec
2008-08-14 12:22:02 +02:00
11db643962
netapi: let libnetapi_samr_lookup_and_open_alias return NTSTATUS.
...
Guenther
(cherry picked from commit dcf6d879a18ac6a2739b
2008-08-14 12:21:44 +02:00
f947d416ff
netapi: implement NetLocalGroupSetMembers_r().
...
Guenther
(This used to be commit bb52ba58e4
2008-08-11 19:48:02 +02:00
b65fcbc1f5
netapi: implement NetLocalGroupDelMembers_r().
...
Guenther
(This used to be commit bd31d8f9ec
2008-08-11 19:47:53 +02:00
14364acd08
netapi: implement NetLocalGroupAddMembers_r().
...
Guenther
(This used to be commit 53dc9a1181
2008-08-11 19:47:44 +02:00
2fde42b694
netapi: add skeleton for NetLocalGroup*Member calls.
...
Guenther
(This used to be commit 563fb06107
2008-08-11 19:47:24 +02:00
4b74ae0f15
netapi: in NetLocalGroupAdd_r() only set description if necessary.
...
Guenther
(This used to be commit 7e9fa2c539
2008-07-31 15:15:39 +02:00
44465215ff
netapi: use "buffer" in libnetapi.
...
Guenther
(This used to be commit 80957bc1bc
2008-07-30 16:43:47 +02:00
39c344a27f
netapi: fix NetLocalGroupAdd.
...
Guenther
(This used to be commit d4594a7a03
2008-07-30 16:34:49 +02:00
798b56edae
Refactoring: libnetapi_open_pipe takes an interface instead of pipe_idx
...
(This used to be commit 726e56c72f
2008-07-21 14:36:27 +02:00
c703304f55
netapi: add caching of samr policy handles.
...
Guenther
(This used to be commit bf8453da9a
2008-07-18 17:29:28 +02:00
6565087b73
netapi: let libnetapi_samr_lookup_and_open_alias compose lsa string.
...
Guenther
(This used to be commit f930900377
2008-07-18 17:26:55 +02:00
3d140562fa
netapi: implement NetLocalGroupEnum_r.
...
Guenther
(This used to be commit 2cd91e7d4d
2008-07-18 17:26:55 +02:00
d86068977c
netapi: add skeleton for NetLocalGroupEnum().
...
Guenther
(This used to be commit 71bd0109d6
2008-07-18 17:25:07 +02:00
63c93682ac
netapi: make map_alias_info_to_buffer suitable for arrays in the buffer.
...
Guenther
(This used to be commit dc0f737bd5
2008-07-18 17:23:20 +02:00
3e5dabc968
netapi: add libnetapi_samr_open_alias_queryinfo.
...
Guenther
(This used to be commit 401d6ce210
2008-07-18 17:23:12 +02:00
34413e4707
netapi: fix some build warnings.
...
Guenther
(This used to be commit 45cd78030f
2008-06-03 01:37:55 +02:00
dbb8e163af
netapi: use libnetapi_samr_lookup_and_open_alias().
...
Guenther
(This used to be commit d8fad6bf44
2008-06-03 01:27:50 +02:00
4fd700ca07
netapi: add libnetapi_samr_lookup_and_open_alias().
...
Guenther
(This used to be commit 890d63f31c
2008-06-03 01:27:50 +02:00
bd9d129e6a
netapi: use libnetapi_samr_open_builtin_domain().
...
Guenther
(This used to be commit d1bf8c5ae6
2008-06-03 01:27:50 +02:00
b652e5b475
netapi: let libnetapi_samr_open_domain return WERROR.
...
Guenther
(This used to be commit 3d037a07e0
2008-06-03 01:27:49 +02:00
1ecf67a18c
netapi: Implement NetLocalGroupSetInfo().
...
Guenther
(This used to be commit f991b4d58e
2008-06-03 01:27:49 +02:00
bf225fc8e0
netapi: add NetLocalGroupSetInfo() skeleton.
...
Guenther
(This used to be commit 325f419636
2008-06-03 01:27:49 +02:00
a3f1e2ee0a
netapi: implement NetLocalGroupGetInfo().
...
Guenther
(This used to be commit d735ee79fa
2008-06-03 01:27:48 +02:00
45baadb31a
netapi: add NetLocalGroupGetInfo() skeleton.
...
Guenther
(This used to be commit f70e37a7fe
2008-06-03 01:27:48 +02:00
4d6e66a42e
netapi: Implement NetLocalGroupDel().
...
Guenther
(This used to be commit d2426f53fa
2008-06-03 01:27:47 +02:00
7773d79afd
netapi: add NetLocalGroupDel() skeleton.
...
Guenther
(This used to be commit 4234c87c6c
2008-06-03 01:27:47 +02:00
