1
0
mirror of https://github.com/samba-team/samba.git synced 2025-06-21 03:17:08 +03:00

505 Commits

Author SHA1 Message Date
Andrew Bartlett
74eed8f3ed s3-param Remove special case for global_myname(), rename to lp_netbios_name()
There is no reason this can't be a normal constant string in the
loadparm system, now that we have lp_set_cmdline() to handle overrides
correctly.

Andrew Bartlett
2011-06-09 12:40:09 +02:00
Volker Lendecke
c7c0e4ca71 s3: Remove unused cli_session_request
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sun May 29 22:25:55 CEST 2011 on sn-devel-104
2011-05-29 22:25:55 +02:00
Volker Lendecke
4ee443d7b3 s3: Remove unused cli_connect 2011-05-29 21:17:27 +02:00
Volker Lendecke
debaf40e99 s3: Add set_socket_options to cli_connect_sock()
A leftover of stuff that cli_connect() does

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sun May 29 15:47:17 CEST 2011 on sn-devel-104
2011-05-29 15:47:17 +02:00
Volker Lendecke
5676f817c7 s3: Remove unused attempt_netbios_session_request 2011-05-29 14:39:12 +02:00
Volker Lendecke
01386ff313 s3: Extract the guest_login field in sesssetup 2011-05-29 12:49:34 +02:00
Volker Lendecke
4ec00fd621 s3: Fix wct check in cli_sesssetup_blob_done 2011-05-29 12:49:34 +02:00
Volker Lendecke
57ae32794f s3: Add called name_type param to cli_connect_nb 2011-05-28 20:50:09 +02:00
Volker Lendecke
c430b57ce4 s3: Fix a type-punned warning 2011-05-28 20:50:09 +02:00
Volker Lendecke
1c11186837 s3: Use cli_connect_nb in cli_start_connection 2011-05-28 10:29:53 +02:00
Volker Lendecke
defcd409a3 s3: Add cli_connect_nb
This builds up a cli_state until after the netbios session setup. It makes use
of smbsock_connect, so it connects to 139 and 445 simultaneously. This improves
the connection to Windows 2008 which does not listen on *SMBSERVER anymore.
2011-05-28 10:29:53 +02:00
Volker Lendecke
b1a7bdb93c s3: Remove two false references to cli->inbuf 2011-05-23 15:45:37 +02:00
Volker Lendecke
9514f96856 s3: Fix a leftover from fstring removal in cli_state
Jeremy, please check!
2011-05-23 15:45:36 +02:00
Jeremy Allison
4360c5bf27 Patch for bug #8156 - net ads join fails to use the user's kerberos ticket.
If kerberos_get_realm_from_hostname() or kerberos_get_default_realm_from_ccache() fails due to
 a misconfigured krb5.conf, try the "realm =" from smb.conf as a fallcback before going back to
 NTLMSSP (which we'll do anyway).

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Sat May 21 00:58:09 CEST 2011 on sn-devel-104
2011-05-21 00:58:09 +02:00
Jeremy Allison
e0b2f6bd26 The "workgroup" parameter is not used at all in cli_session_setup_kerberos(). Remove it. 2011-05-20 23:49:04 +02:00
Volker Lendecke
0645deb1b4 s3: Do central cli_set_error 2011-05-19 17:31:30 +02:00
Volker Lendecke
bc7df52653 s3: Remove the use of cli->inbuf/outbuf from cli_session_request 2011-05-19 13:46:47 +02:00
Christian Ambach
20179bb550 s3:libsmb convert user-specified domain to uppercase
with client ntlmv2 auth = yes, there is a small difference between
using smbclient -U user\domain and smbclient -U user -W domain
if domain is provided in lowercase

using -W will uppercase the given parameter, while picking the
domain name from -U will not convert it to uppercase and this
leads to failing NTLMv2 authentication

with this patch, there is no difference between
smbclient -U domain\user and smbclient -U user -W domain any more

Autobuild-User: Christian Ambach <ambi@samba.org>
Autobuild-Date: Mon May 16 11:42:55 CEST 2011 on sn-devel-104
2011-05-16 11:42:55 +02:00
Günther Deschner
27022587e3 s3-libsmb: move protos to libsmb/proto.h
Guenther
2011-05-06 16:37:18 +02:00
Volker Lendecke
d87427973c s3: Make name_resolve_bcast return sockaddr_storage
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sat Apr 30 20:40:46 CEST 2011 on sn-devel-104
2011-04-30 20:40:46 +02:00
Volker Lendecke
020b691cf8 s3: Remove ip_sevice from get_ipc_connect_master_ip
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sat Apr 30 18:16:28 CEST 2011 on sn-devel-104
2011-04-30 18:16:28 +02:00
Günther Deschner
50883cfeb4 s3-tevent: only include ../lib/util/tevent wrappers where needed.
Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri Apr 29 14:00:30 CEST 2011 on sn-devel-104
2011-04-29 14:00:30 +02:00
Jeremy Allison
240465f96e Remove another fstring in this code.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Thu Apr 28 03:15:32 CEST 2011 on sn-devel-104
2011-04-28 03:15:32 +02:00
Jeremy Allison
af599b3d90 Fixup (C) - we've both worked lots on this :-).
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed Apr 27 21:56:29 CEST 2011 on sn-devel-104
2011-04-27 21:56:29 +02:00
Jeremy Allison
1815f0298f Remove fstrings from client struct. Properly talloc strings (ensuring we never end up with a NULL pointer). 2011-04-27 12:06:25 -07:00
Volker Lendecke
e81ea8a291 s3: Make cli_session_setup_lanman2 async
Signed-off-by: Jeremy Allison <jra@samba.org>

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed Apr 27 00:25:35 CEST 2011 on sn-devel-104
2011-04-27 00:25:34 +02:00
Volker Lendecke
531628e558 s3: Make cli_session_setup_nt1 async
Signed-off-by: Jeremy Allison <jra@samba.org>
2011-04-26 12:22:55 -07:00
Volker Lendecke
40e2ee9cb6 s3: Make plaintext session setup async
Signed-off-by: Jeremy Allison <jra@samba.org>
2011-04-26 12:22:55 -07:00
Volker Lendecke
ca5dcf2412 s3: guest sesssetup is only 13 words
(cherry picked from commit 69650a2aaa8649570261df7efccb35ad76d7cfc1)

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sat Apr 16 16:20:08 CEST 2011 on sn-devel-104
2011-04-16 16:20:08 +02:00
Volker Lendecke
e53dfebba0 s3: Remove some unused code
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sun Apr  3 18:32:51 CEST 2011 on sn-devel-104
2011-04-03 18:32:51 +02:00
Günther Deschner
2473c2fb1b s3-libsmb: put namequery headers to nmblib.h
We might find a better name for it and merge other namequery related things as
well here...

Guenther
2011-03-30 01:13:09 +02:00
Volker Lendecke
592c669d9d s3: Convert cli_raw_tcon to cli_smb
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sun Mar 27 19:50:21 CEST 2011 on sn-devel-104
2011-03-27 19:50:21 +02:00
Volker Lendecke
ffef3aa809 s3: Replace cli_negprot_sendsync() by cli_negprot_send() 2011-03-27 19:04:11 +02:00
Volker Lendecke
fc4095436f s3: Fix Coverity ID 2326, CHECKED_RETURN 2011-03-26 13:37:40 +01:00
Volker Lendecke
fec0baacb6 s3: Make is_zero_addr take a sockaddr_storage
All callers had to cast this anyway

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sun Feb 27 11:02:53 CET 2011 on sn-devel-104
2011-02-27 11:02:53 +01:00
Volker Lendecke
bfc4fe4012 s3: Remove unused "retry" from cli_start_connection
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Mon Dec 20 17:58:33 CET 2010 on sn-devel-104
2010-12-20 17:58:33 +01:00
Volker Lendecke
d096de56b1 s3: Remove unused "retry" from cli_full_connection 2010-12-20 17:10:58 +01:00
Andrew Bartlett
d97492e42a s3-libsmb Improve error message when denying LM encryption
Now that 'client ntlmv2 auth = yes' is the default, make it more clear
what options a user may need to enable to get this to work.

Andrew Bartlett
2010-12-14 01:10:21 +01:00
Andrew Bartlett
f13404e27b s3-libsmb Don't ever ask for machine$ principals as a target.
It is never correct to ask for a machine$ principal as the target of a
kerberos connection.  You should always connect via the
servicePrincipalName.

This current code appears to have built up from a series of minimal
changes, as the codebase adapted the to lack of a SPNEGO principal
from Windows 2008.

Andrew Bartlett
2010-12-10 16:08:31 +11:00
Andrew Bartlett
bb7806283e s3-libads Default to NOT using the server-supplied principal from SPNEGO
This principal is not supplied by later versions of windows, and using
it opens up some oportunities for man in the middle attacks.  (Becuase
it isn't the name being contacted that is verified with the KDC).

This adds the option 'client use spnego principal' to the smb.conf (as
used in Samba4) to control this behaivour.  As in Samba4, this
defaults to false.

Against 2008 servers, this will not change behaviour.  Against earlier
servers, it may cause a downgrade to NTLMSSP more often, in
environments where server names are not registered with the KDC as
servicePrincipalName values.

Andrew Bartlett
2010-12-10 16:08:30 +11:00
Jeremy Allison
03841f9e44 Fix bug #7698 - Assert causes smbd to panic on invalid NetBIOS session request.
Found by the CodeNomicon test suites at the SNIA plugfest.

http://www.codenomicon.com/

If an invalid NetBIOS session request is received the code in name_len() in
libsmb/nmblib.c can hit an assert.

Re-write name_len() and name_extract() to use "buf/len" pairs and
always limit reads.

Jeremy.
2010-09-26 03:01:03 -07:00
Jeremy Allison
d8814b1a48 Fix bug 7694 - Crash bug with invalid SPNEGO token.
Found by the CodeNomicon test suites at the SNIA plugfest.

http://www.codenomicon.com/

If an invalid SPNEGO packet contains no OIDs we crash in the SMB1/SMB2 server
as we indirect the first returned value OIDs[0], which is returned as NULL.

Jeremy.
2010-09-23 21:44:24 -07:00
Günther Deschner
c7fe04abc7 s3-build: only include async headers where needed.
Guenther
2010-09-20 13:54:42 -07:00
Sumit Bose
e2d6b64219 Fix array size of a memmber of struct cli_ulogoff_state
The too small array makes UID-REGRESSION-FIX fail on 32bit
architectures.

Signed-off-by: Günther Deschner <gd@samba.org>
2010-09-17 11:51:56 +02:00
Jeremy Allison
718fd39f10 Fox missing SMB_MALLOC return checks noticed by "Andreas Moroder <andreas.moroder@gmx.net>".
Jeremy.
2010-09-09 15:29:03 -07:00
Günther Deschner
ca765d2f50 s3-build: only include krb5 environment variables where required.
Guenther
2010-08-26 00:20:29 +02:00
Volker Lendecke
6cb5a0d097 s3: Remove some pointless wrapper functions 2010-08-05 13:57:31 +02:00
Andreas Schneider
ce2a086119 s3-popt: Only include popt-common.h when needed. 2010-08-05 12:08:31 +02:00
Günther Deschner
e7a6a3ec0d s3: avoid global include of ads.h.
Guenther
2010-08-05 00:32:02 +02:00
Jeremy Allison
5002b3a90d Add approriate TALLOC_CTX's thoughout the spnego code. No more implicit NULL contexts.
Jeremy.
2010-07-20 16:17:58 -07:00