1
0
mirror of https://github.com/samba-team/samba.git synced 2025-06-21 03:17:08 +03:00

411 Commits

Author SHA1 Message Date
Jeremy Allison
fe0ce8dd8e r6890: Refactor printing interface to take offset into job. Fixes bug
where large print jobs can have out-of-order offsets. Bug found
by Arcady Chernyak <Arcady.Chernyak@efi.com>
Jeremy.
(This used to be commit 482f7e0e3706098b71aa0b31a134994acb1e9fcf)
2007-10-10 10:56:56 -05:00
Gerald Carter
fd237d9903 r6490: BUG 1998: patch from Olaf Imig <Olaf.Imig@bifab.de>; fix byte ordering bug when storing 16-bit RAP print job ids
(This used to be commit 2c66a4098a3c9ca0a12160d4193d65085ece1dfe)
2007-10-10 10:56:42 -05:00
Gerald Carter
a49c567d4a r5993: compiler warning fix
(This used to be commit 4e8b868e6e29513a0c4c1b8992a502d5b6cf2c3d)
2007-10-10 10:56:14 -05:00
Gerald Carter
9b38ced168 r5950: more compiler warning's from Jason Mader
(This used to be commit 27c6e85ad59a86ab45ae3297c7445c4ff15546c8)
2007-10-10 10:56:10 -05:00
Gerald Carter
cacc3e1888 r5807: fix segfault after compiler warning clean up (and cleanup another warning)
(This used to be commit 2dae527e217ff9da2ad9f434bf1280744e93fad7)
2007-10-10 10:56:02 -05:00
Volker Lendecke
5918d8a311 r5770: Get rid of some compiler warnings
(This used to be commit 96a0f7d60c973e9f74ac90e3c79f94a01770f681)
2007-10-10 10:56:00 -05:00
Gerald Carter
ad4fe018c2 r5691: wrapping the pause/resume/purge printer commands in
{become,unbecome}_root() blocks.  We've already done
a print_access_check() to ensure the user is admin.
The means that non-root users can pause and manage printers.
I really don't see how this worked before without setuid
binaries on the server.

Also update print_queue_update() interface to allow an smbd
to update the print queue cache locally rather than going through
the bg lpq daemon.  This is needed for things like pjob_delete()
to ensure the cache is current for the specific client.
(This used to be commit f75369ec865f4ba1ae8201ae750c0f45158ed536)
2007-10-10 10:55:55 -05:00
Jeremy Allison
57e3af57fd r4662: Fix from "Jerome Borsboom" <j.borsboom@erasmusmc.nl> to fix
missing release reference for printer tdb.
Jeremy.
(This used to be commit 5942bb7737fe8efc452d59cda0d6e35e309c97b7)
2007-10-10 10:53:50 -05:00
Gerald Carter
d097ea4905 r4539: patch from Rob -- adding real printcap name cache function to speed up printcap reloads
(This used to be commit 1cad5250932b963c2eb9b775221b13db386d601b)
2007-10-10 10:53:46 -05:00
Gerald Carter
bc7142ce23 r4094: BUG 2107: fix memory bloating caused by large numbers of print_queue_updates() requests sent via messages.tdb
(This used to be commit 56b1110c71b17eeb2ebdb7d506d86deb6b81f0d5)
2007-10-10 10:53:34 -05:00
Jeremy Allison
acf9d61421 r4088: Get medieval on our ass about malloc.... :-). Take control of all our allocation
functions so we can funnel through some well known functions. Should help greatly with
malloc checking.
HEAD patch to follow.
Jeremy.
(This used to be commit 620f2e608f70ba92f032720c031283d295c5c06a)
2007-10-10 10:53:32 -05:00
Gerald Carter
90bd2b4fd0 r4028: * prevent the background LPQ daemon from updating
the print queue cache just because multiple smbd
  processes sent a message that it was out of date.

* add some extra debug messages while trying to track down
  down jobs being left in the queue after printing has
  completed.
(This used to be commit a64505d52fcb23374711e22b3df328c9a7848b84)
2007-10-10 10:53:28 -05:00
Jeremy Allison
79f7373b33 r3867: Fix from david.hu@hp.com - make a copy of an incoming message
rather than indirecting into it as a struct (may not be on an
even byte boundary). Bug #2052.
Jeremy.
(This used to be commit 8a91a69961622a31851f2394c591ddaa61a36000)
2007-10-10 10:53:22 -05:00
Gerald Carter
293136c04b r3067: patch based on volker's initial work in trunk that fixes the queu update problem when using the background daemon
(This used to be commit de7af09e727e744aa27af85ef7c0f73ed5c1550a)
2007-10-10 10:53:00 -05:00
Gerald Carter
5a8effaaae r2569: Patch from Rob Foehl <rwf@loonybin.net>:
- fix typo in libads/ldap_printer.c:39, ads_find_printer_on_server()
  (originally libads-typo.patch)
- fix leak in printing/nt_printing.c, is_printer_published()
  (originally is_printer_published-leak.patch)
- fix double print_backend_init() calls, now only called from main()
- restructuring in printing/nt_printing.c
  - replaced (un)publish_it() with ads-specific functions
  - moved common code to nt_printer_publish()
  - improved error handling in several places
- added check_published_printers() in printing/nt_printing.c, to verify
  that each published printer is actually in the directory at startup
- changed calling semantics of mod_a_printer, dump_a_printer, and
  update_driver_init to be more consistent with the rest of the api and
  reduce some copying
(This used to be commit 50a5a3dbd02acb0d09133b6e42cc37d091ea901d)
2007-10-10 10:52:46 -05:00
Gerald Carter
12172c91da r2191: ensure that we assign our pid to print jobs (and not our parent's pid); ensures that spooling jobs from dead smbds are removed from the tdb
(This used to be commit 9e42d016e1fee9ac999dadc383eb5db45ed79b00)
2007-10-10 10:52:35 -05:00
Gerald Carter
278f9467f2 r2133: Several fixes:
* BUG 1627: fix for NIS compiles on HPUX 11.00, AIX 4.3 and 5.1
  patch from Olaf Flebbe <o.flebbe@science-computing.de>.
  Will need to watch this one in the build farm.

* Fix bug found by rwf@loonybin.net where the PRINT_ATTRIBUTE_PUBLISHED
  was getting reset by attempts to sanitize the defined attributes
  (PRINTER_ATTRIBUTE_SAMBA)

* Resolve name conflict on DEC OSF-5.1 (inspired by patch from
  Adharsh Praveen <rprav@india.hp.com>)

* Work around parsing error in the print change notify code
  (not that the alignment bug is still there but reording the
   entries in the array works around it).

* remove duplicate declaration of getprintprocdir from rpcclient.
(This used to be commit 7474c6a446037f3ca2546cb6984d800bfc524029)
2007-10-10 10:52:32 -05:00
Gerald Carter
1842fde7d1 r1885: tighten the cache consistency with the ntprinters.tdb entry an the in memory cache associated with open printer handles; also make sure that register_messages_flags() doesn't overwrite the originally registers flags
(This used to be commit 540daf71d8ad189af5dd6d45aa1ce2b3d67da752)
2007-10-10 10:52:23 -05:00
Gerald Carter
d90c4a0462 r1384: ensure we remove the tdb entry for a job in the spooling state
(This used to be commit bc8cf6c852617b266f6dabed84bbd912a188f3a3)
2007-10-10 10:52:09 -05:00
Volker Lendecke
baf7cf42a6 r1295: To be able to send a message to the background queue updated, we need to be
root. Otherwise the USR1 signal will not be delivered.

Volker
(This used to be commit c66be874d8ce1f381518e07025305222bac1ab3a)
2007-10-10 10:52:04 -05:00
Gerald Carter
087868c499 r1230: (merges from HP PSA) fixing a couple of caching bugs in the printing code. (a) make sure to clear jobs_changed list when deleting a job and, (b) invalidate the printer handle cache when we get a notification that something has changed on that printer
(This used to be commit e3d4fea7808abc77bfdb1a540ab18afe04af5030)
2007-10-10 10:52:01 -05:00
Gerald Carter
7959cba656 r925: add changes frpm trunk (r841 and r842) -- enable background queue update process and allow printers to have different sharenames from printernames
(This used to be commit 066b9c4276a968788a03709a00d4f672ac032df7)
2007-10-10 10:51:49 -05:00
Jim McDonough
88adbfa1f7 r560: Fix bugzilla 1279: cannot control individual print jobs using cups
Store the print job using a little-endian key.
(This used to be commit e0491dae989ea289438de3bdf29d8810d409a01b)
2007-10-10 10:51:29 -05:00
Jim McDonough
ba8a59dbf4 r555: Fix big-endian storage of jobids in jobs_changed list. Found during
debugging of 1279
(This used to be commit 7c1cfb16c0b2f0128afca0b01036567253a3f92a)
2007-10-10 10:51:29 -05:00
Gerald Carter
dbb38cc6b5 merging print change notify fix from HP appliance. Also might address some one the issues in BUG 1007
(This used to be commit 17ecea4152fb0883acde675b01f19d3e19ff1d64)
2004-03-16 17:06:11 +00:00
Gerald Carter
dbe9e8a4cb fix byte ordering problem when storing the updating pid for the lpq cache; was causing an abort in process_exists() on solaris
(This used to be commit 26681cd2a1567d90cc7d344e8aca6e6a686053f5)
2004-03-15 15:06:33 +00:00
Gerald Carter
cb49c07c98 fix compiler warning
(This used to be commit df19b6066e1f4e200adcd80f9526aa1a68509580)
2004-03-05 17:39:38 +00:00
Gerald Carter
ef36785beb allow the 'printing' parameter to be set on a per share basis.
The problem was that the current_printif struct was set during
print_backend_init() based on the 'printcap name'.  So you could
not use cups and then override the setting for a specific printer
by setting 'printing = bsd' (a common setup for pdf generation
print services.

There is a subtle change in behavior in that the print
interface functions are selecting on the basis of lp_printing()
and not lp_printcap_name(), but the new behavior seems more
intuitive IMHO.
(This used to be commit 14de9c065787bd1675021a6cd6555f81ea965f17)
2004-03-02 14:26:45 +00:00
Gerald Carter
1fe6e29637 BUG 1147; bad pointer case in get_stored_queue_info() causing seg fault
(This used to be commit 91af1fb73a2e86a343c085128aaed2ef0c26de57)
2004-03-01 17:03:05 +00:00
Gerald Carter
bb104f31d5 bug 770; correct fix this time; Make sure that we send the SMBjobid for unix jobs back to the client. Allows windows client to remove print jobs submitted from lpr
(This used to be commit 514561118860f982c458930c34763dac9ce0554e)
2004-01-14 20:56:26 +00:00
Gerald Carter
e7615b5776 bug 660; using byte order safe macros (or tdb_unpack) when reading 2 or 4 byte values from a tdb buffer
(This used to be commit be9f25bea94415af6b631a9c6e7af28d9d6e6565)
2004-01-14 19:12:06 +00:00
Gerald Carter
038784aa80 don't mistake pre-existing UNIX jobs for smb jobs; patch from SATOH Fumiyasu bug 770
(This used to be commit 3a55788dca537248d0aea9973a84075e142b7736)
2003-12-01 18:02:05 +00:00
Gerald Carter
055750f090 allow users to delete jobs with cups printing backend
The changes the name of the job passed off to cups
from "Test Page" to "smbprn.00000033 Test Page" so that
we can get the smb jobid back from lpq.  Working on bug
770.
(This used to be commit 5979f4d645e84fb22223e6cbf0043f2fa21acb2f)
2003-11-25 19:16:35 +00:00
Gerald Carter
281e293331 * Fix from SATOH Fumiyasu for bug 660 (failing to view print
jobs) by only enforce the 'max reported print jobs' parameter
  when it is non-zero.

* Fixed bug 338 by making sure that data values are written
  out when we are marshalling an EnumPrinterDataEx() reply.
  This probably fixes other bugs reported against point-n-print
  feature in 3.0.0
(This used to be commit fd98af75d655449a677360f6991da5caabc88b4d)
2003-11-13 20:15:17 +00:00
Andrew Tridgell
e1c468477c a small include file rearrangement that doesn't affect normal
compilation, but that allows Samba3 to take advantage of pre-compiled
headers in gcc if available.
(This used to be commit b3e024ce1da7c7e24fcacd8a2964dd2e4562ba39)
2003-11-12 01:51:10 +00:00
Gerald Carter
8ce241cb80 fix unitiailized timestamp where merging print_jobs and lpq listing
(This used to be commit 8382cd6796992e55bf10f381089cb740052a0bca)
2003-09-11 17:01:26 +00:00
Gerald Carter
c674e411c7 i guess i'm the only one this ever annyoed...
fix the confusion when we tdb_lock_bystring() but
we retrieve an entry using tdb_fetch_by_string.
It's now always tdb.*bystring()
(This used to be commit 66359531b89368939f0e8f584a45844b5f2f99e7)
2003-07-10 20:37:01 +00:00
Gerald Carter
fb5a006c09 fix typos in log messages and comments.
(This used to be commit fd24183ec30688f3699e466bd4d908b24918e328)
2003-07-01 05:45:16 +00:00
Jeremy Allison
cf00ce3e87 Fix mem leak. Spotted by tpot (thanks Tim).
Jeremy.
(This used to be commit 03a1f46e3448913cc21ed89aafaa22818d4026d0)
2003-04-16 08:46:03 +00:00
Jeremy Allison
6e0bd81f44 Grr. Get rid of one of the extra NULL's that crept in from app-head.
Spotted by Andrew Esh.
Jeremy.
(This used to be commit 9e6e6c3f50844cf4322d6dd193c4e24b76bae9ba)
2003-04-10 19:34:52 +00:00
Jeremy Allison
7991cf1e52 Fix the new storage code to correctly convert from system queue info to
pjob info. Ensure we retrieve more than one job from the storage code.
Jeremy.
(This used to be commit 59be98401c5a8b419597c18acbe996b469bbe89a)
2003-04-04 01:02:20 +00:00
Jeremy Allison
a9b39993fa Subtle changes to message handling after ENUMJOBS.
Jeremy.
(This used to be commit e5e83544dc0acf812bfa5ea17960b5a6be954ca1)
2003-04-02 02:31:51 +00:00
Jeremy Allison
5ab2abd707 Fix extra NULL arg added during app-head merge.
Jeremy.
(This used to be commit b2ef052adad01c37f0fd4b9b82a16a9989d57082)
2003-03-26 19:35:37 +00:00
Jeremy Allison
67df8fb300 Merge of new appliance-head scalable printing fixes.
Jeremy.
(This used to be commit 331e621b580f997592892be0226fb452c67ae9e1)
2003-03-21 22:00:21 +00:00
Jeremy Allison
3be18a1fba lib/messages.c: Check return from chainlock before modifying message queue.
Apply the job returned limit across all requests for job queues.
Jeremy.
(This used to be commit bf795b684e608f82db822e0759e7b69afd451b65)
2003-03-20 00:52:37 +00:00
Jeremy Allison
0bf15545dd Ensure added jobs increment total_jobs.
Jeremy.
(This used to be commit a75d9fc4e1c26e3ae15a97508f6f1cf69fe54148)
2003-03-01 00:49:00 +00:00
Jeremy Allison
647d65e08b Bit of a hack job to prevent smbprn.XXX jobs appearing in the queue if the
jobid is below the UNIX_JOB_START number.
Jeremy.
(This used to be commit 7ec1c8869d3df9af77ff95942beba34f56a06b73)
2003-02-19 01:43:33 +00:00
Jeremy Allison
4703248a8e Ensure we return NOSPACE if we can't fast allocate a print job.
Jeremy.
(This used to be commit 82cf8aa74794649fb16c336011ca48d549d6abb8)
2003-02-08 01:04:43 +00:00
Jeremy Allison
42edbfe918 Hold the lock for a much shorter time when allocating a new jobid.
Jeremy.
(This used to be commit 62e274abbb0ceec90c97c022fa14d96bdf574121)
2003-02-04 23:52:49 +00:00
Jeremy Allison
920287bf6b More scalable print tdb fixes.
Jeremy.
(This used to be commit 7ace900b335e83b447cab63137968806a8e2f4d3)
2003-01-30 23:26:49 +00:00