1
0
mirror of https://github.com/samba-team/samba.git synced 2025-08-06 17:32:29 +03:00
Commit Graph

27 Commits

Author SHA1 Message Date
7f88ad3efc s4:dsdb/subtree_delete: delete from the leafs to the root (bug #7711)
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
2012-11-30 17:17:21 +01:00
5dd4555f39 s4:dsdb/subtree_delete: do the recursive delete AS_SYSTEM/TRUSTED (bug #7711)
Now that the acl module checks for SEC_ADS_DELETE_TREE,
we can do the recursive delete AS_SYSTEM.

We need to pass the TRUSTED flags as we operate from
the TOP module.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
2012-11-30 17:17:21 +01:00
60192fd100 s4:dsdb/subtree_delete: do an early return and avoid some nesting
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
2012-11-30 17:17:21 +01:00
87f3151047 s4-dsdb: pass parent request to dsdb_module_*() functions
this preserves the request hierarchy for dsdb_module_*() calls inside
dsdb ldb modules

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2011-01-17 05:23:04 +01:00
9103047782 s4-ldb: enable version checking in dsdb ldb modules 2010-11-01 13:05:04 +00:00
7eb2eed156 s4-dsdb: convert the rest of the ldb modules to the new module type 2010-11-01 18:55:19 +11:00
1f73f3b1ca dsdb modules: Split ridalloc out of common helpers, because of dependency loops. 2010-10-11 01:06:35 +02:00
aabfb7162c s4:subtree_delete LDB module - remove the DN from an error message
It may looks funny but the DN output prevents older ADUC versions (tested with
release 2000) to perform subtree deletes properly. Version 2008 has this fixed.

Additionally some smaller changes ("%u" for printing unsigned integers,
module name prefix, nicer line-wrap).

Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Tue Oct  5 16:48:19 UTC 2010 on sn-devel-104
2010-10-05 16:48:19 +00:00
2b4f652899 s4:subtree_delete LDB module - it is only responsible for non-deleted objects
The deleted objects (tombstones, recycled & deleted objects) are handled by
"repl_meta_data".

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2010-10-03 15:23:18 +00:00
87df785a68 s4-dsdb: use ldb_operr() in the dsdb code
this replaces "return LDB_ERR_OPERATIONS_ERROR" with "return ldb_operr(ldb)"
in places in the dsdb code where we don't already explicitly set an
error string. This should make is much easier to track down dsdb
module bugs that result in an operations error.
2010-07-07 20:14:55 +10:00
7d483cdc04 s4:subtree_delete LDB module - fix comments and add my copyright
(I've introduced the subtree delete mechanism)
2010-07-04 22:05:17 +02:00
682f7a5338 s4-source4/dsdb/samdb/ldb_modules/subtree_delete.c: Use DSDB_FLAG_NEXT_MODULE flag
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2010-07-02 10:08:02 +10:00
fbd0902958 s4:subtree_delete LDB module - now do support tree delete operations 2010-06-20 18:52:30 +02:00
b03637cb9e dsdb: Fix includes when building against system ldb. 2010-06-19 14:46:22 +02:00
ccaf0c6038 dsdb: Use Samba includes so _PUBLIC_ is defined. 2010-06-19 13:55:41 +02:00
238e89f7b0 dsdb: Make module ops struct for each module public. 2010-06-19 13:46:39 +02:00
a8d6549ccc s4:subtree_delete - "NULL" as format string isn't allowed on FreeBSD
I changed the format string into "(objectClass=*)" which should be an
equivalent expression for choosing all available objects.

Consider bug 7115 for the issue.
2010-02-08 12:08:36 +01:00
5d7805b07f s4-dsdb: greatly simplify the subtree_delete module
We can use dsdb_module_search() to make this much simpler

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2009-12-18 21:03:40 +11:00
75eff6eaf3 s4:subtree_delete - Make the initialisation of the child counter more clear 2009-10-08 00:18:07 +02:00
5107f6fd0a s4:subtree delete module - Cosmetic adaptions 2009-09-07 08:37:25 +02:00
380874ef86 Fix the mess with ldb includes.
Separate again the public from the private headers.

Add a new header specific for modules.
Also add service function for modules as now ldb_context and ldb_module are
opaque structures for them.
2009-01-30 01:02:03 -05:00
51baa8deec LDB ASYNC: samba4 modules 2008-09-29 04:22:20 +02:00
e0c90d6131 Fix some valgrind issues.
These small changes seem to fix some of the early issues in 'make
valgrindtest'

Previously, the subtree_delete code didn't pass on the timeout,
leaving it uninitialised.

The ldap_server/ldap_backend.c change tidies up the talloc hierarchy a
bit.

Andrew Bartlett
(This used to be commit 95314f29a9)
2008-03-29 11:18:00 +11:00
16109a40c0 Use struct-based rather than function-based initialization for ldb modules everywhere.
(This used to be commit 85c96a3258)
2008-02-20 01:54:32 +01:00
9bdc1194da r26283: fix typo
(This used to be commit 7d1169b52b)
2007-12-21 05:48:08 +01:00
d4fbd381fa r26282: These modules expect errors, but if we don't wipe the error string, we
get phony error strings at the caller, which is very confusing.

Andrew Bartlett
(This used to be commit 9ac7f4f609)
2007-12-21 05:48:07 +01:00
5d4f507a65 r25942: Make various ldb modules handle an LDB backend that enforces validity
of Base DNs in searches (returning an error of LDB_ERR_NO_SUCH_ENTRY).

We need to handle this if ldb_tdb is to behave correctly compared with
LDAP, as well as if we are using an LDAP backend.

In doing so, I realised that subtree_rename and subtree_delete
(prevention) need rather different wait loops, so it seemed easier to
split it out into it's own module.

I've fixed the licence on both of these modules to be GPLv3.

Andrew Bartlett
(This used to be commit d3894c90f3)
2007-12-21 05:45:11 +01:00