1
0
mirror of https://github.com/samba-team/samba.git synced 2025-07-23 20:59:10 +03:00
Commit Graph

90 Commits

Author SHA1 Message Date
66ee744ccb s4-registry: Don't leak memory on error.
Reviewed-by: Alexander Bokovoy <ab@samba.org>
2013-02-22 16:36:14 +01:00
24ed8c5924 regshell: Fix a counter that can actually be non-zero.
This was a regression caused by one of the unsigned patches.

Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Wed Feb  8 16:00:22 CET 2012 on sn-devel-104
2012-02-08 16:00:22 +01:00
0ff7e0c998 samba: share readline wrappers among all buildsystems.
Guenther
2010-10-01 22:30:22 +02:00
2c325236be s4:regshell - fix an "asprintf" 2010-05-28 10:04:46 +02:00
8ddb4f6c84 s4:regshell - don't use negative exit codes 2010-05-28 10:04:45 +02:00
f9ca9e46ad Finish removal of iconv_convenience in public API's. 2010-05-18 11:45:30 +02:00
43170dafbc s4:registry - adaptions for "add memory contexts for delete value/key functions" 2010-03-22 22:31:00 +01:00
6c39b10f1d s4:regshell - here we don't need a newline - "ctime" itself provides one 2010-03-21 16:02:36 +01:00
d4425ecea5 s4:regshell - don't return an error code if we get a security descriptors error
s4 itself doesn't support them so print only the error code out (in s4's case
WERR_NOT_SUPPORTED).
2010-03-21 15:56:26 +01:00
89ab6818e1 s4:libregistry - change counters to be "unsigned"
Also the s4 registry library has to have "unsigned" counters like the Windows
one.
2010-03-06 17:48:25 +01:00
3eacc83b35 Spelling fixes for source4/lib/registry.
Signed-off-by: Matthias Dieter Wallnöfer <mwallnoefer@yahoo.de>
2010-02-22 21:45:37 +01:00
9af1c6db0f regshell: Add support for 'cd ..' and cd relative to the root.
Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
2009-09-26 17:05:34 +02:00
0c3bc60a01 s4:lib/registry: s/new/nkey
metze
2009-02-02 13:09:18 +01:00
183c379fe5 s4:lib/tevent: rename structs
list=""
list="$list event_context:tevent_context"
list="$list fd_event:tevent_fd"
list="$list timed_event:tevent_timer"

for s in $list; do
	o=`echo $s | cut -d ':' -f1`
	n=`echo $s | cut -d ':' -f2`
	r=`git grep "struct $o" |cut -d ':' -f1 |sort -u`
	files=`echo "$r" | grep -v source3 | grep -v nsswitch | grep -v packaging4`
	for f in $files; do
		cat $f | sed -e "s/struct $o/struct $n/g" > $f.tmp
		mv $f.tmp $f
	done
done

metze
2008-12-29 20:46:40 +01:00
04f29b84a4 Registry client library: Fixes the creation of new keys
Giving the right permissions
2008-09-21 23:17:59 +02:00
92e1574d3d Registry tools "regshell" and "regtree": Small fixup's
I fixed up my fault regarding the handling of the default value (if it doesn't exist
it hasn't the index number zero and you get immediately the subvalues). Then I corrected an error in regshell to find the right registry context.
2008-09-21 23:17:59 +02:00
a2d8ccad73 Registry tool "regshell": Handle the default attribute in the right way
This commit introduces the default attribute in "regshell"
2008-09-21 23:17:58 +02:00
3911808323 Fix up the "reg_common_open_remote" call
This fixes up the "reg_common_open_remote" call because it didn't work anymore without the event context.
(This used to be commit 42ab865fc9)
2008-09-09 18:03:54 +02:00
8b6b851390 Two useful "regshell" improvements
This patch corrects the "change key" command (Follow up isn't supported yet) and adds a newline in a error message.
(This used to be commit d1052dc42e)
2008-09-09 18:01:20 +02:00
2daf2897d5 Use a custom init function for samba4 that sets a samba4
specific debug function.
By default do not debug, this is the most appropriate action for a library
as we cannot assume what stderr is use for in the main app.
The main app is responsible to set ev_debug_stderr if they so desire.
(This used to be commit e566a2f308)
2008-06-14 13:00:53 -04:00
21fc767378 Specify event_context to ldb_wrap_connect explicitly.
(This used to be commit b4e1ae07a2)
2008-04-17 12:23:44 +02:00
48307b54f9 Remove more uses of global_loadparm.
(This used to be commit 3430cc6097)
2008-02-21 16:01:19 +01:00
d82b6dd09a Fix switching of hives in regshell (#5254)
(This used to be commit 5f33545c78)
2008-02-11 11:48:43 +01:00
47f6bbf8cf r26689: registry: Return max_subkeynamelen, max_valnamelen and max_valbufsize in getkeyinfo().
(This used to be commit b06896d237)
2008-01-07 08:18:07 -06:00
43ac3d9b44 r26453: Janitorial: Don't use a static char[] in smb_readline_replacement.
Fix up callers to free the memory returned, as that is needed if we use the
original readline function as well.
(This used to be commit c81ead1c38)
2007-12-21 05:50:18 +01:00
96a200511e r26443: Remove global_loadparm instances.
(This used to be commit 8242c69623)
2007-12-21 05:50:11 +01:00
b65dba2245 r26355: Eliminate global_loadparm in more places.
(This used to be commit 5d589a0d94)
2007-12-21 05:49:01 +01:00
bca631be1f r26329: Fix more loadparm_context references. Only about a 100 left now.
(This used to be commit ddf233346d)
2007-12-21 05:48:42 +01:00
6c999cd123 r26236: Remove more uses of global_loadparm or specify loadparm_context explicitly.
(This used to be commit 5b29ef7c03)
2007-12-21 05:47:15 +01:00
33032276f5 r25603: More reformat.
Guenther
(This used to be commit 176614423e)
2007-12-21 05:42:48 +01:00
cd962355ab r25000: Fix some more C++ compatibility warnings.
(This used to be commit 08bb1ef643)
2007-10-10 15:05:27 -05:00
2cd9215e77 r24725: Don't segfault if hive file can't be found
(This used to be commit 2daa8fa88d)
2007-10-10 15:02:57 -05:00
b409d4120f r24667: Finally merge the registry improvements that Wilco Baan Hofman and I have
been working on for at least half a year now. Contains the following
improvements:

 * proper layering (finally!) for the registry library. Distinction is
   now made between 'real' backends (local, remote, wine, etc) and
   the low-level hive backends (regf, creg, ldb, ...) that are only used
   by the local registry backend
 * tests for all important hive and registry operations
 * re-enable RPC-WINREG tests (still needs more work though, as
							   some return values aren't checked yet)
 * write support for REGF files
 * dir backend now supports setting/reading values, creating keys
 * support for storing security descriptors
 * remove CREG backend as it was incomplete, didn't match the data model
   and wasn't used at all anyway
 * support for parsing ADM files as used by the policy editor (see lib/policy)
 * support for parsing PREG files (format used by .POL files)
 * new streaming interface for registry diffs (improves speed and memory usage
	for regdiff/regpatch significantly)

   ... and fixes a large number of bugs in the registry code
(This used to be commit 7a1eec6358)
2007-10-10 15:02:34 -05:00
0479a2f1cb r23792: convert Samba4 to GPLv3
There are still a few tidyups of old FSF addresses to come (in both s3
and s4). More commits soon.
(This used to be commit fcf38a38ac)
2007-10-10 14:59:12 -05:00
4f0c0997ce r21834: Remove unnecessary includes
(This used to be commit 7d10e192ca)
2007-10-10 14:49:34 -05:00
655b710204 r18584: found one of the fd leaks. The registry backend was using a
talloc(NULL, xxx) to allocate the registry context. That had two
consequences

1) it was a massive memory leak, as all winreg operations leaked their
   entire context (including an open ldb database) every time

2) event_context_find() never found the exsting event context, so we
   used a new event context each time, which called epoll_create()
   each time, which caused a fd to be allocated
(This used to be commit 1c0a3de398)
2007-10-10 14:18:52 -05:00
873749f218 r18168: Use {NULL} rather than POPT_TABLEEND, which is not always available.
(This used to be commit 8b622c5ded)
2007-10-10 14:17:45 -05:00
73da6bf6da r15806: Remove some unnecessary nesting making the function harder to read.
(This used to be commit 2e1ce01899)
2007-10-10 14:08:25 -05:00
72a5cbadc1 r15406: Move 'smbreadline' out of libreplace as it doesn't replace functionality
not available on some platforms but is a Samba-specific library.
(This used to be commit e9d3660fa6)
2007-10-10 14:05:33 -05:00
e595ede02f r15375: Rename readline.h to smbreadline.h avoid clashes with system header.
(This used to be commit ccc3d8a954)
2007-10-10 14:05:29 -05:00
47bf79eac5 r15370: Fix more dependencies for shared libs
(This used to be commit 9a518661fb)
2007-10-10 14:05:27 -05:00
ad53de9d59 r15364: Use global list of predefined keys
(This used to be commit eee9e33442)
2007-10-10 14:05:26 -05:00
5f64fcf473 r14981: fixed a use of a wild ptr in regshell
(This used to be commit 868deaf89f)
2007-10-10 14:00:50 -05:00
d64ccc0176 r14599: Pass ACLs down the registry layer.
(This used to be commit 6cdefd8945)
2007-10-10 13:58:59 -05:00
35349a58df r14542: Remove librpc, libndr and libnbt from includes.h
(This used to be commit 51b4270513)
2007-10-10 13:58:42 -05:00
8528016978 r14464: Don't include ndr_BASENAME.h files unless strictly required, instead
try to include just the BASENAME.h files (containing only structs)
(This used to be commit 3dd477ca51)
2007-10-10 13:57:27 -05:00
7a121583b4 r14349: Kill proto.h!
Prototypes are now spread over multiple headers, usually one per subsystem.
This change is required to allow proper header dependencies later on,
without recompiling Samba each time the mtime of any source file changes.
(This used to be commit 3da79bf909)
2007-10-10 13:57:14 -05:00
f8fdbc967c r13944: Yet another round of splitups.
(This used to be commit f87debeb12)
2007-10-10 13:52:31 -05:00
aa9f67163c r12620: Get rid of automatically generated lists of init functions of subsystems.
This allows Samba libraries to be used by other projects (and parts of
Samba to be built as shared libraries).
(This used to be commit 44f0aba715)
2007-10-10 13:49:06 -05:00
d4de4c2d21 r12608: Remove some unused #include lines.
(This used to be commit 70e7449318)
2007-10-10 13:49:03 -05:00