1
0
mirror of https://github.com/samba-team/samba.git synced 2025-12-07 20:23:50 +03:00
Commit Graph

2486 Commits

Author SHA1 Message Date
Volker Lendecke
128260527b r16153: Fix possible NULL dereference found by Klocwork # 252 2007-10-10 11:17:23 -05:00
Günther Deschner
e018ea3d1d r16122: As we use 'inetOrgPerson' as structural objectclass for new accounts for
eDir, we already add 'sn' as required attribute on LDAP add
operations.

When we modify an entry, we need to request 'sn' as well in our
attribute lists, so that we don't try to add it a second time.

Guenther
2007-10-10 11:17:21 -05:00
Jim McDonough
00eb42791a r16047: Remove unnecessary line, as this value is set in either branch of the
'if' below.  Spotted by Aleksey Fedoseev.
2007-10-10 11:17:18 -05:00
Volker Lendecke
91534146b4 r16046: Hmmm. I don't fully understand popt, but this is necessary for smbclient to
show a prompt again :-)

James, could you check that this is ok? I think this was part of your Revision
15848.

Thanks,

Volker
2007-10-10 11:17:18 -05:00
Jeremy Allison
b65c646865 r16017: Add Samba4 replacement for timegm to work
on Solaris.
Jeremy.
2007-10-10 11:17:17 -05:00
Jeremy Allison
93dd476a91 r15995: Make smbldap obey config tests. Patch from "John E. Malmberg"
<wb8tyw@qsl.net>.
Jeremy.
2007-10-10 11:17:17 -05:00
James Peach
bf3b71c845 r15848: Introduce commandline options to set the remainder of the parameters in
dynconfig.c. This is mainly useful for test harness scripts, hence the
lack of short options.
2007-10-10 11:17:11 -05:00
Jeremy Allison
f6c110ddb8 r15838: Back-port tridge's talloc fixes (r15824, r15828) from Samba4.
Jeremy.
2007-10-10 11:17:10 -05:00
Jeremy Allison
e5787cf75b r15700: Make nmbd udp sockets non-blocking to prevent problem
with select returning true but no data being available.
Fix for bug #3779.
Jeremy.
2007-10-10 11:17:08 -05:00
Jeremy Allison
24aaa48677 r15672: Fix for bug #3783. winbindd_cm.c calls open_any_socket_out()
to make connections to ports 445 or 139 on the DC it's trying
to contact. It calls sys_select() on the non-blocking sockets,
not sys_select_intr(). This is a mistake (I believe) as it allows
a signal to early terminate the connection attempts - whereas
sys_select_intr() will ignore signals until we get back to
the main processing loop where they'll be handled correctly.
This change means winbindd_cm will not early terminate if it
gets a message whilst trying to connect to DC's.
Gunther, Volker and Jerry please review (but I think this
is correct).
Jeremy.
2007-10-10 11:17:06 -05:00
James Peach
3446ee5c00 r15655: Log the result of module initialisation if it fails. 2007-10-10 11:17:05 -05:00
Günther Deschner
1b5a712467 r15633: Minor smbldap/pdb_ldap cleanup
Guenther
2007-10-10 11:17:04 -05:00
James Peach
b591892800 r15631: Add a new option "enable core files". Administrators can use this to
disable automatic core file dumping. Core files are enabled by default.
2007-10-10 11:17:03 -05:00
Gerald Carter
e439660f91 r15525: fix compile error on HP-UX reported by Ryan Novosielski 2007-10-10 11:16:56 -05:00
James Peach
624318245f r15509: Preserve errno in fcntl lock wrappers. 2007-10-10 11:16:55 -05:00
James Peach
d448629282 r15508: Use clock_gettime for profiling timstamps if it is available. Use
the fastest clock available on uniprocessors.
2007-10-10 11:16:55 -05:00
Volker Lendecke
8cdfe404ef r15494: Fix debug statement 2007-10-10 11:16:54 -05:00
James Peach
e7ddcd8c33 r15449: Remove unused function get_nttime_max (which claims it
is incorrect).
2007-10-10 11:16:46 -05:00
James Peach
e817cfd7d3 r15446: Tidy up the formatting of locking debug messages and make it more
consistent. Bring oplocks withing the purview of the locking debug
channel.
2007-10-10 11:16:45 -05:00
Günther Deschner
5557ada694 r15305: Let winbind search by sid directly (or in windows terms: "bind to a
sid"); works in all AD versions I tested. Also add "net ads sid" search
tool.

Guenther
2007-10-10 11:16:33 -05:00
Paul Green
17774387ad r15283: Oh yeah. The build farm doesn't do much with head. OK, here is the patch to SAMBA_3_0 to declare prototypes for the initialization functions. These are the same changes I just made to head. --paulg 2007-10-10 11:16:31 -05:00
Günther Deschner
4330d1b74c r15251: Adding PreWin2kAccess builtin sid.
Guenther
2007-10-10 11:16:30 -05:00
Volker Lendecke
b9c6e3f556 r15101: Little step towards getting Samba4 tdb into 3: tdb_lock_bystring does not
have the timeout argument in Samba4. Add a new routine
tdb_lock_bystring_with_timeout.

Volker
2007-10-10 11:16:23 -05:00
Jeremy Allison
23dcff4d50 r15084: Try and squeeze more out of the non-read/write code path.
Jeremy.
2007-10-10 11:16:22 -05:00
James Peach
256a19d722 r15047: Add support for using libunwind to generate a backtrace. This is
primarily intended for ia64 systems where libunwind knows more about
the different ways of walking the stack that just about anything else.
2007-10-10 11:16:00 -05:00
Günther Deschner
0fed66926f r15041: Adding rpc client calls to manipulate auditing policies on remote CIFS
servers. Also add a new "net rpc audit" tool. The lsa query infolevels
were taken from samb4 IDL, the lsa policy flags and categories are
partly documented on msdn. I need to cleanup the double
lsa_query_info_policy{2}{_new} calls next.

Guenther
2007-10-10 11:15:59 -05:00
Jeremy Allison
1217ed392b r15030: On a performace hunt... Remove as many extraneous
memset's as possible.
Jeremy.
2007-10-10 11:15:58 -05:00
Jeremy Allison
08e52ead03 r15018: Merge Volker's ipc/trans2/nttrans changes over
into 3.0. Also merge the new POSIX lock code - this
is not enabled unless -DDEVELOPER is defined.
This doesn't yet map onto underlying system POSIX
locks. Updates vfs to allow lock queries.
Jeremy.
2007-10-10 11:15:57 -05:00
Jeremy Allison
68d100830c r15005: Fix printf args to remove warnings.
Jeremy.
2007-10-10 11:15:55 -05:00
Gerald Carter
1e0b79e591 r15003: patch based on code from Arkady Glabek <aglabek@centeris.com> to ensure that global memory is freed when unloading pam_winbind.so (needs more testing on non-linux platforms) 2007-10-10 11:15:55 -05:00
James Peach
56bc02d644 r14898: This change is an attempt to improve the quality of the information that
is produced when a process exits abnormally.

First, we coalesce the core dumping code so that we greatly improve our
odds of being able to produce a core file, even in the case of a memory
fault. I've removed duplicates of dump_core() and split it in two to
reduce the amount of work needed to actually do the dump.

Second, we refactor the exit_server code path to always log an explanation
and a stack trace. My goal is to always produce enough log information
for us to be able to explain any server exit, though there is a risk
that this could produce too much log information on a flaky network.

Finally, smbcontrol has gained a smbd fault injection operation to test
the changes above. This is only enabled for developer builds.
2007-10-10 11:15:53 -05:00
Gerald Carter
021b3dc2db r14868: I will not write code when changing to Daylight Savings Time.
I will not write code when changing to Daylight Savings Time.
I will not write code when changing to Daylight Savings Time.
I will not write code when changing to Daylight Savings Time.
I will not write code when changing to Daylight Savings Time.
I will not write code when changing to Daylight Savings Time.
I will not write code when changing to Daylight Savings Time.
I will not write code when changing to Daylight Savings Time.
I will not write code when changing to Daylight Savings Time.

...

Fix my brain dead inverted logic for turning winbindd on and off
when run on a DC or when calling pdb functions from within winbindd.
2007-10-10 11:15:52 -05:00
Gerald Carter
4ab372f4ca r14855: Various fixes:
* depreacte 'acl group control' after discussion with Jeremy
  and implement functionality as part of 'dos filemode'
* fix winbindd on a non-member server to expand local groups
* prevent code previously only used by smbd from blindly
  turning _NO_WINBINDD back on
2007-10-10 11:15:51 -05:00
Jeremy Allison
7a18f38947 r14764: Fix possible null pointer deref. Coverity #253.
Jeremy.
2007-10-10 11:15:47 -05:00
Jeremy Allison
ba9c98983e r14751: Use the noreturn attribute to try and tell coverity that
smb_panic can't return.
Jeremy.
2007-10-10 11:15:45 -05:00
Jeremy Allison
fd98427f64 r14746: Add the Samba4 replacements for opendir/readdir etc. to
Samba3 - with some 64-bit macro madness. Attempt to fix
the broken directory handling in the *BSD-of-the-month
club.
Jeremy.
2007-10-10 11:15:45 -05:00
Jeremy Allison
bc1a605a39 r14703: Clarify the return codes for the POSIX locking case. This
was confusing.
Jeremy.
2007-10-10 11:15:44 -05:00
James Peach
514a767c57 r14668: Set the FILE_STATUS_OFFLINE bit by observing the events a DMAPI-based
HSM is interested in. Tested on both IRIX and SLES9.
2007-10-10 11:15:42 -05:00
Stefan Metzmacher
c3a9f30e2a r14618: add --no-process-group to all server programms
to make the following possible:

timelimit 20000 bin/nmbd -F -S --no-process-group
timelimit 20000 bin/smbd -F -S --no-process-group

this is needed to 'make test' working without losing child processes

metze
2007-10-10 11:15:39 -05:00
James Peach
763f4c0148 r14600: Refactor capability interface from being IRIX-specific to using only
the POSIX interface. Note that this removes support for inherited
capabilities. This wasn't used, and probably should not be.
2007-10-10 11:15:39 -05:00
Stefan Metzmacher
7cf4ad8899 r14522: sync socket_wrapper code with samba4
metze
2007-10-10 11:15:36 -05:00
Jeremy Allison
3c33eda430 r14462: Fix warning. ber_tag_t is an unsigned int for
printing purposes.
Jeremy.
2007-10-10 11:15:31 -05:00
Jeremy Allison
f3879dd6bb r14454: Janitor for tridge - same code exists in Samba3 and 4.
Jeremy.
-----------------------------
fixed an hmac-md5 error for keys longer than 64 (using deallocated
stack variable)
2007-10-10 11:15:31 -05:00
Gerald Carter
b617091060 r14432: Give in and grant BUILT\Administrators all privileges 2007-10-10 11:15:30 -05:00
Jeremy Allison
4a4953c4d2 r14397: Fix deadcode in coverity error #1.
Jeremy.
2007-10-10 11:15:28 -05:00
Jeremy Allison
8444c997bd r14393: Fix a couple of AIX warnings.
Jeremy.
2007-10-10 11:15:28 -05:00
Jeremy Allison
f65d7afe19 r14387: Try and fix the coverity issues (#53, #54) with negative
sink by ensuring all uses of rpcstr_push are consistent
with a size_t dest size arg.
Jeremy.
2007-10-10 11:15:27 -05:00
Jeremy Allison
9a1e35079a r14345: Fix Coverity #71. We don't currently propagate *any*
alloc error back up the stack from smbldap_set_mod()
so ensure we abort correctly.
Jeremy.
2007-10-10 11:15:26 -05:00
Jeremy Allison
7520a8d2a1 r14342: Fix coverity #68, resource leak on error path.
Jeremy.
2007-10-10 11:15:26 -05:00
Jeremy Allison
1e1bae7afd r14292: Janitor for tridge (samba3 talloc is almost identical
to Samba4 talloc).
Jeremy

 - make the snprintf call in talloc portable to older solaris boxes

 - fixed an error found sing the beam analyser
2007-10-10 11:15:23 -05:00