1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-12 09:18:10 +03:00
Commit Graph

2059 Commits

Author SHA1 Message Date
Simo Sorce
36b2f6c932 untest fix for wide links parameter bug.
it work properly on 2.2 and the patch apply so I think it should be ok.
0001-01-01 00:00:00 +00:00
Andrew Bartlett
69e94440cd Non-error connection numbers are always positive 0001-01-01 00:00:00 +00:00
Jeremy Allison
4ae130bfa8 Add 3 second timeout when terminating server and sending print notify
messages. Stops build-up of large numbers of smbd's waiting to terminate
on large print throughput.
Jeremy.
0001-01-01 00:00:00 +00:00
Jeremy Allison
d1e8991a76 Fix for interesting resource constraint condition. When all opens are
level 2 and a request for open with no oplock is received then the
smbd should send *synchronous* break messages, not asynchronous,
otherwise it spins very rapidly, releasing the lock, sending the
'break to none' messages and then re-acquiring the lock before
any other process has a chance to get the lock and remove it's own
oplock (at least on linux).
Jeremy.
0001-01-01 00:00:00 +00:00
Andrew Bartlett
7cbb194b58 As per a comment by herb a little while back, this should be >=, not == to keep
identical behaviour with previous versions
0001-01-01 00:00:00 +00:00
Andrew Bartlett
e5c67a0124 The previous patch (NTLMSSP common code factoring) was missing a minor detail -
testing :-).  This gets the 'signiture' after the extended security blob,
rather than over the top of it.

Also move that code to the top of the file, with some of the other util functions.

Andrew Bartlett
0001-01-01 00:00:00 +00:00
Andrew Bartlett
a8773c9f82 Factor out common code in the NTLMSSP/SPNEGO code.
The idea here is to seperate, as much as possible, the SPNEGO layer from the
NTLMSSP layer.  This not only helps us with protocol correctness, but also
should allow further mechinisms to be added with relitive ease.  I indend to
make the kerberos code use this shortly.

I've never seen the 'zero length blob' form of the anonymous login, so I've
removed that case.

Andrew Bartlett
0001-01-01 00:00:00 +00:00
Gerald Carter
9180e2d062 performance patch from HP-UX folks (cant remember who) 0001-01-01 00:00:00 +00:00
Tim Potter
c39c54e6b6 Merge of increment_smbd_process_count() fix from appliance. 0001-01-01 00:00:00 +00:00
Tim Potter
303710c206 Merge of max log file fixes from appliance:
- smbd/process.c: check log file sizes more often than in
       timeout_processing()

 - lib/debug.c: increment debug_count inside Debug1() instead of
       when log file sizes are checked.
0001-01-01 00:00:00 +00:00
Jeremy Allison
0173d6fe16 Fix reference count bug where smbd's would not terminate with no
open resources.
Jeremy.
0001-01-01 00:00:00 +00:00
Tim Potter
60c13a7675 Remove unused variable in reply_spnego_ntlmssp_ok 0001-01-01 00:00:00 +00:00
Andrew Bartlett
fe50ca8f54 Updates to the NTLMSSP code again - moving the base64 decode fuctionality out
of the SWAT code, and adding a base64 encoder.

The main purpose of this patch is to add NTLMSSP support to 'ntlm_auth', for
use with Squid.  Unfortunetly the squid side doesn't quite support what we need
yet.

Changes to winbind to get us the info we need, and a couple of consequential
changes/cleanups in the rest of the code.

Andrew Bartlett
0001-01-01 00:00:00 +00:00
Tim Potter
7ed8046d04 Removed level 0 DEBUG leftover from testing. 0001-01-01 00:00:00 +00:00
Gerald Carter
9ac196dad4 small merges from SAMBA_3_0; mostly typos, renames, etc... 0001-01-01 00:00:00 +00:00
Andrew Bartlett
9e48ab86da Refactor the NTLMSSP code again - this time we use function pointers to
eliminate the dependency on the auth subsystem.  The next step is to add
the required code to 'ntlm_auth', for export to Squid etc.

Andrew Bartlett
0001-01-01 00:00:00 +00:00
Gerald Carter
099e844571 [merge] removing unused variable and unused file 0001-01-01 00:00:00 +00:00
Gerald Carter
54b054c1ed make -i flag work lik eit did in 2.2 0001-01-01 00:00:00 +00:00
Andrew Tridgell
e4ce26332b query_alt_name takes a forced unicode string in win2000. It is not
null terminated.

Thanks to Metze for finding this.
0001-01-01 00:00:00 +00:00
Andrew Bartlett
b6641badcb Updates to our NTLMSSP code:
This tries to extract our server-side code out of sessetup.c, and into a more
general lib.  I hope this is only a temporay resting place - I indend to
refactor it again into an auth-subsystem independent lib, using callbacks.

Move some of our our NTLMSSP #defines into a new file, and add two that I found
in the COMsource docs - we seem to have a double-up, but I've verified from
traces that the NTLMSSP_TARGET_TYPE_{DOMAIN,SERVER} is real.

This code also copes with ASCII clients - not that we will ever see any here,
but I hope to use this for HTTP, were we can get them.  Win2k authenticates
fine under forced ASCII, btw.

Tested with Win2k, NTLMv2 and Samba's smbclient.

Andrew Bartlett
0001-01-01 00:00:00 +00:00
Andrew Bartlett
f8d9880c5f Ensure we do not pass uninitialised data to the kernel. (Picked up by
valgrind).

Andrew Bartlett
0001-01-01 00:00:00 +00:00
Andrew Bartlett
ef9c7586ac Oops, this is the change to use an fstring for the incoming service buffer -
the commit to reply.c just matches a pstrcpy for the pstring.  (harmless, fixes
it for the automated test).

Andrew Bartlett
0001-01-01 00:00:00 +00:00
Andrew Bartlett
7854a439ac Make the 'service' in make_connection() use an fstrcpy(), and an fstring,
becouse that is what it's input (reply_tcon_and_x) uses, and becouse we really
don't want supprises for service names.

Also remove a legacy #define, in favor of the lp_ equiv.

Andrew Bartlett
0001-01-01 00:00:00 +00:00
Andrew Bartlett
5ff5f540cc Remove an unused paramter for our old LM-only password change code, and fix a
(harmless) fstring/pstring mixup.

Andrew Bartlett
0001-01-01 00:00:00 +00:00
Andrew Bartlett
3b2e5f68cd No point having this for both parts of the 'if' statement.
Andrew Bartlett
0001-01-01 00:00:00 +00:00
Gerald Carter
142c5029c7 [merge] make sure to updatre print queue cache during timeout_processing() to send notify events; CR 1491 0001-01-01 00:00:00 +00:00
Tim Potter
88eb9e9486 Remove read_with_timeout() and replaced its only caller (the passwd chat
stuff) with a call to read_socket_with_timeout() which does the same thing.

Passwd chat still works but I couldn't figure out the right arguments to
passwd chat to get it to work right but data was definitely getting
through.
0001-01-01 00:00:00 +00:00
Tim Potter
812ce0368c Moved smbd process counting functions from smbd/server.c to smbd/process.c
so that bin/vfstest can link.
0001-01-01 00:00:00 +00:00
Jeremy Allison
6a2b7fd82c Ensure we return disk full by default on short writes.
Jeremy.
0001-01-01 00:00:00 +00:00
Jeremy Allison
99e69fd74d Ensure we don't get an invalid number for total smbd's if the tdb update
fails.
Jeremy.
0001-01-01 00:00:00 +00:00
Jeremy Allison
b0d547b739 Fix erroneous free of SAM_ACCOUNT (make clearer when allocated
memory is being returned).
Jeremy
0001-01-01 00:00:00 +00:00
Jeremy Allison
465d86d95f Fix open problem with changing attributes on an existing file - based
on work by  <steve@griffin.sio2.nl>.
Jeremy.
0001-01-01 00:00:00 +00:00
Tim Potter
4bc82624f6 Remove unused variable. 0001-01-01 00:00:00 +00:00
Jeremy Allison
ddf741c717 Fix memory leaks in pdb_ code.
Jeremy.
0001-01-01 00:00:00 +00:00
Andrew Bartlett
41178afdbd Fix a segfault when we don't correctly load a VFS module (don't keep it in
the loaded list on error).  Also change some of the error returns, becouse
NT_STATUS_UNSUCCESSFUL gives a most useless error message on the client.

As for which error, my logic is that a share without a valid VFS module is
not a valid share, and therefore should return the same error as a non-existant
share.

Andrew Bartlett
0001-01-01 00:00:00 +00:00
Andrew Bartlett
066e4f9a4b Even when I can't manage to do QA, at least the build farm will catch some of
the silly stuff.

(fixes password changes from RAP based clients like smbpasswd)

Andrew Bartlett
0001-01-01 00:00:00 +00:00
Jeremy Allison
6e0cfec165 Fix problem with "hide unreadable". stat file opens are baaack :-).
Jeremy.
0001-01-01 00:00:00 +00:00
Gerald Carter
4c48c475a2 patch to include support for daemontools from Michael Handler 0001-01-01 00:00:00 +00:00
Jeremy Allison
585a73b810 pstring/fstring missmatches found by Andrew Bartlett.
Jeremy.
0001-01-01 00:00:00 +00:00
Andrew Bartlett
c7e5797a95 Becouse these functions return a size_t, they can't return negitive numbers.
So a < 0 check is pointless, instead check against -1, which will be cast to
unsigned.

Andrew Bartlett
0001-01-01 00:00:00 +00:00
Andrew Bartlett
92a777d0ea BIG patch...
This patch makes Samba compile cleanly with -Wwrite-strings.
 - That is, all string literals are marked as 'const'.  These strings are
always read only, this just marks them as such for passing to other functions.

What is most supprising is that I didn't need to change more than a few lines of code (all
in 'net', which got a small cleanup of net.h and extern variables).  The rest
is just adding a lot of 'const'.

As far as I can tell, I have not added any new warnings - apart from making all
of tdbutil.c's function const (so they warn for adding that const string to
struct).

Andrew Bartlett
0001-01-01 00:00:00 +00:00
Andrew Bartlett
028f808c03 Move our password change code along a little - use NTSTATUS, and implmenet
minimum password age and min password length for all password changes.

Andrew Bartlett
0001-01-01 00:00:00 +00:00
Simo Sorce
63a669475b fix for bad check spotted by Ray Simard <ray@sylvan-glade.com> 0001-01-01 00:00:00 +00:00
Shirish Kalele
9df93b1ffc Add msdfs proxy functionality to HEAD. 0001-01-01 00:00:00 +00:00
Jeremy Allison
842e08e52a Forward port the change to talloc_init() to make all talloc contexts
named. Ensure we can query them.
Jeremy.
0001-01-01 00:00:00 +00:00
Jeremy Allison
636ab292db Fix for old DOS client when veto files is set to /.*/
Jeremy.
0001-01-01 00:00:00 +00:00
Jeremy Allison
ac856fbb96 Added "kernel change notify" boolean to allow easier valgrind testing.
Jeremy.
0001-01-01 00:00:00 +00:00
Jeremy Allison
ff3a8d3728 Fixed auth module code. Added VALGRIND defines to reduce spurious warnings.
Jeremy.
0001-01-01 00:00:00 +00:00
Jeremy Allison
15f0bad1fc The element in fsp->print_job should be a RAP jobid, not a uint32 RPC
jobid. This was causing Win9x client "set name" calls to fail.
Still need one cleanup fix to finish.
Jeremy.
0001-01-01 00:00:00 +00:00
Tim Potter
2a9d183cf6 Remove FILE_MACRO as __FILE__ is ANSI C. 0001-01-01 00:00:00 +00:00