1
0
mirror of https://github.com/samba-team/samba.git synced 2025-12-12 12:23:50 +03:00
Commit Graph

1077 Commits

Author SHA1 Message Date
Jelmer Vernooij
9e9a053661 r18572: Use the autogenerated client and server for the echo interface and implement
some of the missing functions. RPC-ECHO now passes against Samba3.
2007-10-10 11:51:51 -05:00
Jelmer Vernooij
a5c0606d76 r18526: Use generated server for unixinfo RPC interface. 2007-10-10 11:51:46 -05:00
Jelmer Vernooij
3f337c104d r18481: Use pidl-generated server side code for dfs. 2007-10-10 11:51:43 -05:00
Gerald Carter
2b37079af2 r18404: * swap from POLICY_HND to the struct policy_handle from ndr/misc.h
* move OUR_HANDLE macro to include/rpc_misc.h
2007-10-10 11:51:22 -05:00
Gerald Carter
878fd68dfc r18393: get the data size and not offset when initializing a data blob from a prs structure 2007-10-10 11:51:21 -05:00
Volker Lendecke
68ded4ba07 r18369: I've got a sniff where NT4 sends just a single byte after the 516 byte
password blob, it seems that pw_len is just a uint8 instead of uint16.

This might also be interesting for Samba4's samr.idl.

Volker
2007-10-10 11:51:20 -05:00
Gerald Carter
3da9f80c28 r18271: Big change:
* autogenerate lsa ndr code
* rename 'enum SID_NAME_USE' to 'enum lsa_SidType'
* merge a log more security descriptor functions from
  gen_ndr/ndr_security.c in SAMBA_4_0

The most embarassing thing is the "#define strlen_m strlen"
We need a real implementation in SAMBA_3_0 which I'll work on
after this code is in.
2007-10-10 11:51:18 -05:00
Jelmer Vernooij
1115745cae r18188: merge 3.0-libndr branch 2007-10-10 11:43:56 -05:00
Volker Lendecke
86f4ca84f2 r18047: More C++ stuff 2007-10-10 11:43:24 -05:00
Volker Lendecke
089b51e28c r18029: More C++ stuff 2007-10-10 11:43:23 -05:00
Jeremy Allison
397ab2b1ab r17877: Make it explicit to the checker that we can never pass
in NULL as ctr to a void returning fn.
Jeremy.
2007-10-10 11:38:56 -05:00
Günther Deschner
8c1198c159 r17454: Adding dfs_EnumEx for rpcclient (Samba4 IDL to follow).
Guenther
2007-10-10 11:38:35 -05:00
Günther Deschner
f9bef1f08f r17453: Fix msdfs RPC management (this broke with the autogenerated dfs rpcs).
* Remove "unknown" from dfs_Enum (samba4 dfs IDL updates to follow).

* When encountering an unsupported infolevel the rpc server must reply
with a dfs_info_0 structure and WERR_OK (observed from w2k3 when talking
to nt4).

Guenther
2007-10-10 11:38:34 -05:00
Volker Lendecke
fd82f185a2 r17363: Some C++ warnings 2007-10-10 11:38:28 -05:00
Volker Lendecke
1e4ee728df r17316: More C++ warnings -- 456 left 2007-10-10 11:38:25 -05:00
Volker Lendecke
3482bb1ef5 r17136: Fix alignment on lsaquery. This broke in particular level 6, where the client
tried to figure out which role we are.

Needs to go into 23a.

Thanks to Karolin for insisting and setting up the test case :-)

Volker
2007-10-10 11:38:14 -05:00
Jeremy Allison
9dafb7f48c r16945: Sync trunk -> 3.0 for 3.0.24 code. Still need
to do the upper layer directories but this is what
everyone is waiting for....

Jeremy.
2007-10-10 11:19:14 -05:00
Jeremy Allison
934dddb2fa r16601: Klocwork #2038. Fix memleak on error path.
Jeremy.
2007-10-10 11:19:02 -05:00
Jeremy Allison
05c50d99a4 r16378: Klocwork #1079. Allow BUFFER5 to cope with a NULL
dependentfiles pointer.
Jeremy.
2007-10-10 11:18:50 -05:00
Jeremy Allison
72709a8465 r16377: Klocwork #1077.
Jeremy.
2007-10-10 11:18:50 -05:00
Jeremy Allison
080464b93d r16373: Fix Klocwork #1071.
Jeremy
2007-10-10 11:18:50 -05:00
Jeremy Allison
5057e90db3 r16371: Fix Klocwork #1048.
Jeremy.
2007-10-10 11:18:50 -05:00
Jeremy Allison
6924d1cd44 r16369: Klocwork #1035.
Jeremy.
2007-10-10 11:18:49 -05:00
Jeremy Allison
fe05769a1a r16365: Fix Klocwork #895, #898, #899, #915, #932, #938 and a
few other problems Klocwork missed.
Jeremy.
2007-10-10 11:18:49 -05:00
Volker Lendecke
e35f901067 r16362: That's the best way to fix a Klocwork bug: Remove the (unused...;-) code
altogether. This was essentially a second implementation if string_to_sid.

Klocwork ID 1038

Volker
2007-10-10 11:18:49 -05:00
Jeremy Allison
ee77dde9b6 r16299: Fix another "dereferencing type-punned pointer will break
strict-aliasing rules" gcc4 warning.
Jeremy.
2007-10-10 11:17:32 -05:00
Jeremy Allison
ee1b9207d3 r16126: Janitor for Volker..... This looks correct to me.
Jeremy.

Fix a parsing error that became apparent in 'make test': If we have no
group
rids in the info3 we set the array buffer pointer to "1" but fail to
actually
ship the array.

Volker.
2007-10-10 11:17:22 -05:00
Volker Lendecke
5a37aba105 r16060: This is one of the more dirty patches I've put in lately. Parse enough of
SetUserInfo level 25 to survive the join method XP uses if the user did not
exist before. For good taste this contains way too much cut&paste, but for a
real fix there is just not enough time.

Up to 3.0.22 we completely ignored that a full level 21 is being sent together
with level 25, but we got away with that because on creation we did not set
the "disabled" flag on the workstation account. Now we correctly follow W2k3
in this regard, and we end up with a disabled workstation after join.

Man, I hate rpc_parse/. The correct fix would be to import PIDL generated samr
parsing, but this is would probably be a bit too much for .23...

Thanks to Tom Bork for finding this one.

Volker
2007-10-10 11:17:18 -05:00
Jeremy Allison
1d9dbe3b66 r15884: Fix bug #3803 from jason@ncac.gwu.edu - bad comparison.
Jeremy.
2007-10-10 11:17:11 -05:00
Günther Deschner
9b0731b2a9 r15453: Process all the supported info levels in the samr_query_domain_info2
call.

Guenther
2007-10-10 11:16:48 -05:00
Günther Deschner
6ed7d7fa70 r15452: Again purely cosmetic reformat of the samr query domain info calls.
Guenther
2007-10-10 11:16:47 -05:00
Günther Deschner
ef40428d93 r15443: Purely cosmetic reformat, no functional changes.
Guenther
2007-10-10 11:16:45 -05:00
Günther Deschner
41b72e77ae r15442: Add some more client rpc for the querydominfo calls (from samba4 idl).
Also return the hostname for the level 6 call (to be consistent with the
server name in level 2).

Guenther
2007-10-10 11:16:44 -05:00
Günther Deschner
6e225e0528 r15441: cleanup older unused padding.
Guenther
2007-10-10 11:16:44 -05:00
Günther Deschner
26dd22c9af r15438: Fix samrQueryDomainInfo level 5 where we returned our netbios
name eversince instead of the domain name when we are a DC.

Yes, there are applications relying on this call to be correct.

Guenther
2007-10-10 11:16:43 -05:00
Günther Deschner
0fed66926f r15041: Adding rpc client calls to manipulate auditing policies on remote CIFS
servers. Also add a new "net rpc audit" tool. The lsa query infolevels
were taken from samb4 IDL, the lsa policy flags and categories are
partly documented on msdn. I need to cleanup the double
lsa_query_info_policy{2}{_new} calls next.

Guenther
2007-10-10 11:15:59 -05:00
Jeremy Allison
f1b4e870a5 r14829: Fix reversed test in coverity fixes.
Jeremy.
2007-10-10 11:15:49 -05:00
Jeremy Allison
0a1ccfefcf r14778: Fix coverity null deref bugs #268 - #271.
Jeremy.
2007-10-10 11:15:48 -05:00
Jeremy Allison
68097e0fbb r14776: Fix coverity #263 - #267. No one was checking talloc
returns. Doh !
Jeremy.
2007-10-10 11:15:47 -05:00
Jeremy Allison
46e575af17 r14774: Fix null deref coverity bugs #260, #261, #262.
Jeremy.
2007-10-10 11:15:47 -05:00
Jeremy Allison
488b772516 r14772: Fix coverity bug #258. Seems coverity has discovered talloc :-).
Jeremy.
2007-10-10 11:15:47 -05:00
Jeremy Allison
4c126ef65d r14770: Fix coverity bug #257. Possible null deref.
Jeremy.
2007-10-10 11:15:47 -05:00
Günther Deschner
6c4fe819c6 r14646: Adding samr querygroup infolevels 2 & 5.
Guenther
2007-10-10 11:15:42 -05:00
Günther Deschner
38b18f428b r14643: Merge dcerpc_errstr from Samba 4.
Might need to rework prs_dcerpc_status().

Guenther
2007-10-10 11:15:41 -05:00
Gerald Carter
db1162241f r14634: Many bug fixes thanks to train rides and overnight stays in airports
* Finally fix parsing idmap uid/gid ranges not to break with spaces
  surrounding the '-'
* Allow local groups to renamed by adding info level 2 to
  _samr_set_aliasinfo()
* Fix parsing bug in _samr_del_dom_alias() reply
* Prevent root from being deleted via Samba
* Prevent builting groups from being renamed or deleted
* Fix bug in pdb_tdb that broke renaming user accounts
* Make sure winbindd is running when trying to create the Administrators
  and Users BUILTIN groups automatically from smbd (and not just check the
  winbind nexted groups parameter value).
* Have the top level rid allocator verify that the RID it is about to
  grant is not already assigned in our own SAM (retries up to 250 times).
  This fixes passdb with existing SIDs assigned to users from the RID algorithm
  but not monotonically allocating the RIDs from passdb.
2007-10-10 11:15:41 -05:00
Jeremy Allison
f65d7afe19 r14387: Try and fix the coverity issues (#53, #54) with negative
sink by ensuring all uses of rpcstr_push are consistent
with a size_t dest size arg.
Jeremy.
2007-10-10 11:15:27 -05:00
Volker Lendecke
b9fb3fc0e3 r14298: The other half of Coverity # 217 2007-10-10 11:15:24 -05:00
Volker Lendecke
932d769a32 r14232: Fix Coverity Bug # 218 2007-10-10 11:15:18 -05:00
Volker Lendecke
680bd1b004 r14228: Fix Coverity bug # 217 2007-10-10 11:15:18 -05:00
Jeremy Allison
666d427c6e r14219: Fix coverity #135. Don't deref a ptr if it can be NULL.
Jeremy.
2007-10-10 11:15:17 -05:00