1
0
mirror of https://github.com/samba-team/samba.git synced 2024-12-28 07:21:54 +03:00
Commit Graph

91 Commits

Author SHA1 Message Date
Volker Lendecke
06a727e8f8 lib: Remove load_case_tables_library()
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
2015-03-24 00:00:20 +01:00
Andreas Schneider
f6b929e721 s3-pam_smbpass: Add a deprecation warning.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Wed Feb 25 03:37:34 CET 2015 on sn-devel-104
2015-02-25 03:37:34 +01:00
Andreas Schneider
7afff0c52e s3-pam_smbpass: Correctly initialize variables.
This fixes a coverity warning.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu Jan 22 22:51:59 CET 2015 on sn-devel-104
2015-01-22 22:51:59 +01:00
Andreas Schneider
cb27bd1022 s3-pam_smbpass: Remove superfluous NULL check for pam functions.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
2015-01-22 20:29:07 +01:00
Andreas Schneider
29cfa2a714 s3-pam_smbpass: Make sure PAM_MAXTRIES can be returned.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
2015-01-22 20:29:07 +01:00
Andreas Schneider
016bee95e3 s3-pam_smbpass: Check the return code of secrets_init().
This fixes a coverity warning.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
2015-01-22 20:29:07 +01:00
Andreas Schneider
bc0768c964 s3-pam_smbpass: Fix set_ctrl() return value.
This fixes a cppcheck warning.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
2015-01-22 20:29:07 +01:00
Andreas Schneider
7bbf221cfd s3-pam_smbpass: Make sure variables are initialized.
This fixes cppcheck warnings.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
2015-01-22 20:29:07 +01:00
Andreas Schneider
0cb9b28acb s3-pam_smbpass: Fix memory leak in pam_sm_authenticate().
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11066

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
2015-01-22 15:36:05 +01:00
Stefan Metzmacher
0f6c31cf53 s3:pam_smbpass: explicitly use allow_warnings=True
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2014-04-02 09:03:46 +02:00
Andrew Bartlett
8f3a516acb pam_smbpass: Wrap calls in talloc_stackframe() to avoid warnings about leaking memory
Any code in source3 is permitted to use talloc_tos() at any point, so we must protect all the library interfaces
against memory leaks this way.

Andrew Bartlett

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
2014-04-02 00:31:48 +02:00
Christian Ambach
ade52f6034 s3:pam_smbpass change includes
use the ones from libreplace instead of system ones

Signed-off-by: Christian Ambach <ambi@samba.org>
Reviewed-by: Jelmer Vernooij <jelmer@samba.org>
2013-12-07 16:45:15 +01:00
Andreas Schneider
fb3cf6c242 waf: Build pam_smbpass module only if enabled. 2012-10-04 10:20:35 +02:00
Günther Deschner
693781db89 s3-waf: create a smbldap.so library.
Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Nov 16 14:03:05 CET 2011 on sn-devel-104
2011-11-16 14:03:05 +01:00
Günther Deschner
e68c4f4b33 waf: install pam modules in PAMMODULESDIR.
Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Tue Sep  6 11:09:45 CEST 2011 on sn-devel-104
2011-09-06 11:09:45 +02:00
Michael Adam
c9efe307cb s3:pam_smbpass: use lp_load_client() in pam_smbpass 2011-07-28 11:17:29 +02:00
Andrew Tridgell
356a2cc0b0 s3-waf: the passdb subsystem needs to be called pdb
the 'pdb' name is builtin to the passdb module loading code as a fixed
string. We need to call the subsystem pdb so that external passdb
modules end up in bin/modules/pdb/ where they can be found by the
Samba3 module loader

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2011-07-28 15:20:51 +10:00
Andrew Bartlett
6b97a3b1ff s3-build allow_undefined_symbols=False is the default now 2011-07-04 19:03:52 +10:00
Andrew Bartlett
b373d0e777 s3-build: Provide a run-time shim to work around duplicate symbols
The become_root() and similar 'smbd' functions that are used widely in
Samba libraries had 'dummy' copies in dummysmbd.c and dummyroot.c.

These have been replaced by a runtime plugin mechanim, which ensures
that standlone binaries still do nothing, while in smbd the correct
function is used.

This avoids having these as duplicate symbols in the smbd binary,
which can cause unpredictable behaviour.

Andrew Bartlett

Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-06-21 15:54:51 +10:00
Andrew Bartlett
6552561b87 s3-build Don't allow undefined symbols in pam_smbpass.so 2011-05-31 15:46:10 +10:00
Jeremy Allison
7d6ebe0de7 More const fixes. Remove CONST_DISCARD. 2011-05-06 01:44:07 +02:00
Andrew Tridgell
a8da13cd5c lib: make asn1_util a private library
this prevents symbol duplication of the asn1 symbols in the service
and ntvfs subsystems

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2011-04-06 08:12:19 +02:00
Günther Deschner
2f36ef7225 s3-passdb: add passdb.h where needed.
Guenther
2011-03-30 01:13:07 +02:00
Andrew Bartlett
5f5ca913b7 lib/util: new merged debug system
This is the s3 debug system, with a number of changes to tidy it up
for common use.  The debug class system is simplified by the removal of the
ISSET table, the system no longer attempts to cope with assignment of
DEBUGLEVEL, and the full class table is always available (rather than
just DEBUGLEVEL_CLASS[DBCG_ALL]) from startup.  It is also no longer
confusingly described as a hack, but as the initial table.

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Tue Mar  1 04:32:12 CET 2011 on sn-devel-104
2011-03-01 04:32:12 +01:00
Günther Deschner
7f5535460a s3-waf: rename LIBSAMBA subsystem to LIBNTLMSSP (which it is in fact).
Guenther
2011-02-23 22:33:52 +01:00
Günther Deschner
bf7f896d55 s3-waf: move GROUPDB into libpassdb.so.
Guenther
2011-02-23 22:33:52 +01:00
Andrew Tridgell
84b235fbb2 s3-waf: convert some subsystems into private libraries
put some commonly used subsystems into private libraries to reduce the
install size

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2011-02-22 02:51:09 +01:00
Andrew Bartlett
1ad8e5229f lib/util/charset Add back setlocale(), but only when called from binaries
When called from a library, we don't want to call this, as we may
overwrite some of our calling program's context.

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Fri Feb 18 09:29:35 CET 2011 on sn-devel-104
2011-02-18 09:29:35 +01:00
Andrew Tridgell
c8b2b10976 s3-waf: use SAMBA3_*() build rules in source3/build
this brings the s3 waf build much closer to the proposed s3build top
level build, using the same bld.SAMBA3_*() rules

There are a few renames of subsystems in here, with a 3 suffix where
it would create a conflict.

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2011-02-18 16:46:41 +11:00
Günther Deschner
34722c72f6 pam: share pam errors in a common location.
Guenther
2011-02-08 14:05:36 +01:00
Günther Deschner
a13b993237 s3-waf: check for "WITH_PAM_MODULES" to determine pam_smbpass build.
Guenther
2010-12-14 22:42:18 +01:00
Günther Deschner
1202e6328b s3-waf: fix pamsmbpass libwbclient dependency.
Guenther
2010-12-14 22:42:18 +01:00
Günther Deschner
5fcd0471e5 s3-waf: add pam_smbpass.
Guenther
2010-09-28 09:41:54 +02:00
Volker Lendecke
54f0da368f s3: Use asprintf where appropriate 2010-09-22 15:42:28 -07:00
Volker Lendecke
7ba5855a73 s3: Fix pam_smbpass logging on FreeBSD 2010-09-22 15:42:28 -07:00
Günther Deschner
ae36783c7b s3-passdb: include samr.h where needed.
Guenther
2010-08-06 15:43:37 +02:00
Günther Deschner
c136b84f0d s3-secrets: only include secrets.h when needed.
Guenther
2010-08-05 10:12:25 +02:00
Andreas Schneider
069350d7e4 s3-pam_smbpass: Remove obsolete signal type cast. 2010-02-23 12:23:42 +01:00
Björn Jacke
06a9678aad s3:pam_smbpass: fix build error on some Linux distros
This addresses bug #6459.
2009-07-03 09:34:21 +02:00
Michael Adam
23e3b44689 s3:pam_smbpass: make smb_update_db() static.
Michael
2009-05-29 23:28:38 +02:00
Bo Yang
de4c13ca68 s3: fix building of pam_smbpass.
Signed-off-by: Bo Yang <boyang@samba.org>
2009-05-29 16:19:17 +08:00
Björn Jacke
caeae66c5b s3:pam_smbpass: don't call openlog() or closelog() from pam_smbpass
Patch from Steve Langasek with tiny fixes by me to make it apply to master.
Also see Debian bug #434372 and bugzilla #4831.

Calling openlog() or closelog() inside a pam module is not good as these
functions are not stackable and no program won't re-do openlog() just because a
pam module might have called closelog().
2009-05-26 16:23:11 +02:00
Günther Deschner
1950e180ca s3-pamsmbpass: copy _pam_get_item and _pam_get_data from pam_winbind.
Guenther
2009-05-25 13:52:50 +02:00
Michael Adam
cf9b027709 s3:fix build of the pam_smbpass shared module
Michael
2009-04-27 11:21:01 +02:00
Jeremy Allison
765c3b953d Ensure consistent use of pdb_get_nt_passwd instead of pdb_get_lanman_passwd.
Reported by hongbing Zhang <hongbing.zhang@gmail.com>.
Jeremy.
(This used to be commit ade27d8baa)
2008-07-02 10:51:45 -07:00
Michael Adam
16b8d9436c Reformat: Remove indentation of part of pam_smbpass/support.c by one tab.
The first 120 lines of this source file were indented by one tab.
Sorry, but I could not stand this..

Michael
(This used to be commit 728723dea3)
2008-03-10 17:22:40 +01:00
Derrell Lipman
914cd3e483 Eliminate global variable in_client and a plethora of extern declarations.
Derrell
(This used to be commit b7f34e7ef2)
2008-03-06 10:41:42 -05:00
Alexander Bokovoy
b9d21dd668 Fix build for pam_smbpass
Signed-off-by: Alexander Bokovoy <ab@samba.org>
(This used to be commit dc568fd52a)
2008-01-16 12:42:26 +03:00
Alexander Bokovoy
ceedf1a111 Fix pam_smbpass build
(This used to be commit fbc510f171)
2007-12-13 12:55:32 +03:00
Jeremy Allison
9373e1ea90 Fix bug #3727 with patch from Steve Langasek <vorlon@debian.org>
Jeremy.
(This used to be commit 0723760ba4)
2007-12-12 17:26:49 -08:00