1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-27 14:04:05 +03:00

19506 Commits

Author SHA1 Message Date
Günther Deschner
aae8f8ae7a r14506: Remove remaining references to a KCM credential cache type.
Guenther
2007-10-10 11:15:35 -05:00
Günther Deschner
3e607aa69a r14505: Rename the timed_event to lockout_policy_event.
Guenther
2007-10-10 11:15:34 -05:00
Günther Deschner
7b1fcb75da r14503: Fix principal in debug statement.
Guenther
2007-10-10 11:15:34 -05:00
Günther Deschner
2155bb0535 r14496: Add WBFLAG_PAM_GET_PWD_POLICY bit to only callout for domain password
policies when requested.

No panic, the flags is uint32 so we are not running out of WBFLAG bits.

Guenther
2007-10-10 11:15:34 -05:00
Günther Deschner
52d721b638 r14495: Allow to play with the logon_param flag when testing samlogons.
Guenther
2007-10-10 11:15:34 -05:00
Günther Deschner
5fdddffba5 r14493: There is no point in falling back to a samlogon when a krb5login has
failed with a clear error indication. This prevents the bad logon count
beeing increased on the DC.

Guenther
2007-10-10 11:15:34 -05:00
Jeremy Allison
2703df7a8f r14489: Guard against coverity reversion. #181 is a false positive
but make the intent clearer.
Jeremy.
2007-10-10 11:15:34 -05:00
Gerald Carter
69f816e9f8 r14482: Fixes for spoolss code (after coverity fixes) when the
client sends a NULL RPC_BUFFER*
2007-10-10 11:15:33 -05:00
Volker Lendecke
d9b85e3b28 r14480: Kill one boolean flag passed down :-) 2007-10-10 11:15:33 -05:00
Gerald Carter
7d73973db1 r14475: patch from Oliver Schulze L. <oliver@samera.com.py> for BUG 3580. Make RHEL makerpms.sh script more verbose and add some additional options to the rpmbuild process 2007-10-10 11:15:33 -05:00
Günther Deschner
c81eb71834 r14474: Also flush the nscd caches before entering the main winbindd loop.
Guenther
2007-10-10 11:15:33 -05:00
Günther Deschner
0aa6328ed6 r14468: Better fix to avoid winbind panic when we have an inproper configuration
and want to just shutdown and exit.

Guenther
2007-10-10 11:15:33 -05:00
Günther Deschner
4157bfe9cf r14467: Reverting 13660. This needs to be fixed differently.
Guenther
2007-10-10 11:15:31 -05:00
Jeremy Allison
3c33eda430 r14462: Fix warning. ber_tag_t is an unsigned int for
printing purposes.
Jeremy.
2007-10-10 11:15:31 -05:00
Jeremy Allison
71e8158042 r14460: SMBexit closes by pid and vuid. Tested with smbtorture.
Jeremy.
2007-10-10 11:15:31 -05:00
Gerald Carter
d2c1842978 r14457: Add a few more special cases for RID 513 in the samr code.
Now that I know what all the requirements for this group are
I can generalize the code some more and make it cleaner.
But at least this is working with lusrmgr.msc on XP and 2k now.
2007-10-10 11:15:31 -05:00
Jeremy Allison
f3879dd6bb r14454: Janitor for tridge - same code exists in Samba3 and 4.
Jeremy.
-----------------------------
fixed an hmac-md5 error for keys longer than 64 (using deallocated
stack variable)
2007-10-10 11:15:31 -05:00
Gerald Carter
0b7549997a r14452: Sorry. Need more coffee....
* Fix sprintf() args when createing the group search filter.
2007-10-10 11:15:31 -05:00
Gerald Carter
2c0a46d731 r14451: In order to get pdb_ldap searching for SID_NAME_ALIAS
groups in the ${MACHINESID} and S_1-5-32 domains correctly,
I had to add a substr search on sambaSID.

* add substr matching rule to OpenLDAP schema
  (we need to update the other schema as will since this
  is a pretty important change).  Sites will need to
  - install the new schema
  - add 'indea sambaSID   sub' to slapd.conf
  - run slapindex

* remove uses of SID_NAME_WKN_GRP in pdb_ldap.c
2007-10-10 11:15:30 -05:00
Gerald Carter
57c705ea63 r14450: Fix more get_md4pw() breakage caused by missing "breaks"
in the switch statement which matched the schannel type
against the account type.
2007-10-10 11:15:30 -05:00
Gerald Carter
e49ca3af8c r14449: fix the build (sorry everyone) 2007-10-10 11:15:30 -05:00
Gerald Carter
a36529535d r14448: * protect against NULL cli_state* pointers in cli_rpc_pipe_open()
* Fix inverted logic check for machine accounts in get_md4pw()
2007-10-10 11:15:30 -05:00
Günther Deschner
c35eb44937 r14443: rework get_md4pw() to ease debugging. The only functional change is that
we now check wheter the sec_channel_type matches the trust account type.

Guenther
2007-10-10 11:15:30 -05:00
Gerald Carter
b617091060 r14432: Give in and grant BUILT\Administrators all privileges 2007-10-10 11:15:30 -05:00
James Peach
a39cbaa699 r14428: Call fill_share_mode_entry with NO_OPLOCK instead of 0. 2007-10-10 11:15:30 -05:00
Gerald Carter
f54d911e68 r14421: This does two things
* Automatically creates the BUILTIN\Users group similar to
  how BUILTIN\Administrators is done.  This code does need to
  be cleaned up considerably.  I'll continue to work on this.

* The important fix is for getusergroups() when dealing with a
  local user and nested groups.  Now I can run the following
  successfully:

    $ su - jerry -c groups
    users BUILTIN\users
2007-10-10 11:15:29 -05:00
Jeremy Allison
6de5e9ae46 r14418: Try and fix Coverity #39 and #40 by making the
implicit function contract explicit.
Jeremy.
2007-10-10 11:15:29 -05:00
Jeremy Allison
7fc61f5a63 r14416: Remove deadcode. Coverity #198.
Jeremy.
2007-10-10 11:15:29 -05:00
Jim McDonough
cb370cc28c r14408: More on fix for coverity #36. The previous fix would cause us to
marshall a buffer based on an unknown size.  Zero out the sec_desc
buffer to prevent this.  This is still not getting proper results for
a registry security descriptor (everything gets ACCESS DENIED), but
at least we aren't blowing out memory now...
2007-10-10 11:15:29 -05:00
Jeremy Allison
d241f74e06 r14406: Disable this call until we can sort out how this
should be done correctly. Fix coverity #37.
Jeremy.
2007-10-10 11:15:29 -05:00
Jeremy Allison
48594f0270 r14405: Fix the build when nscd_flush_cache is detected
(variable definition was missing).
Jeremy.
2007-10-10 11:15:29 -05:00
Gerald Carter
612979476a r14403: * modifies create_local_nt_token() to create a BUILTIN\Administrators
group IFF sid_to_gid(S-1-5-32-544) fails and 'winbind nested groups = yes'

* Add a SID domain to the group mapping enumeration passdb call
  to fix the checks for local and builtin groups.  The SID can be
  NULL if you want the old semantics for internal maintenance.
  I only updated the tdb group mapping code.

* remove any group mapping from the tdb that have a
  gid of -1 for better consistency with pdb_ldap.c.
  The fixes the problem with calling add_group_map() in
  the tdb code for unmapped groups which might have had
  a record present.

* Ensure that we distinguish between groups in the
  BUILTIN and local machine domains via getgrnam()
  Other wise BUILTIN\Administrators & SERVER\Administrators
  would resolve to the same gid.

* Doesn't strip the global_sam_name() from groups in the
  local machine's domain (this is required to work with
  'winbind default domain' code)

Still todo.

* Fix fallback Administrators membership for root and domain Admins
  if nested groups = no or winbindd is not running

* issues with "su - user -c 'groups'" command

* There are a few outstanding issues with BUILTIN\Users that
  Windows apparently tends to assume.  I worked around this
  presently with a manual group mapping but I do not think
  this is a good solution.  So I'll probably add some similar
  as I did for Administrators.
2007-10-10 11:15:28 -05:00
Jeremy Allison
3799f18b35 r14399: Fix deadcode coverity bug #3.
Jeremy.
2007-10-10 11:15:28 -05:00
Jeremy Allison
4a4953c4d2 r14397: Fix deadcode in coverity error #1.
Jeremy.
2007-10-10 11:15:28 -05:00
Jeremy Allison
cd3ad3f1a6 r14395: Fix coverity bug #55. Ensure no unsigned/signed comparisons.
Jeremy.
2007-10-10 11:15:28 -05:00
Jeremy Allison
8444c997bd r14393: Fix a couple of AIX warnings.
Jeremy.
2007-10-10 11:15:28 -05:00
Günther Deschner
4cfd737cc1 r14392: Use KRB5_TGS_NAME.
Guenther
2007-10-10 11:15:28 -05:00
Jeremy Allison
f65d7afe19 r14387: Try and fix the coverity issues (#53, #54) with negative
sink by ensuring all uses of rpcstr_push are consistent
with a size_t dest size arg.
Jeremy.
2007-10-10 11:15:27 -05:00
Simo Sorce
aa26642ee1 r14377: Fix coverity #4 for 3_0 too 2007-10-10 11:15:27 -05:00
Günther Deschner
8d4290cb8e r14368: Remove redundant set of logon flags (now in rpc_netlogon.h).
Guenther
2007-10-10 11:15:27 -05:00
Volker Lendecke
075e784491 r14367: Not that I fully understand what's going on here, but the code as it was here
was clearly buggy as Coverity showed with bug id #36.

According to samba4 idl the sec_desc_buf is [in,out,ref], so we _have_ to ship
it in the request.

Volker
2007-10-10 11:15:27 -05:00
Jeremy Allison
412dc6f5db r14365: As solaris nss includes includes.h, make sure we use
the correct malloc-macros.
Jeremy.
2007-10-10 11:15:27 -05:00
Jeremy Allison
a3b8bee3ff r14359: Try and fix Coverity #176 by making the pointer
aliasing clearer. This isn't a bug but a code
clarification.
Jeremy.
2007-10-10 11:15:26 -05:00
Jeremy Allison
b8397c9f33 r14357: Try and fix Coverity #169 by making the pointer
aliasing clearer. This isn't a bug but a code
clarification.
Jeremy.
 line, and those below, will be ignored--

M    source/smbd/posix_acls.c
2007-10-10 11:15:26 -05:00
Jeremy Allison
7ada96a1cf r14355: Try and fix Coverity #158 by making the pointer
aliasing clearer. This isn't a bug but a code
clarification.
Jeremy.
2007-10-10 11:15:26 -05:00
Jeremy Allison
338538410d r14353: Fix coverity bugs #61 and #62. Remember to divide by
the size of the data table. Clean up the struct a little.
Jeremy.
2007-10-10 11:15:26 -05:00
Jeremy Allison
d793e1550c r14351: Ensure we use the minimum of PATH_MAX and sizeof(pstring).
Fix Coverity #59.
Jeremy.
2007-10-10 11:15:26 -05:00
Jeremy Allison
9a1e35079a r14345: Fix Coverity #71. We don't currently propagate *any*
alloc error back up the stack from smbldap_set_mod()
so ensure we abort correctly.
Jeremy.
2007-10-10 11:15:26 -05:00
Jeremy Allison
7520a8d2a1 r14342: Fix coverity #68, resource leak on error path.
Jeremy.
2007-10-10 11:15:26 -05:00
Jeremy Allison
76c4f2c4dc r14340: Fix coverity #78, resource leak in error path.
Jeremy.
2007-10-10 11:15:26 -05:00