5 Commits

Author	SHA1	Message	Date
Andrew Bartlett	bd81733bb7	librpc: Make CFDATA private to cab.idl and remove pull and push functions ... We can do this because ndr_{pull,push}_CFDATA is unused. The earlier commit 466d5e814727046dd630d5503b43874ec46a365e removed the link between "uint16 cbData" and the size of "DATA_BLOB ab" so when the new ndr_fuzz_X fusser pushed a new structure this allowed a read beyond the end of allocated memory. The ndr_push_cab_file() function is also manually written and does not rely on the value of cbData to calculate the checksum. Found by Douglas Bagnall using Hongfuzz and the new fuzz_ndr_X fuzzer, which like ndrdump's struct mode uses the public structure tables. (This is how it found the unused functions to test). Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>	2019-11-29 00:44:40 +00:00
Gary Lockyer	1d89808dfb	cab.idl: remove unused decode functions ... Remove the decode_* functions as they are no longer needed, and this will reduce the amount of untested automatically generated code. Signed-off-by: Gary Lockyer <gary@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>	2019-06-06 03:30:18 +00:00
Aurelien Aptel	466d5e8147	librpc: use DATA_BLOB in CFDATA structure ... Signed-off-by: Aurelien Aptel <aaptel@suse.com> Reviewed-by: Guenther Deschner <gd@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>	2017-07-19 21:22:13 +02:00
Günther Deschner	4cc4fca23e	librpc: Add autogenerated checksum calculation for Cabinet files ... Guenther Signed-off-by: Guenther Deschner <gd@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>	2016-11-24 20:24:26 +01:00
Günther Deschner	88e1c4dc44	librpc: Introduce cab.idl ... This allows processing of Windows Cabinet files (required for the MS-PAR print protocol implementation) Guenther Signed-off-by: Guenther Deschner <gd@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>	2016-11-24 20:24:26 +01:00