1
0
mirror of https://github.com/samba-team/samba.git synced 2025-02-04 17:47:26 +03:00

245 Commits

Author SHA1 Message Date
Volker Lendecke
2d3623529f s3: Lift the smbd_messaging_context from rpc_pipe_open_internal 2010-08-08 16:03:15 +02:00
Günther Deschner
690ed0c5e2 s3-rpc: when using rpc_pipe_open_internal, make sure to go through NDR.
Otherwise a lot of information that is usually generated in the ndr_push remains
in an uninitialized state.

Guenther
2010-07-08 16:35:26 +02:00
Andreas Schneider
6ac050f73f s3-lanman: Make sure count is not used uninitialized if we jump to out.
Found by clang-analyzer.
2010-06-28 12:56:13 +02:00
Andreas Schneider
06a1766315 s3-lanman: Make sure that job_info is not undefined.
Found by clang-analyzer.
2010-06-28 12:56:13 +02:00
Günther Deschner
439e7590c9 s3-lanman: Fix return code for "" printqname in api_DosPrintQGetInfo().
Guenther
2010-06-16 12:15:24 +02:00
Volker Lendecke
89c5023b25 s3: Explicitly pass sconn to the api_ functions 2010-06-12 15:42:54 +02:00
Günther Deschner
0ca8e2252b s3-lanman: Fix api_RNetUserGetInfo level 2 marshalling offset calculation.
54 + 4 = 58 (and not 60).

Found by torture test.

Guenther
2010-05-28 02:49:37 +02:00
Simo Sorce
d9cffc01be s3:auth use info3 in auth_serversupplied_info
Signed-off-by: Günther Deschner <gd@samba.org>
2010-05-28 00:55:53 +02:00
Volker Lendecke
9b534ad145 s3: Remove an unused variable 2010-05-27 14:27:58 +02:00
Günther Deschner
869eed76e6 s3-lanman: use samr for api_RNetUserGetInfo.
Following MS-RAP 3.2.5.13 NetUserGetInfo Command.

Guenther
2010-05-27 13:37:40 +02:00
Günther Deschner
229b090308 s3-lanman: remove defines now provided by IDL.
Guenther
2010-05-26 22:49:01 +02:00
Günther Deschner
7fa2129db6 s3-lanman: parse encrypted and min_pwd_length in api_SetUserPassword().
Guenther
2010-05-26 22:15:51 +02:00
Günther Deschner
a17203ba65 s3-lanman: use samr for api_SetUserPassword().
Guenther
2010-05-26 22:15:51 +02:00
Simo Sorce
718718d0e7 s3-lanman: Migrated to rpc_connect_spoolss_pipe().
Signed-off-by: Günther Deschner <gd@samba.org>
2010-05-26 15:07:58 +02:00
Günther Deschner
e7982bbe0b s3-lanman: Fix various RAP printing calls according to win98 testing and MS-RAP docs.
Guenther
2010-05-20 13:35:49 +02:00
Günther Deschner
5a6f3a0666 s3-rpc_client: move protos to init_spoolss.h
Guenther
2010-05-18 21:42:48 +02:00
Günther Deschner
cc06133b0a s3-rpc_client: move protos to cli_spoolss.h
Guenther
2010-05-18 21:42:45 +02:00
Günther Deschner
99a7ebc556 s3-lanman: use samr for api_SamOEMChangePassword().
Guenther
2010-05-12 00:22:02 +02:00
Günther Deschner
e6c4df43c8 s3-lanman: use srvsvc for api_RNetServerGetInfo().
Following MS-RAP 3.2.5.3 NetServerGetInfo Command.

Guenther
2010-05-09 23:42:31 +02:00
Simo Sorce
3c1e9a8c33 s3-spoolss: Make spoolss_Time_to_time_t public.
Signed-off-by: Günther Deschner <gd@samba.org>
2010-05-09 23:33:40 +02:00
Günther Deschner
8528e347cb s3-lanman: use srvsvc for api_RNetShareAdd().
Guenther
2010-05-05 18:29:21 +02:00
Günther Deschner
4affc58c6a s3-lanman: before trying to call spoolss_ClosePrinter make sure we have a connection.
Guenther
2010-05-03 17:04:00 +02:00
Günther Deschner
fe1617a818 s3-lanman: fix api_DosPrintQEnum().
This was a subtile bug where the OpenPrinter call (called directly via
dispatcher table) was modifiying r->in.printername in a way that all printers on
a server had the printername stripped off the server unc. Once we switch to full
NDR marshalling in inter RAP<->RPC server communication there is no danger
anymore to have these kind of nasty effects.

Guenther
2010-05-03 14:45:26 +02:00
Günther Deschner
fe33db6c06 s3-lanman: exit early for unsupported levels in api_PrintJobInfo().
Guenther
2010-05-03 14:43:34 +02:00
Günther Deschner
9a313bbac0 s3-lanman: fix api_DosPrintQGetInfo().
Found by torture test.

Guenther
2010-04-29 13:47:33 +02:00
Günther Deschner
7e678ef0cf s3-lanman: fix api_DosPrintQEnum.
Found by torture test.

Guenther
2010-04-29 12:05:42 +02:00
Günther Deschner
d53544800f s3-lanman: support level 0 NetPrintQEnum RAP query.
Guenther
2010-04-28 23:23:38 +02:00
Günther Deschner
f56d9006d5 s3-lanman: use spoolss for api_WPrintDestGetInfo() and api_WPrintDestEnum().
With this, I think, all implemented RAP printing calls are routed over SPOOLSS.
Torture tests to follow...

Guenther
2010-04-28 01:27:40 +02:00
Günther Deschner
c88ff10d69 s3-lanman: fix debug message in api_WPrintJobEnumerate().
Guenther
2010-04-28 01:27:40 +02:00
Günther Deschner
566ea59b27 s3-lanman: remove a unnecessary memset in api_WPrintJobEnumerate().
Guenther
2010-04-28 01:27:40 +02:00
Günther Deschner
fe1f503a95 s3-lanman: remove unused code.
Guenther
2010-04-28 01:27:40 +02:00
Günther Deschner
f23bcb5c5e s3-lanman: use spoolss for api_DosPrintQGetInfo and api_DosPrintQEnum.
Guenther
2010-04-28 01:27:40 +02:00
Günther Deschner
f4f9d54721 s3-lanman: use spoolss for api_PrintJobInfo().
Guenther
2010-04-28 00:10:41 +02:00
Günther Deschner
2b7002f385 s3-lanman: remove unsupported print_job_set_place().
Guenther
2010-04-28 00:10:40 +02:00
Günther Deschner
7259762909 s3: use generated rap header.
Guenther
2010-04-26 22:52:59 +02:00
Günther Deschner
bb22855af5 s3-lanman: fix uninitialized variable in api_RDosPrintJobDel().
Guenther
2010-04-23 15:31:21 +02:00
Günther Deschner
2033314a7c s3-lanman: use spoolss for api_WPrintJobGetInfo().
Guenther
2010-04-19 11:53:55 +02:00
Günther Deschner
0c80d12656 s3-lanman: use spoolss for api_WPrintJobEnumerate().
Guenther
2010-04-19 11:23:44 +02:00
Günther Deschner
8d588e96d9 s3-lanman: use spoolss for api_RDosPrintJobDel().
Guenther
2010-04-08 16:24:33 +02:00
Günther Deschner
d5e2b43176 s3-lanman: use spoolss for api_WPrintQueueCtrl().
Guenther
2010-04-08 16:24:25 +02:00
Jeremy Allison
984eee7e29 Switch over to using get_currect_XXX() accessor functions.
Jeremy.
2010-03-15 14:49:15 -07:00
Jeremy Allison
4b85a0ea7f Rever e80ceb1d7355c8c46a2ed90d5721cf367640f4e8 "Remove more uses of "extern struct current_user current_user;"."
As requested by Volker, split this into smaller commits.

Jeremy.
2010-03-15 14:48:54 -07:00
Jeremy Allison
e80ceb1d73 Remove more uses of "extern struct current_user current_user;".
Use accessor functions to get to this value. Tidies up much of
the user context code. Volker, please look at the changes in smbd/uid.c
to familiarize yourself with these changes as I think they make the
logic in there cleaner.

Cause smbd/posix_acls.c code to look at current user context, not
stored context on the conn struct - allows correct use of these
function calls under a become_root()/unbecome_root() pair.

Jeremy.
2010-03-12 13:56:51 -08:00
Andrew Tridgell
3f0898a9f5 s3-smbd: convert lanman and notify code to TYPESAFE_QSORT() 2010-02-14 18:44:21 +11:00
Jeremy Allison
8ddc977c14 Fix bug #7122 - Reading a large browselist fails (server returns invalid values in subsequent SMBtrans replies)
There are two problems:

1). The server is off-by-one in the end of buffer space test.
2). The server returns 0 in the totaldata (smb_vwv1) and totalparams (smb_vwv0)
fields in the second and subsequent SMBtrans replies.

This patch fixes both.

Jeremy.
2010-02-09 15:14:38 -08:00
Stefan Metzmacher
bc8242a08e s3:smbd: use StrCaseCmp() instead of strcasecmp
metze
2010-02-09 18:59:16 +01:00
Stefan Metzmacher
1686a5e7e7 s3:smbd: Fix really ugly bool vs. int bug!!!
A comparison function for qsort needs to return an 'int'!
Otherwise you'll get random results depending on the compiler
and the architecture...

metze
2010-02-09 18:59:15 +01:00
Stefan Metzmacher
30eec0656c s3:smbd: implement api_RNetServerEnum3
This is needed to support large browse lists.

metze
2010-02-08 18:47:41 +01:00
Stefan Metzmacher
495ac46166 s3:smbd: add/improve some DEBUG messages in api_RNetServerEnum2()
metze
2010-02-08 18:46:57 +01:00
Stefan Metzmacher
dc58672c65 s3:smbd: rename api_RNetServerEnum => api_RNetServerEnum2
metze
2010-02-08 18:35:12 +01:00