1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-15 23:24:37 +03:00

23103 Commits

Author SHA1 Message Date
Volker Lendecke
6dcf0c64cf r24347: fake_sendfile does not need Inbuf/Outbuf
In the future, we might put the new Linux splice(2) syscall here. This
should also work for reply_write, but getting that in is a bit trickier.
We need to decide very early before fetching the whole buffer that we
have a write call.
(This used to be commit 32921c878a7f60251a9217173951065784077077)
2007-10-10 12:29:31 -05:00
Volker Lendecke
d198962d14 r24346: Push reply_prep_legacy into send_file_readX
(This used to be commit cded66a7dc72d41e4d6ea90edd8b03ed080c042f)
2007-10-10 12:29:31 -05:00
Jelmer Vernooij
db2666759d r24341: Make libreplace provide offsetof.
(This used to be commit 4a5fa715a6af281282092644817599f79806981d)
2007-10-10 12:29:31 -05:00
Jelmer Vernooij
594bbfcdee r24340: Use standard data type uint32_t rather than tdb-specific u32.
(This used to be commit 26d1430283bd4ae8b8a84f3253e33417d509c1a4)
2007-10-10 12:29:30 -05:00
Volker Lendecke
921fbb25eb r24332: schedule_aio_read_and_X does not need InBuf/OutBuf
(This used to be commit 9ad91bd20592850d7b6393e1ac7f0e0919d69668)
2007-10-10 12:29:30 -05:00
Volker Lendecke
ef6c3a3c7a r24331: Fix an error where gid_t != 32 bit
(This used to be commit 748fdfbd7ba5cc844f1370a968465b19ae698f94)
2007-10-10 12:29:30 -05:00
Volker Lendecke
1b69659315 r24330: Fix a 64-bit error
(This used to be commit 30fd90346550f1c672edb51ab63b8139a6c4053e)
2007-10-10 12:29:30 -05:00
Volker Lendecke
99a1f5a75c r24329: Fix a 64-bit bug
enums are not necessarily represented as 32-bit uints. On assignment
(see line 1029) implicit conversion happens, but not when pointers are
taken.
(This used to be commit 67ec6863dd91ca2421e4541add99dfd739805242)
2007-10-10 12:29:30 -05:00
Volker Lendecke
d90f6fa1bd r24328: Restore chain_reply error handling
Get the whole smb header from the second chained function, in particular
the error fields
(This used to be commit 0eb831ca0eadb725242cb4ad75eb7008a5c18bf2)
2007-10-10 12:29:30 -05:00
Volker Lendecke
26f6826dfc r24327: First round of fixes to chain_reply
The argument to smb_setlen does not contain the nbt header of 4 bytes

The chained function might allocate outbuf itself (as now happens with
reply_read_and_X). This would erroneously overwrite the caller's outbuf.
Give it an outbuf pointer of it's own
(This used to be commit f923bba90866af14b32c0d0ab58acc00a5939fbb)
2007-10-10 12:29:29 -05:00
Volker Lendecke
bf47a89c98 r24326: Fix the build for Solaris CC
(This used to be commit 7af4c1f547accc973f8b3ed88958bdeaf941754a)
2007-10-10 12:29:29 -05:00
Volker Lendecke
bb373dbd6c r24325: Push down reply_prep_legacy in reply_read_and_X
(This used to be commit 9d2354129dad1d4d015d463f138a196f9f72af2f)
2007-10-10 12:29:29 -05:00
Volker Lendecke
8e146e4b7b r24324: No reply_prep_legacy() in reply_pipe_read_and_X
(This used to be commit 304843315c5457ff0288d66d31f1ddb1ef2796f4)
2007-10-10 12:29:29 -05:00
Volker Lendecke
8d6dcd94eb r24323: Remove the reply_read_and_X wrapper function
(This used to be commit 96b218789401bb9e512339e7c6d9e0c9d9724420)
2007-10-10 12:29:29 -05:00
Volker Lendecke
61ee2d3720 r24322: Wrap reply_read_and_X in reply_prep_legacy
(This used to be commit 7926b5dfb8d05ad2fe40c3f7658a492f0450e505)
2007-10-10 12:29:28 -05:00
Volker Lendecke
02c21aa207 r24321: Attempt to fix the "hape" cc build
(This used to be commit 4e819aea0b783110d3b7a27105c588403e79eac9)
2007-10-10 12:29:28 -05:00
Volker Lendecke
23998e1da8 r24320: Fix the wct checks in reply_trans2 and the reply_trans calls
No idea what I've been smoking here.

Thanks to Stefan for closely looking
(This used to be commit 708f5af2e8c10d9a0d0027e3c31fa23689e746b8)
2007-10-10 12:29:28 -05:00
Volker Lendecke
d465b468c1 r24319: Check wct in reply_read_and_X
(This used to be commit 9ddacdfa131c4a4a852b3d30db1ee22d1852d0c2)
2007-10-10 12:29:28 -05:00
Volker Lendecke
c898c51984 r24318: Print a prominent warning when reply_prep_legacy is called
This is a temporary function anyway
(This used to be commit 9269e3d5882e97d1c884df6511fa6d63a7b1cfcd)
2007-10-10 12:29:27 -05:00
Volker Lendecke
22b30d2a37 r24316: Fix an uninitialized read
Jerry, please check this!

Thanks,

Volker
(This used to be commit db1b89072c3f214c3cb4be844cd7b417e5361615)
2007-10-10 12:29:27 -05:00
Volker Lendecke
3c5811c272 r24314: Attempt to fix bug 4868
(This used to be commit 0ced8fcfe124f99159061143f29775aacd6e1c8f)
2007-10-10 12:29:27 -05:00
Stefan Metzmacher
5cc4dbd449 r24312: revision 24091 removed the 'FORCE'...
metze
(This used to be commit 34d821daf0af6ef1e51dfd5cd99741f426d6956e)
2007-10-10 12:29:27 -05:00
Stefan Metzmacher
a5f412f305 r24311: add a reply_force_nterror() macro
metze
(This used to be commit b9ae00f4980c305f2f7334b139f9bc72fd9afbd6)
2007-10-10 12:29:27 -05:00
Stefan Metzmacher
c25f22562e r24310: we should not call END_PROFILE(SMBntcreateX); twice...
metze
(This used to be commit 7a98e09f2e4d5eff074e2d71dd1ff2f019a4547a)
2007-10-10 12:29:27 -05:00
Stefan Metzmacher
66294f9db5 r24309: if no protocol matches, just return choise 0xffff
as we've done before revision 24002

metze
(This used to be commit 6014ecbbfd50bc8f4f351dec1f9dd35c3fe62456)
2007-10-10 12:29:26 -05:00
Stefan Metzmacher
aece6db714 r24308: this needs a better fix that compiles...
metze
(This used to be commit 1a177eb08d4022c1ef7b5400ffdf426bcb9b97ff)
2007-10-10 12:29:26 -05:00
Stefan Metzmacher
f210f7c432 r24307: fill in choise with value -1 on error
as we've done before revision 24002

metze
(This used to be commit 2961a35e90aae44c8560b1f4b56bfa6343c837d7)
2007-10-10 12:29:26 -05:00
Stefan Metzmacher
9239b8e8d3 r24306: the check_fsp() function has an explicit user argument
so use it...

metze
(This used to be commit 4154bee0d91dd2ace9a7a627418f652d0d11b959)
2007-10-10 12:29:26 -05:00
Stefan Metzmacher
9342df7027 r24304: patch from Bjoern JAcke <bj@SerNet.DE>:
attached patches add EA support for Solaris. If no one disagrees, can
someone check this in please?

metze
(This used to be commit 81e5afc363e1f0bdc4768c0f5c696f4152fe5b44)
2007-10-10 12:29:25 -05:00
Stefan Metzmacher
d68145a509 r24302: add a module that overloads the file_id_create VFS function
and alters the device id depending on the configured algorithm.

The algorithm is configured via "fileid:algorithm":
- "fsname" (default) uses a uint64 hash over the mount point
- "fsid" uses the fsid returned from statfs()

This is needed for "clustering = yes" on some clusterfilesystems

metze
(This used to be commit 30f9171cca3e4f523cde7dfc96096c32e5af50be)
2007-10-10 12:29:25 -05:00
Volker Lendecke
b87c0dde71 r24291: Fix Coverity ID 364
We've checked num_rids != 0 above.
(This used to be commit dab5449f385248ab1fdd60b240ef6ad4a27ba7f2)
2007-10-10 12:29:25 -05:00
Herb Lewis
c7b9f06647 r24290: fix debug statments to match function name
(This used to be commit 5ee0bfde50645b822cefefe90bc9168faeeb34ff)
2007-10-10 12:29:25 -05:00
Jeremy Allison
87afcae522 r24281: Fix bug found by Herb. The vuid entry in the cli_state structure gets
left as nonzero as returned by the failed cli_session_setup_spnego. When we then try
to authenticate as the user in cli_session_setup this returns an
error "Bad userid" (as seen in wireshark).
"We should only leave cli->vuid != 0 on success. Looks like it's
getting set in the cli_session_setup_blob_receive() call and not
cleared again on error."
Jeremy.
(This used to be commit fa8e66dd8d2c68b91b27169c3c43820989f58758)
2007-10-10 12:29:25 -05:00
Volker Lendecke
e215bd8b99 r24280: Fix the build of vfs_afsacl.c
(This used to be commit c231f7b8f6025e2853eb6ecab43fe87566596234)
2007-10-10 12:29:24 -05:00
Volker Lendecke
12d94f77f9 r24279: Remove reply_prep_legacy from reply_write_and_X
(This used to be commit f18b7a9a282ebb5c31a89a601798f9a0db51867e)
2007-10-10 12:29:24 -05:00
Volker Lendecke
a6810cb9a3 r24278: Push down reply_prep_legacy in reply_write_and_X
Remove the need for reply_prep_legacy for reply_pipe_write_and_X
(This used to be commit de143d5fa61aa487613dda729a43dc3d59a72899)
2007-10-10 12:29:24 -05:00
Stefan Metzmacher
3e8fc031c8 r24272: try to fix the build on irix...
metze
(This used to be commit dd7e94258b0fc0157d890d71f05c6fe16b6a2ea9)
2007-10-10 12:29:24 -05:00
Volker Lendecke
b0dc209c19 r24271: Push reply_prep_legacy into reply_write_and_X
(This used to be commit 607e7d2447bf19eea872a3a4d1ad499a53f0a935)
2007-10-10 12:29:24 -05:00
Volker Lendecke
1f67efab7c r24270: Fix some END_PROFILE(SMBwriteX)
(This used to be commit 36f2347561ab06b5d8175ad0a9c4da2817e759f9)
2007-10-10 12:29:23 -05:00
Volker Lendecke
bb9664302b r24269: Check wct in reply_write_and_X
(This used to be commit 1297fac11778cb910d1bcd12b6d9d3a6269972db)
2007-10-10 12:29:23 -05:00
Volker Lendecke
456305325c r24268: Fix two crashes for spoolss
strlcpy does not like a NULL source. Fix a use-after-free.
(This used to be commit c2a214501788b5f0b6f555bd01ed310d331d07fa)
2007-10-10 12:29:22 -05:00
Volker Lendecke
42c1eca265 r24267: Fix the build farm
I had only tested with "net getlocalsid". posix_locking_init() calls this
with a NULL name...
(This used to be commit 3eee1fe28057e2e3da2e9d1506f57f3e35fd37b7)
2007-10-10 12:29:22 -05:00
Volker Lendecke
28210588ed r24266: Remove the "open files database hash size" parameter
This has been superseded by the "tdb_hashsize:<tdbname>" parameter
(This used to be commit df40d336afd256f05a0ec3724cc2096fb7114d81)
2007-10-10 12:29:22 -05:00
Volker Lendecke
8c154674c6 r24265: Add the tdb_hashsize:<tdbname> parameter
This makes it possible to set the default hashsize for any tdb. I would
like to remove the "open files database hash size" in favor of this one.

I'll check that removal in with the next commit, please complain/revert
if it's not ok.

Volker
(This used to be commit e9bd7a63a8d462b1fc3bab99ff843e25bffd156b)
2007-10-10 12:29:21 -05:00
Volker Lendecke
d18b7b1223 r24254: Fix a segfault in r24102
The really pure bugfix would have replaced pparam by *pparam, but we pulled
the fid anyway.

Metze, in line 2421 the FSP_BELONGS_CONN is commented out, is that intended?
The FSCTL_CREATE_OR_GET_OBJECT_ID ioctl did not have it.

Volker
(This used to be commit 2c1376225b98a9325dfc2d00bad1722e63cf522b)
2007-10-10 12:29:21 -05:00
Jeremy Allison
d75a38ae26 r24253: From Jan Martin <Jan.Martin@rwedea.com>.
----------------------------------------------------------
In rare cases, Samba 3.0.25b shows directory contents at the wrong
position in the file tree when displaying a subdirectory of a DFS link.

The problem occurs whenever Windows XP asks for a DFS referral for a
subdirectory of a DFS link with a trailing backslash.
Windows does not do this very often, but we saw it several times per day
on our central DFS server.

smbd/msdfs.c, dfs_path_lookup() does the following with the requested
path:
- in line 390, the local copy 'localpath' is 'unix_convert'ed; the
trailing backslash is removed inside unix_convert
- in lines 417-20, 'dfspath' (another copy of the requested path) is
mangled another way without removing trailing backslashes

That's why the following loop (lines 435-461) that is meant to
synchronously cut off the last path component from both strings until it
comes to a DFS link, does not handle both strings the same.  When the
original path ended with a backslash, 'canon_dfspath' has always one
component more than 'localpath', so that *consumedcntp gets too big in
line 446. This value is reported to the client.
----------------------------------------------------------

Bug #4860.

Jeremy.
(This used to be commit 42d1c6713a56197ca8dfebf74eb0d483102148f7)
2007-10-10 12:29:21 -05:00
Günther Deschner
6ba2d944a0 r24252: Dump guid of msExchMailboxGuid when returned.
Guenther
(This used to be commit 1142f3df546cbf4780c6f54667f7ed31b1a7621b)
2007-10-10 12:29:21 -05:00
Günther Deschner
bed0ea0693 r24251: Neverending fun:
Heimdal doesn't accept all OIDs and gss_import_name() fails with
GSS_S_BAD_NAMETYPE using this one. Use the GSS_KRB5_NT_PRINCIPAL_NAME OID
instead (which works with at least MIT 1.6.1 and Heimdal 1.0.1).

Guenther
(This used to be commit f783b32b65ee50e3730ae2d039ca04c9fc5a201a)
2007-10-10 12:29:21 -05:00
Günther Deschner
b805bcc1b0 r24250: Merge W_ERROR_HAVE_NO_MEMORY macro from Samba 4.
Guenther
(This used to be commit 054084a2359b5069b872b2e630377dc369c31018)
2007-10-10 12:29:21 -05:00
Volker Lendecke
b0ed26faf0 r24244: Complete the conversion of reply_trans[s]
Remove reply_prep/post_legacy from send_trans_replies
(This used to be commit c08366f840ead5aba7199cf0b058587055b4d98e)
2007-10-10 12:29:20 -05:00