Andreas Schneider
612060d677
s3-rpc_server: Only allow registering endpoints on priviledged pipes.
2011-02-02 12:44:20 +01:00
Andreas Schneider
31779662b7
s3-librpc: Added dcerpc_binding_vector_create function.
2011-02-02 12:44:20 +01:00
Andreas Schneider
20afe97177
s3-librpc: Added dcerpc register endpoint functions.
2011-02-02 12:44:20 +01:00
Andreas Schneider
bd5d14e6fa
s3-epmapper: Commented unimplemented functions.
2011-02-02 12:44:20 +01:00
Andreas Schneider
c451a454b3
s3-epmapper: Improved the epm_Map function.
2011-02-02 12:44:20 +01:00
Andreas Schneider
1d33f5c6d6
s3-epmapper: Implemented epm_Lookup.
2011-02-02 12:44:20 +01:00
Andreas Schneider
5b93e06e6c
s3-epmapper: Implemented epm_LookupHandleFree.
2011-02-02 12:44:20 +01:00
Andreas Schneider
3584dd18df
s3-epmapper: Added arg to match uuid in build_ep_list().
2011-02-02 12:44:20 +01:00
Andreas Schneider
658c05b939
s3-epmapper: Added epm_Map function from Samba4.
2011-02-02 12:44:20 +01:00
Andreas Schneider
6747b89b3c
s3-epmapper: Added epm_Delete function.
2011-02-02 12:44:20 +01:00
Andreas Schneider
c31ee9a152
s3-epmapper: Added epm_Insert function.
2011-02-02 12:44:20 +01:00
Andreas Schneider
84995397a7
s3-epmapper: Added a endpoint mapper skeleton.
2011-02-02 12:44:20 +01:00
Stefan Metzmacher
4507d2b9eb
s3:rpc_server/netlogon: add _netr_LogonSamLogon_check()
...
We need to check for invalid parameters before we check for
access denied.
metze
2011-02-02 11:58:26 +01:00
Jeremy Allison
3d4a9ddc24
Based on a conversation with Volker, refactor some of the oplock code to make it comprehensible.
...
delay_for_oplocks() did 4 things.
1). Validation of existing oplock types.
2). Check for compatibility with batch oplocks (pass 1).
3). Check for compatibility with exclusive oplocks (pass 2).
4). Set the correct oplock type from the requested value.
Refactor into 4 separate functions:
1). find_oplock_types() - does validation of oplock types and
returns pointers to specific values.
2). delay_for_batch_oplocks() - the pass 1 phase above.
3). delay_for_exclusive_oplocks() - the pass 2 phase above
4). grant_fsp_oplock_type() - Set the correct oplock type from the requested value.
Now separated out this code should be much easier to understand
and modify. This also fixes an erroneous SMB_ASSERT which was
hidden by the previous complexity of the single delay_for_oplocks()
code.
Jeremy.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed Feb 2 01:52:21 CET 2011 on sn-devel-104
2011-02-02 01:52:21 +01:00
Günther Deschner
a19c1cbb8d
s3-net: prefer dcerpc_samr_X functions in rpc_trustdom_list.
...
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Feb 2 00:21:19 CET 2011 on sn-devel-104
2011-02-02 00:21:19 +01:00
Günther Deschner
c7b1432b6e
s3-net: prefer dcerpc_samr_X functions in rpc_trustdom_del_internals.
...
Guenther
2011-02-01 23:29:14 +01:00
Günther Deschner
95ee07d8ab
s3-net: prefer dcerpc_samr_X functions in rpc_trustdom_add_internals.
...
Guenther
2011-02-01 23:29:14 +01:00
Günther Deschner
49f08d1d7c
s3-net: prefer dcerpc_samr_X functions in rpc_aliaslist_internals.
...
Guenther
2011-02-01 23:29:14 +01:00
Günther Deschner
37f2f518be
s3-net: prefer dcerpc_samr_X functions in rpc_fetch_domain_aliases.
...
Guenther
2011-02-01 23:29:14 +01:00
Günther Deschner
bf10bbc074
s3-net: prefer dcerpc_samr_X functions in rpc_group_members_internals.
...
Guenther
2011-02-01 23:29:14 +01:00
Günther Deschner
20edb2d48b
s3-net: prefer dcerpc_samr_X functions in rpc_list_alias_members.
...
Guenther
2011-02-01 23:29:14 +01:00
Günther Deschner
2a63433e94
s3-net: prefer dcerpc_samr_X functions in rpc_list_group_members.
...
Guenther
2011-02-01 23:29:14 +01:00
Günther Deschner
d280a52fdd
s3-net: prefer dcerpc_samr_X functions in rpc_group_list_internals.
...
Guenther
2011-02-01 23:29:14 +01:00
Günther Deschner
84e3d14f7a
s3-net: prefer dcerpc_samr_X functions in rpc_del_aliasmem.
...
Guenther
2011-02-01 23:29:14 +01:00
Günther Deschner
b9b2325f45
s3-net: prefer dcerpc_samr_X functions in rpc_del_groupmem.
...
Guenther
2011-02-01 23:29:14 +01:00
Günther Deschner
55e042a4f2
s3-net: prefer dcerpc_samr_X functions in rpc_add_aliasmem.
...
Guenther
2011-02-01 23:29:13 +01:00
Günther Deschner
f8147fbb14
s3-net: prefer dcerpc_samr_X functions in rpc_add_groupmem.
...
Guenther
2011-02-01 23:29:13 +01:00
Günther Deschner
e14c214ab3
s3-net: prefer dcerpc_samr_X functions in rpc_group_delete_internals.
...
Guenther
2011-02-01 23:29:13 +01:00
Günther Deschner
54b74c781d
s3-net: prefer dcerpc_samr_X functions in rpc_sh_user_flag_edit_internals.
...
Guenther
2011-02-01 23:29:13 +01:00
Günther Deschner
1d3b378001
s3-net: prefer dcerpc_samr_X functions in rpc_sh_user_str_edit_internals.
...
Guenther
2011-02-01 23:29:13 +01:00
Günther Deschner
a87a9fc9ce
s3-net: prefer dcerpc_samr_X functions in rpc_sh_user_show_internals.
...
Guenther
2011-02-01 23:29:13 +01:00
Günther Deschner
021e0b4cda
s3-net: prefer dcerpc_samr_X functions in rpc_sh_handle_user.
...
Guenther
2011-02-01 23:29:13 +01:00
Günther Deschner
f140e892f6
s3-net: prefer dcerpc_samr_X functions in rpc_info_internals.
...
Guenther
2011-02-01 23:29:13 +01:00
Günther Deschner
e3aafb2a7f
s3-net: prefer dcerpc_samr_X functions in net_rpc_sh_acct.c.
...
Guenther
2011-02-01 23:29:12 +01:00
Günther Deschner
fbbe321d19
s3-waf: fix the build after linux netlink changes.
...
Volker, please check.
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Tue Feb 1 23:21:50 CET 2011 on sn-devel-104
2011-02-01 23:21:50 +01:00
Volker Lendecke
ba4ec70529
s3: Fix bug 7940 -- fall back for utimes calls
...
There are systems where ./configure has detected advanced utimes calls which
are then not available on other kernels. We should do a proper fallback.
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Tue Feb 1 22:37:35 CET 2011 on sn-devel-104
2011-02-01 22:37:35 +01:00
Stefan Metzmacher
ff0f63329a
s3:rpcclient/cmd_samr: remove useless ';'
...
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Tue Feb 1 19:19:24 CET 2011 on sn-devel-104
2011-02-01 19:19:24 +01:00
Stefan Metzmacher
a152f20dd1
s3:libnet/libnet_samsync_display: fix netr_DELTA_* display
...
metze
2011-02-01 18:35:22 +01:00
Stefan Metzmacher
5e4691e70e
s3:rpcclient/cmd_netlogon: fix netr_DELTA_* display
...
metze
2011-02-01 18:35:22 +01:00
Volker Lendecke
1c9cf16c95
s3: Fix the build on sles8
...
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Tue Feb 1 18:34:33 CET 2011 on sn-devel-104
2011-02-01 18:34:33 +01:00
Günther Deschner
753094d5d2
s3-net: add net_scan_dc non-ad variant.
...
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Tue Feb 1 17:48:40 CET 2011 on sn-devel-104
2011-02-01 17:48:40 +01:00
Günther Deschner
600ff3a74e
s3-lanman: prefer dcerpc_samr_X functions.
...
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Tue Feb 1 16:45:10 CET 2011 on sn-devel-104
2011-02-01 16:45:10 +01:00
Günther Deschner
a51ab04cce
s3-rpcclient: prefer dcerpc_samr_X functions.
...
Guenther
2011-02-01 16:00:22 +01:00
Günther Deschner
a0c1c21916
s3-libnet: prefer dcerpc_samr_X functions.
...
Guenther
2011-02-01 16:00:22 +01:00
Volker Lendecke
23146f9912
s3: Send a dropped_ip message if we lose an IP
...
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Tue Feb 1 15:59:17 CET 2011 on sn-devel-104
2011-02-01 15:59:17 +01:00
Volker Lendecke
f71c032f16
s3: test addrchange
2011-02-01 15:11:06 +01:00
Volker Lendecke
80acca1ebf
s3: Add support for AF_NETLINK addr notifications
...
Via an AF_NETLINK socket, the Linux kernel can inform us when IP addresses are
added or dropped.
This will first be used in winbind, it was triggered by clustering with ctdb.
When winbind is connected to a domain controller and ctdb decides to move away
the IP address that winbind used locally for the connection to the DC, the next
request will run into a timeout. winbind sends out its request, but the
response will never arrive: The IP is gone.
It will also be interesting for more reliable online/offline detection, but
this is something for future winbind refactoring.
2011-02-01 15:11:06 +01:00
Günther Deschner
f9af242886
s3-libnetapi: prefer dcerpc_samr_X functions in lib/netapi/user.c.
...
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Tue Feb 1 13:41:42 CET 2011 on sn-devel-104
2011-02-01 13:41:42 +01:00
Günther Deschner
32fb4f5206
s3-libnetapi: prefer dcerpc_samr_X functions in lib/netapi/samr.c.
...
Guenther
2011-02-01 12:49:58 +01:00
Günther Deschner
b76657f8d9
s3-libnetapi: prefer dcerpc_samr_X functions in lib/netapi/localgroup.c.
...
Guenther
2011-02-01 12:49:52 +01:00
Günther Deschner
7f63018117
s3-libnetapi: prefer dcerpc_samr_X functions in lib/netapi/group.c.
...
Guenther
2011-02-01 12:49:44 +01:00
Pavel Shilovsky
6696fd1c1e
Ensure we send the direct levelII oplock break to the correct fid.
...
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Tue Feb 1 00:39:56 CET 2011 on sn-devel-104
2011-02-01 00:39:56 +01:00
Pavel Shilovsky
7690d9d70c
Fix bug #7928 - Samba problems with kernel oplocks option set to "no"
...
We should not grant levelII oplocks on a file with existing
byte range locks.
2011-01-31 12:00:15 -08:00
Stefan Metzmacher
ad10289ebc
s3:lib/events: use DLIST_DEMOTE() for fd events
...
This makes sure that fd events doesn't dry out,
because a fd with a lower number is busy.
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Mon Jan 31 16:59:44 CET 2011 on sn-devel-104
2011-01-31 16:59:44 +01:00
Stefan Metzmacher
0bbe7334d6
s3:smbd: let smbd_server_connection_loop_once() check for select errors
...
metze
2011-01-31 16:16:09 +01:00
Stefan Metzmacher
1f2be10ebf
s3:lib/events: don't loop over fd events is select gave -1
...
metze
2011-01-31 16:16:09 +01:00
Stefan Metzmacher
6953e2fa66
Revert "s3: Fix starving the echo responder"
...
This reverts commit d5cf6482ed
.
I'll add a more generic fix for this problem.
metze
2011-01-31 16:16:09 +01:00
Stefan Metzmacher
19d3779274
Revert "s3:events: Call all ready fd event handlers on each iteration of the main loop"
...
This reverts commit 455fccf86b
.
I'll add a more generic fix for this problem.
metze
2011-01-31 16:16:09 +01:00
Günther Deschner
35a7bebe2b
s3-waf: On FreeBSD, compile zfsacl if sunacl.h is around.
...
Volker, please check.
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Mon Jan 31 10:51:10 CET 2011 on sn-devel-104
2011-01-31 10:51:10 +01:00
Günther Deschner
eb5d884b15
s3-waf: these libs are not private libs.
...
Guenther
2011-01-31 10:04:42 +01:00
Stefan Metzmacher
e2e426588b
s3:libsmb: display NT_STATUS_RPC_SEC_PKG_ERROR in error strings
...
metze
2011-01-30 17:36:21 +01:00
Michael Adam
e57d4c41d7
s3:net registry: ignore WERR_BADFILE when --force is given in deletekey[_recursive]
...
Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Sun Jan 30 14:53:13 CET 2011 on sn-devel-104
2011-01-30 14:53:13 +01:00
Michael Adam
b1f800a0d1
s3:registry: in deletekey_recursive, fix return code upon error.
...
correctly keep the werr from inside the transaction when the opearation
inside the transaction fails.
What is the correct behaviour if the cancel operation fails?
2011-01-30 14:09:04 +01:00
Michael Adam
e81ddbcade
s3:net registry: fix a debug message.
2011-01-30 14:09:04 +01:00
Michael Adam
3649798bee
s3:net registry: fix a debug message.
2011-01-30 14:09:04 +01:00
Volker Lendecke
e6e7c724ad
s3: On FreeBSD, compile zfsacl if sunacl.h is around
...
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sun Jan 30 12:17:49 CET 2011 on sn-devel-104
2011-01-30 12:17:48 +01:00
Volker Lendecke
619e5cb646
s3: Make _lp_maxprotocol static
...
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sat Jan 29 16:07:28 CET 2011 on sn-devel-104
2011-01-29 16:07:28 +01:00
Volker Lendecke
a042617e97
s3: Remove an unneeded check
...
In many other places we already assume that if asprintf returns !=-1 then the
result is allocated.
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sat Jan 29 15:00:09 CET 2011 on sn-devel-104
2011-01-29 15:00:09 +01:00
Volker Lendecke
c52c75338f
s3: inline get_uid_from_state
...
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Fri Jan 28 23:38:16 CET 2011 on sn-devel-104
2011-01-28 23:38:16 +01:00
Volker Lendecke
e099c91ef9
s3: Lift winbindd_cli_state from fillup_password_policy
2011-01-28 22:54:19 +01:00
Volker Lendecke
fe516a3fb7
s3: Do not use state->mem_ctx in fillup_password_policy
2011-01-28 22:54:19 +01:00
Volker Lendecke
2d174d49cd
s3: Lift winbindd_cli_state from winbindd_dual_pam_auth_samlogon
2011-01-28 22:54:19 +01:00
Volker Lendecke
5d4bfc949b
s3: Lift winbindd_cli_state from winbindd_raw_kerberos_login
2011-01-28 22:54:19 +01:00
Jeremy Allison
f2900a8b04
We need to reply to SMB2_GETINFO_FILE with a class of SMB2_FILE_STANDARD_INFO on an IPC$ share.
...
Otherwise a Win7 client issues this request twice (2xroundtrips)
if we return NOT_SUPPORTED. We do the same for SMB1 in call_trans2qpipeinfo()
Jeremy.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri Jan 28 22:53:18 CET 2011 on sn-devel-104
2011-01-28 22:53:18 +01:00
Günther Deschner
fc16baaf91
s3-net: use struct based dcerpc_spoolss_EnumPrinterData_r() call.
...
This is a workaround for a string issue we currently have with argument based
generated dcerpc client code (see bug #7804 for details).
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri Jan 28 22:05:20 CET 2011 on sn-devel-104
2011-01-28 22:05:20 +01:00
Günther Deschner
d4414f08cb
s3-rpcclient: use struct based dcerpc_spoolss_EnumPrinterData_r() call.
...
This is a workaround for a string issue we currently have with argument based
generated dcerpc client code (see bug #7804 for details).
Guenther
2011-01-28 21:16:46 +01:00
Günther Deschner
1232fb5a1e
s3-rpc_client: remove some more obsolete cli_X.h header files.
...
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri Jan 28 11:18:44 CET 2011 on sn-devel-104
2011-01-28 11:18:44 +01:00
Jeremy Allison
ba6dda1934
Add delete-ln test now we can correctly delete hardlinks.
...
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri Jan 28 01:24:19 CET 2011 on sn-devel-104
2011-01-28 01:24:19 +01:00
Jeremy Allison
eec50b21f6
Change "security=share" to downgrade to SMB1 from SMB2, rather than trying to fake it.
2011-01-27 15:26:47 -08:00
Michael Adam
5dd63c6c14
libwbclient: bump the libwbclient SOVER 0 -> 1 due to ABI changes
...
Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Fri Jan 28 00:25:11 CET 2011 on sn-devel-104
2011-01-28 00:25:11 +01:00
Michael Adam
14502c5458
s3:registry: fix comments in regdb_store_regdb_version()
2011-01-27 21:43:48 +01:00
Günther Deschner
9d04f2bd68
s3-build: remove another leftover of -I../source4.
...
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Thu Jan 27 13:30:30 CET 2011 on sn-devel-104
2011-01-27 13:30:30 +01:00
David Disseldorp
eb55338ccd
Looking into printer driver issues, I ran across some peculiarities in
...
copy_file():
- Firstly, if the source file is zero bytes, NT_STATUS_DISK_FULL is
returned.
- Secondly, the conditional lseek is confusing. It fires when
OPENX_FILE_EXISTS_OPEN is set and I can't see why the lseek is
necessary in this case.
- Finally, the lseek error path also results in NT_STATUS_DISK_FULL.
Proposed fix for first and third point below.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Thu Jan 27 00:59:56 CET 2011 on sn-devel-104
2011-01-27 00:59:56 +01:00
Andreas Schneider
efde1d870b
s3-utils: Fixed a resource leak in net_afs.
...
s3-utils: Fixed a resource leak in net_afs.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Thu Jan 27 00:12:47 CET 2011 on sn-devel-104
2011-01-27 00:12:47 +01:00
Andreas Schneider
4fc75c755d
s3-utils: Fixed a resource leak in smbta-util.
...
s3-utils: Fixed a resource leak in smbta-util.
2011-01-26 14:20:37 -08:00
Andreas Schneider
f419c2b091
s3-utils: Fixed possible resource leak in net_usershare.
...
s3-utils: Fixed possible resource leak in net_usershare.
2011-01-26 14:20:37 -08:00
Andreas Schneider
de4ef101c1
s3-utils: Fixed possible resource leak in smbget.
...
s3-utils: Fixed possible resource leak in smbget.
2011-01-26 14:20:37 -08:00
Andreas Schneider
08dc51d3ca
s3-utils: Fixed possible resource leak in smbfilter.
...
s3-utils: Fixed possible resource leak in smbfilter.
2011-01-26 14:20:37 -08:00
Andreas Schneider
f6f0dac427
s3-modules: Fixed the for-loop code block.
...
s3-modules: Fixed the for-loop code block.
2011-01-26 14:20:37 -08:00
Andreas Schneider
2c47368d68
s3-lib: Fixed a missing return value in tldap.
...
s3-lib: Fixed a missing return value in tldap.
2011-01-26 14:20:37 -08:00
Kai Blin
278c6f8fc5
errormap: Add unix_to_werror() function
...
While this function technically is closest to the
map_nt_status_from_unix() function, I think it is better to keep the new
function in line with our usual fooerror_to_barerror() naming scheme.
Signed-off-by: Kai Blin <kai@samba.org>
Autobuild-User: Kai Blin <kai@samba.org>
Autobuild-Date: Wed Jan 26 23:07:24 CET 2011 on sn-devel-104
2011-01-26 23:07:24 +01:00
Jeremy Allison
67e578ab5a
Allow "security = share" with SMB2. We already handle this in smb2/smb2_server.c
...
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed Jan 26 20:37:29 CET 2011 on sn-devel-104
2011-01-26 20:37:29 +01:00
Jeremy Allison
bb358ecd5a
From Metze - make sure we're using the same string length for the hash.
...
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed Jan 26 18:32:15 CET 2011 on sn-devel-104
2011-01-26 18:32:15 +01:00
Günther Deschner
abb7c07de5
s3-winbind: share a common winbind_samlogon_retry_loop().
...
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Jan 26 12:41:14 CET 2011 on sn-devel-104
2011-01-26 12:41:14 +01:00
Günther Deschner
035a0d2fb3
Revert "s3: These assignments are overwritten immediately"
...
This reverts commit 18962ea385
.
2011-01-26 11:55:37 +01:00
Günther Deschner
36cfa1792e
Revert "s3-winbind: fix winbindd_dual_pam_auth_samlogon() for NT4 domains."
...
This reverts commit cea36aeacf
.
2011-01-26 11:55:36 +01:00
Jeremy Allison
3272e16846
Missed one debug printf of name_hash. Ensure always use %x.
...
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed Jan 26 00:46:28 CET 2011 on sn-devel-104
2011-01-26 00:46:27 +01:00
Jeremy Allison
44732734cc
Fix bug #7863 - Unlink may unlink wrong file when hardlinks are involved.
...
Do this by keeping a linked list of delete on close tokens, one for
each filename that identifies a path to the dev/inode. Use the
jenkins hash of the pathname to identify the correct token.
2011-01-25 14:23:19 -08:00
Jeremy Allison
a65bce4e38
Add uint32_t name_hash argument (currently unused) to get_file_infos().
...
Will be used when we store more than one delete on close token.
2011-01-25 14:02:18 -08:00
Jeremy Allison
b97f1ce68a
Add name_hash into the share mode entry struct (as yet only use for renames to identify a specific path).
2011-01-25 14:01:52 -08:00
Jeremy Allison
76418e23bc
Add name_hash to files_struct. Set within fsp_set_smb_fname().
2011-01-25 13:49:01 -08:00
Günther Deschner
c9f4fad75c
idl: add file_id idl.
...
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Tue Jan 25 12:27:00 CET 2011 on sn-devel-104
2011-01-25 12:27:00 +01:00
Günther Deschner
f0b3c72bcc
s3-libndr: remove cmdline_lp_ctx.
...
Guenther
2011-01-25 11:42:46 +01:00
Günther Deschner
dd35fe181c
waf: share libndr.so between samba3 and samba4.
...
Guenther
2011-01-25 11:42:46 +01:00
Günther Deschner
7eac3100ea
libndr: move ndr_print_bool to ndr_basic.c
...
Guenther
2011-01-25 11:42:46 +01:00
Günther Deschner
62e1c80cf5
s3-waf: add PKGCONFIGDIR.
...
Guenther
2011-01-25 11:42:46 +01:00
Björn Baumbach
07ccc2905d
s3-smbclient: Fix cli_errstr() usage (part of bug #7864 )
...
Convert cli_errstr() to nt_errstr()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Tue Jan 25 11:41:53 CET 2011 on sn-devel-104
2011-01-25 11:41:53 +01:00
Björn Baumbach
5d8ada549e
s3-masktest: Fix cli_errstr() usage (part of bug #7864 )
...
Convert cli_errstr() to nt_errstr()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2011-01-25 10:45:22 +01:00
Björn Baumbach
09c612f377
s3-smbclient: Fix cli_errstr() usage (part of bug #7864 )
...
Convert cli_errstr() to nt_errstr()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2011-01-25 10:45:22 +01:00
Björn Baumbach
99f8f5e594
s3-torture: Fix cli_errstr() usage (part of bug #7864 )
...
Convert cli_errstr() to nt_errstr()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2011-01-25 10:45:21 +01:00
Günther Deschner
39ea30de0f
s3-build: remove source4 include path for autoconf build as well.
...
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Mon Jan 24 17:40:56 CET 2011 on sn-devel-104
2011-01-24 17:40:56 +01:00
Günther Deschner
99437614fa
s3-rpcclient: allow to define validation level for samlogon.
...
Guenther
2011-01-24 16:56:00 +01:00
Günther Deschner
ef0a3903f0
s3-waf: fix lib/addns include path.
...
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Mon Jan 24 16:15:58 CET 2011 on sn-devel-104
2011-01-24 16:15:58 +01:00
Günther Deschner
c675b1c827
s3-waf: no need anymore to include "source4" globally.
...
Guenther
2011-01-24 15:28:21 +01:00
Stefan Metzmacher
0dc1eee0b8
libcli/ldap: use lib/ldb_compat.h for the s3 build
...
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Mon Jan 24 14:55:50 CET 2011 on sn-devel-104
2011-01-24 14:55:50 +01:00
Günther Deschner
cea36aeacf
s3-winbind: fix winbindd_dual_pam_auth_samlogon() for NT4 domains.
...
After failing the netr_LogonSamLogonEx, we failed to retry with
netr_LogonSamLogon.
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Mon Jan 24 12:35:42 CET 2011 on sn-devel-104
2011-01-24 12:35:42 +01:00
Volker Lendecke
509dd57d68
Revert "s3: Fix an infinite loop"
...
This reverts commit 61f7d7cdec
.
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Mon Jan 24 10:10:43 CET 2011 on sn-devel-104
2011-01-24 10:10:43 +01:00
Volker Lendecke
61f7d7cdec
s3: Fix an infinite loop
...
If select returns EBADF (which should NEVER happen), then we loop infinitely
because the select masks seem all active.
I've been given an strace where smbd floods syslog with inotify-related
error messages. The strace shows that select returns EBADF, and we're calling
the inotify event callback. It then complains there's no data on the inotify
fd.
Metze, please check!
We might need to fix this in 3.4 and 3.5 as well. And we need to find the
deeper reason where we close a file descriptor and don't tell the events
system about it.
Volker
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sun Jan 23 10:05:39 CET 2011 on sn-devel-104
2011-01-23 10:05:39 +01:00
Volker Lendecke
058de59a8e
s3: Fix connecting to port-139 only servers
...
When the TCP RST came before the 5 msecs timeout kicked in, we
viewed this as final, as state->req_139 was not set yet.
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sat Jan 22 17:42:41 CET 2011 on sn-devel-104
2011-01-22 17:42:41 +01:00
Günther Deschner
6ee39a2f42
s3-torture: fix uninitialized status code.
...
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri Jan 21 16:52:34 CET 2011 on sn-devel-104
2011-01-21 16:52:34 +01:00
Günther Deschner
6923cc8016
s3-rpc_client: fix dcerpc_try_samr_connects().
...
Only return when both results are ok.
Guenther
2011-01-21 16:10:15 +01:00
Günther Deschner
e873ce9b65
s3-rpc_client: no need to include gen_ndr/cli_samr.h anymore.
...
Guenther
2011-01-21 16:10:15 +01:00
Günther Deschner
1f26b101ed
s3-rpc_client: fix uninitialized variable found by -O3.
...
Guenther
2011-01-21 16:10:15 +01:00
Günther Deschner
5e89574dce
s3-waf: remove RPCCLI_SPOOLSS subsystem.
...
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri Jan 21 16:06:40 CET 2011 on sn-devel-104
2011-01-21 16:06:40 +01:00
Günther Deschner
24c51a7d2a
s3-build: remove RPCCLI_SPOOLSS subsystem.
...
Guenther
2011-01-21 15:20:22 +01:00
Günther Deschner
cf7a78b64f
s3-rpcclient: prefer dcerpc_spoolss_X functions.
...
Guenther
2011-01-21 15:20:22 +01:00
Günther Deschner
e94ffc790e
s3-rpc_client: prefer dcerpc_spoolss_X functions.
...
Guenther
2011-01-21 15:20:22 +01:00
Günther Deschner
831f3eec16
s3-lanman: remove trailing whitespace.
...
Guenther
2011-01-21 15:20:22 +01:00
Andreas Schneider
5db115a304
s3-rpc_client: Added dcerpc_try_samr_connects.
...
Autobuild-User: Andreas Schneider <asn@samba.org>
Autobuild-Date: Fri Jan 21 15:19:01 CET 2011 on sn-devel-104
2011-01-21 15:19:01 +01:00
Andreas Schneider
089c25cbbb
s3-rpc_client: Rename get_query_dispinfo_params.
2011-01-21 14:34:18 +01:00
Andreas Schneider
e6475f2151
s3-rpc_client: Added dcerpc_samr_chgpasswd_user3.
2011-01-21 14:34:18 +01:00
Andreas Schneider
200772653a
s3-rpc_client: Added dcerpc_samr_chng_pswd_auth_crap.
2011-01-21 14:34:18 +01:00
Andreas Schneider
3de564b9b6
s3-rpc_client: Added dcerpc_samr_chgpasswd_user2.
2011-01-21 14:34:17 +01:00
Andreas Schneider
78c4f72c31
s3-rpc_client: Added dcerpc_samr_chgpasswd_user.
2011-01-21 14:34:17 +01:00
Andreas Schneider
8b1ffc770c
s3-rpc_client: Added header information to cli_samr.h.
2011-01-21 14:34:17 +01:00
Andreas Schneider
1efa9b1cbd
s3-rpc_client: Added header information to cli_lsarpc.h.
2011-01-21 14:34:17 +01:00
Volker Lendecke
9c2fcb689b
s3:winbind: Fork multiple children per domain
...
This makes us scale better with many simultaneous winbind requests,
some of which might be slow.
This implementation breaks offline logons, as the cached credentials are
maintained in a child (this needs fixing). So, if the offline logons are
active, only allow one DC connection.
Probably the offline logon and the scalable file server cases are
separate enough so that this patch is useful even with the restriction.
2011-01-21 13:51:27 +01:00
Stefan Metzmacher
7a2fa9fc1c
s3:printing: use dcerpc_spoolss_X() functions
...
metze
Signed-off-by: Andreas Schneider <asn@samba.org>
Autobuild-User: Andreas Schneider <asn@samba.org>
Autobuild-Date: Fri Jan 21 13:14:49 CET 2011 on sn-devel-104
2011-01-21 13:14:49 +01:00
Stefan Metzmacher
1f83325261
s3:srv_spoolss: use dcerpc_spoolss_X() functions
...
metze
Signed-off-by: Andreas Schneider <asn@samba.org>
2011-01-21 12:30:22 +01:00
Stefan Metzmacher
e830e37c9c
s3:smbd: use dcerpc_spoolss_X() functions
...
metze
Signed-off-by: Andreas Schneider <asn@samba.org>
2011-01-21 12:30:22 +01:00
Stefan Metzmacher
81443447a1
s3:net: use dcerpc_spoolss_X() functions
...
metze
Signed-off-by: Andreas Schneider <asn@samba.org>
2011-01-21 12:30:22 +01:00
Stefan Metzmacher
a34aa148ca
s3:libads: use dcerpc_spoolss_X() functions
...
metze
Signed-off-by: Andreas Schneider <asn@samba.org>
2011-01-21 12:30:22 +01:00
Volker Lendecke
1b373d6044
s3: Fix a deadlock between smbd and ctdbd
...
Do the notification after we released the share mode lock. Inside notify_fname
we take out another tdb lock. With ctdb also accessing our databases, this can
lead to deadlocks. Putting this notify after the TALLOC_FREE(lck) above we
avoid locking two records simultaneously. Notifies are async and informational
only, so calling the notify_fname without holding the share mode lock should
not do any harm.
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Fri Jan 21 12:29:21 CET 2011 on sn-devel-104
2011-01-21 12:29:21 +01:00
Günther Deschner
8db3258983
s3-spoolss: make it more obvious what winreg_create_printer() does.
...
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri Jan 21 11:43:29 CET 2011 on sn-devel-104
2011-01-21 11:43:29 +01:00
Günther Deschner
621fb88e33
s3-rpcclient: rename duplicate enumkey command to winreg_enumkey.
...
Guenther
2011-01-21 10:58:20 +01:00
Günther Deschner
be884c1bfd
s3-spoolss: as smbtorture testing proves: devmode size is the size of the devicemode minus the driverdata extra size.
...
Jeremy, please check.
Guenther
2011-01-21 10:58:20 +01:00
Günther Deschner
9b1878e538
s3-spoolss: disallow storing an invalid devmode size.
...
Guenther
2011-01-21 10:58:20 +01:00
Michael Adam
5780940092
s3:vfs:shadow_copy2: fix indentation in _SHADOW2_NEXT_SMB_FNAME
...
Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Fri Jan 21 10:57:45 CET 2011 on sn-devel-104
2011-01-21 10:57:45 +01:00
Volker Lendecke
1c1a842071
s3:vfs:shadow_copy2: Fix shadow-copy module for drag&drop from a snapshot
...
We have to return NT_STATUS_NOT_SAME_DEVICE to trigger the Windows client to
start a copy itself. Unbeknownst to us via the ACLs snapshots are read-only, so
a rename would trigger a EACCES. Unfortunately the MacOS/X finder does not do
the smart NOT_SAME_DEVICE fallback that Windows does.
2011-01-21 10:10:03 +01:00
Christian Ambach
d49d203279
s3:registry correct a debug level
...
this is not a level 0 message, move it to 10
2011-01-21 10:10:03 +01:00
Volker Lendecke
52c0fb359f
s3:winbind: Protect against invalid winbindd_cache entries in lookuprids
2011-01-21 10:10:03 +01:00
Gregor Beck
64f8306e8e
s3-net: add roundtrip tests for registry import/export
2011-01-21 10:10:03 +01:00
Volker Lendecke
46a3019d36
s3: Fix the code to immediately disconnect from a non-working ctdbd
2011-01-21 10:10:02 +01:00
Rusty Russell
385d925f7e
s3:vfs:gpfs: fix logic when gpfs:winattr is false (the default!)
...
On my autocluster setup, it's not set. Maybe it should be? Otherwise
smbclient and some Windows client programs will get errors like:
# smbclient //localhost/data -Uadministrator%XXX
Domain=[VSOFS1] OS=[Unix] Server=[Samba 3.4.2-ctdb-10]
smb: \> put /etc/resolv.conf resolv.conf
NT_STATUS_ACCESS_DENIED closing remote file \resolv.conf
smb: \>
Caused by attempting to update the time on close.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Michael Adam <obnox@samba.org>
2011-01-21 10:10:02 +01:00
Stefan Metzmacher
b7d6d3b840
s3:librpc: remove prototype of dcerpc_binding_handle_set_ref_alloc()
...
This function doesn't exist anymore.
metze
2011-01-21 07:21:10 +01:00
Jeremy Allison
78b931ce6c
Remove all uses of "./" in pathnames - make canonical. This will become important when we need to guarantee canonical names for hashing.
...
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri Jan 21 02:59:56 CET 2011 on sn-devel-104
2011-01-21 02:59:56 +01:00
Jeremy Allison
de4b09ca01
Ensure we don't use "./" in findfirst pathnames. Use a directory open of "." instead.
2011-01-20 16:30:28 -08:00
Jeremy Allison
bb54f72b94
Make processing of incoming stream rename paths common between reply_mv and ntrename. Ensure we don't depend on "./" in the streams module.
2011-01-20 16:27:56 -08:00
Stefan Metzmacher
c3ad9bf157
s3:smbd: use anonymous_shared_free() for shared memory signing state
...
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Thu Jan 20 07:48:29 CET 2011 on sn-devel-104
2011-01-20 07:48:29 +01:00
Stefan Metzmacher
34ea909636
lib/util: s/allocate_anonymous_shared/anonymous_shared_allocate/
...
metze
2011-01-20 05:31:45 +01:00
Andreas Schneider
4744da8762
s3-param: Fixed code block in max_open_files().
...
When the HAVE_GETRLIMIT and RLIMIT_NOFILE macros are defined the block
isn't closed.
Autobuild-User: Andreas Schneider <asn@samba.org>
Autobuild-Date: Wed Jan 19 23:10:50 CET 2011 on sn-devel-104
2011-01-19 23:10:50 +01:00
Andreas Schneider
7a97518e12
s3-smbd: Fixed a possible null pointer dereference.
2011-01-19 22:27:48 +01:00
Volker Lendecke
7f87d58900
s3: Add wbinfo --dc-info
...
wbinfo --dc-info prints the current DC name and IP address. This helps
diagnosing problems that might happen when a later wbinfo --ping-dc fails.
This patch started out by using the SAF and NBT cache entires, but those are
relatively short-lived. So I decided to invent a new gencache entry with a very
long timeout. We need to go via the gencache because when for some reason a
winbind child process is stuck, we can't query it for the current DC it's
connected to. This must eventually go away again when we have a fully async
winbind.
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Jan 19 08:40:28 CET 2011 on sn-devel-104
2011-01-19 08:40:28 +01:00
Jeremy Allison
1b43996022
Add DELETE-LN test to show bug #7863 - Unlink may unlink wrong file when hardlinks are involved
...
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed Jan 19 03:06:32 CET 2011 on sn-devel-104
2011-01-19 03:06:32 +01:00
Olly Betts
f8f1711f61
Fix "net usersidlist" not to skip every other user
...
Remove double increment from for loop over users in get_user_tokens(),
left over from when this used to be a while loop. Bug was introduced
in 1e39a619
.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed Jan 19 01:34:29 CET 2011 on sn-devel-104
2011-01-19 01:34:29 +01:00
Günther Deschner
49969e6aeb
s3-winbind: no need to include ../librpc/gen_ndr/cli_lsa.h in
...
winbindd/winbindd_msrpc.c.
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Jan 19 00:37:46 CET 2011 on sn-devel-104
2011-01-19 00:37:46 +01:00
Günther Deschner
5efe6566a0
s3-rpc_client: no need to include ../librpc/gen_ndr/ndr_lsa_c.h anymore.
...
Guenther
2011-01-18 23:54:31 +01:00
Günther Deschner
6feed0c9d2
s3-netlogon: no need to include ../librpc/gen_ndr/ndr_lsa_c.h anymore.
...
Guenther
2011-01-18 23:54:31 +01:00
Günther Deschner
6ed4121d54
s3-netlogon: no need to include ../librpc/gen_ndr/cli_samr.h anymore.
...
Guenther
2011-01-18 23:54:31 +01:00
Günther Deschner
430664d769
s3-net: use correct spoolss header in net rpc.
...
Guenther
2011-01-18 23:54:31 +01:00
Günther Deschner
66bc2f9127
s3-net: use correct spoolss header in net_ads.c.
...
Guenther
2011-01-18 23:54:30 +01:00
Jeremy Allison
7754b75065
Fix error where Windows client spoolss returns WERR_INVALID_DATA W_ERROR(0x0000000D)
...
on opening a printer. We can't return zero for devmode->size. Guenther please check !
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Tue Jan 18 23:45:33 CET 2011 on sn-devel-104
2011-01-18 23:45:33 +01:00
Andreas Schneider
93da0aab97
s3-rpc_client: Fixed status check of dcerpc_lsa_lookup_sids_noalloc.
...
Autobuild-User: Andreas Schneider <asn@samba.org>
Autobuild-Date: Mon Jan 17 17:35:50 CET 2011 on sn-devel-104
2011-01-17 17:35:50 +01:00
Andreas Schneider
296a958c57
s3-rpc_client: Fixed return values of dcerpc_lsa_lookup_sids_generic.
2011-01-17 16:50:55 +01:00
Andreas Schneider
ad65605643
s3-auth: Fixed account lockout check.
2011-01-17 16:50:50 +01:00
Volker Lendecke
9b94f36605
s3: Make sure we call wbcAuthenticateUserEx correctly
...
There are cases where we fill in params.password.response.lm_data with non-NULL
where params.password.response.lm_length is 0. wbcAuthenticateUserEx does not
like that.
I haven't been able to reproduce this with smbclient yet, I've seen it with a
proprietary smb client implementation.
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Mon Jan 17 16:30:11 CET 2011 on sn-devel-104
2011-01-17 16:30:11 +01:00
Stefan Metzmacher
528bcedbc5
s3:build: don't use librpc/gen_ndr/cli_echo.[ch] anymore
...
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Mon Jan 17 09:34:12 CET 2011 on sn-devel-104
2011-01-17 09:34:12 +01:00
Stefan Metzmacher
494e57d913
s3:torture: use dcerpc_echo_X() functions
...
metze
2011-01-17 08:48:25 +01:00
Stefan Metzmacher
85db5c9f8f
s3:rpcclient: use dcerpc_echo_X() functions
...
metze
2011-01-17 08:48:25 +01:00
Volker Lendecke
d3abc90401
s3: Avoid a few calls to cli_errstr
...
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Mon Jan 17 08:47:25 CET 2011 on sn-devel-104
2011-01-17 08:47:25 +01:00
Volker Lendecke
c7a5933e4b
s3: Remove some unused code
2011-01-17 08:03:43 +01:00
Volker Lendecke
6f3e11088c
s3: Convert cli_lock64 to cli_smb
2011-01-17 08:03:43 +01:00
Volker Lendecke
dd2f234412
s3: Convert cli_lock to use cli_locktype
2011-01-17 08:03:43 +01:00
Volker Lendecke
0e2854f743
s3: Convert cli_locktype to cli_smb
2011-01-17 08:03:43 +01:00
Volker Lendecke
7b054ecaed
s3: Make passing up "result_parent" from cli_smb optional
2011-01-17 08:03:43 +01:00
Volker Lendecke
b33f1147a6
s3: Remove unused cli_send_keepalive
2011-01-17 08:03:42 +01:00
Volker Lendecke
6e684c8460
s3: Remove unused cli_send/receive_trans
2011-01-17 08:03:42 +01:00
Volker Lendecke
cba5a26734
s3: Convert try_trans2 to cli_trans
2011-01-17 08:03:42 +01:00
Volker Lendecke
8ac68fc3cb
s3: Convert cli_api to cli_trans
2011-01-17 08:03:42 +01:00
Volker Lendecke
cb412d22eb
s3: Make cli_setpathinfo_basic use cli_setpathinfo
2011-01-17 08:03:42 +01:00
Volker Lendecke
21d5485e06
s3: Add cli_setpathinfo
2011-01-17 08:03:42 +01:00
Volker Lendecke
2068b96dce
s3: Rename cli_setpathinfo->cli_setpathinfo_basic
2011-01-17 08:03:42 +01:00
Volker Lendecke
2d44a0583b
s3: Remove unused cli_send/receive_nt_trans
2011-01-17 08:03:42 +01:00
Volker Lendecke
d5decfbb26
s3: Convert try_nttrans to cli_trans
2011-01-17 08:03:41 +01:00
Volker Lendecke
5dee39b5bf
s3: Move dump_ntquota* to smbcquotas.c
2011-01-17 08:03:41 +01:00
Volker Lendecke
a1f541723d
s3: Convert cli_set_fs_quota_info to cli_trans
2011-01-17 08:03:41 +01:00
Volker Lendecke
797c027cc8
s3: Convert cli_get_fs_quota_info to cli_trans
2011-01-17 08:03:41 +01:00
Volker Lendecke
483e0447f5
s3: Convert cli_list_user_quota to cli_trans
2011-01-17 08:03:41 +01:00
Volker Lendecke
eb7db50f60
s3: Convert cli_set_user_quota to cli_trans
2011-01-17 08:03:41 +01:00
Volker Lendecke
e2a96711d7
s3: Convert cli_get_user_quota to cli_trans
2011-01-17 08:03:41 +01:00