1
0
mirror of https://github.com/samba-team/samba.git synced 2025-07-02 20:59:09 +03:00
Commit Graph

106 Commits

Author SHA1 Message Date
32809bd8c1 util: rewrite dlinklist.h so that DLIST_ADD_END() is O(1)
This changes the meaning of the ->prev pointer in our doubly linked
lists to point at the end of the list from the front of the list. That
allows us to implement DLIST_ADD_END() and related functions in O(1)
time, which can be a huge saving in many places in Samba.

This also means that the 'type' argument to various DLIST_*() macros
is no longer needed, but I have left it in for now to keep the
patchset small, which will make it easier to revert if any problems
are found. In the future we should remove the 'type' arguments.

(jra. Move the one use of DLIST_TAIL over to the new macros).
2010-02-10 15:53:58 -08:00
54fc99e04b s3-ldb: update the old ldb in s3 to use new DLIST macros
(cherry picked from commit a7d8bfd373392eecf4fff33d39b85e1b55ad901d)
2010-02-10 15:38:16 -08:00
32575ed70f Temporary changes to dlinklist to keep the implementation static whilst
uses of (list)->prev are moved over to DLIST_PREV. This will be replaced
when the final (new) version of the dlinklist.h header is added.

Jeremy.
2010-02-10 15:30:59 -08:00
d035a60089 s3-ldb: use GUID_to_ndr_blob()
this also fixes an error in NTSTATUS handling
2009-12-10 17:51:28 +11:00
53744f01dc s3: Cope with older external libtdb 2009-12-02 00:38:03 +01:00
99ba74b75e s3: Fix a "not handled in switch" warning 2009-11-29 23:42:41 +01:00
7bce1ab5e8 Fix builds with external tdb
Make sure we do not reference our internal tdb directly.
Let configure define what tdb.h file to use so that builds that use an
extrenal tdb do not include 2 different versions of the tdb header.
2009-10-11 09:48:53 -04:00
9f1c162e33 s3-ldb: update dlinklist.h to match main copy (lib/util/dlinklist.h)
This also removes build warnings of redefined macros
since it uses the embracing "#ifndef _DLINKLIST_H ... #endif".

Michael
2009-08-28 14:25:40 +02:00
0bdaa8b4ac LDB_ERR_INVALID_DN_SYNTAX doesn't exist ...
The correct name is ldb.ERR_INVALID_DN_SYNTAX
2009-07-02 14:55:38 +10:00
89e979fe99 Fix resource leak in lib/ldb/tools/ldbmodify.c
Patch for bug #6389
2009-06-18 13:49:26 +10:00
e0caf399e1 Fix syntax error in lib/ldb/ldb_sqlite3/base160.c
Patch for bug #6388
2009-06-18 13:49:26 +10:00
6c5c991304 s3: Call va_end() after all va_start()/va_copy() calls.
There are error paths in S3 where va_end() is not properly called after
va_start() or va_copy() have been called.

These issues were noted while performing an inspection for S4 bug #6129.  Thanks
to Erik Hovland <erik@hovland.org> for the original bug report.
2009-06-12 10:29:37 +02:00
6230eb94af Update copies of config.guess and config.sub. 2009-05-16 04:03:12 +02:00
b6981e79df samba3/ldb: Update the ldb_dn API to match that of the Samba 4 LDB:
* ldb_dn_new() now takes an initial DN string
 * ldb_dn_string_compose() -> ldb_dn_new_fmt()
 * dummy ldb_dn_validate(), since LDB DNs in the current implementation
   are always valid if they could be created.
2009-04-23 18:27:32 +02:00
9b64073cf7 ldb/samba3: Support event context argument to ldb_init().
This argument is ignored (Samba3's LDB is synchronous) but having it
there is useful for API compatibility with the LDB used by Samba 4 and
available on some systems.
2009-04-23 18:27:31 +02:00
0998d172db s3 ldb: Fix vasprintf segfault that has been the source of build machine failures this week
The bug was introduced when converting samba3's ldb_search interface
to match samba4:
47951fc5d0
f3ecb70133
2009-01-23 16:18:21 -08:00
1377f28f85 Fix warning; base dn is no longer const. 2009-01-21 18:20:23 +01:00
f3ecb70133 Replace ldb_search() with ldb_search_exp_fmt(), like in Samba 4. 2009-01-21 16:15:53 +01:00
47951fc5d0 Reorder arguments to ldb_search() to match what is in Samba 4. 2009-01-21 15:18:05 +01:00
7458111ea4 Fix bug 5913.
Never seen this to be a problem, but it doesn't hurt either :-)
2009-01-01 22:08:24 +01:00
e551f43b4b Remove two pointless globals 2009-01-01 19:08:33 +01:00
ecca199486 Fix merged build . 2008-10-14 23:25:12 +02:00
f27774729e s3:lib/ldb: Don't return already freed pointer on error.
metze

Signed-off-by: Karolin Seeger <kseeger@samba.org>
2008-09-25 07:15:18 -07:00
7111645d3c Use single copy of tdb in both samba3 and samba4. 2008-09-16 15:16:31 +02:00
79297bc132 Update homepages for talloc, tdb and ldb subprojects
(cherry picked from commit 8cb07814bc)
(This used to be commit 7d85b8d076)
2008-09-14 19:04:05 +02:00
dee5f09357 ldb: Fix permissions of new ldg files.
This one fixes together with 2eaf4ed62 bug #5715 and CVE-2008-3789.

Thanks to Steve Langasek <vorlon@debian.org> for reporting!

Karolin
(cherry picked from commit b666d0a4b5)
(This used to be commit 73f54df7fe)
2008-08-27 13:32:09 +02:00
df15541926 Fix typo.
retieve -> retrieve

Karolin
(This used to be commit 37c6413070)
2008-07-14 16:40:36 +02:00
993d80fd22 init_shared_module -> init_samba_module
(This used to be commit 9b174871a8)
2008-06-23 07:20:18 +02:00
3cf5395ad5 Use "init_shared_module" instead of "init_module" for initializing .so's
(This used to be commit 0c2fd687b2)
2008-06-21 11:25:41 +02:00
1bc1b1ac0a Fix a handle leak for error returns in ldb_try_load_dso
Coverity ID 464
(cherry picked from commit 496d44d2f2)
(This used to be commit f30bc6503d)
2008-06-13 16:15:12 +02:00
3d28e7533f Fix Coverity ID 472
Simo, S4 also has this code. You might want to cherry-pick.

Volker
(This used to be commit 94c29f5593)
2008-03-23 18:28:24 +01:00
4f4f1dfbb6 Fix Coverity ID 473
Simo, S4 also has this bug, you might want to merge the fix.
(This used to be commit b82cf75c82)
2008-03-21 11:52:34 +01:00
7faee02d0d Remove the char[1024] strings from dynconfig. Replace
them with malloc'ing accessor functions. Should save a
lot of static space :-).
Jeremy.
(This used to be commit 52dc5eaef2)
2007-12-10 11:30:37 -08:00
d4bfafa29c Fix bug 5055
(This used to be commit 8bcd2df841)
2007-11-26 15:28:13 +01:00
153cfb9c83 r23801: The FSF has moved around a lot. This fixes their Mass Ave address.
(This used to be commit 87c91e4362)
2007-10-10 12:28:27 -05:00
28b9d61076 r23800: LGPL is now called GNU Lesser General Public License
not GNU Library General Public License
(This used to be commit 727a6cf2cb)
2007-10-10 12:28:26 -05:00
674b835241 r23799: updated old Franklin Street FSF addresses to new URL
(This used to be commit 43cd589773)
2007-10-10 12:28:26 -05:00
9fa1c63578 r23798: updated old Temple Place FSF addresses to new URL
(This used to be commit c676a97114)
2007-10-10 12:28:26 -05:00
fd881dad3f r23794: convert more code from LGPLv2+ to LGPLv3+
(This used to be commit f3df6cd87e)
2007-10-10 12:28:25 -05:00
2c09988e46 r23790: LGPLv3+ conversion for our LGPLv2+ library code
(This used to be commit 1b78cace50)
2007-10-10 12:28:25 -05:00
5e54558c6d r23784: use the GPLv3 boilerplate as recommended by the FSF and the license text
(This used to be commit b0132e94fc)
2007-10-10 12:28:22 -05:00
2a9b4da0fa r23780: Find and fix more GPL2 -> GPL3.
Jeremy.
(This used to be commit c2f7ab1c17)
2007-10-10 12:28:21 -05:00
d824b98f80 r23779: Change from v2 or later to v3 or later.
Jeremy.
(This used to be commit 407e6e695b)
2007-10-10 12:28:20 -05:00
422722aad2 r23367: check the "use mmap" option for ldb too
(This used to be commit 15345bbc73)
2007-10-10 12:23:10 -05:00
9bf4687932 r23337: fix a crash bug...I wonder why only HP-UX 11.00 ans 11.11 noticed
it via a SIGBUS...

I missed to remove the samba3 specifc code path to tdb_open_ex()
when I synced lib/tdb/ with samba4. The explicit cast in on tdb_open_ex()
dropped the compiler warning :-(

metze
(This used to be commit 815d210171)
2007-10-10 12:23:07 -05:00
8b3ea388bc r22229: discard_const_p is in lib/replace now
metze
(This used to be commit 8dea4ebe98)
2007-10-10 12:19:21 -05:00
bc2b6436d0 r22009: change TDB_DATA from char * to unsigned char *
and fix all compiler warnings in the users

metze
(This used to be commit 3a28443079)
2007-10-10 12:19:00 -05:00
63f43ad5e4 r21312: merge from SAMBA_4_0:
fix memory hierachy, and access to already freed memory

metze
(This used to be commit 05a23dd756)
2007-10-10 12:17:55 -05:00
e59e787b48 r20269: merge -r20264:20267 from SAMBA_3_0_24
more no previous prototype warnings
(This used to be commit 41be182f78)
2007-10-10 12:16:38 -05:00
4a1efb1abe r20054: Revert my changes, Simo promised to work on it :-)
(This used to be commit 4b5cf0c9cf)
2007-10-10 12:16:22 -05:00