sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-07-23 20:59:10 +03:00
Code Activity
59,292 Commits 62 Branches 1,163 Tags
5a72eca574f2cb330a0d62936ca901b8ebee4194
Commit Graph

48 Commits

Author SHA1 Message Date
Andrew Kroeger
6c5c991304 s3: Call va_end() after all va_start()/va_copy() calls. 
There are error paths in S3 where va_end() is not properly called after
va_start() or va_copy() have been called.

These issues were noted while performing an inspection for S4 bug #6129.  Thanks
to Erik Hovland <erik@hovland.org> for the original bug report.
 2009-06-12 10:29:37 +02:00
Jelmer Vernooij
b6981e79df samba3/ldb: Update the ldb_dn API to match that of the Samba 4 LDB: 
* ldb_dn_new() now takes an initial DN string
 * ldb_dn_string_compose() -> ldb_dn_new_fmt()
 * dummy ldb_dn_validate(), since LDB DNs in the current implementation
   are always valid if they could be created.
 2009-04-23 18:27:32 +02:00
Jelmer Vernooij
9b64073cf7 ldb/samba3: Support event context argument to ldb_init(). 
This argument is ignored (Samba3's LDB is synchronous) but having it
there is useful for API compatibility with the LDB used by Samba 4 and
available on some systems.
 2009-04-23 18:27:31 +02:00
Tim Prouty
0998d172db s3 ldb: Fix vasprintf segfault that has been the source of build machine failures this week 
The bug was introduced when converting samba3's ldb_search interface
to match samba4:
47951fc5d0
f3ecb70133
 2009-01-23 16:18:21 -08:00
Jelmer Vernooij
f3ecb70133 Replace ldb_search() with ldb_search_exp_fmt(), like in Samba 4. 2009-01-21 16:15:53 +01:00
Jelmer Vernooij
47951fc5d0 Reorder arguments to ldb_search() to match what is in Samba 4. 2009-01-21 15:18:05 +01:00
Stefan Metzmacher
f27774729e s3:lib/ldb: Don't return already freed pointer on error. 
metze

Signed-off-by: Karolin Seeger <kseeger@samba.org>
 2008-09-25 07:15:18 -07:00
Karolin Seeger
dee5f09357 ldb: Fix permissions of new ldg files. 
This one fixes together with 2eaf4ed62 bug #5715 and CVE-2008-3789.

Thanks to Steve Langasek <vorlon@debian.org> for reporting!

Karolin
(cherry picked from commit b666d0a4b5)
(This used to be commit 73f54df7fe)
 2008-08-27 13:32:09 +02:00
Karolin Seeger
df15541926 Fix typo. 
retieve -> retrieve

Karolin
(This used to be commit 37c6413070)
 2008-07-14 16:40:36 +02:00
Volker Lendecke
993d80fd22 init_shared_module -> init_samba_module 
(This used to be commit 9b174871a8)
 2008-06-23 07:20:18 +02:00
Volker Lendecke
3cf5395ad5 Use "init_shared_module" instead of "init_module" for initializing .so's 
(This used to be commit 0c2fd687b2)
 2008-06-21 11:25:41 +02:00
Volker Lendecke
1bc1b1ac0a Fix a handle leak for error returns in ldb_try_load_dso 
Coverity ID 464
(cherry picked from commit 496d44d2f2)
(This used to be commit f30bc6503d)
 2008-06-13 16:15:12 +02:00
Jeremy Allison
7faee02d0d Remove the char[1024] strings from dynconfig. Replace 
them with malloc'ing accessor functions. Should save a
lot of static space :-).
Jeremy.
(This used to be commit 52dc5eaef2)
 2007-12-10 11:30:37 -08:00
Volker Lendecke
d4bfafa29c Fix bug 5055 
(This used to be commit 8bcd2df841)
 2007-11-26 15:28:13 +01:00
Andrew Tridgell
9fa1c63578 r23798: updated old Temple Place FSF addresses to new URL 
(This used to be commit c676a97114)
 2007-10-10 12:28:26 -05:00
Andrew Tridgell
2c09988e46 r23790: LGPLv3+ conversion for our LGPLv2+ library code 
(This used to be commit 1b78cace50)
 2007-10-10 12:28:25 -05:00
Herb Lewis
e59e787b48 r20269: merge -r20264:20267 from SAMBA_3_0_24 
more no previous prototype warnings
(This used to be commit 41be182f78)
 2007-10-10 12:16:38 -05:00
Volker Lendecke
1710dd1fe2 r20036: Merge ldb_search_exp_fmt -- Thanks simo 
(This used to be commit fa6fa1268b)
 2007-10-10 12:16:21 -05:00
Stefan Metzmacher
762b86ff0d r19935: always use discard_const_p() in lib/ldb/ 
metze
(This used to be commit 4a5da57306)
 2007-10-10 12:16:11 -05:00
Volker Lendecke
847644bdac r19917: Fix warnings 
(This used to be commit cf4309b904)
 2007-10-10 12:16:09 -05:00
Volker Lendecke
ca3300cbd1 r19898: Fix klokwork ids 3127, 3128, 3129, 3130 
(This used to be commit 3250d20d27)
 2007-10-10 12:16:07 -05:00
Stefan Metzmacher
9e7e5938ab r19744: merge from samba4 
metze
(This used to be commit fe61e6ebf7)
 2007-10-10 12:15:52 -05:00
Stefan Metzmacher
5a77ccfbfc r19741: fix compiler warnings 
metze
(This used to be commit 18171cf54b)
 2007-10-10 12:15:52 -05:00
Stefan Metzmacher
0fa75c6797 r19739: fix compiler warning 
metze
(This used to be commit b7965ac26c)
 2007-10-10 12:15:51 -05:00
Stefan Metzmacher
866a3b6e40 r19725: sync samba3's ldb with samba4 
metze
(This used to be commit 207643e9c9)
 2007-10-10 12:15:50 -05:00
Simo Sorce
4d12d3a5c8 r19692: Another fix. 
(This used to be commit a86a56fed3)
 2007-10-10 12:15:47 -05:00
Simo Sorce
151237477b r19491: backport changes from samba4 
(This used to be commit aa464c9fda)
 2007-10-10 12:15:39 -05:00
Volker Lendecke
3a22bdf89e r19486: Probably Coverity is wrong here, but this fixes their ID 317. Not sure whether 
to merge it to 4_0. I want it in 3_0 because it took a bit to persuade myself
that el can not be NULL here.

Volker
(This used to be commit c0c035b1c8)
 2007-10-10 12:15:39 -05:00
Andrew Tridgell
7a390a0dab r19430: merge recent ldb changes from Samba4. This includes memory leak fixes 
and significant speedups
(This used to be commit bb5c205fef)
 2007-10-10 12:15:35 -05:00
Stefan Metzmacher
85281ec526 r19191: merge from samba4: 
fix checker warnings

metze
(This used to be commit 93a0fe093b)
 2007-10-10 12:15:21 -05:00
Stefan Metzmacher
25e233db57 r19190: merge from samba4: 
remove wrong check and statement.
to manipulate rootDSE we use ldb_dn_new() as base and that has 0 elements.

metze
(This used to be commit b81cae4180)
 2007-10-10 12:15:21 -05:00
Stefan Metzmacher
d63a3e05a2 r19183: merge from samba4: 
don't crash on invalid utf8 chars

metze
(This used to be commit 71e1f8550f)
 2007-10-10 12:15:20 -05:00
Stefan Metzmacher
617c39ab5f r19182: merge from samba4: 
add ldb_set_create_perms() function to set the create_perms after
ldb_init() and before ldb_connect()

metze
(This used to be commit dd9d469eef)
 2007-10-10 12:15:20 -05:00
Stefan Metzmacher
628fc4b53a r19163: pass always a mem_ctx to functions and a ldb_context where needed 
It would be nice if someone can merge that to samba4,
otherwise I'll merge that to samba4 on monday

metze
(This used to be commit 6bc42f31ce)
 2007-10-10 12:15:19 -05:00
Stefan Metzmacher
a6e45f0da5 r19137: that looks nicer:-) 
metze
(This used to be commit db40552d94)
 2007-10-10 12:15:16 -05:00
Stefan Metzmacher
3652a2360f r19135: fix bugs... 
- passing mem_ctx as ldb_context is a bad idea!
- naming a static function talloc_ is also bad and misleading

metze
(This used to be commit 0523ad2493)
 2007-10-10 12:15:15 -05:00
Volker Lendecke
fd1cf23567 r19132: Fix some C++ warnings. Is there interest to have them in Samba4 as well? 
I have some problems resolving the last 3 ones in attrib_handlers.c. In line
251 the function ldb_dn_explode_casefold is called with mem_ctx as the first
argument. Looking at ldb_dn_explode_casefold I see that the first argument it
expects is a struct ldb_context. I could certainly add a cast to (struct
ldb_context *) to that call, but I would assume that this is the wrong fix. Is
it possible that attrib_handlers.c:251 and :254 should have ldb and not
mem_ctx as the first argument?

Can anybody from Samba4 clarify this for me and apply the correct fix?

Thanks a lot.

Volker
(This used to be commit 26f2cb71eb)
 2007-10-10 12:15:15 -05:00
Volker Lendecke
407873df53 r19079: talloc_array can fail 
(This used to be commit 7b6738522a)
 2007-10-10 12:15:09 -05:00
Volker Lendecke
faaec2f04a r19076: ldb_dn_copy_partial can fail 
(This used to be commit c247cf3fba)
 2007-10-10 12:15:09 -05:00
Volker Lendecke
38c4955c2a r19075: Fix a potential NULL dereference 
(This used to be commit 0ab5d7692c)
 2007-10-10 12:15:08 -05:00
Volker Lendecke
14502053e9 r19072: Fix a potential NULL dereference. Simo/Tridge, not merging yet to 4_0, I'd 
like you to comment.

Volker
(This used to be commit ba18c58f1f)
 2007-10-10 12:15:08 -05:00
Volker Lendecke
101428b7e5 r19067: Fix a potential NULL dereference 
(This used to be commit 6a8937ed03)
 2007-10-10 12:15:07 -05:00
Andrew Tridgell
0cc2cee8d5 r18939: don't rely on the umask being right in ldb creation. Both Samba3 and 
Samba4 smbd force the umask to 0, which meant we ended up with ldb
being world writable.

This isn't really an ideal fix, as it means ldb no longer honors umask
(as it should do, like all good libraries).

Unfortunately the 'proper' fix is too complex for now

this also merges a tiny code style fix from s4 to s3
(This used to be commit dd8ec8725f)
 2007-10-10 12:14:49 -05:00
Andrew Tridgell
45c0a4874b r18910: Change ldb_msg_add_string() to not actually add an attribute if the 
string is zero length. This allows callers to not have to worry about
creating an invalid ldap attribute.

See extensive discussion on samba-technical list :-)
(This used to be commit 9e66df05a4)
 2007-10-10 12:14:45 -05:00
Stefan Metzmacher
ed724f9047 r18901: try to fix the samba3 build without having ldap 
vl: you were a few seconds faster than me...:-)

metze
(This used to be commit 63e5727471)
 2007-10-10 12:14:44 -05:00
Volker Lendecke
b70ee55a7c r18900: Next attempt to fix the Solaris build. Not sure about whether to merge this 
one. Tridge? Metze?

Volker
(This used to be commit d0eef2f6e8)
 2007-10-10 12:14:44 -05:00
Volker Lendecke
ba68916c9a r18889: Add some const. What's the policy here? Should I do this in Samba4 as well? 
Volker
(This used to be commit fd020a1998)
 2007-10-10 12:14:41 -05:00
Andrew Tridgell
3e2c696e45 r18866: Jeremy and Volker have given the go-ahead on the group mapping ldb 
code. Yay!

This first commit copies lib/ldb/ from Samba4. A huge congratulations
should go to Simo on this - he has put an enormous amount of work into
ldb, and it's great to see it go into the Samba3 tree.
(This used to be commit bbedf2e343)
 2007-10-10 12:14:36 -05:00