1
0
mirror of https://github.com/samba-team/samba.git synced 2025-05-03 02:50:23 +03:00

977 Commits

Author SHA1 Message Date
Jeremy Allison
adc252c275 r16429: Fix final 4 Klocwork bugs we're going to fix before
release - #785, #786, #787, #788.
Jeremy.
(This used to be commit 9017547cccadeecb80f3db58a43838dc656fce2f)
2007-10-10 11:18:53 -05:00
Gerald Carter
564529b91a r16079: How embarassing. :-( Broke the build.
I will *always* compile before checking in...
I will *always* compile before checking in...
I will *always* compile before checking in...
I will *always* compile before checking in...
I will *always* compile before checking in...
(This used to be commit f3bd1c8c7de93917787e7341f759699c8399f006)
2007-10-10 11:17:20 -05:00
Gerald Carter
6b1b66904d r16078: Patch from Aleksey Fedoseev <fedoseev@ru.ibm.com> to correctly
set the type of 'acl compatibility from string to integer
after the changes in r14207.
(This used to be commit b01f289f1a788fe8f62a213b67a73a9bfee01bb1)
2007-10-10 11:17:20 -05:00
James Peach
0ed76af63d r15631: Add a new option "enable core files". Administrators can use this to
disable automatic core file dumping. Core files are enabled by default.
(This used to be commit b59189280057849b67ac65f31cec23b859e21c91)
2007-10-10 11:17:03 -05:00
Jeremy Allison
2602e5fab1 r15555: Make "change notify timeout" a per-share parameter - used
when there's no kernel or FAM change notify. If set to zero
this will turn off change notify for the share except when
we ourselves change something (renames / deletes etc. ).
Designed to help on large directory shares where a new
changenotify is issued between each delete. This will
be fixed correctly when we move to internal change notify
(eg. back-port Samba4 changenotify).
Jeremy.
(This used to be commit 5a17bffbcd5082fde79c241468a0ff2b5903d540)
2007-10-10 11:16:59 -05:00
Gerald Carter
18d5a26f74 r15549: removing rhosts and 'hosts equiv' authentication features
(This used to be commit d19dad88155f985f113c667b6bdad5a1b25eca18)
2007-10-10 11:16:58 -05:00
Gerald Carter
1d650a276b r15548: remove unused 'wins partners'
(This used to be commit 1316fd4267f37cd88ab5c63d22df81ace17205bc)
2007-10-10 11:16:58 -05:00
Gerald Carter
745e2490ae r15547: say goodbye to --with-ldapsam (although the ldapsam_compat passdb backend still exists
(This used to be commit 7d99e05ee8f60b2b4d18405dc8be6f9ff822c3ad)
2007-10-10 11:16:58 -05:00
Volker Lendecke
2566900982 r15496: current_user_info is not referenced in loadparm.c
(This used to be commit 800f4cd158c5de8a0031abf4d030f633d784999f)
2007-10-10 11:16:55 -05:00
Jeremy Allison
677b4769bd r15341: Ok I give up, I've been beaten by bug reports. People
just don't get why "guest ok" is not allowed in usershares.
Added "usershare allow guests" bool parameter that allows
this, reved usershare file version to VERSION#2 which
allows this. Updated user tools.
This should now be (finally) finished and I'll add
the new parameter docs and a HOWTO.
Jeremy.
(This used to be commit cdc3aa9d07d568570f2117bea9f1a4d227b3a35d)
2007-10-10 11:16:36 -05:00
Volker Lendecke
60af4023ad r15320: default "passdb expand explicit" to no
(This used to be commit 88b5a21d63b18af56b4fe7e5c353eae3ff7d4752)
2007-10-10 11:16:35 -05:00
Volker Lendecke
335637b2eb r15133: in_server is not used anywhere
(This used to be commit c981bc7f31483e7821b9654eb30d665283aa07d5)
2007-10-10 11:16:25 -05:00
Jeremy Allison
5445694eb9 r15112: Move strict locking default to auto. Fix up the error
return for one of the Samba4 torture tests.
Jeremy.
(This used to be commit 9db6617756ff155eb7549c3c622a9920189e577d)
2007-10-10 11:16:24 -05:00
Jeremy Allison
22dbd67708 r15018: Merge Volker's ipc/trans2/nttrans changes over
into 3.0. Also merge the new POSIX lock code - this
is not enabled unless -DDEVELOPER is defined.
This doesn't yet map onto underlying system POSIX
locks. Updates vfs to allow lock queries.
Jeremy.
(This used to be commit 08e52ead03304ff04229e1bfe544ff40e2564fc7)
2007-10-10 11:15:57 -05:00
Gerald Carter
bbf666e447 r15003: patch based on code from Arkady Glabek <aglabek@centeris.com> to ensure that global memory is freed when unloading pam_winbind.so (needs more testing on non-linux platforms)
(This used to be commit 1e0b79e591d70352a96e0a0487d8f394dc7b36ba)
2007-10-10 11:15:55 -05:00
Lars Müller
52f4dfa6fc r14923: Return False in the case a parametrical option is not configured in
the config file.

For a "somesettings: foo = " we still return an empty line.
(This used to be commit 59175ee522c5b4f9554ee734c008d8048eb1eadb)
2007-10-10 11:15:54 -05:00
Lars Müller
e9488049c1 r14922: Use BOOL for the returned value.
(This used to be commit b228474be0ced2637272a7b614b92e412a118993)
2007-10-10 11:15:54 -05:00
Lars Müller
570b49f33f r14869: Allow to dump a paramatrical option.
Flaw: We print an empty line if the paramatrical option is not defined
in the requested section.
(This used to be commit a0d84ccc02e19d22d827e7d052fab6d471f0a1b3)
2007-10-10 11:15:52 -05:00
Gerald Carter
6c9eaa6880 r14855: Various fixes:
* depreacte 'acl group control' after discussion with Jeremy
  and implement functionality as part of 'dos filemode'
* fix winbindd on a non-member server to expand local groups
* prevent code previously only used by smbd from blindly
  turning _NO_WINBINDD back on
(This used to be commit 4ab372f4cab22225716b5c9a9a08f0c1dbc9928d)
2007-10-10 11:15:51 -05:00
Jeremy Allison
81d4f40bbe r14763: Add a new tuning parameter, open files database hash size,
this allows us to experiment with ensuring the tdb hash
size for our open files and locking db are appropriately
sized. Make the hash size larger by default (10007 instead
of 1049) and make the locking db hash size the same as the
open file db hash size.
Jeremy.
(This used to be commit e7225f7e813423c3e2a94af6a9d7ce8a1b50a166)
2007-10-10 11:15:46 -05:00
James Peach
40d0707827 r14668: Set the FILE_STATUS_OFFLINE bit by observing the events a DMAPI-based
HSM is interested in. Tested on both IRIX and SLES9.
(This used to be commit 514a767c57f8194547e5b708ad2573ab9a0719c6)
2007-10-10 11:15:42 -05:00
Gerald Carter
1839b4be14 r14634: Many bug fixes thanks to train rides and overnight stays in airports
* Finally fix parsing idmap uid/gid ranges not to break with spaces
  surrounding the '-'
* Allow local groups to renamed by adding info level 2 to
  _samr_set_aliasinfo()
* Fix parsing bug in _samr_del_dom_alias() reply
* Prevent root from being deleted via Samba
* Prevent builting groups from being renamed or deleted
* Fix bug in pdb_tdb that broke renaming user accounts
* Make sure winbindd is running when trying to create the Administrators
  and Users BUILTIN groups automatically from smbd (and not just check the
  winbind nexted groups parameter value).
* Have the top level rid allocator verify that the RID it is about to
  grant is not already assigned in our own SAM (retries up to 250 times).
  This fixes passdb with existing SIDs assigned to users from the RID algorithm
  but not monotonically allocating the RIDs from passdb.
(This used to be commit db1162241f79c2af8afb7d8c26e8ed1c4a4b476f)
2007-10-10 11:15:41 -05:00
Gerald Carter
1267a3b297 r14530: removing unused 'winbind max idle children' parameter
(This used to be commit 0e789b7e43388b0e7155708981b4ab52ec6d3961)
2007-10-10 11:15:36 -05:00
James Peach
d245d5c017 r14255: Revert r14204 which was horribly broken.
(This used to be commit 950ed28f9f3f57dc449bd3bd6e7be7acb1e3d26d)
2007-10-10 11:15:21 -05:00
James Peach
a62c0925e8 r14207: Convert the lp_acl_compatibility() param into an enum.
(This used to be commit 5429c495c538e416010cf44e1d6fb771770a72ae)
2007-10-10 11:15:16 -05:00
James Peach
a156d128f2 r14204: Remove the basically unused P_GSTRING and P_UGSTRING
parameter types.
(This used to be commit 23328fe6fc5e3b4ed3dc35e1475d661a8593eb1a)
2007-10-10 11:15:16 -05:00
Jeremy Allison
f635dcb5f3 r14018: Coverity error CID #27. Missing return -1 on error condition.
Jeremy.
(This used to be commit 94e869d9c6d1a1c1df0d072530bf8d4452bd10bb)
2007-10-10 11:11:05 -05:00
Jeremy Allison
894358a8f3 r13915: Fixed a very interesting class of realloc() bugs found by Coverity.
realloc can return NULL in one of two cases - (1) the realloc failed,
(2) realloc succeeded but the new size requested was zero, in which
case this is identical to a free() call.

The error paths dealing with these two cases should be different,
but mostly weren't. Secondly the standard idiom for dealing with
realloc when you know the new size is non-zero is the following :

 tmp = realloc(p, size);
 if (!tmp) {
    SAFE_FREE(p);
    return error;
 } else {
    p = tmp;
 }

However, there were *many* *many* places in Samba where we were
using the old (broken) idiom of :

 p = realloc(p, size)
 if (!p) {
    return error;
 }

which will leak the memory pointed to by p on realloc fail.

This commit (hopefully) fixes all these cases by moving to
a standard idiom of :

 p = SMB_REALLOC(p, size)
 if (!p) {
    return error;
 }

Where if the realloc returns null due to the realloc failing
or size == 0 we *guarentee* that the storage pointed to by p
has been freed. This allows me to remove a lot of code that
was dealing with the standard (more verbose) method that required
a tmp pointer. This is almost always what you want. When a
realloc fails you never usually want the old memory, you
want to free it and get into your error processing asap.

For the 11 remaining cases where we really do need to keep the
old pointer I have invented the new macro SMB_REALLOC_KEEP_OLD_ON_ERROR,
which can be used as follows :

 tmp = SMB_REALLOC_KEEP_OLD_ON_ERROR(p, size);
 if (!tmp) {
    SAFE_FREE(p);
    return error;
 } else {
    p = tmp;
 }

SMB_REALLOC_KEEP_OLD_ON_ERROR guarentees never to free the
pointer p, even on size == 0 or realloc fail. All this is
done by a hidden extra argument to Realloc(), BOOL free_old_on_error
which is set appropriately by the SMB_REALLOC and SMB_REALLOC_KEEP_OLD_ON_ERROR
macros (and their array counterparts).

It remains to be seen what this will do to our Coverity bug count :-).

Jeremy.
(This used to be commit 1d710d06a214f3f1740e80e0bffd6aab44aac2b0)
2007-10-10 11:10:59 -05:00
Gerald Carter
5df58c38f3 r13829: From the "It's not pretty but it works" category
* Finish prototype of the "add port command" implementation
  Format is "addportcommand portname deviceURI"

* DeviceURI is either
  - socket://hostname:port/
  - lpr://hostname/queue
  depending on what the client sent in the request
(This used to be commit 6d74de7a676b71e83a3c3714743e6380c04e4425)
2007-10-10 11:10:56 -05:00
Gerald Carter
e33b728c7b r13815: "Into the blind world let us now descend,"
Began the poet, his face as pale as death.
"I will go first, and you will follow me."
---

Adding XcvDataPort() to the spoolss code for remotely
add ports.  The design is to allow an intuitive means
of creating a new CUPS print queue from the Windows 2000/XP
APW without hacks like specifying the deviceURI in the
location field of the printer properties dialog.

Also set 'default devmode = yes' as the new default
since it causes no harm and only is executed when you
have a NULL devmode anyways.
(This used to be commit 123e478ce5b5f63a61d00197332b847e83722468)
2007-10-10 11:10:55 -05:00
Gerald Carter
d0ab9712f5 r13794: If you are going to go, go big. That's what I always say.
* disable winbind enum {users,groups} by default after
  further conversations with Volker.
(This used to be commit d640d815405ce226c51577de5524daf63515d0a7)
2007-10-10 11:10:54 -05:00
Gerald Carter
1438ee5359 r13772: More default changes
* winbind nested groups = yes
* host msdfs = ye
* msdfs root = yes
(This used to be commit b5f01559e1f75c427e59646ee79e18433806213e)
2007-10-10 11:10:53 -05:00
James Peach
51d3bbe285 r13736: Don't assume that printf can handle string arguments being NULL. Tidy
up typing and tighten error checking a little.
(This used to be commit 37e12a196b1b1ee57b17a21226ba55d3aa6c69a5)
2007-10-10 11:10:51 -05:00
Jeremy Allison
f5f37f6f8a r13610: Patch from Bjoern JACKE <samba@j3e.de>. Don't default to
/tmp if there is no path in the share, make it unavailable.
All printer shares should have a path and IPC$ is already
explicitly set to tmpdir().
Jeremy.
(This used to be commit b1915a0591d9842b4c95f527363a807e8a756697)
2007-10-10 11:10:19 -05:00
Gerald Carter
fb5362c069 r13571: Replace all calls to talloc_free() with thye TALLOC_FREE()
macro which sets the freed pointer to NULL.
(This used to be commit b65be8874a2efe5a4b167448960a4fcf6bd995e2)
2007-10-10 11:10:14 -05:00
Gerald Carter
28d12c3b9d r13513: Changing defaults:
* enable privileges = yes
  * enable asu support = no

Remove unused function after the tdbsam rewrite.
(This used to be commit 5385a01ee19d9c7e00b4dd7a6ab3ec1d4b03b558)
2007-10-10 11:10:08 -05:00
Gerald Carter
75ef18fa75 r13460: by popular demand....
* remove pdb_context data structure
* set default group for DOMAIN_RID_GUEST user as RID 513 (just
  like Windows)
* Allow RID 513 to resolve to always resolve to a name
* Remove auto mapping of guest account primary group given the
  previous 2 changes
(This used to be commit 7a2da5f0cc05c1920c664c9a690a23bdf854e285)
2007-10-10 11:10:04 -05:00
Gerald Carter
ef3f2c9675 r13393: Do not initialize the lp_svcctl_list() value since it is handled
internally in services_db.c now.  This prevents internal services from
being listed twice (one internal and one external) when no
'svcctl list' parameter is explcitly set in smb.conf
(This used to be commit 6c4ede6cee7e1d25a6357e959972e8d390c27fe3)
2007-10-10 11:09:58 -05:00
Gerald Carter
0af1500fc0 r13316: Let the carnage begin....
Sync with trunk as off r13315
(This used to be commit 17e63ac4ed8325c0d44fe62b2442449f3298559f)
2007-10-10 11:06:23 -05:00
Derrell Lipman
9c15bd311d r13212: r12414@cabra: derrell | 2006-01-28 17:52:17 -0500
lp_load() could not be called multiple times to modify parameter settings based
 on reading from multiple configuration settings.  Each time, it initialized all
 of the settings back to their defaults before reading the specified
 configuration file.

 This patch adds a parameter to lp_load() specifying whether the settings should
 be initialized.  It does, however, still force the settings to be initialized
 the first time, even if the request was to not initialize them.  (Not doing so
 could wreak havoc due to uninitialized values.)
(This used to be commit f2a24de769d1b2266e576597c57a8e3b1e2a2b51)
2007-10-10 11:06:18 -05:00
James Peach
543ff192b3 r13027: Support file change notifications from FAM.
(This used to be commit 652b511ff24ce41c7745a0e00363e619e5027828)
2007-10-10 11:06:11 -05:00
Volker Lendecke
4d1d826be4 r12735: After talking to Tridge and Jeremy... This needs to be made more generic
before it goes in.

Volker
(This used to be commit 2c3d5c029a31111e1fe84ddc13c1bfc183d8bfde)
2007-10-10 11:06:02 -05:00
Volker Lendecke
a189257c15 r12721: GPFS 2.4 on Linux will contain some windows semantics, ie share modes and
oplocks across the cluster. Adapt Samba to it.

The gpfs API is called via libgpfs.so. This code is written with dlopen(), so
that you can compile on a system with gpfs installed and later on run on
systems without gpfs available.

So to actually make Samba call gpfs share mode calls you need to compile with
gpfs.h and libgpfs.so around and set 'gpfs share = yes' on the shares you
export from GPFS.

Volker
(This used to be commit 2253b17a1a88555291b59d52c826c81c2b8f7e7f)
2007-10-10 11:06:01 -05:00
Günther Deschner
1501a1755c r12415: Forgot newlines.
Guenther
(This used to be commit c727a1a330e50b0919ff705d9ebc55c72d8fdee4)
2007-10-10 11:05:55 -05:00
Günther Deschner
107fe91d2b r12414: Remove the unnecessary SMB_STRDUP in server_role_str() + reuse the role
translation elsewhere.

Guenther
(This used to be commit 6c4a6da3dc7cecce09890a0da7d97b9d1bb47827)
2007-10-10 11:05:55 -05:00
Volker Lendecke
7ae0fd8ed8 r12290: Typo
(This used to be commit de839cc1658b6394e153a1f027c29524b301625b)
2007-10-10 11:05:52 -05:00
Volker Lendecke
bd21ee68e5 r11999: Re-add "passdb expand explicit".
We came to the conclusion that changing the default is something that has to
wait one or two more releases, but it will happen one way or the other.

Volker
(This used to be commit 30fcdf84d8943e630af78a96320607c42e4d15aa)
2007-10-10 11:05:41 -05:00
Volker Lendecke
1bfb5b734b r11909: Implement 'reset on zero vc'. This kills other connections when a session
setup comes in with the vc (virtual connection) field set to zero. This is
done by Windows, probably you can tweak that by some registry key.

	This boolean option controls whether an incoming session setup
	should kill other connections coming from the same IP. This matches
        the default Windows 2003 behaviour.

	Setting this parameter to yes becomes necessary when you have a flaky
	network and windows decides to reconnect while the old connection
	still has files with share modes open. These files become inaccessible
	over the new connection.

	The client sends a zero VC on the new connection, and Windows 2003
	kills all other connections coming from the same IP. This way the
	locked files are accessible again.

	Please be aware that enabling this option will kill connections behind
	a masquerading router.

Volker
(This used to be commit 5629ca16235f0aa21fea3afd9e414309e4e1374e)
2007-10-10 11:05:34 -05:00
Volker Lendecke
05f7bec525 r11739: As per Jeremy's request, add a panic action for developers. Now configure.in
needs something along the lines of

if [ $LOGNAME == "jht" ]
then
   CFLAGS="$CFLAGS -DDEVELOPER"
fi

But that goes a bit far I think.... :-)))

Volker
(This used to be commit 99d76042e962405fcaeb974a55db563207e0f92a)
2007-10-10 11:05:26 -05:00
Volker Lendecke
88eb98275e r11734: Remove unused variable
(This used to be commit 5b882acafbacce6246b8f729eb8e347039ee16bd)
2007-10-10 11:05:26 -05:00