1
0
mirror of https://github.com/samba-team/samba.git synced 2025-05-01 22:50:23 +03:00

722 Commits

Author SHA1 Message Date
Jeremy Allison
a056eb85ff Missed one check on the memcpy for bug #7063.
Jeremy.
2010-02-09 14:56:12 -08:00
Jeremy Allison
539bbf8653 Second part of fix for bug 7063 - Samba 3.4.5 on ubuntu 8.04 64 bit - Core dumps.
Ensure we have no naked memcpy calls. This isn't a crash bug (it's
already checked in the data_blob_talloc_zero() above, but I want to
get into the pattern of having all memcpy's covered by safety checks.

Jeremy.
2010-02-09 14:48:15 -08:00
Jeremy Allison
110a6f29f0 Fix bug 7063 - Samba 3.4.5 on ubuntu 8.04 64 bit - Core dumps.
Reported and found by Martin Hochreiter <linuxbox@wavenet.at>.
Ensure we copy the right amount of registry data into the outgoing
buffer.

Jeremy.
2010-02-02 16:32:51 -08:00
Günther Deschner
f720f7512e s3-spoolss: stricter name checks when opening back-channel notify connection.
Make sure to always check if the name the client passed in
spoolss_RemoteFindFirstPrinterChangeNotifyEx is not one of our names.

Guenther
2010-01-19 14:14:30 +01:00
Günther Deschner
f20effc437 s3-spoolss: fix enumprinter key client and server.
Guenther
2009-12-10 17:48:50 +01:00
Günther Deschner
e14fb8f913 s3-spoolss: use SPOOLSS_ARCHITECTURE_ALL in driver enum server code.
Guenther
2009-12-08 16:20:51 +01:00
Günther Deschner
7770d1492b s3-spoolss: cleanup _spoolss_EnumPrinterDrivers().
Guenther
2009-12-08 11:51:02 +01:00
Günther Deschner
0efbd932b6 s3-spoolss: remove unused architecture from fill_printer_driver_info1().
Guenther
2009-12-08 11:50:54 +01:00
Günther Deschner
af08962c94 s3-spoolss: remove ridiculous amount of duplicate driver code.
Guenther
2009-12-08 11:50:47 +01:00
Günther Deschner
1c9eba40ae s3-spoolss: fully support level 8 drivers.
Guenther
2009-12-08 11:50:40 +01:00
Günther Deschner
35c50dcce3 s3-spoolss: use driver level info8 everywhere in spoolss server internally.
Guenther
2009-12-08 11:05:21 +01:00
Günther Deschner
ef9d6580ef s3-spoolss: let _spoolss_DeletePrinterData call into _spoolss_DeletePrinterDataEx.
Guenther
2009-12-07 14:42:13 +01:00
Günther Deschner
167dca0cbf s3-spoolss: let _spoolss_SetPrinterData call into _spoolss_SetPrinterDataEx.
Guenther
2009-12-07 14:42:13 +01:00
Günther Deschner
778124ea32 s3-spoolss: let _spoolss_GetPrinterData call into _spoolss_GetPrinterDataEx.
Guenther
2009-12-07 14:42:12 +01:00
Günther Deschner
459a968fb4 s3-spoolss: handle SEC_FLAG_MAXIMUM_ALLOWED in spoolss_OpenPrinterEx.
In case someone (smbtorture4) requests SEC_FLAG_MAXIMUM_ALLOWED, translate it
to a request of PRINTER_ACCESS_ADMINISTER.

Guenther
2009-12-03 23:49:03 +01:00
Günther Deschner
5f60855ba2 samba-spoolss: use spoolss_StringArray2 in spoolss_EnumPrinterKey.
This should finally resolve the endian issues we were seeing on sparc and is
much cleaner for spoolss clients and servers.

Guenther
2009-12-02 14:56:17 +01:00
Günther Deschner
753b9c6d56 s3-spoolss: fix fstrings in convert_devicemode() function.
Guenther
2009-11-30 23:29:29 +01:00
Günther Deschner
e512ccb5b6 s3-spoolss: simplify _spoolss_EnumPrinterKey a little more.
Guenther
2009-11-27 18:31:13 +01:00
Günther Deschner
49e464cef5 s3-spoolss: use macros to fillup driver levels.
Guenther
2009-11-27 01:09:10 +01:00
Günther Deschner
3d679a3b5f s3-rpc: Avoid including every pipe's client and server stubs everywhere in samba.
Guenther
2009-11-26 20:03:17 +01:00
Günther Deschner
85b6461174 s3-spoolss: pre cosmetics: reorder levels in construct_printer_info levels.
Guenther
2009-11-26 19:21:10 +01:00
Günther Deschner
e92470d442 s3-spoolss: re-arrange driver info level fillup functions.
Guenther
2009-11-24 16:48:19 +01:00
Günther Deschner
846aa18648 s3-spoolss: fixes for _spoolss_EnumPrinterKey client and server.
Thanks Metze for review!

Guenther
2009-11-24 15:49:35 +01:00
Günther Deschner
a6142987ac s3-spoolss: Fix GetPrinter level 101.
Guenther
2009-11-23 16:56:03 +01:00
Günther Deschner
ec56895bde s3-printing: use spoolss types and structs while getting and deleting drivers.
Guenther
2009-11-23 12:19:11 +01:00
Günther Deschner
68cc1166d9 s3-printing: use spoolss types and structs while adding drivers.
Guenther
2009-11-23 12:19:04 +01:00
Günther Deschner
d464151f3b s3-spoolss: fix spoolss_EnumPrinterKey client and server code.
Guenther
2009-11-23 11:44:43 +01:00
Günther Deschner
2c11b73391 s3-registry: use push_reg_sz().
Guenther
2009-09-30 00:29:49 +02:00
Günther Deschner
062d26d57b s3-spoolss: add stubs for new idl opcodes in spoolss server.
Guenther
2009-08-20 14:25:41 +02:00
Günther Deschner
53196955d4 s3-spoolss: remove another duplicate copy of print_architecture_table.
Guenther
2009-08-17 18:09:11 +02:00
Günther Deschner
74454cc731 s3-spoolss: Fix Bug #6568: _spoolss_GetPrintProcessorDirectory() implementation.
We should always return a local path so that users are not forced to setup a
[prnproc$] share on the server. This restores pre-3.4.0 spoolss behaviour.

Guenther
2009-08-04 18:50:59 +02:00
Günther Deschner
75030ff2b1 s3-spoolss: fix crash bug in spoolss_addprinterex_level_2.
Guenther
2009-08-04 00:16:37 +02:00
Jeremy Allison
5d05d22999 Added prefer_ipv4 bool parameter to resolve_name().
W2K3 DC's can have IPv6 addresses but won't serve
krb5/ldap or cldap on those addresses. Make sure when
we're asking for DC's we prefer IPv4.
If you have an IPv6-only network this prioritizing code
will be a no-op. And if you have a mixed network then you
need to prioritize IPv4 due to W2K3 DC's.
Jeremy.
2009-07-28 11:51:58 -07:00
Jeremy Allison
6a9e003910 Fix bug #6564 - SetPrinter fails (panics) as non root.
Missing become_root()/unbecome_root() around reload_services.
Jeremy.
2009-07-17 17:36:26 -07:00
Günther Deschner
33768fea07 s3-spoolss: make some of the command hooks static.
Guenther
2009-07-16 03:05:45 +02:00
Volker Lendecke
66152d29b3 Attempt to fix the build 2009-07-03 22:33:21 +02:00
Günther Deschner
bee0421f4c s3-spoolss: implement _spoolss_AddPrinter.
Guenther
2009-07-03 22:05:21 +02:00
Günther Deschner
b85b93dcff s3-spoolss: Bug #6512. Fix support for enumerating user forms.
Found while testing Xerox WorkCentre 133 PCL driver, now also tested with
torture test.

Guenther
2009-06-30 13:34:51 +02:00
Günther Deschner
118ac25784 s3-spoolss: restructure _spoolss_EndDocPrinter().
Guenther
2009-06-24 00:36:11 +02:00
Günther Deschner
6dd1f99ec0 s3-spoolss: add server-support for queries for the "all" architecture in printdriver enum calls.
Guenther
2009-06-08 21:24:31 +02:00
Günther Deschner
652251701d s3-printing: no need to define struct table_node 4 times.
Guenther
2009-05-13 15:27:06 +02:00
Günther Deschner
9966541f89 s3-printing: simplify print_queue helper functions and return WERROR.
Guenther
2009-05-06 10:19:04 +02:00
Günther Deschner
d22965e2e5 s3-spoolss: avoid referring to uid 0 in spoolss server (use sec_initial_uid() instead).
Guenther
2009-04-30 11:22:23 +02:00
Michael Adam
8185d31fb0 s3:registry: replace typedef REGISTRY_VALUE by struct regval_blob
Michael
2009-04-27 11:21:03 +02:00
Jeremy Allison
2012770393 Fix coverity #908, #909, uninitialized variable.
Jeremy.
2009-04-23 01:47:04 -07:00
Jeremy Allison
1e315b0013 Fix coverity #910, uninitialized variable.
Jeremy.
2009-04-23 01:38:21 -07:00
Jelmer Vernooij
f4195183a4 s3: Use common security_descriptor_equal(). 2009-04-21 18:17:40 +02:00
Volker Lendecke
9b3f2e69f7 Make "struct policy" private to srv_lsa_hnd.c 2009-04-19 09:27:14 +02:00
Günther Deschner
81b18464be s3-spoolss: remove some direct checks for 0 uid in AddForm,SetForm,DelForm.
Also add some become_root()/unbecome_root() pairs which were missing IMHO.

Guenther
2009-04-17 23:20:22 +02:00
Günther Deschner
6900d61d36 s3-spoolss: add support for _spoolss_EnumPrinterDrivers() level 6.
Guenther
2009-04-17 17:27:32 +02:00