sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-01-11 05:18:09 +03:00
Code
139,368 Commits 60 Branches 1,145 Tags 452 MiB
5af8627feb
Commit Graph

287 Commits

Author SHA1 Message Date
Aurélien Aptel
68305d90b3 clitar.c: create and free talloc context properly 
Signed-off-by: Aurélien Aptel <aurelien.aptel@gmail.com>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
 2014-02-19 18:22:29 +01:00
David Disseldorp
08f3c4e942 clitar: remove unnecessary public function prototypes 
Public functions declared in clitar_proto.h needn't be listed as
prototypes in clitar.c.

Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
 2014-02-19 18:22:29 +01:00
Aurélien Aptel
44265721bc clitar.c: add prototype, rearrange definition for easier reading. 
Signed-off-by: Aurélien Aptel <aurelien.aptel@gmail.com>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
 2014-02-19 18:22:28 +01:00
Aurélien Aptel
5cd72b39b3 clitar.c: documentation 
Signed-off-by: Aurélien Aptel <aurelien.aptel@gmail.com>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
 2014-02-19 18:22:28 +01:00
Aurélien Aptel
82dce8f7a8 clitar.c: honor regex flag, emulate old behaviour (and quirks), add tests 
Signed-off-by: Aurélien Aptel <aurelien.aptel@gmail.com>
[ddiss@samba.org: split from test changes already upstream]
Reviewed-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
 2014-02-19 18:22:28 +01:00
Aurélien Aptel
fc05ff32fd clitar.c: blocksize in block unit, fix error handling in tar_create(). 
Signed-off-by: Aurélien Aptel <aurelien.aptel@gmail.com>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
 2014-02-19 18:22:28 +01:00
Aurélien Aptel
3a7efaa009 clitar.c: when returning int, always use 0 for success 
Signed-off-by: Aurélien Aptel <aurelien.aptel@gmail.com>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
 2014-02-19 18:22:28 +01:00
Aurélien Aptel
9cb9077233 clitar.c: default block size was a multiple of TBLOCK 
Signed-off-by: Aurélien Aptel <aurelien.aptel@gmail.com>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
 2014-02-19 18:22:28 +01:00
Aurélien Aptel
7c973de802 clitar.c: only list <include list> instead of whole share, handle wildcards 
Signed-off-by: Aurélien Aptel <aurelien.aptel@gmail.com>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
 2014-02-19 18:22:28 +01:00
Aurélien Aptel
679cd16270 clitar.c: implement interactive command + respective test 
Signed-off-by: Aurélien Aptel <aurelien.aptel@gmail.com>
[ddiss@samba.org: split from test changes already upstream]
Reviewed-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
 2014-02-19 18:22:28 +01:00
Aurélien Aptel
3348b139d2 clitar.c: cosmetic changes 
Signed-off-by: Aurélien Aptel <aurelien.aptel@gmail.com>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
 2014-02-19 18:22:28 +01:00
Aurélien Aptel
5f99b0915d clitar.c: operation INCLUDE_LIST same as INCLUDE 
use local variable during argument parsing to separate
the 2 cases.

Signed-off-by: Aurélien Aptel <aurelien.aptel@gmail.com>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
 2014-02-19 18:22:28 +01:00
Aurélien Aptel
6d0ff6d2f0 clitar.c: fix creation exclusion, don't reverse in exclusion mode 
Signed-off-by: Aurélien Aptel <aurelien.aptel@gmail.com>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
 2014-02-19 18:22:28 +01:00
Aurélien Aptel
b825854005 clitar.c: fix include mode bug 
- if we include path/a/, path/ was skipped because
  it's not in path/a/.
- solution: add a flag to tar_path_in_list() to also
  check the opposite ie. if the list is in the path

Signed-off-by: Aurélien Aptel <aurelien.aptel@gmail.com>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
 2014-02-19 18:22:27 +01:00
Aurélien Aptel
cbad767ded clitar.c: implement reset mode 
Signed-off-by: Aurélien Aptel <aurelien.aptel@gmail.com>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
 2014-02-19 18:22:27 +01:00
Aurélien Aptel
e2b0092e1d clitar: implement exclusion filter for extraction 
Signed-off-by: Aurélien Aptel <aurelien.aptel@gmail.com>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
 2014-02-19 18:22:27 +01:00
Aurélien Aptel
d96e2b2052 clitar.c: implement dry mode, add total_size and fix write bug 
Signed-off-by: Aurélien Aptel <aurelien.aptel@gmail.com>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
 2014-02-19 18:22:27 +01:00
Aurélien Aptel
d23074cece clitar.c: add line in DBG macro 
Signed-off-by: Aurélien Aptel <aurelien.aptel@gmail.com>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
 2014-02-19 18:22:27 +01:00
Aurélien Aptel
39a21cdce3 clitar.c: implement nosystem, nohidden and include filter. 
Signed-off-by: Aurélien Aptel <aurelien.aptel@gmail.com>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
 2014-02-19 18:22:27 +01:00
Aurélien Aptel
9032fc7eec clitar.c: implement basic tar creation 
Signed-off-by: Aurélien Aptel <aurelien.aptel@gmail.com>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
 2014-02-19 18:22:27 +01:00
Aurélien Aptel
ec1583ebd4 clitar.c: don't create file when processing dir 
Signed-off-by: Aurélien Aptel <aurelien.aptel@gmail.com>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
 2014-02-19 18:22:27 +01:00
Aurélien Aptel
b7f6fd26b6 clitar.c: implement basic full extraction 
Signed-off-by: Aurélien Aptel <aurelien.aptel@gmail.com>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
 2014-02-19 18:22:27 +01:00
Aurélien Aptel
c9e23fd1a6 clitar.c: fix_unix_path() now replace / with \ 
Signed-off-by: Aurélien Aptel <aurelien.aptel@gmail.com>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
 2014-02-19 18:22:27 +01:00
Aurélien Aptel
dfd627b902 clitar.c: factor path_list handling in a function, remove tar_fd 
Signed-off-by: Aurélien Aptel <aurelien.aptel@gmail.com>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
 2014-02-19 18:22:27 +01:00
Aurélien Aptel
5af65f87b5 clitar.c: update TAR_DEFAULT_BLOCK_SIZE comment 
Signed-off-by: Aurélien Aptel <aurelien.aptel@gmail.com>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
 2014-02-19 18:22:27 +01:00
Aurélien Aptel
29542d1cb5 clitar.c: start processing tar files in extraction mode 
- move default block size to a define
- add doc comments
- basic processing in tar_extract

Signed-off-by: Aurélien Aptel <aurelien.aptel@gmail.com>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
 2014-02-19 18:22:27 +01:00
Aurélien Aptel
50d069637d client.c, clitar.c: rename process_tar to tar_process, prepare code 
Signed-off-by: Aurélien Aptel <aurelien.aptel@gmail.com>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
 2014-02-19 18:22:26 +01:00
Aurélien Aptel
60eec86ceb clitar.c, client.c: add flag to know if there's a tar operation to do. 
- remove tar_type global.

Signed-off-by: Aurélien Aptel <aurelien.aptel@gmail.com>
[ddiss@samba.org: rebase against lp_cli_maxprotocol() changes]
Reviewed-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
 2014-02-19 18:22:26 +01:00
Aurélien Aptel
b753900b09 clitar.c: fix path name when adding them 
Signed-off-by: Aurélien Aptel <aurelien.aptel@gmail.com>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
 2014-02-19 18:22:26 +01:00
Aurélien Aptel
3a8e3264d0 clitar: use lowercase for bool value 
Signed-off-by: Aurélien Aptel <aurelien.aptel@gmail.com>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
 2014-02-19 18:22:26 +01:00
Aurélien Aptel
113aa6f3d4 clitar.c: add tar_dump() debug function, fix bugs 
Signed-off-by: Aurélien Aptel <aurelien.aptel@gmail.com>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
 2014-02-19 18:22:26 +01:00
Aurélien Aptel
45a45c8eda implement argument parsing, split client_proto.h 
Signed-off-by: Aurélien Aptel <aurelien.aptel@gmail.com>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
 2014-02-19 18:22:26 +01:00
Aurélien Aptel
342d38eb4b clitar.c: start of argument parsing 
Signed-off-by: Aurélien Aptel <aurelien.aptel@gmail.com>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
 2014-02-19 18:22:26 +01:00
Aurélien Aptel
b9b5bc433d clitar.c: add doc, remove _t suffix in enum name 
Signed-off-by: Aurélien Aptel <aurelien.aptel@gmail.com>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
 2014-02-19 18:22:26 +01:00
Aurélien Aptel
a896f046fe clitar.c: add cmd_setmode(), remove typedef 
Signed-off-by: Aurélien Aptel <aurelien.aptel@gmail.com>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
 2014-02-19 18:22:26 +01:00
Aurélien Aptel
1d142c6237 clitar.c: expand context structure and implement cmd_block() 
Signed-off-by: Aurélien Aptel <aurelien.aptel@gmail.com>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
 2014-02-19 18:22:26 +01:00
Aurélien Aptel
2945596011 clitar.c: fresh new compilable file. 
Signed-off-by: Aurélien Aptel <aurelien.aptel@gmail.com>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
 2014-02-19 18:22:25 +01:00
Scott Lovenberg
bd18d996e2 Clean up client timeout definitions [rev. 2] 
The definitions for default client timeout values have been moved to client.h.  When initializing a client struct we use this value instead of the old hardcoded value.  The timeout value remains 20 seconds.

Signed-off-by: Scott Lovenberg <scott.lovenberg@gmail.com>
Reviewed by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu Dec  6 03:25:58 CET 2012 on sn-devel-104
 2012-12-06 03:25:58 +01:00
Salvador I. Gonzalez
4e4c3062bc Fix smbclient/tarmode panic on connecting to Windows 2000 clients. 
'Freed frame ../source3/libsmb/clilist.c:934, expected ../source3/client/clitar.c:821'
  Cause: (strequal(finfo->name,"..") || strequal(finfo->name,"."))
    evaluates to true, do_tar returns without freeing ctx

Signed-off-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Mon Aug 13 23:12:50 CEST 2012 on sn-devel-104
 2012-08-13 23:12:50 +02:00
Jeremy Allison
b70f23c2b5 Correctly check for errors in strlower_m() returns. 2012-08-09 12:08:18 -07:00
Jeremy Allison
0fefe24d6f Fix bug #8922. 
Looking at the do_list status returns was historically
ignored, allowing tar to continue after NT_STATUS_ACCESS_DENIED.
Return to this state.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri May 11 14:55:53 CEST 2012 on sn-devel-104
 2012-05-11 14:55:53 +02:00
Andrew Bartlett
6aa12fcb30 build: Remove SMB_OFF_T, replace with off_t 
Now that we always require a 64 bit off_t, we no longer need SMB_OFF_T.

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Fri Apr  6 01:47:43 CEST 2012 on sn-devel-104
 2012-04-06 01:47:43 +02:00
Andrew Bartlett
9cc056e567 build: Remove sys_creat wrapper 2012-04-05 02:39:08 +02:00
Masafumi Nakayama
909056a2da s3-cli: fix bug 563, >8GB tar on BE machines 
Borrows on existing patches proposed by Craig Barratt and Brad Ellis.

Signed-off-by: David Disseldorp <ddiss@suse.de>

Autobuild-User: David Disseldorp <ddiss@samba.org>
Autobuild-Date: Tue Jan  3 18:31:28 CET 2012 on sn-devel-104
 2012-01-03 18:31:28 +01:00
Jeremy Allison
c8a1082f2b Move the callers that need to use the new cli_open() back to calling 
it from cli_openx().
 2011-12-03 21:36:47 -08:00
Jeremy Allison
010566215b Convert smbclient to using NtCreateX by preference, fall back to openX on 
'not implemented' or similar error.
 2011-12-02 20:41:02 +01:00
Stefan Metzmacher
58482494fd s3:clitar: remove unused/not existing extern variables 
metze
 2011-09-13 13:16:07 +02:00
Björn Baumbach
bffc521a8a s3-client/clitar.c: replace cli_read_old() with cli_read() 
Signed-off-by: Stefan Metzmacher <metze@samba.org>
 2011-07-23 09:18:26 +02:00
Björn Baumbach
9b168e128a s3-libsmb: replace cli_read() with cli_read_old() 
Will introduce new cli_read() function.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
 2011-07-20 22:09:25 +02:00
Jeremy Allison
ee34c25c8a First part of fix for bug 8310 - toupper_ascii() is broken on big-endian systems 
Remove
int toupper_ascii(int c);
int tolower_ascii(int c);
int isupper_ascii(int c);
int islower_ascii(int c);

and replace with their _m equivalents, as they are identical.
 2011-07-19 13:19:29 -07:00
Stefan Metzmacher
5cc279eb34 s3:clitar: avoid usage of cli_errstr() 
metze
 2011-07-08 14:09:07 +02:00
Björn Baumbach
26f7c0771b s3-client/clitar.c: Fix cli_errstr() usage (part of bug #7864) 
Convert cli_errstr() to nt_errstr()

Signed-off-by: Stefan Metzmacher <metze@samba.org>
 2011-05-18 10:55:15 +02:00
Günther Deschner
27022587e3 s3-libsmb: move protos to libsmb/proto.h 
Guenther
 2011-05-06 16:37:18 +02:00
Jeremy Allison
9eee6e2fd2 More const fixes... getting near the end now. 
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri May  6 00:57:00 CEST 2011 on sn-devel-104
 2011-05-06 00:57:00 +02:00
Jeremy Allison
f85e095dd2 More simple const fixups. 2011-05-05 23:56:08 +02:00
Jeremy Allison
df023b8657 Tidy up some missing checks for NULL in strlcpy. 2011-05-04 12:12:15 -07:00
Jeremy Allison
6f7c4a0539 Convert safe_strXX to strlXXX. Clean up off-by-ones. 2011-05-04 12:12:15 -07:00
Andrew Bartlett
0520da2bbe s3-smb Use FILE_ATTRIBUTE_ARCHIVE intead of aARCH 
This means we use just one constant for this file attribute.

Andrew Bartlett
 2011-04-29 16:38:13 +10:00
Andrew Bartlett
0eca33bbf6 s3-smb Use FILE_ATTRIBUTE_DIRECTORY intead of aDIR 
This means we use just one constant for this file attribute.

Andrew Bartlett
 2011-04-29 16:38:13 +10:00
Andrew Bartlett
0a3c84b554 s3-smb Use FILE_ATTRIBUTE_SYSTEM intead of aSYSTEM 
This means we use just one constant for this file attribute.

Andrew Bartlett
 2011-04-29 16:38:13 +10:00
Andrew Bartlett
317e19aeb3 s3-smb Use FILE_ATTRIBUTE_HIDDEN intead of aHIDDEN 
This means we use just one constant for this file attribute.

Andrew Bartlett
 2011-04-29 16:38:12 +10:00
Andrew Bartlett
7f66ebde2e s3-smb Use FILE_ATTRIBUTE_READONLY intead of aRONLY 
This means we use just one constant for this file attribute.

Andrew Bartlett
 2011-04-29 16:38:12 +10:00
Volker Lendecke
0226428eb9 s3: Use cli_writeall instead of cli_write 
Signed-off-by: Jeremy Allison <jra@samba.org>
 2011-04-26 12:22:55 -07:00
Günther Deschner
0e771263ee s3-includes: only include system/filesys.h when needed. 
Guenther
 2011-03-30 01:13:07 +02:00
Volker Lendecke
7c868e6174 s3: Fix Coverity ID 83: RESOURCE_LEAK 2011-03-27 22:22:10 +02:00
Andrew Bartlett
9da4ace1d9 s3-debug Impove setup_logging() to specify logging to stderr 
This change improves the setup_logging() API so that callers which
wish to set up logging to stderr can simply ask for it, rather than
directly modify the dbf global variable.

Andrew Bartlett
 2010-11-02 04:36:04 +00:00
Jeremy Allison
14ff2e8de9 Fix bug #7700 - Improvement of return code of smbclient 
Based on an initial patch from H Hasegawa <hasegawa.hiroyuki@fujixerox.co.jp>.
Convert cli_list and associated functions to take calls that return NTSTATUS.

Jeremy.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri Oct 29 19:40:16 UTC 2010 on sn-devel-104
 2010-10-29 19:40:16 +00:00
Björn Jacke
5728b0fb5f s3: use monotonic clock for time deltas in smbtar 2010-08-31 10:26:09 +02:00
Volker Lendecke
fcdda8f443 s3: Remove "cli" from "struct finfo" 2010-07-30 17:01:33 +02:00
Volker Lendecke
dace013898 s3: Remove a typedef (struct file_info) 2010-07-27 21:05:35 +02:00
Andreas Schneider
ee01fe8c5b s3-client: Make sure we only write to an opened file. 
Found by clang-analyzer.
 2010-06-29 11:12:12 +02:00
Volker Lendecke
5ba42b0a5b s3: "tar_parseargs" only looks at the mtime 2009-11-29 11:22:02 +01:00
Volker Lendecke
e1f53e5d49 s3: "dotareof" only looks at the file type 2009-11-29 11:22:02 +01:00
Volker Lendecke
44ce5603dd s3: Pass the "fake dir create times" parameter to sys_*stat 
Step 0 to restore it as a per-share paramter
 2009-11-29 11:22:01 +01:00
Volker Lendecke
d6e55d8ec0 Revert "s3: Make the implicit reference to Protocol in mask_match_list() explicit" 
This reverts commit 1e22899d26.
 2009-11-23 16:35:00 +01:00
Volker Lendecke
0f8e2a6ebb Revert "s3: Move the global variable Protocol to struct smbd_server_connection" 
This reverts commit c85a4c9ba4.
 2009-11-23 16:34:59 +01:00
Volker Lendecke
c85a4c9ba4 s3: Move the global variable Protocol to struct smbd_server_connection 2009-11-21 20:49:17 +01:00
Volker Lendecke
1e22899d26 s3: Make the implicit reference to Protocol in mask_match_list() explicit 2009-11-21 20:49:17 +01:00
Volker Lendecke
49ca690b4b Introduce "struct stat_ex" as a replacement for SMB_STRUCT_STAT 
This patch introduces

struct stat_ex {
        dev_t           st_ex_dev;
        ino_t           st_ex_ino;
        mode_t          st_ex_mode;
        nlink_t         st_ex_nlink;
        uid_t           st_ex_uid;
        gid_t           st_ex_gid;
        dev_t           st_ex_rdev;
        off_t           st_ex_size;
        struct timespec st_ex_atime;
        struct timespec st_ex_mtime;
        struct timespec st_ex_ctime;
        struct timespec st_ex_btime; /* birthtime */
        blksize_t       st_ex_blksize;
        blkcnt_t        st_ex_blocks;
};
typedef struct stat_ex SMB_STRUCT_STAT;

It is really large because due to the friendly libc headers playing macro
tricks with fields like st_ino, so I renamed them to st_ex_xxx.

Why this change? To support birthtime, we already have quite a few #ifdef's at
places where it does not really belong. With a stat struct that we control, we
can consolidate the nanosecond timestamps and the birthtime deep in the VFS
stat calls.

At this moment it is triggered by a request to support the birthtime field for
GPFS. GPFS does not extend the system level struct stat, but instead has a
separate call that gets us the additional information beyond posix. Without
being able to do that within the VFS stat calls, that support would have to be
scattered around the main smbd code.

It will very likely break all the onefs modules, but I think the changes will
be reasonably easy to do.
 2009-05-26 17:48:23 +02:00
Jeremy Allison
606edf0f35 Make cli_setatr async. 
Jeremy.
 2009-05-06 16:13:42 -07:00
Jeremy Allison
4cbd0c77e4 Make cli_getatr() async. 
Jeremy.
 2009-05-05 20:59:22 -07:00
Volker Lendecke
4949a2cfaa Fix some warnings due to uint16_t!=-1 always being true 2009-05-03 22:48:31 +02:00
Jeremy Allison
f3af298e5b Cause cli_close to return an NTSTATUS. 
Jeremy.
 2009-04-30 16:57:42 -07:00
Jeremy Allison
8cf78ff553 Get medieval on our ass about SMB1 file descriptors being 16 bits, not an int. 
Convert all uses of cli_open(), cli_nt_createXXX to NTSTATUS versions.
This is smaller than it looks, it just fixes a lot of old code.
Next up, ensure all cli_XX functions return NTSTATUS.
Jeremy.
 2009-04-30 15:26:43 -07:00
Jeremy Allison
502f47c7c0 Make cli_chkpath async. 
Jeremy
 2009-04-22 06:46:42 -07:00
Jeremy Allison
dfc79de607 Make cli_mkdir async. Change it to return NTSTATUS. 
Jeremy.
 2009-04-21 05:52:34 -07:00
Jeremy Allison
66c0f3690a Fix bug #6161 - smbclient corrupts source path in tar mode 
This was my fault. I broke the smbclient tar argument processing
in creating the string for chdir when removing pstrings.
Jeremy.
 2009-03-05 17:19:18 -08:00
Jeremy Allison
07e0094365 Fix all warnings in source3 with gcc4.3. 
Jeremy.
 2008-12-31 18:06:57 -08:00
Jelmer Vernooij
4746f79d50 Use {u,}int64_t instead of SMB_BIG_{U,}INT. 2008-10-14 01:59:36 +02:00
Volker Lendecke
c8dfed63a6 Fix a brown paper bag segfault in clitar 
Thanks to "No Body is Perfect" from gmail, whoever that is :-)

Volker
(cherry picked from commit 679d8dfa39)
(This used to be commit b8e1d62b8e)
 2008-06-17 21:14:47 +02:00
Volker Lendecke
fa495ce1c1 Fix Coverity ID 564 
finfo1==NULL just does not happen in current code
(This used to be commit 9ea0078c31)
 2008-03-15 22:30:25 +01:00
Volker Lendecke
ba6c78c355 Fix Coverity ID 463 
(This used to be commit 21d126c56a)
 2008-01-24 16:31:55 +01:00
Volker Lendecke
587cf54c61 strtok -> strtok_r 
(This used to be commit fd34ce4370)
 2008-01-23 15:08:04 +01:00
Volker Lendecke
bea1659911 Remove next_token_nr_talloc and its associated global 
Only client.c and clitar.c used this, I think they should carry the static
themselves. Also move the a bit funny routine toktocliplist to clitar.c, the
only place where it is used.
(This used to be commit 86d9412611)
 2007-12-21 09:58:20 +01:00
Volker Lendecke
d58868f2a4 C++ warning 
(This used to be commit 85a7f800b6)
 2007-12-09 17:04:05 +01:00
Jeremy Allison
67344a467f Remove pstring from clitar.c 
Jeremy
(This used to be commit 1d5fee5038)
 2007-12-07 11:28:16 -08:00
Jeremy Allison
e67a6620a7 Add popt to binaries in makefile. Hack clitar to compile until I fix it. 
Jeremy.
(This used to be commit 252ef28bb8)
 2007-12-06 18:08:01 -08:00
Jeremy Allison
0cfad17e4a Fix bug #4393 smbclient does not store files with zero filesize in tar-archives 
from tometzky@batory.org.pl.
Jeremy.
(This used to be commit f3bd5e828a)
 2007-11-16 17:06:36 -08:00
Jeremy Allison
68be9a8200 More pstring removal. This one was tricky. I had to add 
one horror (pstring_clean_name()) which will have to
remain until I've removed all pstrings from the client code.
Jeremy.
(This used to be commit 1ea3ac8014)
 2007-11-15 14:19:52 -08:00
Jeremy Allison
30191d1a57 RIP BOOL. Convert BOOL -> bool. I found a few interesting 
bugs in various places whilst doing this (places that assumed
BOOL == int). I also need to fix the Samba4 pidl generation
(next checkin).
Jeremy.
(This used to be commit f35a266b3c)
 2007-10-18 17:40:25 -07:00