1
0
mirror of https://github.com/samba-team/samba.git synced 2024-12-27 03:21:53 +03:00
Commit Graph

48 Commits

Author SHA1 Message Date
Jeremy Allison
5ea101f048 Allow STR_TERMINATE and -1 src_len for pull_ucs2_base_talloc().
Jeremy.
(This used to be commit 063358d87a)
2007-12-04 15:21:14 -08:00
Günther Deschner
82089a2e84 Fix winreg callers.
Guenther
(This used to be commit 677d9e6d86)
2007-12-03 18:43:19 +01:00
Stefan Metzmacher
f9578af966 ndr: change NTSTAUS into enum ndr_err_code (samba3 callers)
lib/messages_local.c
rpc_client/ndr.c
smbd/notify_internal.c
utils/net_rpc_registry.c

metze
(This used to be commit c2645d2164)
2007-11-09 21:23:16 +01:00
Günther Deschner
fc22f295d0 Make sure we can read SACLs from the registry.
Guenther
(This used to be commit 62d4cce456)
2007-11-05 03:26:01 +01:00
Jeremy Allison
30191d1a57 RIP BOOL. Convert BOOL -> bool. I found a few interesting
bugs in various places whilst doing this (places that assumed
BOOL == int). I also need to fix the Samba4 pidl generation
(next checkin).
Jeremy.
(This used to be commit f35a266b3c)
2007-10-18 17:40:25 -07:00
Günther Deschner
5de28a07cc r25592: Allow to set sec_info for registry security descriptor queries.
Guenther
(This used to be commit 09e10d1d29)
2007-10-10 12:31:16 -05:00
Günther Deschner
ffd91e763e r25526: Fix usage output.
Guenther
(This used to be commit 31a0bf7b8c)
2007-10-10 12:31:12 -05:00
Günther Deschner
70001d3106 r25525: Add "net rpc registry getsd <keyname>" to display security descriptors.
Guenther
(This used to be commit 550ae11ad1)
2007-10-10 12:31:11 -05:00
Günther Deschner
c32358d001 r25314: Add HKEY_CURRENT_USER to reg_hive_key().
Guenther
(This used to be commit 693b3c26c0)
2007-10-10 12:30:58 -05:00
Michael Adam
46f199961f r24637: In order for "net rpc registry" to be able to write to
Samba's own registry, the access mask for opening the
registry for the write operations needs to be
SEC_RIGHTS_MAXIMUM_ALLOWED instead of REG_WRITE: we can
not open e.g. HKLM read write explicitly, since we can
not write to this virtual part of the registry, only
to the subkeys like 'HKLM\Software\Samba\smbconf' that
are stored on disk.

Note that MAXIMUM_ALLOWED is also what windows' regedit
passed to the open calls.

Michael
(This used to be commit 57c30f7319)
2007-10-10 12:30:12 -05:00
Volker Lendecke
6e419551ae r24057: Fix some uninitialized variables found by the IBM checker
(This used to be commit d74bbc53c2)
2007-10-10 12:29:00 -05:00
Andrew Tridgell
5e54558c6d r23784: use the GPLv3 boilerplate as recommended by the FSF and the license text
(This used to be commit b0132e94fc)
2007-10-10 12:28:22 -05:00
Jeremy Allison
d824b98f80 r23779: Change from v2 or later to v3 or later.
Jeremy.
(This used to be commit 407e6e695b)
2007-10-10 12:28:20 -05:00
Volker Lendecke
7192160599 r22747: Fix some C++ warnings
(This used to be commit a66a04e9f1)
2007-10-10 12:21:54 -05:00
Jelmer Vernooij
1052cadbae r21462: Fix EnumValue (?)
(This used to be commit e73a418b5b)
2007-10-10 12:18:06 -05:00
Jelmer Vernooij
62e11c4f17 r20832: Remove extra pointers previously added to unique [out] pointers. Instead,
add [ref] pointers where necessary (top-level [ref] pointers,
by spec, don't appear on the wire).

This brings us closer to the DCE/RPC standard again.
(This used to be commit 580f2a7197)
2007-10-10 12:17:11 -05:00
Volker Lendecke
8cc702bf5a r20498: Two 64-bit warnings
(This used to be commit 382827ebac)
2007-10-10 12:16:53 -05:00
Volker Lendecke
38cc572b1e r20003: Fix error message
(This used to be commit de05358351)
2007-10-10 12:16:19 -05:00
Volker Lendecke
ecf90c495e r19991: Sorry for this 2000-liner...
The main thing here is a rewrite of srv_winreg_nt.c. The core functionality
has moved to registry/reg_api.c which is then usable by the rest of Samba as
well.

On that way it fixes creating keys with more than one element in the
path. This did not work before.

Two things that sneaked in (sorry :-) is the change of some routines from
NTSTATUS to WERROR the removed "parent" argument to regkey_open_internal.

Volker
(This used to be commit fea52801de)
2007-10-10 12:16:18 -05:00
Volker Lendecke
f57cd1f63c r19914: The "default" value with the name "" need different 0-length treatment as the
other StringBufs, otherwise clicking on a key with this value being set leads
to regedit.exe on w2k3 chew all memory.
(This used to be commit b148cde7f3)
2007-10-10 12:16:09 -05:00
Volker Lendecke
334c868b83 r19827: Move registry_push/pull_value to lib/util_reg.c
(This used to be commit 3047a4b92c)
2007-10-10 12:16:00 -05:00
Volker Lendecke
6fad55ff89 r19825: To create a key, smbd also needs read privs assigned
(This used to be commit b2866b1318)
2007-10-10 12:16:00 -05:00
Volker Lendecke
ef4112922a r19822: Implement net rpc registry createkey, deletekey and deletevalue
(This used to be commit 419ebc92f0)
2007-10-10 12:15:59 -05:00
Volker Lendecke
e56be1dead r19821: Make net_rpc_registry use net_run_function2.
Fix an erroneous NT_STATUS_NO_MEMORY found by Chetan S <cshring@gmail.com>.

Thanks :-)

Volker
(This used to be commit 30f02e73fd)
2007-10-10 12:15:59 -05:00
Volker Lendecke
c63be3a4e7 r19818: Remove reg_split_hive, make use of registry_openkey
(This used to be commit 7fd1578a90)
2007-10-10 12:15:58 -05:00
Volker Lendecke
28bbef032f r19817: Implement net rpc registry setvalue (only dword and sz so far)
(This used to be commit 9ecb69c075)
2007-10-10 12:15:58 -05:00
Volker Lendecke
3b5d82cedd r19812: dump_regval_buf is not needed anymore
(This used to be commit f24e64160d)
2007-10-10 12:15:57 -05:00
Volker Lendecke
202f63e476 r19811: Decode REG_MULTI_SZ and REG_BINARY
(This used to be commit 6793301751)
2007-10-10 12:15:57 -05:00
Volker Lendecke
515dea007a r19807: First attempt at wrapping something sane around the registry API. Will be
extended.

Volker
(This used to be commit 40922eb924)
2007-10-10 12:15:57 -05:00
Volker Lendecke
ef012f8e7a r19804: Fix a valgrind error
(This used to be commit cb9e16c838)
2007-10-10 12:15:57 -05:00
Volker Lendecke
9849f04868 r19790: Check in the PIDL change and the converted unixinfo and winbind pipes without
waiting for comments. This is what version control is for, and it does fix a
segfault I ran into ;-)

Nevertheless, Jelmer & Jerry, please take a look!

Thanks,

Volker
(This used to be commit 95c14a822c)
2007-10-10 12:15:55 -05:00
Gerald Carter
18d4176633 r18981: * cleanup some vestiges of old cli_reg.c code and mark some TODO
items in cac_winreg.c
* Get 'net rpc registry enumerate' to list values again
* Fix winreg.idl QueryInfoKey().  The max_subkeysize is the
  max_classlen (we previously had this correct in Samba3")
* fix valgrind error about uninitialized memory and use-before-set
  on size value inmemset() call
* Fix key enumeration in 'net rpc registry enumerate'
* regenerate gen_dir files based on local pidl patches

Please note that the generated ndr files are from my local
copy of pidl.  If you need to regenerate, please apply the
patch that I posted to the samba-technical list earlier today.
(This used to be commit 5d843612a1)
2007-10-10 12:14:53 -05:00
Gerald Carter
95e4091596 r18964: fix 'net rpc registry save' to use the new wnireg client code
(This used to be commit f2747daafc)
2007-10-10 12:14:52 -05:00
Gerald Carter
bbaa0b178d r18919: * Get the new rpccli_winreg_XXXX() functions into the tree
There some broken functionality here that I'm still working on.
* remove unneeded parsing routines
(This used to be commit cbfe1a4b49)
2007-10-10 12:14:46 -05:00
Jeremy Allison
fbdcf2663b r16945: Sync trunk -> 3.0 for 3.0.24 code. Still need
to do the upper layer directories but this is what
everyone is waiting for....

Jeremy.
(This used to be commit 9dafb7f48c)
2007-10-10 11:19:14 -05:00
Jeremy Allison
2ef834cdd8 r16614: Klocwork #2012. memleak on error path.
Jeremy.
(This used to be commit 58b9adb849)
2007-10-10 11:19:03 -05:00
Jeremy Allison
8413a18a58 r16612: Klocwork fix #2011. memleak on error path.
Jeremy.
(This used to be commit b4e9475d2a)
2007-10-10 11:19:03 -05:00
Volker Lendecke
e7fc37cf0f r16360: Fix Klocwork ID 136 520 521 522 523 542 574 575 576 607
in net_rpc.c: 715 716 732 734 735 736 737 738 739 749

in net_rpc_audit.c: 754 755 756

in net_rpc_join.c: 757

in net_rpc_registry: 766 767

in net_rpc_samsync.c: 771 773

in net_sam.c: 797 798

Volker
(This used to be commit 3df0bf7d60)
2007-10-10 11:18:48 -05:00
Günther Deschner
c34e73cfcf r14146: Just some typos.
Guenther
(This used to be commit ade86cc787)
2007-10-10 11:15:13 -05:00
Lars Müller
c42be9fd38 r12986: Use d_fprintf(stderr, ...) for any error message in net.
All 'usage' messages are still printed to stdout.

Fix some compiler warnings for system() calls where we didn't used the
return code.  Add appropriate error messages and return with the error
code we got from system() or NT_STATUS_UNSUCCESSFUL.
(This used to be commit f650e3bdaf)
2007-10-10 11:06:09 -05:00
Gerald Carter
10b182fe73 r12870: fixing net rpc registry enumerate from overwritnig the open subkey handle
(This used to be commit cc2e7052bd)
2007-10-10 11:06:05 -05:00
Gerald Carter
77460a9075 r11579: syncing up perf counter code cfrom trunk
(This used to be commit 59c00924b6)
2007-10-10 11:05:21 -05:00
Jeremy Allison
8d7c886671 r11137: Compile with only 2 warnings (I'm still working on that code) on a gcc4
x86_64 box.
Jeremy.
(This used to be commit d720867a78)
2007-10-10 11:05:02 -05:00
Gerald Carter
54abd2aa66 r10656: BIG merge from trunk. Features not copied over
* \PIPE\unixinfo
* winbindd's {group,alias}membership new functions
* winbindd's lookupsids() functionality
* swat (trunk changes to be reverted as per discussion with Deryck)
(This used to be commit 939c3cb5d7)
2007-10-10 11:04:48 -05:00
Gerald Carter
44707ad2e0 r9739: conver the reg_objects (REGSUBKEY_CTR & REGVAL_CTR) to use
the new talloc() features:

 Note that the REGSUB_CTR and REGVAL_CTR objects *must* be talloc()'d
 since the methods use the object pointer as the talloc context for
 internal private data.

 There is no longer a regXXX_ctr_intit() and regXXX_ctr_destroy()
 pair of functions.  Simply TALLOC_ZERO_P() and TALLOC_FREE() the
 object.

Also had to convert the printer_info_2->NT_PRINTER_DATA field
to be talloc()'d as well.  This is just a stop on the road to
cleaning up the printer memory management.
(This used to be commit ef721333ab)
2007-10-10 11:03:25 -05:00
Gerald Carter
2129d3c711 r7691: * add .gdbinit to the svn:ignore files
* start adding write support to the Samba registry
  Flesh out the server implementations of
  RegCreateKey(), RegSetValue(), RegDeleteKey() and RegDeleteValue()

I can create a new key using regedit.exe now but the 'New Key #1'
key cannot be deleted yet.
(This used to be commit e188fdbef8)
2007-10-10 10:57:19 -05:00
Gerald Carter
d5e79de595 r6995: * fixing segfault when writing out registry values of zero length
* add RegSaveKey() client function
* add 'net rpc registry save' subcommand
(This used to be commit f35e0a0a8d)
2007-10-10 10:57:00 -05:00
Gerald Carter
f0c650a382 r6942: * merging the registry changes back to the 3.0 tree
* removing the testprns tool
(This used to be commit 81ffb0dbbb)
2007-10-10 10:56:57 -05:00