Stefan Metzmacher
efc2c3159e
s3:cli_pipe: make use of cli_state_remote_name()
...
metze
2011-07-22 17:06:09 +02:00
Stefan Metzmacher
ef23fb3412
s3:cli_pipe: use result->desthost instead of cli->desthost
...
metze
2011-07-22 17:06:09 +02:00
Andrew Bartlett
74eed8f3ed
s3-param Remove special case for global_myname(), rename to lp_netbios_name()
...
There is no reason this can't be a normal constant string in the
loadparm system, now that we have lp_set_cmdline() to handle overrides
correctly.
Andrew Bartlett
2011-06-09 12:40:09 +02:00
Andrew Bartlett
ad0a07c531
s3-talloc Change TALLOC_ZERO_P() to talloc_zero()
...
Using the standard macro makes it easier to move code into common, as
TALLOC_ZERO_P isn't standard talloc.
2011-06-09 12:40:08 +02:00
Andrew Bartlett
3d15137653
s3-talloc Change TALLOC_ARRAY() to talloc_array()
...
Using the standard macro makes it easier to move code into common, as
TALLOC_ARRAY isn't standard talloc.
2011-06-09 12:40:08 +02:00
Günther Deschner
675573d54b
s3-includes: finally only include client.h when libsmb is used.
...
Guenther
2011-05-06 16:37:22 +02:00
Jeremy Allison
4f41be356a
Fix many const compiler warnings.
2011-05-05 10:41:59 -07:00
Günther Deschner
bd92826aa8
s3-rpc_client: run minimal_includes.pl.
...
Guenther
2011-05-05 02:05:27 +02:00
Günther Deschner
0bb4701a74
s3: remove various references to server side dcerpc structs (which are not needed).
...
Guenther
2011-05-02 15:03:44 +02:00
Günther Deschner
50883cfeb4
s3-tevent: only include ../lib/util/tevent wrappers where needed.
...
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri Apr 29 14:00:30 CEST 2011 on sn-devel-104
2011-04-29 14:00:30 +02:00
Stefan Metzmacher
f7bc84409a
s3:rpc_client: map fault codes to NTSTATUS with dcerpc_fault_to_nt_status()
...
Most fault codes have a NTSTATUS representation, so use that.
This brings the fault handling in common with the source4/librpc/rpc code,
which make it possible to share more highlevel code, between source3 and
source4 as the error checking can be the same now.
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Sun Apr 24 10:44:53 CEST 2011 on sn-devel-104
2011-04-24 10:44:53 +02:00
Volker Lendecke
9a0676d5c9
s3: Fix Coverity ID 986, BUFFER_SIZE_WARNING
...
strncpy can leave the destination unterminated
2011-04-22 10:06:34 +02:00
Günther Deschner
4b3fe5247a
s3-cli_pipe: fix timeout in rpc_pipe_open_tcp_port().
...
Make sure we use a timeout of 60 seconds, not 60 milliseconds...
This prevented us from successfully using the ncacn_ip_tcp client in a lot of
places, I guess.
Guenther
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Apr 13 18:59:19 CEST 2011 on sn-devel-104
2011-04-13 18:59:19 +02:00
Günther Deschner
6e3f0d28a4
s3-includes: only include ntdomain.h where needed.
...
Guenther
2011-03-30 01:13:09 +02:00
Andreas Schneider
da718a5961
s3-epmapper: Use DCERPC_AUTH_LEVEL_CONNECT for ep ncalrpc.
2011-03-23 17:19:22 +01:00
Volker Lendecke
889e03617d
s3: Fix Coverity ID 2232, REVERSE_INULL
...
No point checking for !cli after dereferencing it
2011-03-16 22:07:24 +01:00
Andreas Schneider
038042363a
s3-rpc_client: Don't ask endpoint mapper for its own port.
2011-03-09 09:28:42 +01:00
Andreas Schneider
d343409d6b
s3-rpc_client: Added DCERPC_AUTH_TYPE_NCALRPC bind.
...
Signed-off-by: Günther Deschner <gd@samba.org>
2011-03-08 11:41:29 +01:00
Andreas Schneider
bf18403c81
s3-rpc_client: Move client pipe functions to own header.
2011-02-28 18:15:04 +01:00
Stefan Metzmacher
f915dd5dd4
s3:rpc_client: make rpccli_bh_create() non-static for now
...
metze
2011-02-09 11:46:20 +01:00
Günther Deschner
1232fb5a1e
s3-rpc_client: remove some more obsolete cli_X.h header files.
...
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri Jan 28 11:18:44 CET 2011 on sn-devel-104
2011-01-28 11:18:44 +01:00
Günther Deschner
1f26b101ed
s3-rpc_client: fix uninitialized variable found by -O3.
...
Guenther
2011-01-21 16:10:15 +01:00
Stefan Metzmacher
fba2fdf265
s3:rpc_client: use dcerpc_epm_Map() and don't ignore 'result' anymore.
...
metze
2011-01-04 21:28:49 +01:00
Simo Sorce
3453bc7b11
s3-dcerpc: make auth context opaque
...
This way we always double check in advance that the context
is of the right type with talloc_get_type_abort instead of
potentially accessing random memory by addressing the wrong
structure in the union.
Signed-off-by: Günther Deschner <gd@samba.org>
2010-09-23 10:54:24 -07:00
Simo Sorce
d10e192b83
s3-dcerpc: finally remove the legaqcy spnego_type variable from pipe_auth_data
...
Signed-off-by: Günther Deschner <gd@samba.org>
2010-09-23 10:54:23 -07:00
Simo Sorce
2c9f420d75
s3-dcerpc: move client spnego stuff in /librpc/crypto
...
Signed-off-by: Günther Deschner <gd@samba.org>
2010-09-23 10:54:22 -07:00
Simo Sorce
59722ef2fb
spnego: avoid explicit dependency on dcerpc specific structures
...
Signed-off-by: Günther Deschner <gd@samba.org>
2010-09-23 10:54:22 -07:00
Simo Sorce
412ebad02b
gssapi: avoid explicit dependency on dcerpc specific structures
...
Signed-off-by: Günther Deschner <gd@samba.org>
2010-09-23 10:36:54 -07:00
Simo Sorce
0e5eb82a6f
s3-dcerpc: move crypto stuff in /librpc/crypto
...
Signed-off-by: Günther Deschner <gd@samba.org>
2010-09-23 10:36:54 -07:00
Stefan Metzmacher
78b6265ac2
s3:rpc_client: remove unused rpc_pipe_set_hnd_state()
...
metze
2010-09-17 15:42:36 +02:00
Stefan Metzmacher
fde3412ccb
s3:rpc_client: use rpc_api_pipe_send() for auth3
...
metze
2010-09-17 15:42:35 +02:00
Stefan Metzmacher
6ecf8d16bc
s3:rpc_client: rpc_pipe_bind_step_one_done() doesn't need reply_pdu
...
metze
2010-09-17 15:42:35 +02:00
Stefan Metzmacher
de6254d3d6
s3:rpc_client: allow DCERPC_PKT_AUTH3 via rpc_api_pipe_send/recv
...
metze
2010-09-17 15:42:34 +02:00
Stefan Metzmacher
a510b9de39
s3:rpc_client: implement rpccli_bh_set_timeout()
...
metze
2010-09-04 09:01:15 +02:00
Günther Deschner
7b6fc9f414
s3-dcerpc: only include rpc_dce.h where needed.
...
Guenther
2010-08-26 00:20:29 +02:00
Günther Deschner
0ed16e94c3
s3: separate out cli schannel functions that depend on cli_netlogon.
...
Guenther
2010-08-26 00:16:57 +02:00
Günther Deschner
898c612335
s3-dcerpc: avoid talloc_move on schannel creds in cli_rpc_pipe_open_schannel_with_key().
...
Initially, the schannel creds were talloc memduped, then, during the netlogon
creds client merge (baf7274fed
) they were first
talloc_referenced and then later (53765c81f7
)
talloc_moved.
The issue with using talloc_move here is that users of that function in winbind
will only be able to have two schanneled connections, as the cached schannel
credentials pointer from the netlogon pipe will be set to NULL. Do a deep copy
of the struct instead.
Guenther
2010-08-24 02:04:27 +02:00
Simo Sorce
a782a80d2f
s3-dcerpc: Allocate structure members on the right context
2010-08-23 17:11:32 -04:00
Günther Deschner
35052d71d3
s3-dcerpc: fix uninitialized variable in cli_get_session_key().
...
Simo, please check.
Guenther
2010-08-17 13:06:13 +02:00
Simo Sorce
f40ef7e24c
s3-dcerpc: Use common send functions for ntlmssp too
...
Remove unused function.
2010-08-17 06:33:14 -04:00
Simo Sorce
86914b8fab
s3-dcerpc: properly implement gse/spnego_get_session_key
2010-08-17 06:33:13 -04:00
Simo Sorce
26a3ba60e6
s3-dcerpc: Check data and return appropriate error
2010-08-17 06:33:13 -04:00
Simo Sorce
9a9a38c666
Change debug statements to use __location__
2010-08-17 06:33:13 -04:00
Simo Sorce
72a0098415
s3-dcerpc: Pull packet in the caller, before validation
2010-08-17 06:33:13 -04:00
Simo Sorce
558320cf58
Add my (c)
2010-08-17 06:33:13 -04:00
Stefan Metzmacher
745f63fd1e
s3:rpc_client: remove unused cli_do_rpc_ndr* functions
...
metze
2010-08-16 14:30:18 +02:00
Stefan Metzmacher
dd16d3b2d6
s3:rpc_client: remove unused rpc_pipe_open_local()
...
metze
2010-08-16 14:30:17 +02:00
Stefan Metzmacher
2c0e296dd7
s3:rpc_client: add dcerpc_binding_handle backend
...
metze
2010-08-12 14:31:21 +02:00
Günther Deschner
64b26affe0
s3-dcerpc: fix some uninitialized variables build warnings.
...
Guenther
2010-08-03 15:57:56 +02:00
Simo Sorce
4c64e4d4af
s3-dceprc: Improve dcerpc_guess_sizes() interface
...
Make it possible to pass in the NDR padding size so that theoretically
client and server code can decide to use a different alignment.
Pass in the header length as a parameter so that this function can be used for
different type of packets.
Make sure padding size will not make the fragment exceed the maximum length.
Calculate padding taking in account the header length.
2010-07-30 14:55:28 -04:00
Simo Sorce
a9d3a596a7
s3-dcerpc: Make function to guess pdu sizes common.
2010-07-30 14:55:27 -04:00
Simo Sorce
9329a9fe84
s3-dceprc: consolidate use of dcerpc_push_dcerpc_auth()
2010-07-30 14:55:27 -04:00
Simo Sorce
da6c246aac
s3-dcerpc: Remove unused functions
2010-07-30 14:55:27 -04:00
Simo Sorce
186f93633b
s3-dcerpc: use common spengo wrapper code for client SPNEGO/NTLMSSP
2010-07-30 14:55:27 -04:00
Simo Sorce
984438ca15
s3-dcerpc: add sign/seal support when using SPNEGO/KRB5
2010-07-30 14:55:27 -04:00
Simo Sorce
0b24e8e869
s3-dcerpc: Add SPNEGO incapsulation for KRB5 auth
2010-07-30 14:55:27 -04:00
Simo Sorce
7c9c075987
Do not refernece pipe_auth_data directly in dcerpc_gssapi.c
2010-07-28 15:53:56 -04:00
Simo Sorce
d17abc69f6
s3-dcerpc: Avoid ifdef, it is handled within dcerpc_gssapi.c already
2010-07-28 15:35:59 -04:00
Simo Sorce
7eaa15af2c
s3-dcerpc: Add sign/seal with gssapi
2010-07-28 12:42:15 -04:00
Simo Sorce
1abcbd70ae
s3-dcerpc: Add next authentication step with gssapi
2010-07-28 12:24:44 -04:00
Simo Sorce
135a82e78f
s3-decrpc: Introduce gssapi support for dcerpc krb5 auth
2010-07-28 12:24:44 -04:00
Simo Sorce
183e0a0d9f
s3-dcerpc: Refactor calculate_data_len_tosend()
2010-07-28 12:23:22 -04:00
Simo Sorce
c08d684f4e
s3-dcerpc: Add auth trailer only when appropriate.
2010-07-28 12:23:00 -04:00
Simo Sorce
866f85e319
s3-dcerpc: consolidate unmarshalling of dcerpc_auth
2010-07-28 12:22:31 -04:00
Simo Sorce
146af48d48
s3-dcerpc: revive cli_rpc_pipe_open_krb5()
2010-07-28 12:21:29 -04:00
Simo Sorce
2463a87177
s3-dcerpc: Use dcerpc_AuthType in pipe_auth_data
2010-07-28 12:19:32 -04:00
Simo Sorce
1e915d231d
s3-dcerpc: Cleanup and refactor create_rpc_bind_req()
2010-07-28 12:18:45 -04:00
Simo Sorce
7407c979a1
s3-dcerpc: Use dcerpc_check_auth in client code too
2010-07-28 12:17:56 -04:00
Simo Sorce
3139333419
s3-dcerpc: Move dcerpc_add_auth_footer() to the common helpers file
2010-07-28 12:15:13 -04:00
Simo Sorce
6f5cdf9ae9
s3-dcerpc: Introduce generic helper function to add auth trailer
2010-07-28 12:14:59 -04:00
Simo Sorce
1b572493e2
s3-dcerpc: Pass explicit arguments so that this is not client specific
2010-07-28 12:14:36 -04:00
Simo Sorce
e2b0e43da9
s3-dcerpc: Move marshalling of dcerpc_auth_header in the callers
2010-07-28 12:14:19 -04:00
Simo Sorce
636de433ac
cleaup: Reformat cli_get_session_key()
...
merge cli_get_session_key
2010-07-21 19:14:23 -04:00
Simo Sorce
26f1218a36
s3-libsmb: Use data_blob_talloc to get krb5 ticket and session keys
2010-07-20 20:02:09 -04:00
Jeremy Allison
5002b3a90d
Add approriate TALLOC_CTX's thoughout the spnego code. No more implicit NULL contexts.
...
Jeremy.
2010-07-20 16:17:58 -07:00
Jeremy Allison
cce19c5162
Fix one more data_blob -> data_blob_talloc. Move away from implicit NULL context tallocs.
...
Jeremy.
2010-07-20 14:59:31 -07:00
Simo Sorce
4581902553
s3-dcerpc: Unifiy cli_pipe_auth_data and pipe_auth_data
...
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2010-07-20 15:52:37 +10:00
Jeremy Allison
0bb8d133c9
Remove gen_negTokenInit() - change all callers to spnego_gen_negTokenInit().
...
We now have one function to do this in all calling code. More rationalization
to follow.
Jeremy.
2010-07-19 17:14:26 -07:00
Simo Sorce
cdcdaaa6dd
s3-ntlmssp: Remove ntlmssp_end and let the talloc hierarchy handle it.
...
All the members are children of ntlmssp_state anyway.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2010-07-19 14:19:47 +10:00
Simo Sorce
628b57ca37
s3-dcerpc: Move common cli/srv functions into a common file
2010-07-17 15:01:11 -04:00
Volker Lendecke
3925411de4
s3: Really fix the 64-bit warnings
...
Hmm. Forgot to git commit this piece, sorry :-(
2010-07-17 20:21:19 +02:00
Volker Lendecke
32fd6e3c25
s3: Fix some 64-bit warnings
2010-07-17 19:58:21 +02:00
Günther Deschner
c5e85a4987
s3-dcerpc: rename SCHANNEL_SIG_SIZE to NL_AUTH_SIGNATURE_SIZE and move to IDL.
...
Guenther
2010-07-16 23:09:54 +02:00
Simo Sorce
65116adceb
s3-dcerpc: Fix ability to receive Big Endian PDUs
2010-07-16 16:02:39 -04:00
Günther Deschner
7cf4797dd3
s3-dcerpc: fix c++ warning.
...
Guenther
2010-07-16 01:51:18 +02:00
Simo Sorce
8f2bfa88b5
s3-dcerpc: Use DATA_BLOB instead of prs_struct for req_data
...
Signed-off-by: Günther Deschner <gd@samba.org>
2010-07-16 01:51:18 +02:00
Simo Sorce
8e9cd4144e
s3-dcerpc: Use DATA_BLOB instead of prs_struct for rpc_out
...
Signed-off-by: Günther Deschner <gd@samba.org>
2010-07-16 01:51:18 +02:00
Simo Sorce
3b83211cd8
s3-dcerpc: Avoid unnecessary memory allocation for dcerpc_ctx_list
...
Signed-off-by: Günther Deschner <gd@samba.org>
2010-07-16 01:51:18 +02:00
Simo Sorce
ff121c89d3
s3-dcerpc: Use DATA_BLOB instead of prs_struct for reply_pdu
...
Signed-off-by: Günther Deschner <gd@samba.org>
2010-07-16 01:51:17 +02:00
Simo Sorce
b44a91b220
s3-dcerpc: Use DATA_BLOB instead of prs_struct for incoming fragments
...
Signed-off-by: Günther Deschner <gd@samba.org>
2010-07-16 01:51:17 +02:00
Simo Sorce
cc15396c8a
s3-dcerpc: Read a pdu in 2 steps, header first the payload
...
We can't really cope with receiving more data than expected anyway
as there is code that checks if the size of the buffer is consistent with
pkt->frag_length and throws an error if not.
Signed-off-by: Günther Deschner <gd@samba.org>
2010-07-16 01:51:17 +02:00
Simo Sorce
79c207ed62
s3-dceprc: Use IDL defined constants for length calculations
...
Signed-off-by: Günther Deschner <gd@samba.org>
2010-07-16 01:51:17 +02:00
Simo Sorce
84c50a248e
Reformat and cleanup
...
Signed-off-by: Günther Deschner <gd@samba.org>
2010-07-16 01:51:17 +02:00
Simo Sorce
bd19c964d5
s3-dcerpc: Move common helpers into a common file
...
Signed-off-by: Günther Deschner <gd@samba.org>
2010-07-16 01:51:17 +02:00
Simo Sorce
cb3725a931
dcerpc: remove ncacn_packet_header and related functions
...
ncacn_packet_header was an artifact and it is not necessary anymore
Signed-off-by: Günther Deschner <gd@samba.org>
2010-07-16 01:51:17 +02:00
Simo Sorce
f9a15d1d94
s3-dcerpc: Refactor code and stop using ncacn_packet_header
...
Signed-off-by: Günther Deschner <gd@samba.org>
2010-07-16 01:51:17 +02:00
Simo Sorce
2452a7a4c1
s3-dcerpc: consolidate respones packet creation code
...
Signed-off-by: Günther Deschner <gd@samba.org>
2010-07-16 01:51:16 +02:00
Simo Sorce
f0626d14f0
s3-dcerpc: Stop using hand marshalling in rpc_finish_auth3_bind_send()
...
Signed-off-by: Günther Deschner <gd@samba.org>
2010-07-16 01:51:16 +02:00
Simo Sorce
7d9c62c646
s3-dcerpc: Do not parse the packet twice.
...
Signed-off-by: Günther Deschner <gd@samba.org>
2010-07-16 01:51:16 +02:00
Simo Sorce
282db1f5d2
s3-dcerpc: Remove unused function
...
Signed-off-by: Günther Deschner <gd@samba.org>
2010-07-16 01:51:16 +02:00