sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2024-12-28 07:21:54 +03:00
Code
53,398 Commits 60 Branches 1,144 Tags 452 MiB
5c76472491
Commit Graph

2735 Commits

Author SHA1 Message Date
Günther Deschner
a21bfc4daf s3-samr: Fix SetUserInfo level 16 and 21 w.r.t. ACB_AUTOLOCK acct_flag. 
It is not allowed to *set* this flag remotely if it has been not set already.

Found by torture test.

Guenther
 2009-05-09 00:03:50 +02:00
Günther Deschner
705f36b804 s3-samr: Fix SetUserInfo level 7 when there has been no name change. 
Found by torture test.

Guenther
 2009-05-09 00:02:00 +02:00
Günther Deschner
b7925cb3f2 s3-samr: more accurateness in _samr_SetDomainInfo(). 
Guenther
 2009-05-08 22:15:31 +02:00
Günther Deschner
266b79e004 s3-samr: implement more info levels in _samr_QueryDomainInfo(). 
Gets us closer to pass RPC-SAMR.

Guenther
 2009-05-08 09:55:10 +02:00
Günther Deschner
d7b32b51f8 s3-samr: Fix potential memory leak in _samr_ChangePasswordUser(). 
Guenther
 2009-05-08 01:24:28 +02:00
Günther Deschner
6f4b5798c9 s3-selftest: need to enable lanman auth in order make RPC-SAMR-PASSWORDS pass. 
Guenther
 2009-05-08 00:46:54 +02:00
Günther Deschner
227b61d7ea s3-samr: Do not leak information whether a user exist or not in pwd change calls. 
Found by torture test.

Guenther
 2009-05-08 00:46:54 +02:00
Günther Deschner
5773d7d102 s3-samr: implement _samr_ChangePasswordUser(). 
This is vastly copied from samba4 samr server.

Guenther
 2009-05-08 00:46:49 +02:00
Günther Deschner
d17c6af57c s3-samr: implement _samr_OemChangePasswordUser2(). 
Guenther
 2009-05-08 00:44:46 +02:00
Günther Deschner
6aca5fca8d s3-samr: Let _samr_TestPrivateFunctionsUser() return not supported. 
This is to get us closer to pass RPC-SAMR-USERS.

Guenther
 2009-05-08 00:41:40 +02:00
Günther Deschner
b96fdae1f4 s3-samr: Do not return users in _samr_QueryDisplayInfo() for builtin domain. 
Found by torture test.

Guenther
 2009-05-08 00:41:40 +02:00
Günther Deschner
f05d888d7a s3-samr: let set_user_info_16 and 20 follow the same pattern as all other levels. 
Guenther
 2009-05-08 00:41:40 +02:00
Günther Deschner
f93f713898 s3-samr: support some more info levels in samr_SetUserInfo calls. 
Guenther
 2009-05-08 00:41:40 +02:00
Günther Deschner
b0df0e8cc7 s3-samr: support some more info levels in samr_QueryUser calls. 
Guenther
 2009-05-08 00:41:40 +02:00
Günther Deschner
599b9fe86e s3-samr: Fix _samr_Connect5(). In error case it still needs to return empty info1. 
Guenther
 2009-05-07 14:33:33 +02:00
Jeremy Allison
78fb479325 After getting confirmation from Guenther, add 3 changes we'll 
ultimately need to fix bug #6099 Samba returns incurrate capabilities list.
1). Add a comment to point out that r->in.negotiate_flags is an aliased pointer to
r->out.negotiate_flags.
2). Ensure we return NETLOGON_NEG_STRONG_KEYS in our flags
return if the client requested it.
3). Clean up the error exits so we always return the same
way.
Signed off by Guenther.
Jeremy.
 2009-05-06 16:10:20 -07:00
Günther Deschner
78754ab2c9 s3-netlogon: Fix NETLOGON credential chain. Fixes Bug #6099 (Windows 7 joining Samba3) and probably many, many more. 
Jeremy, with 9a5d5cc1db you alter the in negotiate
flags (which are a pointer to the out negotiate flags assigned in the generated
netlogon server code). So, while you wanted to just set the *out* negflags, you
did in fact reset the *in* negflags, effectively eliminating the
NETLOGON_NEG_STRONG_KEYS bit (formerly known as NETLOGON_NEG_128BIT) which then
caused creds_server_init() to generate 64bit creds instead of 128bit, causing
the whole chain to break. *Please* check.

Guenther
 2009-05-06 19:37:39 +02:00
Günther Deschner
9966541f89 s3-printing: simplify print_queue helper functions and return WERROR. 
Guenther
 2009-05-06 10:19:04 +02:00
Günther Deschner
af5a71d528 s3-lsa: use LSA_POLICY_MODE flags in _lsa_GetSystemAccessAccount(). 
Guenther
 2009-04-30 14:28:38 +02:00
Günther Deschner
d22965e2e5 s3-spoolss: avoid referring to uid 0 in spoolss server (use sec_initial_uid() instead). 
Guenther
 2009-04-30 11:22:23 +02:00
Günther Deschner
dd33abf649 s3-svcctl: Fix crash in _svcctl_EnumServicesStatusW(). 
The resume handle is a unique pointer, always check before dereference.

Guenther
 2009-04-28 10:37:34 +02:00
Michael Adam
8185d31fb0 s3:registry: replace typedef REGISTRY_VALUE by struct regval_blob 
Michael
 2009-04-27 11:21:03 +02:00
Michael Adam
221151a2a2 s3:registry: replace typedef REGVAL_CTR by struct regval_ctr. 
This paves the way for hiding the typedef and the implementation
from the surface.

Michael
 2009-04-27 11:21:02 +02:00
Günther Deschner
aa26bdd719 s3-svcctl: fix _svcctl_ControlService. 
Guenther
 2009-04-24 13:38:34 +02:00
Jeremy Allison
2012770393 Fix coverity #908, #909, uninitialized variable. 
Jeremy.
 2009-04-23 01:47:04 -07:00
Jeremy Allison
1e315b0013 Fix coverity #910, uninitialized variable. 
Jeremy.
 2009-04-23 01:38:21 -07:00
Volker Lendecke
8bc88aae5d Move serverinfo_to_SamInfo3() to rpc_server/ 
Normally I hate moving around stuff, but this function is only called from the
RPC server side and it pulls in passdb when trying to link in our rpc client
routines. That seems unnecessary to me.
 2009-04-22 12:33:46 +02:00
Jelmer Vernooij
f4195183a4 s3: Use common security_descriptor_equal(). 2009-04-21 18:17:40 +02:00
Volker Lendecke
4024abb0a8 Remove "struct samr_info" 2009-04-21 14:18:34 +02:00
Volker Lendecke
3f39df75d8 Fix _samr_QuerySecurity 2009-04-21 14:18:34 +02:00
Volker Lendecke
512cf3ea24 Fix samr_SetSecurity 2009-04-21 14:18:34 +02:00
Volker Lendecke
922f836b82 Convert the alias handles to type-safe policy handles 2009-04-21 12:02:28 +02:00
Volker Lendecke
228c56f8ec Convert the group handles to type-safe policy handles 2009-04-21 12:02:28 +02:00
Volker Lendecke
95a76d3c98 Convert the user handles to type-safe policy handles 2009-04-21 12:02:28 +02:00
Andrew Bartlett
a11ecbbff0 Merge branch 'master' of ssh://git.samba.org/data/git/samba into libcli-auth-merge-without-netlogond 2009-04-20 17:19:45 +02:00
Andrew Bartlett
6c9caed481 Merge commit 'origin/master' into libcli-auth-merge-without-netlogond 2009-04-20 16:53:02 +02:00
Volker Lendecke
e3db09cf02 Do not vasprint stuff where not necessary 2009-04-20 16:51:44 +02:00
Jeremy Allison
86b0d56897 Fix warning in use of talloc_set_name. 
Jeremy.
 2009-04-20 04:05:12 -07:00
Volker Lendecke
4afcde91b9 Convert the domain handles to type-safe policy handles 2009-04-20 08:27:23 +02:00
Volker Lendecke
dd073a333e Make force_flush_samr_cache use a dom_sid to find what to flush 2009-04-19 22:58:06 +02:00
Volker Lendecke
46317ce214 Remove flag "builtin_domain" from disp_info 2009-04-19 11:39:47 +02:00
Volker Lendecke
bf196df52f Remove flag "builtin_domain" from samr_info 2009-04-19 09:27:15 +02:00
Volker Lendecke
386511b8e1 Make get_samr_info_by_sid use recent coding conventions 2009-04-19 09:27:15 +02:00
Volker Lendecke
35e6a0e618 Add "uint32_t access_granted" to policy handles 
All policy handles have a mask of allowed operations attached that were
calculated at creation time, so they should carry this mask. This is the basis
for consolidating all our policy handle access checks.

If you want to do your own more complicated access checks further down, just
pass "0" to policy_handle_find.
 2009-04-19 09:27:15 +02:00
Volker Lendecke
9b3f2e69f7 Make "struct policy" private to srv_lsa_hnd.c 2009-04-19 09:27:14 +02:00
Volker Lendecke
fa4ff87acd Convert the samr connect_handles to type-safe calls 2009-04-18 13:58:48 +02:00
Volker Lendecke
c9bc1728f9 Add type-safe policy_handle_create/find 2009-04-18 13:58:48 +02:00
Volker Lendecke
fd558b37f6 Add some const 2009-04-18 13:58:48 +02:00
Günther Deschner
81b18464be s3-spoolss: remove some direct checks for 0 uid in AddForm,SetForm,DelForm. 
Also add some become_root()/unbecome_root() pairs which were missing IMHO.

Guenther
 2009-04-17 23:20:22 +02:00
Günther Deschner
6900d61d36 s3-spoolss: add support for _spoolss_EnumPrinterDrivers() level 6. 
Guenther
 2009-04-17 17:27:32 +02:00