1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-04 05:18:06 +03:00
Commit Graph

52973 Commits

Author SHA1 Message Date
Günther Deschner
4721be488c s3-spoolss: Fix format of description string in spoolss_PrinterInfo1.
This is what windows does and should get us closer to show the appropriate
printer location string in explorer.

Guenther
2009-04-14 23:21:47 +02:00
Günther Deschner
ca3de0103b netdomjoin-gui: make sure to grey out change fields when not running as root.
Guenther
2009-04-14 23:06:30 +02:00
Jeremy Allison
0f1b402848 Try and fix the S4 build - include thread includes.
Jeremy.
2009-04-14 13:02:29 -07:00
Jeremy Allison
27a3118bcf Make talloc_stack threadsafe using TLS. Volker please
check. Passes make test and basic valgrind testing.
Jeremy.
2009-04-14 12:23:22 -07:00
Günther Deschner
48f14949b1 libwbclient: Fix undocumented arguments doxygen warnings.
Guenther
(cherry picked from commit f2b3fbf0c0)
2009-04-14 20:05:21 +02:00
Günther Deschner
1b9384a11f s3-nsswitch: fix make test_wbpad.
Guenther
2009-04-14 14:56:59 +02:00
Stefan Metzmacher
74707e8e8e socket_wrapper: fix the build on systems without ipv6 support
metze
2009-04-14 12:47:18 +02:00
Günther Deschner
a2ef1fee69 s4-smbtorture: make sure samba3 does not regress in EnumServicesStatusW call.
Guenther
2009-04-14 12:13:32 +02:00
Günther Deschner
fa302020ee s3-svcctl: fix memcpy in _svcctl_EnumServicesStatusW().
Make sure we are not copying more than what we have as valid data.

Fix from Jeremy. Thanks a lot for watching this so closely!

Guenther
2009-04-14 12:13:24 +02:00
Günther Deschner
e3ceb0c653 s3-spoolss: remove unused dup_nt_devicemode().
Guenther
2009-04-14 12:13:17 +02:00
Günther Deschner
4a2dfbf3c9 s4-smbtorture: print SPOOLSS_JOB_CONTROL flags in RPC-SPOOLSS test.
Guenther
2009-04-14 12:13:08 +02:00
Andrew Bartlett
786447dea0 s3:charcnv remove now unused malloc() based conversion functions 2009-04-14 12:54:13 +10:00
Andrew Bartlett
97af7f1ed1 Add some harmless use of talloc_tos() in ntlm_auth 2009-04-14 12:54:12 +10:00
Andrew Bartlett
3b3e21bd9b Convert Samba3 to use the common lib/util/charset API
This removes calls to push_*_allocate() and pull_*_allocate(), as well
as convert_string_allocate, as they are not in the common API

To allow transition to a common charcnv in future, provide Samba4-like
strupper functions in source3/lib/charcnv.c

(the actual implementation remains distinct, but the API is now shared)

Andrew Bartlett
2009-04-14 12:53:56 +10:00
Andrew Bartlett
4786a493f7 Solve some of the conflict between Samba3 and Samba4 push_string
This renames push_string in Samba3 into push_string_base and
push_string_check for the two different use cases.

This should allow push_string to be imported from Samba4, using it's
calling conventions.
2009-04-14 12:11:00 +10:00
Andrew Bartlett
41e4f12c48 Merge branch 'master' of ssh://git.samba.org/data/git/samba into master-devel 2009-04-14 10:55:53 +10:00
Andrew Bartlett
82ad66e9df s4:ldb Make it possible to re-run ldap.py again
The parentGUID test didn't clean up after itself correctly.

Andrew Bartlett
2009-04-14 10:52:33 +10:00
Günther Deschner
fc056e561b s3-rpcclient: add set_job command.
Guenther
2009-04-13 23:45:52 +02:00
Günther Deschner
1dbb6530fa s4-smbtorture: fix two valgrind warnings.
Guenther
2009-04-13 23:45:45 +02:00
Günther Deschner
56f5105400 s4-smbtorture: disable test_SecondaryClosePrinter when running against s3 for now.
Guenther
2009-04-13 23:45:37 +02:00
Günther Deschner
0f76e2d0bd s4-smbtorture: move test_ReplyOpenPrinter from RPC-SPOOLSS to RPC-SPOOLSS-NOTIFY.
Guenther
2009-04-13 23:45:29 +02:00
Günther Deschner
a79e1ce048 s3-spoolss: fix typo in fill_printer_driver_info3().
Guenther
2009-04-13 23:45:12 +02:00
Günther Deschner
e1a76de03a s3-loadparm: Fix resume command typo for "printing = vlp".
Guenther
2009-04-13 17:08:17 +02:00
Günther Deschner
3ef0b8671d s3-spoolss: Fix permission checks for _spoolss_AddForm,SetForm and DelForm.
Found by smbtorture test.

Guenther
2009-04-13 16:15:32 +02:00
Günther Deschner
baeee97449 s3: re-run make samba3-idl.
Guenther
2009-04-13 16:14:08 +02:00
Günther Deschner
63b22a74f6 spoolss: add spoolss_DriverAttributes bitmask.
Guenther
2009-04-13 16:14:01 +02:00
Günther Deschner
97ffd709f8 s3-spoolss: use enumprinterdrivers_level() for level 3 enum.
Guenther
2009-04-13 16:12:56 +02:00
Günther Deschner
9b3d3e8aeb s3-spoolss: use enumprinterdrivers_level() for level 2 enum.
Guenther
2009-04-13 16:12:49 +02:00
Günther Deschner
f325c34203 s3-spoolss: use enumprinterdrivers_level() for level 1 enum.
Guenther
2009-04-13 16:12:42 +02:00
Günther Deschner
0393c99302 s3-spoolss: add generic enumprinterdrivers_level function.
Guenther
2009-04-13 16:12:35 +02:00
Günther Deschner
81aca44d30 s4-smbtorture: use printerinfo level 1 name, not description in
test_EnumPrinters_old().

Guenther
2009-04-13 16:10:50 +02:00
Günther Deschner
609e401b97 s3: re-run make samba3-idl.
Guenther
2009-04-13 16:10:39 +02:00
Günther Deschner
3918ee8870 spoolss: fix order of strings in PrinterInfo1 structs.
Guenther
2009-04-13 16:10:31 +02:00
Volker Lendecke
94d3047de1 Use convert_string_talloc, thanks Andrew! 2009-04-13 09:30:18 +02:00
Volker Lendecke
3c10d06524 We have to deny a level 2 oplock if kernel oplocks are enabled
The second r/o opener of a file is supposed to get a level2 oplock. The first
opener due to the protection in process_oplock_break_message() has been forced
to break to no oplock. The second opener according to locking.tdb gets a level2
oplock. Further down in open_file_ntcreate we try to set this level2 oplock in
the kernel, and the non-clustered Linux kernel disallows this. The rules for
the kernel leases are a bit baroque, but the attempt to do the SETLEASE
correctly fails and we end up with no oplock for any client.

In the clustered case however the linux kernel on the second opening node has
not seen the open fd of the first node, it is only the cluster fs that has this
information. If the cluster fs does not have the very same notion of leases as
the local kernel has, we can end up with a WRLCK style kernel lease for the
second opener where locking.tdb only indicates a level2 oplock. Getting a
kernel oplock break signal with just a level2 oplock in locking.tdb is
something smbd is not prepared for. For example after sending out the break in
response to the kernel signal we set a timeout, waiting for a reply.

More work needs to be done to make level2 kernel oplocks real for us. This
patch addresses a real problem we have right now without them.
2009-04-12 14:56:23 +02:00
Volker Lendecke
602059a6ab Fix a bug in smbclient not sending the correct called name
Jeremy, I think the ability to say

smbclient //foo/bar -I <ip-address> -p 139

making the called name to "foo" got lost with 3d2d0203. Was this removed
deliberately? If so, please revert this patch. If not, please merge
appropriately.

Thanks,

Volker
2009-04-12 14:51:15 +02:00
Volker Lendecke
b742b4547e Add "netbios retarget"
This is fun -- XP still does this :-)

netbios retarget : foo = 192.168.234.10:1139

and if you connect to port 139 name foo, XP will happily do SMB over 1139
2009-04-12 14:51:15 +02:00
Volker Lendecke
dcda3ab8ca Reactivate get_socket_port 2009-04-12 14:51:15 +02:00
Volker Lendecke
c344ad3043 write_data already guarantees everything was written 2009-04-12 14:51:15 +02:00
Volker Lendecke
a36472dd38 Extract and print the server name type the client connects to 2009-04-12 14:51:15 +02:00
Volker Lendecke
e9569ae925 Fix some nonempty blank lines 2009-04-11 11:06:21 +02:00
Volker Lendecke
5fc9ca93f3 Fix a memleak in an unlikely error path in change_notify_create() 2009-04-11 11:06:21 +02:00
Volker Lendecke
ea6094d2cb Use talloc_tos() for a temp convert_string_allocate() 2009-04-11 11:06:21 +02:00
Jeremy Allison
2ff80f0d76 Link in the threads functions, not yet used.
Jeremy.
2009-04-10 14:45:45 -07:00
Stefan Metzmacher
971c30a4fc s4:rpc_server: split out the parsing of the ncacn_packet from analyzing of the content
metze
2009-04-10 19:38:30 +02:00
Stefan Metzmacher
225a4f7cc2 s4:rpc_server: report available output for all replies
metze
2009-04-10 19:38:30 +02:00
Stefan Metzmacher
f20f5ae8e6 socket_wrapper: fix crash bug in swrap_readv/writev
metze
2009-04-10 19:38:29 +02:00
Günther Deschner
bc5cd07764 s3-spoolss: implement dummy _spoolss_AddPort().
Guenther
2009-04-10 13:25:09 +02:00
Günther Deschner
65ee4ae30b s3-spoolss: add support for level 8 in _spoolss_GetPrinter().
Guenther
2009-04-10 13:25:01 +02:00
Günther Deschner
bcd042e595 s3-eventlog: implement _eventlog_FlushEventLog().
Guenther
2009-04-10 13:15:25 +02:00