Jeremy Allison
5f295eb6f5
More conversions of NULL -> talloc_autofree_context()
...
so we at least know when we're using a long-lived context.
Jeremy.
2009-07-16 18:28:58 -07:00
Jeremy Allison
d4a87ee966
Replace more long-lived contexts with talloc_autofree_context().
...
Jeremy.
2009-07-16 18:14:56 -07:00
Jeremy Allison
d5c20c072b
Replace short-lived NULL talloc contexts with talloc_tos().
...
Jeremy.
2009-07-16 18:13:46 -07:00
Jeremy Allison
9f0bdd4e17
Remove an unused talloc context.
...
Jeremy.
2009-07-16 18:12:17 -07:00
Günther Deschner
4faef0da76
s3-lsa: Fix pointless check for sec_info flags in _lsa_QuerySecurity().
...
Guenther
2009-07-17 00:13:29 +02:00
Günther Deschner
35e45fb841
s3-lsa: implement _lsa_LookupPrivName().
...
Guenther
2009-07-17 00:12:56 +02:00
Günther Deschner
3b899af422
s3-lsa: implement _lsa_EnumAccountsWithUserRight().
...
Guenther
2009-07-17 00:11:14 +02:00
Jeremy Allison
74c405db40
Tidyup prompted by #6554 - Wrong deallocation in sam_account_ok.
...
Jeremy.
2009-07-16 09:54:14 -07:00
Günther Deschner
f982c912f4
s3-rpc_parse: remove more unused code.
...
Guenther
2009-07-16 03:05:45 +02:00
Günther Deschner
33768fea07
s3-spoolss: make some of the command hooks static.
...
Guenther
2009-07-16 03:05:45 +02:00
Jeremy Allison
48a0732147
Fix bug #6551 - win98 clients cannot connect after server upgrade to samba-3.4.0.
...
The values of vuid and tid were not being correctly updated in the struct smb_request
when passed to chain_reply inside sessionsetupX and tconX.
Jeremy.
2009-07-15 13:59:11 -07:00
Stefan Metzmacher
377a97579b
s3:smbd: try to fix a compiler warning on i386 : left shift count >= width of type
...
metze
2009-07-15 21:04:06 +02:00
Stefan Metzmacher
2fca950d68
s3:libsmb: we need to include "includes.h" as first header to let code build on all platforms
...
This should fix the Tru64 build.
metze
2009-07-15 20:59:35 +02:00
Stefan Metzmacher
8447600d98
s3:tldap: fix the build - a void function should not return a value
...
metze
2009-07-15 20:59:34 +02:00
Jeremy Allison
1f5aec877f
Make cli_unlock and cli_unlock64 async. Fix POSIX lock test.
...
Jeremy.
2009-07-15 11:49:33 -07:00
Björn Jacke
5236b3699d
s3: make linking of rpcclient --as-needed safe
2009-07-15 17:38:40 +02:00
Peter Volkov
2df4550aae
s3: make linking of cifs.upcall --as-needed safe
...
See http://www.gentoo.org/proj/en/qa/asneeded.xml for details.
2009-07-15 17:38:34 +02:00
Michael Adam
7bd4699228
s3:dbwrap: fix embarrassing typo :-)
...
Michael
2009-07-15 17:10:47 +02:00
Michael Adam
5a525f7f28
s3:registry: db backend: add my C
...
Michael
2009-07-15 14:01:58 +02:00
Michael Adam
78576117eb
s3:registry: flush the provided subkey_ctr in regdb_fetch_keys_internal()
...
This way, we always return what has really been read from the db,
and not more. The callers assume exactly this, but one could hand
in an already pre-filled subkey container...
Michael
2009-07-15 14:01:58 +02:00
Michael Adam
92df5e4a02
s3:registry: add function regsubkey_ctr_reinit()
...
This reinitializes an already allocated regsubkey_ctr structure,
emptying out the subkey array and hash table.
Michael
2009-07-15 14:01:57 +02:00
Michael Adam
dc0bcfa188
s3:registry: turn regdb_fetch_keys_internal() from int to WERROR return type
...
This way, more error information is propagated to the callers.
Michael
2009-07-15 14:01:57 +02:00
Michael Adam
c52dd1d5b8
s3:registry: use transaction wrapper in create_sorted_subkeys()
...
Michael
2009-07-15 14:01:56 +02:00
Michael Adam
109ea29b2c
s3:registry: restructure logic of create_sorted_subkes() slightly
...
This makes it clearer to me, and it also makes it easier to
use the transaction retry wrapper in the next step.
Michael
2009-07-15 14:01:56 +02:00
Michael Adam
2d6dbcd0b1
s3:registry: use transaction wrapper in regdb_delete_subkey().
...
Michael
2009-07-15 14:01:55 +02:00
Michael Adam
a48d8353c7
s3:registry: add a comment header for the delete_subkey set of commands.
...
Michael
2009-07-15 14:01:55 +02:00
Michael Adam
5640598cbb
s3:registry: add a comment header for the create_subkey set of functions
...
Michael
2009-07-15 14:01:54 +02:00
Michael Adam
8c7b960493
s3:registry: use transaction wrapper in regdb_create_subkey()
...
Michael
2009-07-15 14:01:54 +02:00
Michael Adam
86d747e19f
s3:registry: use transaction wrapper in regdb_store_keys_internal().
...
Michael
2009-07-15 14:01:53 +02:00
Michael Adam
f93c9e0d41
s3:registry: don't leak to talloc_stack in regdb_store_keys_internal2()
...
and catch one potential talloc failure.
Michael
2009-07-15 14:01:53 +02:00
Michael Adam
3eec829e2f
s3:registry: unify exit logic and remove leaking to talloc_stack in regdb_store_keys_internal()
...
Michael
2009-07-15 14:01:53 +02:00
Michael Adam
14f593aa0f
s3:registry: change regdb_store_keys_internal2() to return WERROR
...
instead of bool for better error propagation.
Michael
2009-07-15 14:01:52 +02:00
Michael Adam
1c65c98f33
s3:registry: refactor adding of builtin reg values out
...
into regdb_ctr_add_value(). For readability.
Michael
2009-07-15 14:01:52 +02:00
Michael Adam
cf4f808b8b
s3:registry: use transaction wrapper in init_registry_data()
...
Michael
2009-07-15 14:01:51 +02:00
Michael Adam
e6340963cf
s3:registry: add regdb_store_values_internal() that takes a db_context argument
...
Michael
2009-07-15 14:01:51 +02:00
Michael Adam
302265aae1
s3:registry: add a regdb_fetch_values_internal() that takes a db_context argument
...
Michael
2009-07-15 14:01:50 +02:00
Michael Adam
8a5b164b20
s3:registry: use transaction wrapper in init_registry_key().
...
Michael
2009-07-15 14:01:50 +02:00
Michael Adam
95ebf534d2
s3:registry: add db_context argument to init_registry_key_internal()
...
Michael
2009-07-15 14:01:49 +02:00
Michael Adam
a00109e1e6
s3:registry: panic upon error at transaction_cancel in create_sorted_subkeys
...
Michael
2009-07-15 14:01:49 +02:00
Michael Adam
3189828087
s3:registry: fix a comment in create_sorted_subkeys()
...
Michael
2009-07-15 14:01:48 +02:00
Michael Adam
4c366a0946
s3:registry: don't loop transaction_commit in create_sorted_subkeys() upon error
...
This would try to commit a higher level transaction upon commit-error.
Michael
2009-07-15 14:01:48 +02:00
Michael Adam
6cb14409af
s3:registry: in regdb_delete_subkey(), don't use the transaction wrappers.
...
This way, the db handle gets used explicitly and the core of the
function can be abstracted.
Michael
2009-07-15 14:01:47 +02:00
Michael Adam
4eeacd6ef0
s3:registry: in regdb_delete_subkey(), panic if transaction_cancel fails
...
Michael
2009-07-15 14:01:47 +02:00
Michael Adam
355892c296
s3:registry: panic upon failed transaction_cancel in regdb_create_subkey()
...
Michael
2009-07-15 14:01:47 +02:00
Michael Adam
3409a44da2
s3:registry: don't use exported transaction wrappers in regdb_create_subkey()
...
So that the regdb handle is again explicit and the core of the
function can be abstracted.
Michael
2009-07-15 14:01:46 +02:00
Michael Adam
1dfaa371fa
s3:registry: create regdb_store_keys_internal() with db_context argument
...
and let exported regdb_store_keys() just call regdb_store_keys_internal()
with regdb as an argument. Internally, in reg_backend_db.c, always use the
_internal version.
Michael
2009-07-15 14:01:46 +02:00
Michael Adam
eb1958ca3d
s3:registry: rename regdb_store_keys_internal() to regdb_store_keys_internal2()
...
Michael
2009-07-15 14:01:45 +02:00
Michael Adam
589bacfbdb
s3:registry: create regdb_fetch_keys_internal() with db_context argument
...
and let exported regdb_fetch_keys() just call regdb_fetch_keys_internal()
with regdb as an argument. Internally, in reg_backend_db.c, always use the
_internal version.
Michael
2009-07-15 14:01:45 +02:00
Michael Adam
db4f797e35
s3:registry: add db_context argument to scan_parent_subkeys()
...
Michael
2009-07-15 14:01:44 +02:00
Michael Adam
c01d955ac0
s3:registry: add db_context argument to regdb_fetch_key_internal()
...
Michael
2009-07-15 14:01:44 +02:00