1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-28 17:47:29 +03:00

644 Commits

Author SHA1 Message Date
Gerald Carter
2f5de718a9 r8506: BUG 2853: don't strip out characters like '$' from printer names
when substituting for the lpq command.
2007-10-10 11:00:07 -05:00
Gerald Carter
d07179de2f r8501: * disable printer handle object cache (was mostly used
for NT4 clients enumerating printer data on slow CPUs)
* fix pinter and secdesc record upgrade to normalize the key
  (rev'd printer tdb version)
* fixed problem that was normalizing the printername name field

in general, this should fix the issues upgrading print servers
from 3.0.14a to 3.0.20
2007-10-10 11:00:06 -05:00
Jeremy Allison
c7fe18761e r8219: Merge the new open code from HEAD to 3.0. Haven't yet run the torture
tests on this as it's very late NY time (just wanted to get this work
into the tree). I'll test this over the weekend....
Jerry - in looking at the difference between the two trees there
seem to be some printing/ntprinting.c and registry changes we might
want to examine to try keep in sync.
Jeremy.
2007-10-10 10:58:18 -05:00
Gerald Carter
d3427960b0 r8089: successfully delete printer subkeys via the registry....now for values 2007-10-10 10:58:10 -05:00
Gerald Carter
00bce2b3bb r8066: * had to modify the printer data storage slightly in ntprinters.tdb
when packing values.  It is a compatible change though and will
  not require a tdb version upgrade
* Can successfully create new printer subkeys via winreg that
  are immediately available via spoolss calls.  Still cannot delete
  keys yet though.  That comes next.
2007-10-10 10:58:10 -05:00
Gerald Carter
4aec5dce5c r8025: *how* can this code have been around so long and
nver normalized the string used for printer and
sec_desc key lookups ?????

normalized sharename to lower case before storing/fetching
from tdb.

Need to look at drivers and forms tdb as well (perhaps).
2007-10-10 10:58:09 -05:00
Gerald Carter
5f4a3f61a3 r7983: clean up some use of un-initialized variables found by valgrind 2007-10-10 10:58:06 -05:00
Jeremy Allison
9506b8e145 r7882: Looks like a large patch - but what it actually does is make Samba
safe for using our headers and linking with C++ modules. Stops us
from using C++ reserved keywords in our code.
Jeremy
2007-10-10 10:58:00 -05:00
Gerald Carter
ada1d326ae r7829: fix unitialized printer status field that was breaking migration of print queues 2007-10-10 10:57:58 -05:00
Gerald Carter
a091b37d59 r7692: start versioning the registry.tdb file since it can be modified now 2007-10-10 10:57:19 -05:00
Gerald Carter
e188fdbef8 r7691: * add .gdbinit to the svn:ignore files
* start adding write support to the Samba registry
  Flesh out the server implementations of
  RegCreateKey(), RegSetValue(), RegDeleteKey() and RegDeleteValue()

I can create a new key using regedit.exe now but the 'New Key #1'
key cannot be deleted yet.
2007-10-10 10:57:19 -05:00
Gerald Carter
46cd95c9b4 r7620: when adding a new printer driver, we should copy the files
(not move) to the W32X86/{2,3}/ directory.  Printmig.exe
copies the driver files for all drivers to print$/W32X86
and the calls AddPrinterDriver() for each driver.  If we
move the file, then adding a driver which shares a file with
a previous driver will fail.

I can now restore drivers in bulk to a Samba 3 server.
2007-10-10 10:57:17 -05:00
Gerald Carter
c98e17446a r7614: convert move_driver_to_download_area() to return WERROR in order to provide better error messages to clients when a AddPrinterDriver[Ex]() call fails 2007-10-10 10:57:16 -05:00
Gerald Carter
26387fc74c r7584: cleanup the default printer security descriptor 2007-10-10 10:57:15 -05:00
Jeremy Allison
0b6f87d5e1 r7200: Don't use memset, use SET_STAT_INVALID (has the same effect).
Jeremy.
2007-10-10 10:57:05 -05:00
Gerald Carter
ec3ef5ddbe r7041: compile fixes....long day I guess 2007-10-10 10:57:01 -05:00
Gerald Carter
c72182c1e2 r7038: * upgrade version of nt*tdb files. Have to fix
some issues in the printer security descriptors.
  Ensure that each printer sd has an oaner and group SID
  (BUILTIN\Administrators) and that we utilize more than
  the generic bits assigned in <= 3.0.14a.
2007-10-10 10:57:01 -05:00
Jeremy Allison
482f7e0e37 r6890: Refactor printing interface to take offset into job. Fixes bug
where large print jobs can have out-of-order offsets. Bug found
by Arcady Chernyak <Arcady.Chernyak@efi.com>
Jeremy.
2007-10-10 10:56:56 -05:00
Jeremy Allison
3b2cd19fcb r6673: Fix the write cache based on some VERY good detective work
from Ingo Kilian <ikilian@web.de>.
You must do a make clean after updating this.
Jeremy.
2007-10-10 10:56:50 -05:00
Jeremy Allison
316df944a4 r6595: This is Volkers new-talloc patch. Just got the go-ahead from
Volker to commit. Woo Hoo !
Jeremy.
2007-10-10 10:56:46 -05:00
Gerald Carter
2c66a4098a r6490: BUG 1998: patch from Olaf Imig <Olaf.Imig@bifab.de>; fix byte ordering bug when storing 16-bit RAP print job ids 2007-10-10 10:56:42 -05:00
Volker Lendecke
3493d9f383 r6263: Get rid of generate_wellknown_sids, they are const static and initializable
statically.

Volker
2007-10-10 10:56:33 -05:00
Herb Lewis
efea76ac71 r6225: get rid of warnings from my compiler about nested externs 2007-10-10 10:56:30 -05:00
Gerald Carter
4e8b868e6e r5993: compiler warning fix 2007-10-10 10:56:14 -05:00
Gerald Carter
27c6e85ad5 r5950: more compiler warning's from Jason Mader 2007-10-10 10:56:10 -05:00
Gerald Carter
2dae527e21 r5807: fix segfault after compiler warning clean up (and cleanup another warning) 2007-10-10 10:56:02 -05:00
Jeremy Allison
2e1f727184 r5792: Added new parameter "inherit owner". If set on a share, the created file/directory
will be owned by the same uid as the containing directory. Doing this for directories
in a race-free mannor has only been tested on Linux (it depends on being able to open
a directory and then do a fchown on that file descriptor). If this functionality is
not available then the code silently downgrades to not changing the ownership of a
new directory. This new parameter (docs to follow) finally makes it possible to create
"drop boxes" on Samba, which requires all files within a directory to be commonly owned.
A HOWTO on how to use this will follow.
Jeremy.
2007-10-10 10:56:01 -05:00
Volker Lendecke
96a0f7d60c r5770: Get rid of some compiler warnings 2007-10-10 10:56:00 -05:00
Gerald Carter
f75369ec86 r5691: wrapping the pause/resume/purge printer commands in
{become,unbecome}_root() blocks.  We've already done
a print_access_check() to ensure the user is admin.
The means that non-root users can pause and manage printers.
I really don't see how this worked before without setuid
binaries on the server.

Also update print_queue_update() interface to allow an smbd
to update the print queue cache locally rather than going through
the bg lpq daemon.  This is needed for things like pjob_delete()
to ensure the cache is current for the specific client.
2007-10-10 10:55:55 -05:00
Gerald Carter
98596037ca r5684: BUG 2405: patch from Torsten Werner <torsten.werner@assyst-intl.com> to define 'lpstat' printcap output on HPUX 2007-10-10 10:55:54 -05:00
Gerald Carter
743ddbc7f2 r5683: BUG 2363: allow 'in use' driver to be removed as long as one 'Windows NT x86' driver remains' 2007-10-10 10:55:54 -05:00
Gerald Carter
3eee00e0d0 r5359: BUG 2333: use the lpq command to pass in the correct printer name for cups_queue_get(). See comments in code for details 2007-10-10 10:55:39 -05:00
Gerald Carter
d64fd1116d r5029: after talking to Rob, ensure that we set the NETIOSNAME.domainname
as the longname in the published printer information since this
is what we will have used when we joined the domain.

More testing on this tomorrow.
2007-10-10 10:55:12 -05:00
Gerald Carter
0ac3c4c5a2 r5012: fix segfault caused by using a ipp_t * after calling cupsDoRequest() 2007-10-10 10:55:11 -05:00
Gerald Carter
15fd4a05ec r4907: remove unreached code 2007-10-10 10:55:07 -05:00
Gerald Carter
f65598b3b0 r4902: please note that cupsDoRequest() deletes the request* so don't call ippDelete(request) *ever* 2007-10-10 10:55:07 -05:00
Jeremy Allison
2afe2a16c9 r4881: Varient of Lar's patch for #2270. Jerry promises to test :-).
Jeremy.
2007-10-10 10:55:06 -05:00
Gerald Carter
8971a85442 r4874: add DOmain Admins (Full Control) to the default printer sd if we are a DC 2007-10-10 10:55:06 -05:00
Gerald Carter
41dc7f7573 r4805: Last planned change to the privileges infrastructure:
* rewrote the tdb layout of privilege records in account_pol.tdb
  (allow for 128 bits instead of 32 bit flags)
* migrated to using SE_PRIV structure instead of the PRIVILEGE_SET
  structure.  The latter is now used for parsing routines mainly.

Still need to incorporate some client support into 'net' so
for setting privileges.  And make use of the SeAddUserPrivilege
right.
2007-10-10 10:53:55 -05:00
Gerald Carter
85731706c9 r4740: allow SE_PRINT_OPERATORS to have printer admin access 2007-10-10 10:53:53 -05:00
Jeremy Allison
5942bb7737 r4662: Fix from "Jerome Borsboom" <j.borsboom@erasmusmc.nl> to fix
missing release reference for printer tdb.
Jeremy.
2007-10-10 10:53:50 -05:00
Gerald Carter
1cad525093 r4539: patch from Rob -- adding real printcap name cache function to speed up printcap reloads 2007-10-10 10:53:46 -05:00
Jeremy Allison
c5a8bf3335 r4306: Couple more MALLOC fixes from albert chin (china@thewrittenword.com).
Jeremy.
2007-10-10 10:53:43 -05:00
Jeremy Allison
61479f56be r4234: More malloc fixes to use the macros.
Jeremy.
2007-10-10 10:53:39 -05:00
Gerald Carter
56b1110c71 r4094: BUG 2107: fix memory bloating caused by large numbers of print_queue_updates() requests sent via messages.tdb 2007-10-10 10:53:34 -05:00
Gerald Carter
e3decbc441 r4089: fix logic error in add_a_form() that only compared N characters instead of the entire form name 2007-10-10 10:53:32 -05:00
Jeremy Allison
620f2e608f r4088: Get medieval on our ass about malloc.... :-). Take control of all our allocation
functions so we can funnel through some well known functions. Should help greatly with
malloc checking.
HEAD patch to follow.
Jeremy.
2007-10-10 10:53:32 -05:00
Gerald Carter
26bbad62b9 r4030: patch from Rob -- don't force the cups printer-make-and-model tag as the comment for autoloaded printers 2007-10-10 10:53:29 -05:00
Gerald Carter
a64505d52f r4028: * prevent the background LPQ daemon from updating
the print queue cache just because multiple smbd
  processes sent a message that it was out of date.

* add some extra debug messages while trying to track down
  down jobs being left in the queue after printing has
  completed.
2007-10-10 10:53:28 -05:00
Jeremy Allison
8a91a69961 r3867: Fix from david.hu@hp.com - make a copy of an incoming message
rather than indirecting into it as a struct (may not be on an
even byte boundary). Bug #2052.
Jeremy.
2007-10-10 10:53:22 -05:00